Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7dqU-00043D-Uy for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 08:16:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7dqU-0007np-Cu for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 May 2017 08:16:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7dqF-0007Oa-Im for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 08:16:27 +0000 Received: from mail-io0-x233.google.com ([2607:f8b0:4001:c06::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7dqC-0006HR-CR for pgadmin-hackers@postgresql.org; Mon, 08 May 2017 08:16:26 +0000 Received: by mail-io0-x233.google.com with SMTP id o12so17114446iod.3 for ; Mon, 08 May 2017 01:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ay+bpzGXCknrrYVKeLOfctHwt9vOBLCKSoZoTRXQ2TA=; b=g9s1FU0tJwn1H9b6iI7NHmPiExd0nQTJMXJsfl2+HFC3lcD2ps7JX+U/JfIOe4mPK9 QMjL2h5f9/WrbnZrTcO8ec5d0I+cWUPIXx/joLXNObklTsYjkFBGKW2TMSzKytASK5rG QvYvK2SuVN1/0kCj83xJKE3W1C/uXB8ltQoQNYOflC5ha527INVzDPygqBBCZh19SaU7 E0Z7EWByVCzzHZGtdTg376N8lnNhctUYa/U2XZNhkBS2z3VbopEmw5K+C/O0gFkSNjOM zDzcUhwzgLdcN0VMfswhqinGS/ko0nzP3pD0UaK6L1svS/jwFdArGJm9J/mP8a13kgTw TitQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ay+bpzGXCknrrYVKeLOfctHwt9vOBLCKSoZoTRXQ2TA=; b=fyKA5ScJyjPaTkwNTf1URJPTcZSV8Ju2Z5OD3UosooJYnwKwSj4VZ9dEvOsI369P0z WIz/JITkFBDY2aS7L6BP++x8vbhkD7TOztDVKCRR1nq9uWwaMk+5NwFalt+1XIn9DS08 Of8quoPMTGSEvp84gvnL2R3b4iT3kBHakMjnLpYZAID6qfA7O22GUvRrIU+Vb4VNQ/fC WLZLpN1eXjJzd1YEoLE2YV5090vQGhY0l+qg/gEI+sT0qMxbuycrQqZ+fM6ZzunXkqR2 8gb1wisEmo0Smry9YdFCK7pAs29vKc69E7wHmqx/zO51y4NIqYI0IOXJ05t4CwgErhWS CRpA== X-Gm-Message-State: AODbwcChUEMzjZQCohcwJwfsw7nO7BI8OuGVBGwvoeAE09HPBxO1C863 /73RbMSbjGtRi5c6q3hvM+of0/CbUg== X-Received: by 10.107.3.165 with SMTP id e37mr1723072ioi.232.1494231383682; Mon, 08 May 2017 01:16:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Mon, 8 May 2017 01:16:23 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 8 May 2017 09:16:23 +0100 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Robert Eckhardt Cc: Sarah McAlear , Joao Pedro De Almeida Pereira , Ashesh Vashi , pgadmin-hackers , Matthew Kleiman , Akshay Joshi Content-Type: multipart/alternative; boundary=001a113ed3bed64352054efeda9c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113ed3bed64352054efeda9c Content-Type: text/plain; charset=UTF-8 Akshay, as Ashesh is unavailable today, can you please review/commit this ASAP? Thanks. On Fri, May 5, 2017 at 1:18 PM, Dave Page wrote: > Can you get this polished off on Monday please Ashesh? > > On Thu, May 4, 2017 at 12:51 PM, Robert Eckhardt > wrote: > >> All, >> >> This change in the xss testing is preventing our CI from going green and >> is also preventing the Dependents and Dependencies tabs in Greenplum from >> being useful. >> >> Can we either merge this or provide feedback as to what needs to change >> so that it can be merged. >> >> Thank you >> Rob >> >> On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear >> wrote: >> >>> Hi Hackers & Ashesh! >>> >>> Is there anything else we can do for this? >>> >>> Thanks! >>> Matt & Sarah >>> >>> On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Thanks for reviewing, Ashesh. >>>> >>>> We have updated the patch. The headers are all consistent and we >>>> removed the __init__.py files in directories containing only .sql. >>>> >>>> Thanks! >>>> Joao & Matt >>>> >>>> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < >>>> jdealmeidapereira@pivotal.io> wrote: >>>> >>>>> Hello Ashesh, >>>>> >>>>> Thanks for reviewing the patch. >>>>> >>>>> We added the __init__.py files into templates to convert them into >>>>> packages so that the tests inside of them can be found by the test runner. >>>>> >>>>> Thanks! >>>>> Joao & Sarah >>>>> >>>>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi < >>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>> >>>>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: >>>>>> >>>>>>> Ashesh, can you review/commit this please? >>>>>>> >>>>>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> We found out that when you are connected to a GreenPlum database >>>>>>>> and try to get Dependents and Dependencies of an object the application was >>>>>>>> returning a SQL error. >>>>>>>> >>>>>>>> This patch splits the SQL query used to retrieve the Dependents, >>>>>>>> Dependencies, and Roles SQL file into multiple versioned files. >>>>>>>> Add Unit Tests for each file. >>>>>>>> Also added __init__.py files to other test directories to run the >>>>>>>> tests in them. >>>>>>>> >>>>>>> Hi Joao & Sarah, >>>>>> >>>>>> Why do we need to add __init__.py in the template directory? >>>>>> I didn't understand the purpose of the adding __init__.py files in >>>>>> the template directories. >>>>>> >>>>>> NOTE: The headers in those files are not consistent with the other >>>>>> project files. >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> >>>>>> >>>>>>> Add ORDER BY into Copy Selection Feature test to ensure the results >>>>>>>> are retrieved always in the same order >>>>>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and >>>>>>>> skip it for versions less than 9.1 >>>>>>>> >>>>>>>> Thanks >>>>>>>> >>>>>>>> Joao & Sarah >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113ed3bed64352054efeda9c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Akshay, as Ashesh is unavailable today, can you please rev= iew/commit this ASAP?

Thanks.

On Fri, May 5, 2017 at 1:18 PM, = Dave Page <dpage@pgadmin.org> wrote:
Can you get this polished off on Monday please = Ashesh?

On Thu, May 4, 2017 at 12:51 PM, Robert= Eckhardt <reckhardt@pivotal.io> wrote:
All,=C2=A0

This change= in the xss testing is preventing our CI from going green and is also preve= nting the=C2=A0Dependents and Dependencies tabs in Greenplum from being use= ful.=C2=A0

Can we either merge this or provide fee= dback as to what needs to change so that it can be merged.=C2=A0
=
Thank you
Rob

On Tue, May 2, 2017 at 5:17 PM, S= arah McAlear <smcalear@pivotal.io> wrote:
Hi Hackers & Ashesh!

Is = there anything else we can do for this?

Thanks!Matt & Sarah

On Thu, Apr = 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira <<= a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank">jdealmeida= pereira@pivotal.io> wrote:
=
Thanks for reviewing, Ashesh.

We have u= pdated the patch. The headers are all consistent and we removed the __init__.py files in directories contai= ning only .sql.

Thanks!
Joao & Matt

On Wed, Apr 26, 2017= at 11:22 AM, Joao Pedro De Almeida Pereira <jdealmeidapereir= a@pivotal.io> wrote:
Hello Ashesh,

Thanks for reviewing the patch.
=

We added the __init__.py files into templates to conver= t them into packages so that the tests inside of them can be found by the t= est runner.

Thanks!
Joao & Sarah

On Wed, Apr 26, 2017 at 1= :26 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com&g= t; wrote:
On Mon, Apr 24, 2017 a= t 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you r= eview/commit this please?

On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida= Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,

We found out that when you are c= onnected to a GreenPlum database and try to get Dependents and Dependencies= of an object the application was returning a SQL error.

This patch splits the SQL query used to retrieve the Dependents, Dep= endencies, and Roles SQL file into multiple versioned files.
Add = Unit Tests for each file.
Also added __init__.py files to other t= est directories to run the tests in them.
Hi Joao & Sarah,

= Why do we need to add __init__.py in the template directory?
I di= dn't understand the purpose of the adding __init__.py files in the temp= late directories.

NOTE: The headers in those files= are not consistent with the other project files.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company

<= p style=3D"margin:0pt">

http://www.linkedin.com/in/asheshvash= i

Add ORDER BY into Copy Selection Feature test to ensure the r= esults are retrieved always in the same order
Renamed the Scenari= o of the=C2=A0xss_checks_pgadmin_debugger_test and skip it for version= s less than 9.1

Thanks

Jo= ao & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--
D= ave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB U= K: http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers






--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

= EnterpriseDB UK: = http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a113ed3bed64352054efeda9c--