public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: Chris Mayo <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [PATCH] Document that a patch should be submitted to the list as an attachment
Date: Tue, 11 Oct 2016 15:34:54 +0100
Message-ID: <CA+OCxozwteHaoa9ge5n2WXu9SgF71cn8Z118a5E2JEaNP0yBTw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Monday, October 10, 2016, Chris Mayo <[email protected]> wrote:

> Signed-off-by: Chris Mayo <[email protected] <javascript:;>>
> ---
>  docs/en_US/submitting_patches.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
>
This doesn't apply - can you rebase it please?

Thanks.

(pgadmin4)snake:pgadmin4 dpage$ git apply
~/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:13:
trailing whitespace.
the chances of it being rejected. Once you're happy with your work, mail it
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:14:
trailing whitespace.
as an attachment to the mailing list [email protected].
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:15:
trailing whitespace.
Please ensure you include a full description of what the patch does,
/Users/dpage/Downloads/0001-Document-that-a-patch-should-be-submitted-to-the-lis.patch:16:
trailing whitespace.
as well as the rationale for any important design decisions.
error: patch failed: docs/en_US/submitting_patches.rst:30
error: docs/en_US/submitting_patches.rst: patch does not apply



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] Document that a patch should be submitted to the list as an attachment
  In-Reply-To: <CA+OCxozwteHaoa9ge5n2WXu9SgF71cn8Z118a5E2JEaNP0yBTw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox