Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4ME5-0005qB-0O for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Apr 2018 07:56:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f4ME3-0002J9-GQ for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Apr 2018 07:55:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4ME3-0002Iz-0O for pgadmin-hackers@lists.postgresql.org; Fri, 06 Apr 2018 07:55:59 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f4MDu-00066s-MA for pgadmin-hackers@postgresql.org; Fri, 06 Apr 2018 07:55:57 +0000 Received: by mail-wm0-x22d.google.com with SMTP id x4so1256284wmh.5 for ; Fri, 06 Apr 2018 00:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vqC2c3poMW7Jbu4SnZrt4e1VWGU39lrh2kdEF1XP3hw=; b=vlcCF8dsxfC0OhXiRj4DuNA0qRN9k1Y8H5O8G4YpErDcMlZtm5001yU9rOnmHIZQsW g+6o3Qv5M16ucDoqUG6VsNyqcw+P+7QiygH7YeXZN2ywBPkwswXdnZHki92KICizi7PL CI1uJC58poF7Co0VisxWP2e7fPwcL8XdM/IDxVQiB6B0Rj4wRDcsy9deXYcSV+bxy73E rsAzMjtSNjYDlgJgHPQKVM+W5hAhL4BZeI03NvnG1XljOib1Fh4HuPErMl1SNuPmeVpO q0yazTL2q1roV0rXBdQ5vm0dQXrZfwbx98SFlUzNBJVit1X7aV+LylGxXptEQhvsuAr1 B+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vqC2c3poMW7Jbu4SnZrt4e1VWGU39lrh2kdEF1XP3hw=; b=JCsnj6lry58NwcxReSifiGMa5FC+KYF0ubPukgDxkCmI1dlOxmTscSWQQLVTW2Lbo/ QuLI3xzyzAIw27GQupL7WSo1t857E/CRnEqMToMtZi+eJ2/m8Bnrn7TlQTV18wh4GrKh +Vqfkf/BaqdOR+8g17weePJ3etynLC5GtpUGyncFH3I9F2Hw7Wr+qyp0aSf7RIZI4Rtt ZUDaMMLiuQoFfwgS3jNvJ3nGeYQQx1X/TS4oazMQFTEozKGWhnuqwvUpBg7Pgu3KD1sJ n274ntF2ldCKqbq0s8vsn6qkEdFl50WZGrBsOwPkUUozbIP07adKrDl6LKz8bcT45fxL phMA== X-Gm-Message-State: AElRT7FpBo/pMQjzNQPJL71AbNzpHmSjmyp+klfrAEHsopbKbJq2v6+i 1/lJyLOYk17NDAvee/VUw2sLLBIweEHSzLfVepefJg== X-Google-Smtp-Source: AIpwx48vNegpUatRPBgqarQgXeZwcO37teSBUEDl4bm0t+IBmJMtIUuWHgtgU3bS5M7BGOgbLascqwxjtPCPOayr1Uc= X-Received: by 10.28.91.65 with SMTP id p62mr14586903wmb.140.1523001348539; Fri, 06 Apr 2018 00:55:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Fri, 6 Apr 2018 00:55:47 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 6 Apr 2018 08:55:47 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1144161a5f59d6056929622e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1144161a5f59d6056929622e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 6, 2018 at 8:52 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > I checked and found that the issue was in wcDocker which was causing > problem while opening query tool, > I have logged an issue on github: https://github.com/ > WebCabin/wcDocker/issues/124 > > Query tool, Debugger etc are working properly when open in new Browser Ta= b > and not in Panel. > > I'm also able to fix the issue which I was facing while running Jasmine > test by correctting the path for *jquery.event.drag* library from > jquery.event.drag-2.2 to jquery.event.drag-2.3.0. > > Let's wait for author's reply on the issue. > Great, thanks. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Apr 4, 2018 at 3:20 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> On Wed, Apr 4, 2018 at 3:19 PM, Dave Page wrote: >> >>> >>> >>> On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Joao, >>>> >>>> Yes it bundles latest version but I doubt that is not using it, If we >>>> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. >>>> I have tried that and I started getting jQuery related errors when >>>> trying to run query tool or when running jasmine tests. >>>> >>> >>> Can you spend some time trying to figure it out please? We need to get >>> on to 3.x as older versions are no longer receiving updates which could >>> pose a security risk. >>> >> =E2=80=8BSure Dave.=E2=80=8B >> >> >>> >>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira < >>>> jdealmeidapereira@pivotal.io> wrote: >>>> >>>>> Hi Murtuza, >>>>> >>>>> The patches look good and they pass all tests in CI. >>>>> One think that we realized was the SlickGrid as a npm package now: >>>>> https://www.npmjs.com/package/slickgrid >>>>> Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully >>>>> supported or not...... >>>>> >>>>> Thanks >>>>> Victoria & Joao >>>>> >>>>> On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> =E2=80=8BHi Dave, >>>>>> >>>>>> Reverted back jQuery version to 1.x because of SlickGrid dependancy. >>>>>> Please find updated patch. >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Please hold on my previous patch. >>>>>>> >>>>>>> We can't use latest jQuery version as SlickGrid has dependancy on >>>>>>> older version. >>>>>>> I'll send updated patch again. >>>>>>> >>>>>>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> Please find updated patches, there are two patches attached one is >>>>>>>> for the story and another is for changes required as per new modul= es. >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < >>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> PFA patch to update the modules to latest version. >>>>>>>>>> >>>>>>>>>> >>>>>>>>> - Why isn't jQuery updated to 3.3.1? >>>>>>>>> >>>>>>>> =E2=80=8BDone=E2=80=8B >>>>>>>> >>>>>>>> >>>>>>>>> =E2=80=8B >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to >>>>>>>>> psycopg2 and pycrypto etc? >>>>>>>>> >>>>>>>> =E2=80=8BDone=E2=80=8B >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> We are not able to update some of the modules to latest version >>>>>>>>>> due to dependancy on other modules, For example >>>>>>>>>> - Python: Flask-Security has dependancy on flask-babelex which >>>>>>>>>> causes conflict with flask_babel >>>>>>>>>> >>>>>>>>> >>>>>>>>> Hmm, flask-babelex might be a better option anyway; in particular= , >>>>>>>>> it avoids loading catalogs with every request which seems desirab= le given >>>>>>>>> the size of ours. On the other hand, it hasn't been updated so re= cently. >>>>>>>>> >>>>>>>> =E2=80=8BI have removed flask-babel and used flask_babelex instead= .=E2=80=8B >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & >>>>>>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3. >>>>>>>>>> >>>>>>>>> >>>>>>>>> OK. >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144161a5f59d6056929622e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Apr 6, 2018 at 8:52 AM, Murtuza Zabuawala <= ;mu= rtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

I checked and found that the issue was in wcDoc= ker which was causing problem while opening query tool,
I have logged an issue = on github:=C2=A0https://github.com/WebCabin/wcDocker/issues/124=
Qu= ery tool, Debugger etc are working properly when open in new Browser Tab an= d not in Panel.

I'm also able to fix the issue which I was facing while ru= nning Jasmine test by correctting the path for=C2=A0jquery.event.drag library from=C2=A0jquer= y.event.drag-2.2 to=C2=A0jquery.event.drag-2.3.0.

Let's wait for author's reply on the issue.
=

Great, thanks.
=C2=A0


<= div dir=3D"ltr">
--
Regards,
Murtuza Zabuawala
Enterpris= eDB:=C2=A0http://www.enterprisedb.com
The Enterprise Postgre= SQL Company


On Wed, Apr 4,= 2018 at 3:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
On Wed,= Apr 4, 2018 at 3:19 PM, Dave Page <dpage@pgadmin.org> wrote:
<= div class=3D"gmail_extra">


On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Joao,

Yes it bundles latest version but I doubt that is n= ot using it, If we upgrade the jQuery to 3.3.1 then it's breaking the S= lickGrid.
= I have tried that and I started getting jQuery related errors when trying t= o run query tool or when running jasmine tests.

Can you spend some time trying to figure it out please? We= need to get on to 3.x as older versions are no longer receiving updates wh= ich could pose a security risk.
=E2=80=8BSure Dave.=E2=80=8B
=C2=A0
=C2=A0

-= -
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.ente= rprisedb.com
The Enterprise PostgreSQL Company

=

On Wed, Apr 4, 2018 at 1= :39 AM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi = Murtuza,

The patches look good and they pass all tests i= n CI.
Al= so Slickgrid comes packaged with jquery 3.1 not sure if it is fully support= ed or not......

Thanks
Victoria & Jo= ao

On Tue, Apr 3, 2018= at 11:50 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com= > wrote:
=E2=80=8BHi Dav= e,
<= br>
= Reverted back jQuery version to 1.x because of SlickGrid dependancy.
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">Please find updated patch.

--
Regards,Mur= tuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Please hold on my previou= s patch.=C2=A0

= We can't use latest jQuery version as SlickGrid has dependancy on older= version.
= I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi Dave,

Please find updated patches, there are tw= o patches attached one is for the story and another is for changes required= as per new modules.


On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=E2=80=8BDone=E2=80=8B
= =C2=A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2= and pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
<= div dir=3D"ltr">
=
=C2=A0
=
We are not able to updat= e some of the modules to latest version due to dependancy on other modules,= For example
- Python: Flask-Security has dependancy on flask-babelex which causes co= nflict with flask_babel

Hmm, fl= ask-babelex might be a better option anyway; in particular, it avoids loadi= ng catalogs with every request which seems desirable given the size of ours= . On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and us= ed flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't updat= e to Bootstrap4 because Bootstrap Switch & = Bootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0

=

--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company




=


--
Dave Pag= e
Blog: http:/= /pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprise= db.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1144161a5f59d6056929622e--