MIME-Version: 1.0
In-Reply-To: 
 <CANxoLDdnaPB8gt-v+4aVY2urY8suGqK=pFiWFZ-Agxkgkx_VYw@mail.gmail.com>
References: 
 <CANxoLDdnaPB8gt-v+4aVY2urY8suGqK=pFiWFZ-Agxkgkx_VYw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 29 Jun 2018 14:26:36 +0100
Message-ID: 
 <CA+OCxozxjz+m=zy_AN4QPQtNHKuYTpQ6YpihoS=ugpzLe_jvEQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN
 output in PG11
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000001f5822056fc7cc11"
Precedence: bulk

--0000000000001f5822056fc7cc11
Content-Type: text/plain; charset="UTF-8"

Hi

On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <akshay.joshi@enterprisedb.com
> wrote:

> Hi Hackers,
>
> Attached is the patch to fix the RM #3397 Add support for JIT stats in
> EXPLAIN output in PG11. Please review it.
>

A couple of immediate thoughts:

- When the canvas is first rendered, there's a vertical scrollbar now. As
soon as I mouseover the new icon, it vanishes and the icon jumps to the
right.

- The icon seems lighter than the other controls on the left.

- The icon isn't disabled when there is no info to show.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--0000000000001f5822056fc7cc11
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div class=3D"gmail_extra"><br><div class=3D"gmail_quote=
">On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <span dir=3D"ltr">&lt;<a hr=
ef=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.joshi@=
enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote"=
 style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><d=
iv dir=3D"ltr">Hi Hackers,<div><br></div><div>Attached is the patch to fix =
the RM #3397=C2=A0Add support for <span id=3D"m_6647672068001386983:243.7">=
JIT</span> stats in EXPLAIN output in PG11. Please review it.</div></div></=
blockquote><div><br></div><div>A couple of immediate thoughts:</div><div><b=
r></div><div>- When the canvas is first rendered, there&#39;s a vertical sc=
rollbar now. As soon as I mouseover the new icon, it vanishes and the icon =
jumps to the right.</div><div><br></div><div>- The icon seems lighter than =
the other controls on the left.</div><div><br></div><div>- The icon isn&#39=
;t disabled when there is no info to show.</div><div><br></div><div>Thanks.=
=C2=A0</div></div><div><br></div>-- <br><div class=3D"gmail_signature" data=
-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake=
.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter=
: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" =
target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise Postgre=
SQL Company<br></div>
</div></div>

--0000000000001f5822056fc7cc11--