Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hqfpX-0004rA-KI for pgadmin-hackers@arkaria.postgresql.org; Thu, 25 Jul 2019 15:38:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hqfpW-0003A6-GW for pgadmin-hackers@arkaria.postgresql.org; Thu, 25 Jul 2019 15:38:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hqfpW-00039z-9W for pgadmin-hackers@lists.postgresql.org; Thu, 25 Jul 2019 15:38:54 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hqfpT-0002VJ-PC for pgadmin-hackers@postgresql.org; Thu, 25 Jul 2019 15:38:53 +0000 Received: by mail-wr1-x443.google.com with SMTP id y4so51306707wrm.2 for ; Thu, 25 Jul 2019 08:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7DyX6p9U3UH3dlVDiVMXdcbCVQEXrK8uuDlr8A6AFR0=; b=ZbcJa6tcrCVyclnrESNfKUGs6bNw67fFxF7X28V2LF0s8Fydhu/7eAgWqvobOsxVFC ediXhmwerU9DrOVXYrLenNvK1raGAh7VgtyeIElZNWqJe8meaoOH2DxmPfcIV4PNY4Qq OKKxOfte/w/IhCGQ/7l1WHQnuKtoWMEaHoI2Wm1EZBcvBKXvWLX3nZnzPdRDH6E7JILt Th46JokI+ChPfeEZuKHTrhokDlbw63oVMmQWtwx0INjnAd83uykP8HRBnHrUnyQ1bPeh xMYhknU2/skAk0fLdgFN95kSgJv1cPQOQl3Sdm5+R4W22S1vh3yzSD669T2E8YB3J5bm 61aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7DyX6p9U3UH3dlVDiVMXdcbCVQEXrK8uuDlr8A6AFR0=; b=fN8bYJY8U0vbkl1LOj60RdeKsRr+qHA9EklA7bdfEwZ0ZcmXNEIcfo2nkluPrOmA+z JVVlVQwMtcSM0RcOk6zzDdHOMkDTje8OtO/L0gD20DUkDoJKi4ESAJ7OAwcHh+saEj5B ElcAcPuVFRx6mG8WIljubuA6c+n4y1Jzfcm0u1GumGgAeXzAnvjkGixw3Cp6pxW8sgas XdNro8RAhkKTAUZA9u8HFVXKlt5N4bS/zbDrbAAutEO+6qjrVdIo9sDUGWqDR+aFCRD3 uBH1X2Z5lf6MB/8UrVFdQFSqK65RkrzZU9zCUb2FufqEugm8rDP2pKSRbZInn6z220mj wnsg== X-Gm-Message-State: APjAAAVAMQii7Je/dHMrgM2ar1VAUVGE5nK3CV2jar39+UGP3ktmAX/z pmiuAjlNv8S5uHbuljJk5xvp28kDi5fr6M1iG4hUfzkzgDo= X-Google-Smtp-Source: APXvYqycsZ8fbWLeDyGIVZw8gKicnm8bwX6/DHmA5VEEAXA4mzmfG1Zqf9/B+0w525hPIjnqLOpjRBpusv/hEB7/fN0= X-Received: by 2002:adf:f104:: with SMTP id r4mr3810049wro.140.1564069130730; Thu, 25 Jul 2019 08:38:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 25 Jul 2019 16:38:38 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497 To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f10985058e83383d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f10985058e83383d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Jul 24, 2019 at 12:58 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the updated patch with Documentation for Identity/Generated > columns and updated screenshots. > Please ignore the previous patch. > > On Wed, Jul 24, 2019 at 12:39 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have added the support of Generated Columns (PG/EPAS 12) and also fixed >> RM #4496, #4497. >> >> During the implementation of that I have also fixed following issues that >> I encountered: >> >> - User should not be able to provide Default value with Identity >> column. >> - 'Drop Cascade' button to delete multiple columns should be disabled. >> - Set "Not Null?" switch to 'Yes' when we create Identity column. >> - Fix issue when we insert default value for the column and then >> remove it. It generates wrong msql. >> - Fix issue when we provide the default value of a column and then >> select the datatype to serial/bigserial/smallserial, it generates wrong >> msql. >> >> Modified/Added regression test cases for adding Identity column and >> Generated columns. >> Please review it. >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000f10985058e83383d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Jul 24, 2019 at 12:58 PM Aks= hay Joshi <akshay.joshi= @enterprisedb.com> wrote:
Hi Hackers,

Attached i= s the updated patch with Documentation for Identity/Generated columns and u= pdated screenshots.
Please ignore the previous patch.=C2=A0=C2=A0=

On Wed, Jul 24, 2019 at 12:39 PM Akshay Joshi <akshay.joshi@enterprisedb.c= om> wrote:
Hi Hackers,

I have added the support = of Generated Columns (PG/EPAS 12) and also fixed RM #4496, #4497.=C2=A0

During the implementation of that I have also fixed f= ollowing issues that I encountered:
  • User should not be able to provide Default value with Identity co= lumn.
  • 'Drop Cascade' button to d= elete multiple columns should be disabled.
  • Set "Not Null?" switch to 'Yes' when we create Identit= y column.
  • Fix issue when we insert defau= lt value for the column and then remove it. It generates wrong msql.
    • Fix issue when we provide the default value of= a column and then select the datatype to serial/bigserial/smallserial, it = generates wrong msql.
Modified/Added regression test ca= ses for adding Identity column and Generated columns.
Please revi= ew it.=C2=A0

--
Thanks & Regards
Akshay Joshi
= Sr. Software Architec= t
= EnterpriseDB Software= India Private Limited
Mobile: +91 976-788-8246


--
=
Thanks & Reg= ards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited=
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000f10985058e83383d--