Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKjrN-0003OY-8D for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Jun 2017 11:19:45 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dKjrL-0006ek-EY for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Jun 2017 11:19:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dKjr7-0006G7-2B for pgadmin-hackers@postgresql.org; Tue, 13 Jun 2017 11:19:29 +0000 Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dKjr3-0000Z8-0Z for pgadmin-hackers@postgresql.org; Tue, 13 Jun 2017 11:19:27 +0000 Received: by mail-it0-x232.google.com with SMTP id m62so38771288itc.0 for ; Tue, 13 Jun 2017 04:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4w0+8/SuZ7G4UcOtZYagKmC4t3RVW7hbqNGE4MP3hU4=; b=gaoJU6N6n7KyIXwphtMxE1BUvL2iiQjXXo6j+si+lZjFDTIVm9tBavm5fmyx6zK5BD HBUXC9q5/PrWVVeHk0cb62ksj+3kpHCRtLRFuVkbsbimZ1+1BtWtA/JNzsib1n/mD1Wd o8rR3iHNPyqYrr3DrHlRZu8MJxUOsq9H0Pelbmdi3JCqkfnpgA3GmHT+zVIt8vilpK2R HDIFpdPMBMhRBR63b7cZDOs6yxChg+CM/GfSoRW+pMATEGiU/psaiZ6bF1d6qciqRd0k cmyX/BbIEoM8r2H5ev7rmyK3nVs9ov3F8fVxC3dzUZcSHtdaDUqLctQ70c3jtRphxbLb 7eoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4w0+8/SuZ7G4UcOtZYagKmC4t3RVW7hbqNGE4MP3hU4=; b=DjowUmmshoRCq8eNZTM808HYx76mi8XjbkB9JZPB9Vm60wEl/WefxdSPG6FHYt7/ox qwie4utMR1gDbfOXaKUnQ9aw0S/ydtHkh6HBT8CBxHE2pHdpAGUPCQ7F8j6anFAbqDff COdE9imuSZagRJy0HdsaimgpIdeZCSiTPd4w1HPKI+yWUE0Oq4Yvq3WMId1CcGJ/ewqW kY4MK5zSeQDK3KfVbntEQTtTQAcqVjOX4zjjA9MP4vlHmaKbP2uDitOrUsw5qOEC3TuA JaW2FEjBalZ61ZiEnYteLtGehO8Epu5/ziDXk2gclMse+s2cJt4I0Ki3nEF2TMUzcn/7 qvtg== X-Gm-Message-State: AKS2vOxRQ5+Z7hu1d5GAkrTtxSSFgsJOed++wwAUMyo5zF30DxgIK2iy JD1CbD4BSpDgCxWHjuRzGtznBaKgEmQ8 X-Received: by 10.36.6.137 with SMTP id 131mr7500691itv.28.1497352762851; Tue, 13 Jun 2017 04:19:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.147 with HTTP; Tue, 13 Jun 2017 04:19:21 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 13 Jun 2017 12:19:21 +0100 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Surinder Kumar Cc: Ashesh Vashi , Shruti B Iyer , Joao Pedro De Almeida Pereira , Murtuza Zabuawala , pgadmin-hackers Content-Type: text/plain; charset="UTF-8" List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org On Tue, Jun 13, 2017 at 11:47 AM, Surinder Kumar wrote: > On Tue, Jun 13, 2017 at 4:05 PM, Dave Page wrote: >> >> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar >> wrote: >> > >> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page wrote: >> >> >> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi >> >> wrote: >> >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page wrote: >> >> >> >> >> >> And then I find a problem. Sigh. >> >> >> >> >> >> When running in the desktop runtime, under QtWekKit (the forked, >> >> >> updated version that is by far the best of the browser engines we've >> >> >> used), we get the attached error at startup. I don't see this under >> >> >> QtWebEngine, though as we've already found, that's not usable for >> >> >> other reasons. >> >> >> >> >> >> Is this fixable? >> >> > >> >> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html': >> >> > " >> >> > WebKit engine itself has not been updated since Qt 5.2 release. >> >> > That's >> >> > why >> >> > it didn't support recent changes in Web standards that happened after >> >> > 2013, >> >> > including: new JavaScript language standard ES2015 (also known as >> >> > ES6), >> >> > as >> >> > well as improvements in DOM API and CSS. >> >> > ... >> >> > " >> >> > >> >> > Could this be a reason? >> >> >> >> For the old webkit, certainly, but if you read further down, the >> >> version we're using has been updated and does now claim to support >> >> most of ES2015. >> > >> > In fact the modern browsers don't support ES6 JS so the JS files >> > containing >> > ES6 code are first transpiled using babel into JS that browsers >> > supports. >> >> Well, we *could* do that, but are we? I'm not sure the current code >> does anything more than lint and webpack it. > > Yes. babel is used in webpack config which converts JSX, JS and react JS > library code into browser supportable JS code and put them into generated > directory which we are then imported in sqleditor.js Ahh, yes - I see it (still getting my head around this stuff). So, perhaps we need a different transform to support webkit? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers