Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZekWF-0004bc-5X for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 13:55:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZekWE-0005NO-DE for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 13:55:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZekWD-0005NH-D3 for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 13:55:33 +0000 Received: from mail-yk0-x22f.google.com ([2607:f8b0:4002:c07::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZekWA-00014W-0E for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 13:55:31 +0000 Received: by ykft14 with SMTP id t14so41894428ykf.0 for ; Wed, 23 Sep 2015 06:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=vXLovjfrBeJzphWFQNOKqb/djZJkfM3nDbrNrGX9St4=; b=uxfjxnGZpkShONXMdXHN+nq7tnfUBHr7IzceurLJglcpMK7NwFGWMvZGTu7GhWLUiH dN/ZmAprpyXEmV5kTZKa92ESAyrxFaAq00UlK7YMmFHLqHCn1Li0PSIZCx6xDzVsrpeV B37mJn08iVS112Sp0Ds5rBStaH4stECwOCHVr/adbVqPwsulW5j76HpMbHntrJyex8GX QZSr916wkb+DR2pyDCcPMdipW3Q8Q7pNFJ+7DSpqg5a3+k2cZu7XVySVBfhSXgrqPW07 y5kcvFKeyyQKyGYdqPEu+hthVxaypkifTyxS+blUugDC6m3dWhmukcghWGMMrwPqk8Sf cTkg== MIME-Version: 1.0 X-Received: by 10.170.43.12 with SMTP id 12mr26007956ykl.104.1443016529198; Wed, 23 Sep 2015 06:55:29 -0700 (PDT) Received: by 10.129.115.134 with HTTP; Wed, 23 Sep 2015 06:55:29 -0700 (PDT) In-Reply-To: References: Date: Wed, 23 Sep 2015 07:55:29 -0600 Message-ID: Subject: Re: Patch: New field in frmMain statusbar From: Adam Scott To: Dave Page Cc: Magnus Hagander , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11379132a0cc1c05206a77a0 X-Pg-Spam-Score: -2.2 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11379132a0cc1c05206a77a0 Content-Type: text/plain; charset=UTF-8 Is the last patch okay? If there's something more required or anything please let me know. Thank you, Adam On Thu, Sep 17, 2015 at 7:47 AM, Adam Scott wrote: > Being consistent with the frmQuery probably helps the user as well. > Here's the patch to display the connection name as it is displayed in the > frmQuery. > > Thank you, > Adam > > > On Wed, Sep 16, 2015 at 9:30 AM, Dave Page wrote: > >> I think so - I realise it's not the display name (which would be >> ideal), but it is a condensed name that fully describes the >> connection. >> >> On Tue, Sep 15, 2015 at 4:01 PM, Adam Scott >> wrote: >> > If it displayed what's displayed in the Query editor would that be >> better? >> > >> > Thank you, >> > Adam >> > >> > >> > On Tue, Sep 15, 2015 at 8:41 AM, Adam Scott >> wrote: >> >> >> >> If you have a development host and a production host, the database >> names >> >> will be the same. I think the value of the having the new field goes >> away >> >> if you exclude the hostname. You won't know what host the object you >> are >> >> selecting belongs to. That could be the difference between modifying >> an >> >> object in development and production. >> >> >> >> It seems to me that what you could say about the display name is what >> >> could be said about the connection's display name in the tree control >> since >> >> this is what is displayed (plus the database name). >> >> >> >> What the patch displays answers the questions, "What connection am I >> on?" >> >> "What database am I on?" >> >> >> >> I guess I can work on adding another patch that allows you to customize >> >> what is displayed using frmOptions...? >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> On Tue, Sep 15, 2015 at 5:20 AM, Dave Page wrote: >> >>> >> >>> On Tue, Sep 15, 2015 at 12:14 PM, Magnus Hagander < >> magnus@hagander.net> >> >>> wrote: >> >>> > On Tue, Sep 15, 2015 at 10:55 AM, Dave Page >> wrote: >> >>> >> >> >>> >> On Mon, Sep 14, 2015 at 5:11 PM, Magnus Hagander < >> magnus@hagander.net> >> >>> >> wrote: >> >>> >> > The part that changed is just the one that added db1 and db2, >> right? >> >>> >> >> >>> >> It's the server display name *and* the database name, so to give a >> >>> >> (redacted) example from my machine, I would have: >> >>> >> >> >>> >> aws-ap-southeast-1b.xxxxxxxxxxxxxxxx.com (aws-ap-southeast-1b. >> >>> >> xxxxxxxxxxxxxxxx.com:5432):postgres >> >>> >> >> >>> >> Which as you can see is quite long. >> >>> > >> >>> > >> >>> > I thought the point of display names was to have them nice and >> short :) >> >>> > I've >> >>> > certainly never used displaynames that are that long. >> >>> >> >>> I generally use the full hostnames (as I have machines in multiple >> >>> domains) - and in the places that you currently see them, that length >> >>> is actually fine. >> >>> >> >>> > Yes, I totally see with names like that it becomes annoying, and >> >>> > certainly >> >>> > not easy to parse. Perhaps what we really shoul dhave is just >> >>> > displayname + >> >>> > databasename, and exclude the actual hostname? >> >>> >> >>> That would be an improvement, certainly. >> >>> >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >> >> >> >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11379132a0cc1c05206a77a0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Is the last patch okay?=C2=A0 If there's som= ething more required or anything please let me know.

Thank you= ,
Adam


On Thu, Sep 17, 2015 at 7:47 AM, Adam Scott &= lt;adam.c.scott= @gmail.com> wrote:
Being consistent with the frmQuery probably helps the us= er as well.=C2=A0 Here's the patch to display the connection name as it= is displayed in the frmQuery.

Thank you,
Adam
<= br>
On Wed, Sep 16, 2015 at 9:30 AM, Dave Page <= dpage@pgadmin.org> wrote:
I= think so - I realise it's not the display name (which would be
ideal), but it is a condensed name that fully describes the
connection.

On Tue, Sep 15, 2015 at 4:01 PM, Adam Scott <adam.c.scott@gmail.com> wrote:
> If it displayed what's displayed in the Query editor would that be= better?
>
> Thank you,
> Adam
>
>
> On Tue, Sep 15, 2015 at 8:41 AM, Adam Scott <adam.c.scott@gmail.com> wrote:=
>>
>> If you have a development host and a production host, the database= names
>> will be the same.=C2=A0 I think the value of the having the new fi= eld goes away
>> if you exclude the hostname.=C2=A0 You won't know what host th= e object you are
>> selecting belongs to.=C2=A0 That could be the difference between m= odifying an
>> object in development and production.
>>
>> It seems to me that what you could say about the display name is w= hat
>> could be said about the connection's display name in the tree = control since
>> this is what is displayed (plus the database name).
>>
>> What the patch displays answers the questions, "What connecti= on am I on?"
>> "What database am I on?"
>>
>> I guess I can work on adding another patch that allows you to cust= omize
>> what is displayed using frmOptions...?
>>
>>
>>
>>
>>
>>
>>
>>
>> On Tue, Sep 15, 2015 at 5:20 AM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> On Tue, Sep 15, 2015 at 12:14 PM, Magnus Hagander <magnus@hagander.net&g= t;
>>> wrote:
>>> > On Tue, Sep 15, 2015 at 10:55 AM, Dave Page <dpage@pgadmin.org> w= rote:
>>> >>
>>> >> On Mon, Sep 14, 2015 at 5:11 PM, Magnus Hagander <= magnus@hagander.ne= t>
>>> >> wrote:
>>> >> > The part that changed is just the one that added= db1 and db2, right?
>>> >>
>>> >> It's the server display name *and* the database n= ame, so to give a
>>> >> (redacted) example from my machine, I would have:
>>> >>
>>> >> aws-ap-southeast-1b.xxxxxxxxxxx= xxxxx.com (aws-ap-southeast-1b.
>>> >> xxxxxxxxxxxxxxxx.com:5432):postgres
>>> >>
>>> >> Which as you can see is quite long.
>>> >
>>> >
>>> > I thought the point of display names was to have them nic= e and short :)
>>> > I've
>>> > certainly never used displaynames that are that long.
>>>
>>> I generally use the full hostnames (as I have machines in mult= iple
>>> domains) - and in the places that you currently see them, that= length
>>> is actually fine.
>>>
>>> > Yes, I totally see with names like that it becomes annoyi= ng, and
>>> > certainly
>>> > not easy to parse. Perhaps what we really shoul dhave is = just
>>> > displayname +
>>> > databasename, and exclude the actual hostname?
>>>
>>> That would be an improvement, certainly.
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a11379132a0cc1c05206a77a0--