Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ag5mn-0002qx-QO for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Mar 2016 07:22:30 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1ag5mn-0005sk-8l for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Mar 2016 07:22:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ag5mY-0005dz-SF for pgadmin-hackers@postgresql.org; Wed, 16 Mar 2016 07:22:14 +0000 Received: from mail-yw0-x22c.google.com ([2607:f8b0:4002:c05::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1ag5mP-00049F-Q7 for pgadmin-hackers@postgresql.org; Wed, 16 Mar 2016 07:22:14 +0000 Received: by mail-yw0-x22c.google.com with SMTP id m126so27492977ywd.0 for ; Wed, 16 Mar 2016 00:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Jj+5zj2lzdc9AcaaTfo4PWyEwnP66h0gmH82ZZN3NkI=; b=0SVv9ZTcnCO5Id15DzNhwuHL52ZAT1MkuplcYzFHqEw1/soNJPuxVVNU7nFH8Wf193 pNM4EyEAKksTKrQOhBFmxBS00AfL8B0AXXs90kRvePhhEcORCpmJDWOzTwhthJkzOQ9G /ADpqD1kPPABpKFN38hRAqFS79gU6QfQlfHbrgOSsRBMweIQjtOxzuWxOS7LDm2GYjjb BQ72obTuyUSGJ4DI1vq+slkfXX9zlFLQLNFEPqxW5xI1Ow/JgXtgZeYfHQgO9C7QwXJs VVchc07qBvZGwc0NqDINSvoWqTGBc6uKo+Q6tVPrZEiXWOJ7QOL2MngcP3IZMriJ2Z4n mx7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Jj+5zj2lzdc9AcaaTfo4PWyEwnP66h0gmH82ZZN3NkI=; b=T6vfmzWkt2krod2dnxw3MkqVOvvD4Qiw8GYcafZKfBXofddYWs0/LDeU3JEmYJSHtc Ove4jPDAc5IWj+Llhwe2sG2o1AQPk7MAvNC+WAgNEZ+SMEUnAtsY5Bmb8sEWkgYwV6fd CgfQL9+D4Zhbgc+rhp7BCmR2iSC2A+WSBgWMseabiZAQM4SMIluR63U0vanjzY5fkX1q eZamZossUncp3Dgi/vemWUIgUh4iBYZkZd3mStLzrDqvmZ4qBSX2StvLV7rNcirRrqRj 3jxnuMsxfQqTXr1i5aiAN4bGlhB2BhkGz24rYlfYKoA9BGbeCRFLqMU8mUVjQK19rGjs Ix1w== X-Gm-Message-State: AD7BkJJGKq9BAYoVGWCivr/w0G7EIYA/kXxwOpQWLJb3NzeHJbZJ4sxrA5vDyYYfg4yO/PNg9Z1/lqk4Gegk1tT9 MIME-Version: 1.0 X-Received: by 10.37.55.131 with SMTP id e125mr442045yba.34.1458112923586; Wed, 16 Mar 2016 00:22:03 -0700 (PDT) Received: by 10.13.207.199 with HTTP; Wed, 16 Mar 2016 00:22:03 -0700 (PDT) In-Reply-To: References: Date: Wed, 16 Mar 2016 12:52:03 +0530 Message-ID: Subject: Re: patch for cast module From: Sanket Mehta To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11473ad8daaf4a052e255ec5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11473ad8daaf4a052e255ec5 Content-Type: text/plain; charset=UTF-8 Hi, I forgot tot mention bugs in previous mail. 1. System cast field was showing Yes even if the cast was not a system cast, which I have resolved. 2. In Dependent and Dependency method in __init__.py file, unnecessary third parameter 'cast' was being passed which I have removed Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Mar 16, 2016 at 12:43 PM, Sanket Mehta < sanket.mehta@enterprisedb.com> wrote: > Hi Dave, > > PFA the patch for cast module incorporating changes regarding showing > system objects. > Apart from support for showing system object I have resolved few bugs in > that, unnecessary code and added nodes.sql file. > > Please do review it and if it looks good, please commit. > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Fri, Mar 4, 2016 at 4:33 PM, Dave Page wrote: > >> Thanks, patch applied. >> >> On Tue, Mar 1, 2016 at 7:20 AM, Sanket Mehta >> wrote: >> > Hi, >> > >> > There was an error in cast module while fetching its dependency and >> > dependent. >> > Below is the patch which resolves this issue. >> > Please review and commit it. >> > >> > >> > >> > Regards, >> > Sanket Mehta >> > Sr Software engineer >> > Enterprisedb >> > >> > On Wed, Feb 24, 2016 at 10:17 PM, Dave Page wrote: >> >> >> >> Thanks - committed. >> >> >> >> On Tue, Feb 23, 2016 at 1:34 PM, Sanket Mehta >> >> wrote: >> >>> >> >>> Hi, >> >>> >> >>> PFA the revised patch as per your comments. >> >>> Please review it and let me know the feedback. >> >>> >> >>> Regards, >> >>> Sanket Mehta >> >>> Sr Software engineer >> >>> Enterprisedb >> >>> >> >>> On Tue, Feb 23, 2016 at 4:10 PM, Dave Page wrote: >> >>>> >> >>>> Hi >> >>>> >> >>>> I've attached an update to this patch, in which I've done some >> >>>> word-smithing on various comments, and adjusted the SQL templates to >> improve >> >>>> the formatting. >> >>>> >> >>>> However, it looks like it's bit-rotted, as the >> dependents/dependencies >> >>>> display is throwing Python errors. Please fix and then I think it's >> just >> >>>> about ready to commit. >> >>>> >> >>>> Thanks. >> >>>> >> >>>> >> >>>> On Fri, Feb 19, 2016 at 11:03 AM, Sanket Mehta >> >>>> wrote: >> >>>>> >> >>>>> Hi Dave, >> >>>>> >> >>>>> PFA the revise patch. >> >>>>> >> >>>>> It includes changes according to your review comments as well as >> >>>>> dependency/dependent part also. >> >>>>> >> >>>>> Let me know in case anything is missing. >> >>>>> >> >>>>> Regards, >> >>>>> Sanket Mehta >> >>>>> Sr Software engineer >> >>>>> Enterprisedb >> >>>>> >> >>>>> On Mon, Feb 15, 2016 at 10:25 PM, Dave Page >> wrote: >> >>>>>> >> >>>>>> And this time with the attachment... >> >>>>>> >> >>>>>> On Mon, Feb 15, 2016 at 4:53 PM, Dave Page >> wrote: >> >>>>>>> >> >>>>>>> That's much better. Just a couple of comments now, partly based >> on an >> >>>>>>> email I wrote earlier: >> >>>>>>> >> >>>>>>> - There is still inconsistency in comment style. Please see the >> >>>>>>> attachment for an example. Note that there is *always* a space >> between the >> >>>>>>> comment marker and text. >> >>>>>>> >> >>>>>>> - If I try to edit a cast, I can change the description - but no >> SQL >> >>>>>>> is shown on the SQL tab, despite the comment being correctly >> applied when I >> >>>>>>> hit save. The properties pane of the main window is also not >> updated. >> >>>>>>> >> >>>>>>> Otherwise, it looks fine. >> >>>>>>> >> >>>>>>> Thanks. >> >>>>>>> >> >>>>>>> On Mon, Feb 15, 2016 at 1:28 PM, Sanket Mehta >> >>>>>>> wrote: >> >>>>>>>> >> >>>>>>>> Hi, >> >>>>>>>> >> >>>>>>>> PFA the revised patch with all the required comments. >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> >> >>>>>>>> Regards, >> >>>>>>>> Sanket Mehta >> >>>>>>>> Sr Software engineer >> >>>>>>>> Enterprisedb >> >>>>>>>> >> >>>>>>>> On Mon, Feb 15, 2016 at 4:18 PM, Dave Page >> >>>>>>>> wrote: >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta >> >>>>>>>>> wrote: >> >>>>>>>>>> >> >>>>>>>>>> Hi Dave, >> >>>>>>>>>> >> >>>>>>>>>> Regarding your suggestion of putting some comments in >> javascript, >> >>>>>>>>>> I think I have already put some comments regarding model data >> and their >> >>>>>>>>>> controls if any extended. >> >>>>>>>>>> >> >>>>>>>>>> Can you please let me know where exactly you think more >> comments >> >>>>>>>>>> are required? >> >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> Hi >> >>>>>>>>> >> >>>>>>>>> The issue for me is that jQuery code isn't the easiest to read >> at >> >>>>>>>>> the best of times, with nested/anonymous functions and inline >> JSON etc. As I >> >>>>>>>>> look through the code for the various nodes in isolation, it's >> extremely >> >>>>>>>>> difficult to get a sense of what exactly each part of the code >> is doing. In >> >>>>>>>>> this example, what I see by reading the code is: >> >>>>>>>>> >> >>>>>>>>> - Define the required libraries (require.js stuff) >> >>>>>>>>> - Extend the collection class >> >>>>>>>>> - Extend the node class >> >>>>>>>>> - Define an init function inline >> >>>>>>>>> - Add the menu options >> >>>>>>>>> >> >>>>>>>>> That part is fairly easy to figure out (easier because there are >> >>>>>>>>> blank lines between the logical sections). From there though, >> it becomes >> >>>>>>>>> much harder; >> >>>>>>>>> >> >>>>>>>>> - There are no blank lines to separate logical code sections at >> all >> >>>>>>>>> between line 48 and 235 (there is one blank line, but it >> doesn't separate >> >>>>>>>>> code sections). >> >>>>>>>>> - There are 4 comments that I can see. The first two are >> identical, >> >>>>>>>>> and appear to have identical code blocks following them for >> reasons that are >> >>>>>>>>> not even remotely obvious. >> >>>>>>>>> - As a newcomer to this code, I'm wondering if it's purpose is >> to >> >>>>>>>>> define the backform model. If so, why is it not broken up into >> sections with >> >>>>>>>>> a comment to tell me what field each block handles, and any >> other useful >> >>>>>>>>> information I may need to know? If it's not, then what is it >> for? >> >>>>>>>>> >> >>>>>>>>> So... I'm not going to tell you exactly where to put comments, >> >>>>>>>>> because the point is that without spending a couple of hours >> understanding >> >>>>>>>>> this, I simply don't know. The point of the comments (and >> separation of >> >>>>>>>>> logical sections of code with blank lines) is to make it easy >> for another >> >>>>>>>>> developer (especially one as rusty as me) to read and >> understand, then fix >> >>>>>>>>> and improve. Be generous with comments, but don't use them >> unnecessarily >> >>>>>>>>> (e.g. "a = 1 // Set a to one"). >> >>>>>>>>> >> >>>>>>>>> Of course, this is not just directed at you Sanket - it's >> something >> >>>>>>>>> all of us working on pgAdmin need to keep in mind. >> >>>>>>>>> >> >>>>>>>>> Thanks. >> >>>>>>>>> >> >>>>>>>>> -- >> >>>>>>>>> Dave Page >> >>>>>>>>> Blog: http://pgsnake.blogspot.com >> >>>>>>>>> Twitter: @pgsnake >> >>>>>>>>> >> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>>>>>>> The Enterprise PostgreSQL Company >> >>>>>>>> >> >>>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> >> >>>>>>> -- >> >>>>>>> Dave Page >> >>>>>>> Blog: http://pgsnake.blogspot.com >> >>>>>>> Twitter: @pgsnake >> >>>>>>> >> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>>>>> The Enterprise PostgreSQL Company >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> -- >> >>>>>> Dave Page >> >>>>>> Blog: http://pgsnake.blogspot.com >> >>>>>> Twitter: @pgsnake >> >>>>>> >> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>>>> The Enterprise PostgreSQL Company >> >>>>> >> >>>>> >> >>>> >> >>>> >> >>>> >> >>>> -- >> >>>> Dave Page >> >>>> Blog: http://pgsnake.blogspot.com >> >>>> Twitter: @pgsnake >> >>>> >> >>>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>> The Enterprise PostgreSQL Company >> >>> >> >>> >> >> >> >> >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11473ad8daaf4a052e255ec5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I forgot tot mention bugs in previous= mail.


1. System cast field was showing Yes even if the ca= st was not a system cast, which I have resolved.
2. In Dependent a= nd Dependency method in __init__.py=C2=A0 file, unnecessary third parameter= 'cast' was being passed which I have removed



Regards,
Sanket Mehta
Sr Software engineer=
Enterprisedb

On Wed, Mar 16, 2016 at 12:43 PM, Sanket Meh= ta <sanket.mehta@enterprisedb.com> wrote:
Hi Dave,

PFA the patch for cast module incorporating changes regarding showing sys= tem objects.
Apart from support for showing system object I h= ave resolved few bugs in that, unnecessary code and added nodes.sql file.
Please do review it and if it looks good, please commit.

<= div>
Regards,
Sanket Mehta
Sr Software engine= er
Enterprisedb

On Fri, Mar 4,= 2016 at 4:33 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Tue, Mar 1, 2016 at 7:20 AM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi,
>
> There was an error in cast module while fetching its dependency and > dependent.
> Below is the patch which resolves this issue.
> Please review and commit it.
>
>
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Wed, Feb 24, 2016 at 10:17 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Thanks - committed.
>>
>> On Tue, Feb 23, 2016 at 1:34 PM, Sanket Mehta
>> <sanket.mehta@enterprisedb.com> wrote:
>>>
>>> Hi,
>>>
>>> PFA the revised patch as per your comments.
>>> Please review it and let me know the feedback.
>>>
>>> Regards,
>>> Sanket Mehta
>>> Sr Software engineer
>>> Enterprisedb
>>>
>>> On Tue, Feb 23, 2016 at 4:10 PM, Dave Page <dpage@pgadmin.org> wrote: >>>>
>>>> Hi
>>>>
>>>> I've attached an update to this patch, in which I'= ve done some
>>>> word-smithing on various comments, and adjusted the SQL te= mplates to improve
>>>> the formatting.
>>>>
>>>> However, it looks like it's bit-rotted, as the depende= nts/dependencies
>>>> display is throwing Python errors. Please fix and then I t= hink it's just
>>>> about ready to commit.
>>>>
>>>> Thanks.
>>>>
>>>>
>>>> On Fri, Feb 19, 2016 at 11:03 AM, Sanket Mehta
>>>> <sanket.mehta@enterprisedb.com> wrote:
>>>>>
>>>>> Hi Dave,
>>>>>
>>>>> PFA the revise patch.
>>>>>
>>>>> It includes changes according to your review comments = as well as
>>>>> dependency/dependent part also.
>>>>>
>>>>> Let me know in case anything is missing.
>>>>>
>>>>> Regards,
>>>>> Sanket Mehta
>>>>> Sr Software engineer
>>>>> Enterprisedb
>>>>>
>>>>> On Mon, Feb 15, 2016 at 10:25 PM, Dave Page <dpage@pgadmin.org> = wrote:
>>>>>>
>>>>>> And this time with the attachment...
>>>>>>
>>>>>> On Mon, Feb 15, 2016 at 4:53 PM, Dave Page <dpage@pgadmin.org&g= t; wrote:
>>>>>>>
>>>>>>> That's much better. Just a couple of comme= nts now, partly based on an
>>>>>>> email I wrote earlier:
>>>>>>>
>>>>>>> - There is still inconsistency in comment styl= e. Please see the
>>>>>>> attachment for an example. Note that there is = *always* a space between the
>>>>>>> comment marker and text.
>>>>>>>
>>>>>>> - If I try to edit a cast, I can change the de= scription - but no SQL
>>>>>>> is shown on the SQL tab, despite the comment b= eing correctly applied when I
>>>>>>> hit save. The properties pane of the main wind= ow is also not updated.
>>>>>>>
>>>>>>> Otherwise, it looks fine.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> On Mon, Feb 15, 2016 at 1:28 PM, Sanket Mehta<= br> >>>>>>> <sanket.mehta@enterprisedb.com> wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> PFA the revised patch with all the require= d comments.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Sanket Mehta
>>>>>>>> Sr Software engineer
>>>>>>>> Enterprisedb
>>>>>>>>
>>>>>>>> On Mon, Feb 15, 2016 at 4:18 PM, Dave Page= <dpage@pgadmin.o= rg>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Feb 15, 2016 at 8:10 AM, Sanke= t Mehta
>>>>>>>>> <sanket.mehta@enterprisedb.com> wrot= e:
>>>>>>>>>>
>>>>>>>>>> Hi Dave,
>>>>>>>>>>
>>>>>>>>>> Regarding your suggestion of putti= ng some comments in javascript,
>>>>>>>>>> I think I have already put some co= mments regarding model data and their
>>>>>>>>>> controls if any extended.
>>>>>>>>>>
>>>>>>>>>> Can you please let me know where e= xactly you think more comments
>>>>>>>>>> are required?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> The issue for me is that jQuery code i= sn't the easiest to read at
>>>>>>>>> the best of times, with nested/anonymo= us functions and inline JSON etc. As I
>>>>>>>>> look through the code for the various = nodes in isolation, it's extremely
>>>>>>>>> difficult to get a sense of what exact= ly each part of the code is doing. In
>>>>>>>>> this example, what I see by reading th= e code is:
>>>>>>>>>
>>>>>>>>> - Define the required libraries (requi= re.js stuff)
>>>>>>>>> - Extend the collection class
>>>>>>>>> - Extend the node class
>>>>>>>>>=C2=A0 =C2=A0- Define an init function = inline
>>>>>>>>>=C2=A0 =C2=A0- Add the menu options
>>>>>>>>>
>>>>>>>>> That part is fairly easy to figure out= (easier because there are
>>>>>>>>> blank lines between the logical sectio= ns). From there though, it becomes
>>>>>>>>> much harder;
>>>>>>>>>
>>>>>>>>> - There are no blank lines to separate= logical code sections at all
>>>>>>>>> between line 48 and 235 (there is one = blank line, but it doesn't separate
>>>>>>>>> code sections).
>>>>>>>>> - There are 4 comments that I can see.= The first two are identical,
>>>>>>>>> and appear to have identical code bloc= ks following them for reasons that are
>>>>>>>>> not even remotely obvious.
>>>>>>>>> - As a newcomer to this code, I'm = wondering if it's purpose is to
>>>>>>>>> define the backform model. If so, why = is it not broken up into sections with
>>>>>>>>> a comment to tell me what field each b= lock handles, and any other useful
>>>>>>>>> information I may need to know? If it&= #39;s not, then what is it for?
>>>>>>>>>
>>>>>>>>> So... I'm not going to tell you ex= actly where to put comments,
>>>>>>>>> because the point is that without spen= ding a couple of hours understanding
>>>>>>>>> this, I simply don't know. The poi= nt of the comments (and separation of
>>>>>>>>> logical sections of code with blank li= nes) is to make it easy for another
>>>>>>>>> developer (especially one as rusty as = me) to read and understand, then fix
>>>>>>>>> and improve. Be generous with comments= , but don't use them unnecessarily
>>>>>>>>> (e.g. "a =3D 1 // Set a to one&qu= ot;).
>>>>>>>>>
>>>>>>>>> Of course, this is not just directed a= t you Sanket - it's something
>>>>>>>>> all of us working on pgAdmin need to k= eep in mind.
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterpri= sedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com=
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com=
>>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a11473ad8daaf4a052e255ec5--