Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2vod-0001LA-Se for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 07:22:48 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b2vod-0005FA-5L for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 May 2016 07:22:47 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b2voc-0005F0-2q for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 07:22:46 +0000 Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b2voU-0004F0-A5 for pgadmin-hackers@postgresql.org; Wed, 18 May 2016 07:22:44 +0000 Received: by mail-vk0-x22c.google.com with SMTP id c189so50312761vkb.1 for ; Wed, 18 May 2016 00:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Af9OM6B+tED+IZD1MWf5MQYQlDqv/TiGTXk/TI1aUMs=; b=wo+XqnARirNbHFN02L1bCxHTWDMK9/ECRLp4wx01EEWtiwyvaVozFWE4uQwJljY5UV IFFazrPmi7ofAQ70outXND/U+pGa9gkUtew+3Y7o2xV+drDMSw5cpFtr8qcS4e+AHiU9 2HJEpTPQ03bzvBORc8+fS9+xDYU+EaJx6YVOHmr/wCE7mgo0n9SNiYV32UC5ozu12MTr q9DsGHoQJqmj14FMuTPPifW+kgWJxroNHi04rojw8UJFhfWyic1NyVCOISPTfhY3ycY8 AM2cKRZKgQ1fZ9n0ZnBCRsaKpS+ZrWWOtfZEDRsZa61nwbgGCDwwm871bx8ZOlHo4H4F F50A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Af9OM6B+tED+IZD1MWf5MQYQlDqv/TiGTXk/TI1aUMs=; b=Tf+TruA2IFzQkF+z2AvubGSp+mTaohdGimixPogKRIlAR31kcoL2UoC8/oE84C/1jv ARJ2fLzb/sKA4HyFl9cpXKHAqX86VCU5cA0OP1Voa43/NQ7GwoayKUW/2OF158JkwyKA rY7IzdDQtoXo2APTHOXx9F22q6fFDxks/qy9XnkY1itlET8OWL2/Tjn2bHw6nqXyMmPe Mm5ajn4xcsymeXSI2UMpOQBIeoxjP6vn0944AeRuP05Szxev2T/lO5u7VzI2QE1TVgXT bokl5y4+0qLjEudO4B1P9vJn0Qy8GWNdBZ43riNzqYP4LmFJErbUIJ63gkXJrVyYDcvu q/7A== X-Gm-Message-State: AOPr4FVPGzntfgriL3j76gj5ON7BST0ljZTMuAl8dcuFrscnm6pez3bGqdttZ2ZvtiYi3EwzDDl6cyS7+EG2ZV2+ MIME-Version: 1.0 X-Received: by 10.176.69.178 with SMTP id u47mr1194399uau.148.1463556157478; Wed, 18 May 2016 00:22:37 -0700 (PDT) Received: by 10.31.189.70 with HTTP; Wed, 18 May 2016 00:22:37 -0700 (PDT) In-Reply-To: References: Date: Wed, 18 May 2016 12:52:37 +0530 Message-ID: Subject: Re: PATCH: FTS configuration node From: Sanket Mehta To: Ashesh Vashi Cc: Harshal Dhumal , Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c11bd86e02dbd053318b840 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c11bd86e02dbd053318b840 Content-Type: text/plain; charset=UTF-8 On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > On Wed, May 18, 2016 at 12:41 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi, >> >> PFA the revised patch. >> Response is lnline. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Tue, May 17, 2016 at 12:54 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi Sanket, >>> >>> Please find my review comments below: >>> >>> 1. In create mode it generates wrong sql. >>> >>> CREATE TEXT SEARCH CONFIGURATION test.asdf ( >>> COPY= >>> ); >>> >>> steps to reproduce: >>> a] Fill up any necessary fields in general tab. >>> b] On definition tab set Copy config filed and navigate to SQL tab. >>> c] Come back again to definition tab clear Copy config field and set >>> Parser field and again navigate to SQL tab >>> >> Fixed >> >>> >>> 2. Create new FTS configuration with parser throws below error. >>> >>> provide atleast copy config or parser. >>> >>> (this is because you have used key name for parser in js as "prsname" >>> and in python you have applied validations on key "parser") >>> >> Fixed >> >>> >>> 3. When we clear dictionary for any token using cross (x) button in >>> select2; JavaScript code for selecct2 fails. (see attached screenshot) >>> >> This occurs due to issue in select2 control. Its a generalized issue >> which will be resolved later. >> > When you say - it is common issue, can you please point where else you've > seen this behaviour? > The same behaviour occurs in all nodes where multiselect cell is being used like, exclusion control, debugger etc. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> >>> >>> >>> >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer * >>> >>> >>> >>> EenterpriseDB >>> >>> On Mon, May 16, 2016 at 7:37 PM, Sanket Mehta < >>> sanket.mehta@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> Revised patch is attached with this mail. >>>> My response is inline. >>>> >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> On Fri, May 13, 2016 at 6:20 PM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Sanket >>>>> >>>>> Below are my review comments: >>>>> >>>>> >>>>> - Add button should be disabled in Tokens tab while creating. >>>>> >>>>> Done >>>> >>>>> >>>>> - Unable to click on down arrow for token select control. >>>>> >>>>> Done >>>> >>>>> >>>>> - Title should be change from "Create FTS-dictionaries" to "Create >>>>> FTS-Configuration". >>>>> >>>>> Done >>>> >>>>> >>>>> - Tree node is not getting refreshed on name change. >>>>> >>>>> Done >>>> >>>>> >>>>> - Unable to rename FTS Configuration when name contains any >>>>> capital letter. >>>>> >>>>> Done >>>> >>>>> >>>>> - If user tries to add already existing token then respective row >>>>> in the backgrid should be highlighted. >>>>> >>>>> Done >>>> >>>>> >>>>> - "URL not found" when click on SQL help icon from the properties >>>>> dialog. >>>>> >>>>> Done >>>> >>>>> >>>>> - SQL should not be generated when remove and add the same token >>>>> again. Currently it is creating two sql's one for remove and >>>>> another is for add. >>>>> - *Fix for the above issue is*: - Add "keys: ['token']," to >>>>> TokenModel in your js file. >>>>> >>>>> Done >>>> >>>> >>>>> >>>>> On Fri, May 13, 2016 at 2:58 PM, Sanket Mehta < >>>>> sanket.mehta@enterprisedb.com> wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> Last patch for FTS configuration does not contain node.ui.js file >>>>>> Kindly ignore it. >>>>>> >>>>>> Here is the new revised patch attached with this mail. >>>>>> Please do review it and let me know if any changes required >>>>>> >>>>>> Regards, >>>>>> Sanket Mehta >>>>>> Sr Software engineer >>>>>> Enterprisedb >>>>>> >>>>>> On Thu, May 12, 2016 at 4:38 PM, Sanket Mehta < >>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> PFA the revised patch. >>>>>>> Please do review it and let me know if anything is not proper. >>>>>>> >>>>>>> Regards, >>>>>>> Sanket Mehta >>>>>>> Sr Software engineer >>>>>>> Enterprisedb >>>>>>> >>>>>>> On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal < >>>>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> + patch link >>>>>>>> >>>>>>>> >>>>>>>> http://www.postgresql.org/message-id/CAFiP3vwkka+=1FOJ7kr2zbC4AzecoCa9eO9DZ34-Oyy_9gE92g@mail.gmail.com >>>>>>>> >>>>>>>> -- >>>>>>>> *Harshal Dhumal* >>>>>>>> *Software Engineer * >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> EenterpriseDB >>>>>>>> >>>>>>>> On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta < >>>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> PFA first patch for FTS configuration node. >>>>>>>>> >>>>>>>>> It depends upon backgrid select2cell multi select control, for >>>>>>>>> which Harshal has sent the patch recently. >>>>>>>>> Please do apply his patch first and then apply this patch. >>>>>>>>> >>>>>>>>> Please do review it and let me know if any changes are required. >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Sanket Mehta >>>>>>>>> Sr Software engineer >>>>>>>>> Enterprisedb >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>> To make changes to your subscription: >>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> *Principal Software Engineer * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --94eb2c11bd86e02dbd053318b840 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= On Wed, May 18, 2016 at 12:42 PM, Ashesh Vashi <ashesh.vashi@e= nterprisedb.com> wrote:

On Wed,= May 18, 2016 at 12:41 PM, Sanket Mehta <sanket.mehta@enterpri= sedb.com> wrote:

Hi,

PFA the revised patch.
Response is lnline.
Regards,
Sanket Mehta
<= div>Sr Software engineer
Enterprisedb

On Tue, May 17, 2016 at 12:54 P= M, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
= Hi Sanket,

Please find my review comments below:

= 1. In create mode it generates wrong sql.

CREATE TEXT SEARCH CONFIGU= RATION test.asdf (
=C2=A0=C2=A0=C2=A0 COPY=3D
);
steps to reproduce:
=C2=A0=C2=A0=C2=A0 a] Fill up any necessa= ry fields in general tab.
=C2=A0=C2=A0=C2=A0 b] On definition tab set Co= py config filed and navigate to SQL tab.
=C2=A0=C2=A0=C2=A0 c] Com= e back again to definition tab clear Copy config field and set Parser field= and again navigate to SQL tab
Fixe= d=C2=A0

2.= Create new FTS configuration with parser throws below error.

provide atleast copy config or pars= er.

(this is because you have used key = name for parser in js as "prsname" and in python you have applied= validations on key "parser")
=
Fixed=C2=A0

3. When we clear dictionary for any token using cross (x) butt= on in select2; JavaScript code for selecct2 fails. (see attached screenshot= )
This occurs due to issue in select2 con= trol. Its a generalized issue which will be resolved later.
When you say - it is common issue, can you= please point where else you've seen this behaviour?
<= /div>
The same behaviour occurs in all nodes where multise= lect cell is being used like, exclusion control, debugger etc.

--

Thanks &a= mp; Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2= =A0Enterp= rise PostgreSQL Company


http://www.linkedin.com/in/ash= eshvashi=C2=A0






--=C2=A0
Harshal = Dhumal
Software Engineer=C2=A0




On Mon, May 16, 2016 at 7:3= 7 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

Revis= ed patch is attached with this mail.
My response is inline.
=


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Fri, May 13, 2016 at 6:20 PM= , Akshay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Hi Sanket=C2=A0
Below are my review comments:

    =
  • Add button should be disabled in Tokens tab while creating.
Done=C2=A0
  • Unable to click on down arrow for token se= lect control.=C2=A0
Done= =C2=A0
  • Title shou= ld be change from "Create FTS-dictionaries" to "= ;Create FTS-Configuration".
Done=C2=A0
  • Tree node is not getting refreshed on name change.
    • <= /ul>
Done=C2=A0
  • Unable to rename FTS Config= uration when name contains any capital letter.
Done=C2=A0
  • If user tries to add already existing token then respective= row in the backgrid should be highlighted.
Done=C2=A0
  • "URL not found" when click on SQL= help icon from the properties dialog.=C2=A0
<= /div>
Done=C2=A0
=
  • SQL should not be generated when= remove and add the same token again. Currently it is creating two sq= l's one for remove and another is for add.
    • Fix fo= r the above issue is: - Add "keys: ['token']," to TokenModel in your js file.
Done
=C2=A0

O= n Fri, May 13, 2016 at 2:58 PM, Sanket Mehta <sanket.mehta@en= terprisedb.com> wrote:
H= i All,

Last patch for FTS configuration does not contain= node.ui.js file
Kindly ignore it.

Here = is the new revised patch attached with this mail.
Please do revie= w it and let me know if any changes required

Regards,
San= ket Mehta
Sr Software engineer
Enterprisedb
=

On Thu, May 12, 2016 at 4:3= 8 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA t= he revised patch.
Please do review it and let me know if anything= is not proper.

Regards,
Sanket Mehta
Sr Softwa= re engineer
Enterprisedb

On Thu, May 5, 2016 at 8:19= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:

--=C2=A0
Ha= rshal Dhumal
Software Engineer=C2=A0

On Thu, May 5, 2016 at 8:18 PM, Sa= nket Mehta <sanket.mehta@enterprisedb.com> wrote= :
Hi,

PFA first patch for FTS configuration node.

It depends upon backgrid select2cell multi select control, for which Har= shal has sent the patch recently.
Please do apply his patch first= and then apply this patch.

Please do review it an= d let me know if any changes are required.


Regards,
Sanket Mehta
S= r Software engineer
Enterprisedb


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi
Principal Softw= are Engineer=C2=A0
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">
<= /b>
=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /font>



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--94eb2c11bd86e02dbd053318b840--