public inbox for [email protected]  

help / color / mirror / Atom feed

From: Sanket Mehta <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: graphical explain
Date: Mon, 18 Apr 2016 12:48:42 +0530
Message-ID: <CA+yw=mMfo+uPB=bkdFD=tLvvEp5F6R0_G2woeToSEdZijEFsZg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyHV6BNUnZrNy3Zu=JoWsiG_Pv8=NyPzCpc4jgK=2mnhQ@mail.gmail.com>
References: <CA+yw=mOxpdmFpuA2PBp3z_0H0=3gMncuy=c8B61oDs+REyjbEQ@mail.gmail.com>
	<CA+yw=mMQS7GMcq0GGENbOrw4iJJQMmeDomehrZ985X-yJz0RFA@mail.gmail.com>
	<CA+OCxoyHV6BNUnZrNy3Zu=JoWsiG_Pv8=NyPzCpc4jgK=2mnhQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave,

Regarding your second comment,
Almost all the libraries that I have checked uses Jquery UI which is quite
heavy.
Please share your comments about using these libraries.


Meanwhile currently I have implemented zoom in/out functionality in
graphical explain.
I have added two buttons on left top corner of panel (see the attached
screen shot),
which you can use to zoom in/out the graph.

Please do review it and let me know your comments about them.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Wed, Apr 13, 2016 at 2:23 PM, Dave Page <[email protected]> wrote:

> Hi,
>
> A couple of comments following a quick test:
>
> 1) Some of the horizontal lines are not actually horizontal - they
> noticeably drop down. Please see the attached screenshot.
>
> 2) I thought we were going to use a "viewport" to allow the user to
> navigate through the diagram? I was thinking of displaying a thumbnail
> with viewport in the top-left, with the main view being synchronised
> to the viewport position/zoom level - for example, look at the 2D Zoom
> example on http://www.ajax-zoom.com/. Something like Croppie might
> help: http://foliotek.github.io/Croppie/ (as ajax-zoom is not free).
>
> On Tue, Apr 12, 2016 at 11:36 AM, Sanket Mehta
> <[email protected]> wrote:
> > Hi,
> >
> > Please do ignore previous patch as it contains trailing whitespaces.
> > PFA the revised patch after resolving this issue.
> >
> >
> >
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> > On Mon, Apr 11, 2016 at 10:04 PM, Sanket Mehta
> > <[email protected]> wrote:
> >>
> >> Hi,
> >>
> >> PFA the patch for graphical explain feature.
> >>
> >> It consists of explain.js, __init__.py and demo_explain.html,
> snap_svg.js
> >> and snap_svg-min.js file.
> >>
> >> Currently I have placed hard coded JSON data in demo_explain.html file
> to
> >> display graphical output; which will be replace by actual output user
> get
> >> from server in JSON format.
> >>
> >> Use below URL to access graphical output:
> >>
> >> http://localhost:5050/misc/explain where 5050 is the port your web
> server
> >> is running on
> >>
> >> To test the patch, user can replace plan data (stored in 'data'
> variable)
> >> in demo_explain.html with other valid plan data in JSON format and run
> the
> >> above URL.
> >>
> >> Please review the patch and provide comments for the same.
> >>
> >> TODO: Integration of graphical explain into sql editor
> >>
> >>
> >> Regards,
> >> Sanket Mehta
> >> Sr Software engineer
> >> Enterprisedb
> >
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list ([email protected])
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [image/png] Screen Shot 2016-04-18 at 12.43.55 PM.png (106.7K, 3-Screen%20Shot%202016-04-18%20at%2012.43.55%20PM.png)
  download | view image

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: graphical explain
  In-Reply-To: <CA+yw=mMfo+uPB=bkdFD=tLvvEp5F6R0_G2woeToSEdZijEFsZg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox