Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zc8tR-0002zo-TE for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Sep 2015 09:20:46 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zc8tQ-0000jg-UO for pgadmin-hackers@arkaria.postgresql.org; Wed, 16 Sep 2015 09:20:44 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zc8tD-0000VC-9E for pgadmin-hackers@postgresql.org; Wed, 16 Sep 2015 09:20:31 +0000 Received: from mail-yk0-f180.google.com ([209.85.160.180]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1Zc8tA-0001k5-Al for pgadmin-hackers@postgresql.org; Wed, 16 Sep 2015 09:20:29 +0000 Received: by ykdg206 with SMTP id g206so212487539ykd.1 for ; Wed, 16 Sep 2015 02:20:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5BGI6HLWDinAqC+nWnJ4cJ5Q+u3vz4GcWhJwX2kF14w=; b=MHaAfCHFHg0t9aKxek5z7F91xJhd8Ho36bXse/U1RMCI7xnKrn3JjZI0yNS6hWJBOy aVo2IbmecQ/QYvwclRDeP9x+Law7BH0SkwaaVNws3TE+K7m+Vvw9CbWXQBqrluOLG/gZ dasj/rtSbdsr+20IckrPxcETTrqNSjKOt79IBMs11p87z+8KfDLUD4bzI0mcJRxQ2xD2 UUuTJCZBgAVxzde7NaeYh7BCxSR9QD9QiRQT+m5K9vMuA5XjnRfJLRRlk+s0RaiTzmWq xGJp7TrXqcixS9Fh5CJkfnabZ/G+GZBETGTKPiBmjeoO70ehBS+Igq1OTgJIK8HLHjZp 6+8w== X-Gm-Message-State: ALoCoQnq2vp4bOZSox1cby3Lzaal9pTiLF2ZlLB7F5L3PNvoPQto5q10ivNvFvgB2DM+K7ymdsPI MIME-Version: 1.0 X-Received: by 10.13.204.22 with SMTP id o22mr25977360ywd.146.1442395227350; Wed, 16 Sep 2015 02:20:27 -0700 (PDT) Received: by 10.13.240.196 with HTTP; Wed, 16 Sep 2015 02:20:27 -0700 (PDT) In-Reply-To: References: Date: Wed, 16 Sep 2015 11:20:27 +0200 Message-ID: Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2 From: Sanket Mehta To: Ashesh Vashi Cc: pgadmin-hackers , John Obaterspok Content-Type: multipart/alternative; boundary=001a114827ac27214d051fd9cfd9 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114827ac27214d051fd9cfd9 Content-Type: text/plain; charset=UTF-8 Hi John, Patch is not proper. I got below error when I try to apply the patch: error: patch failed: pgadmin/frm/frmQuery.cpp:2435 error: pgadmin/frm/frmQuery.cpp: patch does not apply Please do provide the proper patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta < sanket.mehta@enterprisedb.com> wrote: > Sure Ashesh, > > I will review the patch. > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Sanket, >> >> Can you please take a look at it? >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok < >> john.obaterspok@gmail.com> wrote: >> >>> Hello, >>> >>> I'm updated the patch to add commit/rollback actions in the toolbar with >>> the following: >>> 1) updated icons (based on existing pgadmin icon with arrows drawn by me) >>> 2) add entry to menu as well >>> 3) disable icons when not in a transaction >>> 4) Ctrl+Shift C|R shortcut >>> >>> Hopefully all issues are resolved now! >>> >>> Regards, >>> >>> John >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > --001a114827ac27214d051fd9cfd9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi John,

Patch is not proper.<= br>
I got below error when I try to apply the patch:

error: pat= ch failed: pgadmin/frm/frmQuery.cpp:2435
error: pgadmin/frm/frmQuery.cpp= : patch does not apply

Please do provide the proper patch.
= =C2=A0

Regards,
Sanket Mehta
= Sr Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 10:51 AM, Sanket Meh= ta <sanket.mehta@enterprisedb.com> wrote:
Sure Ashesh,

I will review the patch.

Regards,
Sanket Mehta
Sr = Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Sanket,

Can y= ou please take a look at it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Sep 14, 2015 at 1:07 AM, J= ohn Obaterspok <john.obaterspok@gmail.com> wrote:
Hell= o,

I'm updated the patch to add commit/rollback acti= ons in the toolbar with the following:
1) updated icons (based on exist= ing pgadmin icon with arrows drawn by me)
2) add entry to menu as= well
3) disable icons when not in a transaction
4)= Ctrl+Shift C|R shortcut

Hopefully all issues are = resolved now!

Regards,

= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 John



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--001a114827ac27214d051fd9cfd9--