public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sanket Mehta <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js
Date: Fri, 22 Apr 2016 16:34:26 +0530
Message-ID: <CA+yw=mNNmLY_j6_zDOJ-P9zMcS8ZNCFWbU-a4WPVBSzoqfeL8A@mail.gmail.com> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
Due to commit id 944bdbb96c3b360c856d7586144b835e44afac43 in node.ui.js,
functions were not being fetched after selecting source and target types as
I have overridden the options property for functions select control.
I have resolved that issue and patch is attached with this mail.
Please do review it.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] options_issue_in_casts.patch (1.6K, 3-options_issue_in_casts.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
index 690a6d5..0010222 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/casts/templates/cast/js/casts.js
@@ -177,20 +177,19 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
type: 'text', disabled: function(m) { return !m.isNew(); },
group: 'Definition', mode: ['create'],
control: 'node-ajax-options',
- options: function() {
-
- var srcTyp = this.model.get('srctyp');
- var trgtyp = this.model.get('trgtyp');
+ options: function(control) {
+ var srcTyp = control.model.get('srctyp');
+ var trgtyp = control.model.get('trgtyp');
var res = [];
if(srcTyp != undefined && srcTyp != '' &&
trgtyp != undefined && trgtyp != '')
{
- var node = this.field.get('schema_node'),
+ var node = control.field.get('schema_node'),
_url = node.generate_url.apply(
node, [
- null, 'get_functions', this.field.get('node_data'), false,
- this.field.get('node_info')
+ null, 'get_functions', control.field.get('node_data'), false,
+ control.field.get('node_info')
]);
$.ajax({
type: 'POST',
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: PATCH: resolving issue in casts as functions are not being fetched due to change in node.ui.js
In-Reply-To: <CA+yw=mNNmLY_j6_zDOJ-P9zMcS8ZNCFWbU-a4WPVBSzoqfeL8A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox