Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aaecF-0006fV-Ow for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Mar 2016 07:21:08 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aaecF-0000Q4-6k for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Mar 2016 07:21:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aaecD-0000Pr-7Y for pgadmin-hackers@postgresql.org; Tue, 01 Mar 2016 07:21:05 +0000 Received: from mail-yw0-x234.google.com ([2607:f8b0:4002:c05::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aaec7-0005vY-VN for pgadmin-hackers@postgresql.org; Tue, 01 Mar 2016 07:21:03 +0000 Received: by mail-yw0-x234.google.com with SMTP id h129so142132583ywb.1 for ; Mon, 29 Feb 2016 23:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=ukRYwuC/5ozJXXhssHdggXVYTYHG8p5lm1OM2OpUaOI=; b=YQWplDCAW/KUJgsWlk8Nj5kNUM0AsRTqLkkS0Jz46X0NeqdevDt2Tf9V5HPxSqQSCP yt5w2TnWFZXvfnhHc0+xmKNZfZddVTX6u1Fn9O4KA54Ry9zck3oZ8ZDYRJOqaTvgT+Rv UKV0uIds4NojJWhURI66ywZLRGvwu08FYq2bBDjt4pMAh2Gc0mZPg9Ig6BC2s4cpyJW3 YelEWpKWNrpwtOt/UcZmdw+XvIkN94VBZOgUgVjzqRW2CXo5fcPBfRDzCJzb9wwZ926A 32MTtee5+B6V2h8dybCtE690sXs/11l6pHetb1acPytw74PN9H/EreyL1co3uuH/8G0b /HCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ukRYwuC/5ozJXXhssHdggXVYTYHG8p5lm1OM2OpUaOI=; b=V6EXM5WXuJzBuRtU0Mduo5jafPjs0W+pzaJEYWM/6dG7qoLzfiqhw6xxOUnVxv0EaB xoRNmnNkeE/YfE4qM3DDwCK8f2kmP5w2YBIrQO9OXPlcmejqSPZWYasKdNW+Z4BEo2Zw m+ZaOnBOYHfY+YXC7zNS8XM8EEqAOqxs/g2/rDXoeySnFblOnQqWzLjKNf/S4+Y3McFZ x9e2v1qTcUvYSF6GHH4AL+vRRlI/XUSsB2HIMxLnvtBsOeer2Z+T2oELRQxwkG1ArElK lg6aIkFdTT/i7ukHVjaqzhXgD9Z6gjKChDY6rB/w0bvHnD27usfuuaCrzktYI0Nh+CLZ l7Bg== X-Gm-Message-State: AD7BkJJbnyMvKhCOYeMMCrNkjshjVPQoQkGG83RYA2I6zZxOr5li+i/sbCByzysiSalVTr7VjTsdn2WCzFuoOSb3 MIME-Version: 1.0 X-Received: by 10.13.234.14 with SMTP id t14mr10650904ywe.110.1456816857783; Mon, 29 Feb 2016 23:20:57 -0800 (PST) Received: by 10.13.207.199 with HTTP; Mon, 29 Feb 2016 23:20:57 -0800 (PST) In-Reply-To: References: Date: Tue, 1 Mar 2016 12:50:57 +0530 Message-ID: Subject: Re: patch for cast module From: Sanket Mehta To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c08411650d62d052cf79b7e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c08411650d62d052cf79b7e Content-Type: multipart/alternative; boundary=94eb2c08411650d628052cf79b7c --94eb2c08411650d628052cf79b7c Content-Type: text/plain; charset=UTF-8 Hi, There was an error in cast module while fetching its dependency and dependent. Below is the patch which resolves this issue. Please review and commit it. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Feb 24, 2016 at 10:17 PM, Dave Page wrote: > Thanks - committed. > > On Tue, Feb 23, 2016 at 1:34 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi, >> >> PFA the revised patch as per your comments. >> Please review it and let me know the feedback. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Tue, Feb 23, 2016 at 4:10 PM, Dave Page wrote: >> >>> Hi >>> >>> I've attached an update to this patch, in which I've done some >>> word-smithing on various comments, and adjusted the SQL templates to >>> improve the formatting. >>> >>> However, it looks like it's bit-rotted, as the dependents/dependencies >>> display is throwing Python errors. Please fix and then I think it's just >>> about ready to commit. >>> >>> Thanks. >>> >>> >>> On Fri, Feb 19, 2016 at 11:03 AM, Sanket Mehta < >>> sanket.mehta@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> PFA the revise patch. >>>> >>>> It includes changes according to your review comments as well as >>>> dependency/dependent part also. >>>> >>>> Let me know in case anything is missing. >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> On Mon, Feb 15, 2016 at 10:25 PM, Dave Page wrote: >>>> >>>>> And this time with the attachment... >>>>> >>>>> On Mon, Feb 15, 2016 at 4:53 PM, Dave Page wrote: >>>>> >>>>>> That's much better. Just a couple of comments now, partly based on an >>>>>> email I wrote earlier: >>>>>> >>>>>> - There is still inconsistency in comment style. Please see the >>>>>> attachment for an example. Note that there is *always* a space between the >>>>>> comment marker and text. >>>>>> >>>>>> - If I try to edit a cast, I can change the description - but no SQL >>>>>> is shown on the SQL tab, despite the comment being correctly applied when I >>>>>> hit save. The properties pane of the main window is also not updated. >>>>>> >>>>>> Otherwise, it looks fine. >>>>>> >>>>>> Thanks. >>>>>> >>>>>> On Mon, Feb 15, 2016 at 1:28 PM, Sanket Mehta < >>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> PFA the revised patch with all the required comments. >>>>>>> >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> Sanket Mehta >>>>>>> Sr Software engineer >>>>>>> Enterprisedb >>>>>>> >>>>>>> On Mon, Feb 15, 2016 at 4:18 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta < >>>>>>>> sanket.mehta@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Dave, >>>>>>>>> >>>>>>>>> Regarding your suggestion of putting some comments in javascript, >>>>>>>>> I think I have already put some comments regarding model data and their >>>>>>>>> controls if any extended. >>>>>>>>> >>>>>>>>> Can you please let me know where exactly you think more comments >>>>>>>>> are required? >>>>>>>>> >>>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> The issue for me is that jQuery code isn't the easiest to read at >>>>>>>> the best of times, with nested/anonymous functions and inline JSON etc. As >>>>>>>> I look through the code for the various nodes in isolation, it's extremely >>>>>>>> difficult to get a sense of what exactly each part of the code is doing. In >>>>>>>> this example, what I see by reading the code is: >>>>>>>> >>>>>>>> - Define the required libraries (require.js stuff) >>>>>>>> - Extend the collection class >>>>>>>> - Extend the node class >>>>>>>> - Define an init function inline >>>>>>>> - Add the menu options >>>>>>>> >>>>>>>> That part is fairly easy to figure out (easier because there are >>>>>>>> blank lines between the logical sections). From there though, it becomes >>>>>>>> much harder; >>>>>>>> >>>>>>>> - There are no blank lines to separate logical code sections at all >>>>>>>> between line 48 and 235 (there is one blank line, but it doesn't separate >>>>>>>> code sections). >>>>>>>> - There are 4 comments that I can see. The first two are identical, >>>>>>>> and appear to have identical code blocks following them for reasons that >>>>>>>> are not even remotely obvious. >>>>>>>> - As a newcomer to this code, I'm wondering if it's purpose is to >>>>>>>> define the backform model. If so, why is it not broken up into sections >>>>>>>> with a comment to tell me what field each block handles, and any other >>>>>>>> useful information I may need to know? If it's not, then what is it for? >>>>>>>> >>>>>>>> So... I'm not going to tell you exactly where to put comments, >>>>>>>> because the point is that without spending a couple of hours understanding >>>>>>>> this, I simply don't know. The point of the comments (and separation of >>>>>>>> logical sections of code with blank lines) is to make it easy for another >>>>>>>> developer (especially one as rusty as me) to read and understand, then fix >>>>>>>> and improve. Be generous with comments, but don't use them unnecessarily >>>>>>>> (e.g. "a = 1 // Set a to one"). >>>>>>>> >>>>>>>> Of course, this is not just directed at you Sanket - it's something >>>>>>>> all of us working on pgAdmin need to keep in mind. >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c08411650d628052cf79b7c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

There was an error in= cast module while fetching its dependency and dependent.
Be= low is the patch which resolves this issue.
Please review and comm= it it.



<= div class=3D"gmail_signature">
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Wed, Feb 24, 2016 at 10:17 PM, Dave Page = <dpage@pgadmin.org> wrote:
Thanks - committed.

On Tue, F= eb 23, 2016 at 1:34 PM, Sanket Mehta <sanket.mehta@enterprised= b.com> wrote:
Hi,

PFA the revised patch as per your comments.
Pl= ease review it and let me know the feedback.

Regards,
Sanke= t Mehta
Sr Software engineer
Enterprisedb

On Tue, Feb 23, 2016 at 4:1= 0 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

I've attached a= n update to this patch, in which I've done some word-smithing on variou= s comments, and adjusted the SQL templates to improve the formatting.
=

However, it looks like it's bit-rotted, as the depe= ndents/dependencies display is throwing Python errors. Please fix and then = I think it's just about ready to commit.

Thank= s.


O= n Fri, Feb 19, 2016 at 11:03 AM, Sanket Mehta <sanket.mehta@en= terprisedb.com> wrote:
Hi Dave,

PFA the revise patch.
=
It includes changes according to your review comments as well as = dependency/dependent part also.

Let me know in case anything i= s missing.

Regards,
Sanket Mehta
Sr Software engi= neer
Enterprisedb

On Mon, Feb 15, 2016 at 10:= 25 PM, Dave Page <dpage@pgadmin.org> wrote:
And this time with the attachment...

On Mo= n, Feb 15, 2016 at 4:53 PM, Dave Page <dpage@pgadmin.org> wr= ote:
That's much bet= ter. Just a couple of comments now, partly based on an email I wrote earlie= r:

- There is still inconsistency in comment style. Plea= se see the attachment for an example. Note that there is *always* a space b= etween the comment marker and text.

- If I try to = edit a cast, I can change the description - but no SQL is shown on the SQL = tab, despite the comment being correctly applied when I hit save. The prope= rties pane of the main window is also not updated.

Otherwise, it looks fine.
<= div class=3D"gmail_extra">
Thanks.

On Mon= , Feb 15, 2016 at 1:28 PM, Sanket Mehta <sanket.mehta@enterpri= sedb.com> wrote:
Hi,

PFA the revised patch with all the required = comments.



Regards,
Sanket Mehta
Sr Softwa= re engineer
Enterprisedb

On Mon, Feb 15, 2016 at 4:1= 8 PM, Dave Page <dpage@pgadmin.org> wrote:


On Mon, Feb 15, 2016 at 8:10 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi Dave,

Reg= arding your suggestion of putting some comments in javascript, I think I ha= ve already put some comments regarding model data and their controls if any= extended.

Can you please let me know where exactly you think = more comments are required?

Hi=

The issue for me is that jQuery code isn't th= e easiest to read at the best of times, with nested/anonymous functions and= inline JSON etc. As I look through the code for the various nodes in isola= tion, it's extremely difficult to get a sense of what exactly each part= of the code is doing. In this example, what I see by reading the code is:<= /div>

- Define the required libraries (require.js stuff)=
- Extend the collection class
- Extend the node class<= /div>
=C2=A0 - Define an init function inline
=C2=A0 - Add th= e menu options

That part is fairly easy to figure = out (easier because there are blank lines between the logical sections). Fr= om there though, it becomes much harder;

- There a= re no blank lines to separate logical code sections at all between line 48 = and 235 (there is one blank line, but it doesn't separate code sections= ).=C2=A0
- There are 4 comments that I can see. The first two are= identical, and appear to have identical code blocks following them for rea= sons that are not even remotely obvious.=C2=A0
- As a newcomer to= this code, I'm wondering if it's purpose is to define the backform= model. If so, why is it not broken up into sections with a comment to tell= me what field each block handles, and any other useful information I may n= eed to know? If it's not, then what is it for?

So... I'm not going to tell you exactly where to put comments, because= the point is that without spending a couple of hours understanding this, I= simply don't know. The point of the comments (and separation of logica= l sections of code with blank lines) is to make it easy for another develop= er (especially one as rusty as me) to read and understand, then fix and imp= rove. Be generous with comments, but don't use them unnecessarily (e.g.= "a =3D 1 // Set a to one").

Of course, = this is not just directed at you Sanket - it's something all of us work= ing on pgAdmin need to keep in mind.

Thanks.
=

--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company




--
Dave Pa= ge
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpris= edb.com
The Enterprise PostgreSQL Company



--
Dave Pa= ge
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpris= edb.com
The Enterprise PostgreSQL Company




--
Dave Pa= ge
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpris= edb.com
The Enterprise PostgreSQL Company




--
Dave Pa= ge
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpris= edb.com
The Enterprise PostgreSQL Company

--94eb2c08411650d628052cf79b7c-- --94eb2c08411650d62d052cf79b7e Content-Type: text/x-patch; charset=US-ASCII; name="cast_error_dependecy_dependent.patch" Content-Disposition: attachment; filename="cast_error_dependecy_dependent.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_il9351sa0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9jYXN0cy9fX2luaXRfXy5weSBiL3dlYi9w Z2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNl cy9jYXN0cy9fX2luaXRfXy5weQppbmRleCBlMzk3YTZlLi5jZGVjMjc4IDEw MDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMv c2VydmVycy9kYXRhYmFzZXMvY2FzdHMvX19pbml0X18ucHkKKysrIGIvd2Vi L3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJh c2VzL2Nhc3RzL19faW5pdF9fLnB5CkBAIC0xNCw3ICsxNCw3IEBAIGZyb20g Zmxhc2sgaW1wb3J0IHJlbmRlcl90ZW1wbGF0ZSwgbWFrZV9yZXNwb25zZSwg Y3VycmVudF9hcHAsIHJlcXVlc3QsIGpzb25pZnkKIGZyb20gZmxhc2suZXh0 LmJhYmVsIGltcG9ydCBnZXR0ZXh0CiBmcm9tIHBnYWRtaW4udXRpbHMuYWph eCBpbXBvcnQgbWFrZV9qc29uX3Jlc3BvbnNlLCBcCiAgICAgbWFrZV9yZXNw b25zZSBhcyBhamF4X3Jlc3BvbnNlLCBpbnRlcm5hbF9zZXJ2ZXJfZXJyb3IK LWZyb20gcGdhZG1pbi5icm93c2VyLnV0aWxzIGltcG9ydCBOb2RlVmlldwor ZnJvbSBwZ2FkbWluLmJyb3dzZXIudXRpbHMgaW1wb3J0IFBHQ2hpbGROb2Rl VmlldwogZnJvbSBwZ2FkbWluLmJyb3dzZXIuY29sbGVjdGlvbiBpbXBvcnQg Q29sbGVjdGlvbk5vZGVNb2R1bGUKIGltcG9ydCBwZ2FkbWluLmJyb3dzZXIu c2VydmVyX2dyb3Vwcy5zZXJ2ZXJzLmRhdGFiYXNlcyBhcyBkYXRhYmFzZXMK IGZyb20gcGdhZG1pbi51dGlscy5hamF4IGltcG9ydCBwcmVjb25kaXRpb25f cmVxdWlyZWQKQEAgLTc4LDExICs3OCwxMSBAQCBjbGFzcyBDYXN0TW9kdWxl KENvbGxlY3Rpb25Ob2RlTW9kdWxlKToKIGJsdWVwcmludCA9IENhc3RNb2R1 bGUoX19uYW1lX18pCiAKIAotY2xhc3MgQ2FzdFZpZXcoTm9kZVZpZXcpOgor Y2xhc3MgQ2FzdFZpZXcoUEdDaGlsZE5vZGVWaWV3KToKICAgICAiIiIKLSAg ICBjbGFzcyBDYXN0VmlldyhOb2RlVmlldykKKyAgICBjbGFzcyBDYXN0Vmll dyhQR0NoaWxkTm9kZVZpZXcpCiAKLSAgICAgICAgQSB2aWV3IGNsYXNzIGZv ciBjYXN0IG5vZGUgZGVyaXZlZCBmcm9tIE5vZGVWaWV3LiBUaGlzIGNsYXNz IGlzCisgICAgICAgIEEgdmlldyBjbGFzcyBmb3IgY2FzdCBub2RlIGRlcml2 ZWQgZnJvbSBQR0NoaWxkTm9kZVZpZXcuIFRoaXMgY2xhc3MgaXMKICAgICAg ICAgcmVzcG9uc2libGUgZm9yIGFsbCB0aGUgc3R1ZmYgcmVsYXRlZCB0byB2 aWV3IGxpa2UgY3JlYXRlL3VwZGF0ZS9kZWxldGUgY2FzdCwKICAgICAgICAg c2hvd2luZyBwcm9wZXJ0aWVzIG9mIGNhc3Qgbm9kZSwgc2hvd2luZyBzcWwg aW4gc3FsIHBhbmUuCiAKQEAgLTYxNCw3ICs2MTQsNyBAQCBjbGFzcyBDYXN0 VmlldyhOb2RlVmlldyk6CiAgICAgICAgICAgICBkaWQ6IERhdGFiYXNlIElE CiAgICAgICAgICAgICBjaWQ6IENhc3QgSUQKICAgICAgICAgIiIiCi0gICAg ICAgIGRlcGVuZGVudHNfcmVzdWx0ID0gZ2V0X2RlcGVuZGVudHMoc2VsZi5j b25uLCBjaWQsICdsYW5ndWFnZScpCisgICAgICAgIGRlcGVuZGVudHNfcmVz dWx0ID0gc2VsZi5nZXRfZGVwZW5kZW50cyhzZWxmLmNvbm4sIGNpZCwgJ2Nh c3QnKQogICAgICAgICByZXR1cm4gYWpheF9yZXNwb25zZSgKICAgICAgICAg ICAgICAgICByZXNwb25zZT1kZXBlbmRlbnRzX3Jlc3VsdCwKICAgICAgICAg ICAgICAgICBzdGF0dXM9MjAwCkBAIC02MzIsNyArNjMyLDcgQEAgY2xhc3Mg Q2FzdFZpZXcoTm9kZVZpZXcpOgogICAgICAgICAgICAgZGlkOiBEYXRhYmFz ZSBJRAogICAgICAgICAgICAgY2lkOiBDYXN0IElECiAgICAgICAgICIiIgot ICAgICAgICBkZXBlbmRlbmNpZXNfcmVzdWx0ID0gZ2V0X2RlcGVuZGVuY2ll cyhzZWxmLmNvbm4sIGNpZCwgJ2xhbmd1YWdlJykKKyAgICAgICAgZGVwZW5k ZW5jaWVzX3Jlc3VsdCA9IHNlbGYuZ2V0X2RlcGVuZGVuY2llcyhzZWxmLmNv bm4sIGNpZCwgJ2Nhc3QnKQogICAgICAgICByZXR1cm4gYWpheF9yZXNwb25z ZSgKICAgICAgICAgICAgICAgICByZXNwb25zZT1kZXBlbmRlbmNpZXNfcmVz dWx0LAogICAgICAgICAgICAgICAgIHN0YXR1cz0yMDAK --94eb2c08411650d62d052cf79b7e Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c08411650d62d052cf79b7e--