Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqnQ9-000433-1A for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Apr 2016 19:59:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aqnQ8-0006o2-CK for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Apr 2016 19:59:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aqnPv-0006ZU-3N for pgadmin-hackers@postgresql.org; Thu, 14 Apr 2016 19:59:07 +0000 Received: from mail-vk0-x232.google.com ([2607:f8b0:400c:c05::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aqnPr-00039X-IS for pgadmin-hackers@postgresql.org; Thu, 14 Apr 2016 19:59:06 +0000 Received: by mail-vk0-x232.google.com with SMTP id t129so123021890vkg.2 for ; Thu, 14 Apr 2016 12:59:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=lMKJYjaaubEPIcbk3E1G+Upgrr5lE0Kiue5G5X5e9b0=; b=03bV9SW0lNJm6R99K2veX78FmpKccoN9HnIQ08cGZ0dVAAKYpSNCYiFnDT1KRS88gz M1ANp5SPwG1PLMt02kbsFOCs9s0bgTgv+d3rXmY4fzU+9U9Ge4nRWPmK0hjJUFiQFgBl ZrA90NNFc7seS76EY6lhVqLBXoM0wuUGD8Q1RwI7akkRwW1ucfCb+mlJbNiAl9jFftoP 5/1K/BN+23ovdqzXCyinufseJaCiEbKqxC5F66a0xAbXb7Pc65dF5vfv2a1qaPM8rrvZ Bcchd+Nw3pRIWlqthh5KcqxOeRtQqGnljAxmoodT1OSK2Wm5bMiAiaWaTlxQ+kee1fFq YTWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=lMKJYjaaubEPIcbk3E1G+Upgrr5lE0Kiue5G5X5e9b0=; b=cQS/Pvto6TpWVbJpX1pJOpw6ZE+E0wR4a5S0tVRtqCBPz2QwToDfwPPNyzi5SW7v9f pAS1cFBVo+wxH/RJY/L/+vS4mxz8NJ3Q+fWk9DAt85LiM7SL6TJ5hueMtpNDIlMDu5uX gm2Bdgv9CSvZMxICw83GGC/N+DtLkG0EXJ3sM53EUA/HRDkgX3WoTGbLZe3MI2rvFGgl pO3NIkrLvTWtF47s6YrPrOYhY4J2iFiiu0ukPT5TkUjiBLHUID/JxAC6C51mA5WSvStc BcYh3Ic6J2qyO3HyndzbnPbWSQXazwBsy5oY6msDg/gAQqQ1yLEEDUeYdA9RgmA8tlpp OodQ== X-Gm-Message-State: AOPr4FUe63udpvndTHB3XBRTSBpXNx28eiGK+xoNV/5+O7s77HMhd8rkCrr2b0ZXs5SvaRbAkO3U8CR5ybK23IBr MIME-Version: 1.0 X-Received: by 10.31.180.133 with SMTP id d127mr9110209vkf.86.1460663941450; Thu, 14 Apr 2016 12:59:01 -0700 (PDT) Received: by 10.31.164.75 with HTTP; Thu, 14 Apr 2016 12:59:01 -0700 (PDT) In-Reply-To: References: Date: Fri, 15 Apr 2016 01:29:01 +0530 Message-ID: Subject: Re: PATCH: FTS Dictionary From: Sanket Mehta To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114388a85dec0405307753a6 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114388a85dec0405307753a6 Content-Type: text/plain; charset=UTF-8 Thanks for reviewing it Dave. I will resolve these issues ASAP. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Fri, Apr 15, 2016 at 1:27 AM, Dave Page wrote: > On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta > wrote: > > Hi, > > > > PFA patch for FTS Dictionaries. > > Please do review it and let me know in case of any issues. > > Thanks - committed with a few cosmetic changes, and a couple of minor > issues to resolve: > > 1) The template is not shown in properties views if it is not in a > system schema (because of the way you are dealing with schema names > etc). Please also check how the existing code will behave, if there is > a template in the public schema with the same name as one in > pg_catalog. > > 2) Please strip the quotes from the options before displaying them. > > I'll create a card for this. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a114388a85dec0405307753a6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks for reviewing it Dave.
I will resolve these iss= ues ASAP.

Regards,
Sanket Mehta
=
Sr Software engineer
Enterprisedb

On Fri, Apr 15, 2016 at 1:27 AM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta
<sanket.mehta@enterpris= edb.com> wrote:
> Hi,
>
> PFA patch for FTS Dictionaries.
> Please do review it and let me know in case of any issues.

Thanks - committed with a few cosmetic changes, and a couple of mino= r
issues to resolve:

1) The template is not shown in properties views if it is not in a
system schema (because of the way you are dealing with schema names
etc). Please also check how the existing code will behave, if there is
a template in the public schema with the same name as one in
pg_catalog.

2) Please strip the quotes from the options before displaying them.

I'll create a card for this.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a114388a85dec0405307753a6--