Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbPUP-0001pZ-99 for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Sep 2015 08:51:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZbPUO-0005XX-JK for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Sep 2015 08:51:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZbPUB-0005Hv-1Z for pgadmin-hackers@postgresql.org; Mon, 14 Sep 2015 08:51:39 +0000 Received: from mail-yk0-f175.google.com ([209.85.160.175]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZbPU3-0003rm-Mu for pgadmin-hackers@postgresql.org; Mon, 14 Sep 2015 08:51:37 +0000 Received: by ykdg206 with SMTP id g206so146090403ykd.1 for ; Mon, 14 Sep 2015 01:51:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ETfjdsol8cnJAe537YDmgVkDHxxI7DyKkDa87v0G9LE=; b=flJ85wBgfOuPgVkI8TpqmUgiED4loM5zbwz6ldf/rRB+0IOXIHyuFeFsRh/Gm/THDK Bf3XlauDqlOcfIZKXB24HDBxfzhGoZo2ImyovCZIBJkUeX+nR7ICLaNxUk8o99gui2Dk Pqw5GgNV1r3vCc94V3gKDZ5f0iwF7pi7/6qJdfjhOHBEQcDlO9RcZkAfpXAmsHkHfeUg A46hXYQhNX69yDrmx1jPDFQ8X6EHioZfkVT9NzjGL9R/A4eNmXyNVo+z8/66ZdatyOrV YMCPrr9Av3Xqr0CsCxO2V28g+TQE+uNwsLGXGvg3FTmGneGC3ZWacqXD0MvpsmpvnqGR uLIg== X-Gm-Message-State: ALoCoQkTAtsjpx6WJfsLrQM2kSB0iyDhiFy78tCsXPLTiVe4fYhbm9racfmQAAQ55AcqcEsTVAHu MIME-Version: 1.0 X-Received: by 10.129.79.202 with SMTP id d193mr12356152ywb.159.1442220690745; Mon, 14 Sep 2015 01:51:30 -0700 (PDT) Received: by 10.13.240.196 with HTTP; Mon, 14 Sep 2015 01:51:30 -0700 (PDT) In-Reply-To: References: Date: Mon, 14 Sep 2015 14:21:30 +0530 Message-ID: Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2 From: Sanket Mehta To: Ashesh Vashi Cc: pgadmin-hackers , John Obaterspok Content-Type: multipart/alternative; boundary=001a114d3b0ef5dd1f051fb12bca X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114d3b0ef5dd1f051fb12bca Content-Type: text/plain; charset=UTF-8 Sure Ashesh, I will review the patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi wrote: > Sanket, > > Can you please take a look at it? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok < > john.obaterspok@gmail.com> wrote: > >> Hello, >> >> I'm updated the patch to add commit/rollback actions in the toolbar with >> the following: >> 1) updated icons (based on existing pgadmin icon with arrows drawn by me) >> 2) add entry to menu as well >> 3) disable icons when not in a transaction >> 4) Ctrl+Shift C|R shortcut >> >> Hopefully all issues are resolved now! >> >> Regards, >> >> John >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a114d3b0ef5dd1f051fb12bca Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure Ashesh,

I will review the patch.

Regards,
Sanket Mehta
Sr Sof= tware engineer
Enterprisedb

On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Sanket,

Can y= ou please take a look at it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Sep 14, 2015 = at 1:07 AM, John Obaterspok <john.obaterspok@gmail.com> wrote:
Hello,

I'm updated the patch t= o add commit/rollback actions in the toolbar with the following:
1) upd= ated icons (based on existing pgadmin icon with arrows drawn by me)
2) add entry to menu as well
3) disable icons when not in = a transaction
4) Ctrl+Shift C|R shortcut

Hopefully all issues are resolved now!

Regards,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 John
<= br>


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=



--001a114d3b0ef5dd1f051fb12bca--