Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5bEq-0002yi-5u for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 May 2016 16:00:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b5bEp-000578-PE for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 May 2016 16:00:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b5amc-0003Kv-VB for pgadmin-hackers@postgresql.org; Wed, 25 May 2016 15:31:43 +0000 Received: from mail-vk0-x230.google.com ([2607:f8b0:400c:c05::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b5amY-00048X-4L for pgadmin-hackers@postgresql.org; Wed, 25 May 2016 15:31:42 +0000 Received: by mail-vk0-x230.google.com with SMTP id f66so69309625vkh.2 for ; Wed, 25 May 2016 08:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+tnv+pBpI7T+N4cBTi1pX8ckg8Xks7lZ2EtD+fzzMNs=; b=ePwVgpsFOH3ym74bYZMFMn+TPQP+S7n5F1y3IA0hio3ceDe5sRgreev34G/VVrYjyI Rnj7IB57k7Sq+kQhXWbZpLnz+D16I9FZwLbmJkef8cQeflh7T+gGeqjVPkAzVqiJok2c ttBdAkl7VgGmsTK0ieC6LJGnu9jT67ZDydVqx35UuPJJ/zCl87MtEutPFN3JoWzxf+FV AMiURfebWV136VAUvmMnAGRHL7bBMuxRj0uostYuFxDuoUHbjAkEBn+i585jzrrez7fI EQ9dhwviFFcKazsqjEGTNnkSjUfUeupi9/EJoe+KAoljb/GNQxmXi88vWEWcG7gQ6a4F 3/2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+tnv+pBpI7T+N4cBTi1pX8ckg8Xks7lZ2EtD+fzzMNs=; b=ZFz3EwLShnMXllWhK12AUdZtONCavcV/2FW0nsCkK8inil+s6b99k7mHzDpVNKL20I yr0oYkCMyCtzv97j9VjdxNszoW6AKIHyH8Il3bU5Hhfpn3ugHC2Pwzm3T9AiH72j35sq zTV9zCuBlVZQWPWx+Vf/Q9nClttLJtfoEg/EsEqAi9cWpkNNwQNZ7R0imFgwyeTtKhz5 C+zQ38WElrfqYDS70NG2r/hg7fiau0/vimlnDtE+7VGYS9FTYLwPoKlligc5xr9nbyHj ZEcG5NH8ucGSATpmOXj5LVTqiJPxe68RrDcNadzC3jUr0vljysfWnBkiAVCgKCeQtseU yBvA== X-Gm-Message-State: ALyK8tLR5fKy8+Aef6OBeXy/bWKqy557w4hOSUF6JB3ZAsgoe228Ws4K8/6IY1D6mXUj7dN3I3Cg0UWUVl739Q== X-Received: by 10.176.1.232 with SMTP id 95mr2767296ual.144.1464190295794; Wed, 25 May 2016 08:31:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.2.239 with HTTP; Wed, 25 May 2016 08:31:06 -0700 (PDT) In-Reply-To: References: From: Thom Brown Date: Wed, 25 May 2016 16:31:06 +0100 X-Google-Sender-Auth: WWpwR-JiDv_O3tEddmXAvPmseR0 Message-ID: Subject: Re: [PATCH] Tables node (pgAdmin4) To: Ashesh Vashi Cc: Murtuza Zabuawala , Dave Page , Akshay Joshi , Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113cc4f076f19d0533ac5ede X-Pg-Spam-Score: -2.4 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113cc4f076f19d0533ac5ede Content-Type: text/plain; charset=UTF-8 Thanks. I've raised all of these in tickets 1231 to 1237. Thom On 25 May 2016 at 04:23, Ashesh Vashi wrote: > Hi Thom, > > Can you please create RM cases for the same, it will be easy to track > those issues? > We're using "https://redmine.postgresql.org/projects/pgadmin4/" for the > same. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Wed, May 25, 2016 at 6:42 AM, Thom Brown wrote: > >> On 25 May 2016 at 02:00, Thom Brown wrote: >> > On 25 May 2016 at 00:29, Thom Brown wrote: >> >> On 24 May 2016 at 19:09, Ashesh Vashi >> wrote: >> >>> >> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala >> >>> wrote: >> >>>> >> >>>> Hi, >> >>>> >> >>>> PFA patch, which will fixes below mentioned issues, >> >>> >> >>> Committed. >> >> >> >> >> >> In the Create Table dialog, on the Advanced tab, the "Of type" >> drop-down >> >> lists tables and composite types, but those are supposed to just be >> >> composite types. >> >> >> >> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE >> should >> >> be disabled when using OF. Also, there should probably be a way of >> setting >> >> options for the columns taken from the composite type. For example: >> >> >> >> CREATE TYPE inventory AS (product_id bigint, product_name text, weight >> >> numeric); >> >> >> >> CREATE TABLE stock OF inventory ( >> >> PRIMARY KEY (product_id), >> >> weight WITH OPTIONS DEFAULT 0 >> >> ); >> >> >> >> There's currently no way of doing this (neither the primary key, nor >> the >> >> default value for any columns). It should probably automatically >> populate >> >> the columns from the composite type on the columns tab. >> >> >> >> Also, could the generated SQL have an empty line between each >> statement? >> > >> > Another thing I've noticed is that, when adding columns, the "Is >> > primary key?" column is greyed out. Why not just make those >> > modifiable in that view rather than having to go into the details for >> > each column? >> > >> > When there's something that hasn't been set up correctly, like adding >> > variables for a column, but not actually selecting a variable, the SQL >> > pane, correctly, doesn't show an output, but the error message, >> > "Please provide input for variable." isn't enough to identify what >> > needs checking. Could the relevant tab and field/row be >> > highlighted/coloured in red/bold? This is more general, so doesn't >> > just apply to the create table dialog. >> >> Last issue today: >> >> When using "Of type", it's not valid to allow additional columns to be >> added, so those should be prevented. >> >> Thom >> > > --001a113cc4f076f19d0533ac5ede Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks.=C2=A0 I've raised all of these in tickets= 1231 to 1237.

Thom
On 25 May 2016 at 04:23, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Thom,

Can you pleas= e create RM cases for the same, it will be easy to track those issues?

--

Thanks & Regards,<= /span>

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Co= mpany

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, May 25= , 2016 at 6:42 AM, Thom Brown <thom@linux.com> wrote:
On 25 May 2016 at 02:00, Thom Brown <= thom@linux.com> = wrote:
> On 25 May 2016 at 00:29, Thom Brown <thom@linux.com> wrote:
>> On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>>
>>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> <murtuza.zabuawala@enterprisedb.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> PFA patch, which will fixes below mentioned issues,
>>>
>>> Committed.
>>
>>
>> In the Create Table dialog, on the Advanced tab, the "Of type= " drop-down
>> lists tables and composite types, but those are supposed to just b= e
>> composite types.
>>
>> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so L= IKE should
>> be disabled when using OF.=C2=A0 Also, there should probably be a = way of setting
>> options for the columns taken from the composite type.=C2=A0 For e= xample:
>>
>> CREATE TYPE inventory AS (product_id bigint, product_name text, we= ight
>> numeric);
>>
>> CREATE TABLE stock OF inventory (
>>=C2=A0 =C2=A0 =C2=A0PRIMARY KEY (product_id),
>>=C2=A0 =C2=A0 =C2=A0weight WITH OPTIONS DEFAULT 0
>> );
>>
>> There's currently no way of doing this (neither the primary ke= y, nor the
>> default value for any columns).=C2=A0 It should probably automatic= ally populate
>> the columns from the composite type on the columns tab.
>>
>> Also, could the generated SQL have an empty line between each stat= ement?
>
> Another thing I've noticed is that, when adding columns, the "= ;Is
> primary key?" column is greyed out.=C2=A0 Why not just make those=
> modifiable in that view rather than having to go into the details for<= br> > each column?
>
> When there's something that hasn't been set up correctly, like= adding
> variables for a column, but not actually selecting a variable, the SQL=
> pane, correctly, doesn't show an output, but the error message, > "Please provide input for variable." isn't enough to ide= ntify what
> needs checking.=C2=A0 Could the relevant tab and field/row be
> highlighted/coloured in red/bold?=C2=A0 This is more general, so doesn= 't
> just apply to the create table dialog.

Last issue today:

When using "Of type", it's not valid to allow additional colu= mns to be
added, so those should be prevented.

Thom


--001a113cc4f076f19d0533ac5ede--