public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nagesh Dhope <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM5292] Alertify header buttons focus color issue
Date: Thu, 26 Mar 2020 10:14:27 +0530
Message-ID: <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com> (raw)

Hi Hackers,

Please find a patch which includes

   1. Use *btn-secondary* styles for all buttons in alertify dialog header.
   2. Added *!default *for $active-border variable, so that it can be
   overridden if required.
   3. Added entry for *.scss *in .editorconfig

-- 
Thanks,
Nagesh


Attachments:

  [application/octet-stream] RM5292.patch (1.4K, 3-RM5292.patch)
  download | inline diff:
diff --git a/web/.editorconfig b/web/.editorconfig
index f7e28ea..fb3c027 100644
--- a/web/.editorconfig
+++ b/web/.editorconfig
@@ -22,6 +22,9 @@ indent_size = 2
 [*.css]
 indent_size = 2
 
+[*.scss]
+indent_size = 2
+
 # Matches the exact file package.json
 [{package.json}]
 indent_size = 2
diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss
index 6380754..6859a74 100644
--- a/web/pgadmin/static/scss/_alertify.overrides.scss
+++ b/web/pgadmin/static/scss/_alertify.overrides.scss
@@ -288,8 +288,18 @@
 }
 
 
-.ajs-maximize {
+.ajs-commands {
+  button {
     @extend .btn-secondary;
     outline: none !important;
+  }
 }
 
+.wizard-header {
+  .ml-auto {
+    button {
+      @extend .btn-secondary;
+      outline: none !important;
+     }
+  }
+}
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index f148c67..0d6cd5e 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -182,7 +182,7 @@ $color-editor-foldmarker: #0000FF !default;
 $color-editor-activeline: #50B0F0 !default;
 
 $active-color: $color-primary !default;
-$active-border: 3px solid $active-color;
+$active-border: 3px solid $active-color !default;
 $panel-border-width: $border-width;
 $panel-border-color: $border-color;
 $panel-border-radius: $border-radius;

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
  In-Reply-To: <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox