Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jA6pE-00072Y-Dm for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Mar 2020 06:51:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jA6pC-0002zt-Rp for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Mar 2020 06:51:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jA6pC-0002zm-Fn for pgadmin-hackers@lists.postgresql.org; Fri, 06 Mar 2020 06:51:10 +0000 Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jA6p5-0000EO-2Q for pgadmin-hackers@postgresql.org; Fri, 06 Mar 2020 06:51:09 +0000 Received: by mail-vs1-xe35.google.com with SMTP id k26so877546vso.5 for ; Thu, 05 Mar 2020 22:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JA0FD3l2fjUzYAQ81SlCD9aUyUcJlVbevpYwVHByizY=; b=GhguKFPeoyYOfz4RHxTiGZQxUY3X40+tqTo/XY/w7C63U9wxSf6NBhcVsnH4+gyOZQ HVHLt+4grTO7pK6qJaAPy99wKPjAphARz3Yo/6WNEZ9/aWMXnMEiPS2mJHldKOS0qhkF su+3OgkFiWrMwoeIOF7frVKsbUt50neIjzxWwYavxd+/PTI22NO60VT2KZC44nfwBkRd 7YB+vu+j9u6hYcVIvnN6xbbQx77OGPbMAo6+d48AcRPso9UY5PmeEc9EwS2jjPK19FY4 wIalcPgHtBaoySMD9pqI8cTZvKgoOf5bCJcbcB6UoYEg7sI+ZAFC3zCruw6Vd0OzHn1W lQOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JA0FD3l2fjUzYAQ81SlCD9aUyUcJlVbevpYwVHByizY=; b=d+TwAnpPZD9bImWoru06q9tSMhlIpWwjpYS5Lvsxgi++A6s2/jSq91Isw75o6iaunD h0ypPbm0ph7X5egCH3Ty9Zs60sY4ceVvOdTmeBaGVWYCsCCaZOJOsV0OKzmC4kIWWy+h r9pVCdd1XuD2HzRiaGuK0MzLEBcw+xpWKzXIP1v2b/3NtAZwekQ22ZrM9HrvSuBs38Uo IfFuZTdiWXBW+1fb/Qh7/mfNItqqf9oUfd4HdK0Mr922UjPVR/FiRji6CswTLovaibSs QQreMALpzPDm1FX7gc5uHZMU+j7Z00lw8bjmymeSx2yCtxOgE8PAtG8lhGfyTsbr57Ym RvTw== X-Gm-Message-State: ANhLgQ0UbHfBQglqPOn8Jj1yy9mTmKVQQR2j4igTH7eano6Kgypoz0FY KfPGVV5wGq9TqPHTglC/433xa8ksPjGqIYp/zc9mzUDYTRznfVBxsXMeCcvZ2ldXZEBQBcsuqbl Hulz50qC4k4kHtKsM3kZzMEX3lDA1FPLwb9lb+tecjFh2T2II02jrKLZ1/aW36l5JNCYPndd7yf c/xuhG3iYUE7luqfYdLe0vkw2KZUPl9SgBCPUaVjAeZ4Jfwl0jmC4= X-Google-Smtp-Source: ADFU+vvcGGnpVuLbY4TCZOdKrTNDQv6j6sQhGCOn7teES1xWzn2KLW9sU5BVEoOarx2Vx1M0QMjwdPzVtLXJlcXziQg= X-Received: by 2002:a67:fb19:: with SMTP id d25mr1241084vsr.220.1583477461103; Thu, 05 Mar 2020 22:51:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Nagesh Dhope Date: Fri, 6 Mar 2020 12:20:50 +0530 Message-ID: Subject: Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified To: Akshay Joshi Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000094964b05a02a13de" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000094964b05a02a13de Content-Type: multipart/alternative; boundary="00000000000094964a05a02a13dc" --00000000000094964a05a02a13dc Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find a patch to make controls under *Active query details* subnode read-only on the dashboard. On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the updated patch to include dialogs (create/edit) for all >> the nodes. >> Kindly review. >> >> On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Aditya >>> >>> As per discussion, we should visit all the nodes create/edit dialog and >>> make the controls read-only wherever appropriate. >>> >>> On Wed, Jan 22, 2020 at 5:46 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to allow input controls to be set as readonly >>>> instead of disabled. >>>> I've also changed the code for the nodes to make sure properties tab >>>> have readonly fields wherever applicable. This will allow tab navigation in >>>> properties tab and also allow screen readers to read it. >>>> Please note that, I've not visited each and every node create/edit >>>> dialog to identify what should be readonly or what should be disabled as it >>>> depends on business logic. The patch is mainly for the properties tab. >>>> >>>> Kindly review. >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks, Nagesh --00000000000094964a05a02a13dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,
Please find a patch to make controls under = Active query details subnode read-only on the dashboard.
<= br>

On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Thanks, patch applied.

On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal = <= aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached = is the updated patch to include dialogs (create/edit) for all the nodes.
Ki= ndly review.

On Thu, Jan 23, 2020 at 1:08 PM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi=C2=A0Aditya

As per dis= cussion, we should visit all the nodes create/edit dialog and make the cont= rols read-only wherever=C2=A0appropriate.

On Wed, Jan 22, 2020 at 5:46= PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hacker= s,

Attached is the patch to allow input controls to be set as readonly= instead of disabled.
I've also changed the code for the nodes to make = sure properties tab have readonly fields wherever applicable. This will all= ow=C2=A0tab navigation in properties tab and also allow screen readers to r= ead it.
Please note that, I've not visited each and every node create/e= dit dialog to identify what should be readonly or what should be disabled a= s it depends on business logic. The patch is mainly for the properties tab.=

Kindly review.

--
=
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0EnterpriseDB= India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks,
Nagesh
<= /div> --00000000000094964a05a02a13dc-- --00000000000094964b05a02a13de Content-Type: application/octet-stream; name="RM4993_v3.patch" Content-Disposition: attachment; filename="RM4993_v3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7fthzox0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Rhc2hib2FyZC9zdGF0aWMvanMvZGFzaGJvYXJkLmpz IGIvd2ViL3BnYWRtaW4vZGFzaGJvYXJkL3N0YXRpYy9qcy9kYXNoYm9hcmQuanMKaW5kZXggMDk2 OWE1Yy4uYTBkNWY2MyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vZGFzaGJvYXJkL3N0YXRpYy9q cy9kYXNoYm9hcmQuanMKKysrIGIvd2ViL3BnYWRtaW4vZGFzaGJvYXJkL3N0YXRpYy9qcy9kYXNo Ym9hcmQuanMKQEAgLTE2Nyw3ICsxNjcsNyBAQCBkZWZpbmUoJ3BnYWRtaW4uZGFzaGJvYXJkJywg WwogICAgICAgbGFiZWw6IGdldHRleHQoJ0JhY2tlbmQgdHlwZScpLAogICAgICAgdHlwZTogJ3Rl eHQnLAogICAgICAgZWRpdGFibGU6IHRydWUsCi0gICAgICBkaXNhYmxlZDogdHJ1ZSwKKyAgICAg IHJlYWRvbmx5OiB0cnVlLAogICAgICAgZ3JvdXA6IGdldHRleHQoJ0RldGFpbHMnKSwKICAgICAg IHZpc2libGU6IGZ1bmN0aW9uKCkgewogICAgICAgICByZXR1cm4gdGhpcy52ZXJzaW9uID49IDEw MDAwMDsKQEAgLTE3NywyMSArMTc3LDIxIEBAIGRlZmluZSgncGdhZG1pbi5kYXNoYm9hcmQnLCBb CiAgICAgICBsYWJlbDogZ2V0dGV4dCgnUXVlcnkgc3RhcnRlZCBhdCcpLAogICAgICAgdHlwZTog J3RleHQnLAogICAgICAgZWRpdGFibGU6IGZhbHNlLAotICAgICAgZGlzYWJsZWQ6IHRydWUsCisg ICAgICByZWFkb25seTogdHJ1ZSwKICAgICAgIGdyb3VwOiBnZXR0ZXh0KCdEZXRhaWxzJyksCiAg ICAgfSwgewogICAgICAgaWQ6ICdzdGF0ZV9jaGFuZ2UnLAogICAgICAgbGFiZWw6IGdldHRleHQo J0xhc3Qgc3RhdGUgY2hhbmdlZCBhdCcpLAogICAgICAgdHlwZTogJ3RleHQnLAogICAgICAgZWRp dGFibGU6IHRydWUsCi0gICAgICBkaXNhYmxlZDogdHJ1ZSwKKyAgICAgIHJlYWRvbmx5OiB0cnVl LAogICAgICAgZ3JvdXA6IGdldHRleHQoJ0RldGFpbHMnKSwKICAgICB9LCB7CiAgICAgICBpZDog J3F1ZXJ5JywKICAgICAgIGxhYmVsOiBnZXR0ZXh0KCdTUUwnKSwKICAgICAgIHR5cGU6ICd0ZXh0 JywKICAgICAgIGVkaXRhYmxlOiB0cnVlLAotICAgICAgZGlzYWJsZWQ6IHRydWUsCisgICAgICBy ZWFkb25seTogdHJ1ZSwKICAgICAgIGNvbnRyb2w6IEJhY2tmb3JtLlNxbEZpZWxkQ29udHJvbCwK ICAgICAgIGdyb3VwOiBnZXR0ZXh0KCdEZXRhaWxzJyksCiAgICAgfV0sCg== --00000000000094964b05a02a13de--