Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jHL5i-0007D0-NK for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 Mar 2020 05:30:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jHL5h-0005F1-79 for pgadmin-hackers@arkaria.postgresql.org; Thu, 26 Mar 2020 05:30:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jHL5g-0005AZ-VZ for pgadmin-hackers@lists.postgresql.org; Thu, 26 Mar 2020 05:30:05 +0000 Received: from mail-vs1-xe2a.google.com ([2607:f8b0:4864:20::e2a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jHL5c-00038s-Pu for pgadmin-hackers@postgresql.org; Thu, 26 Mar 2020 05:30:02 +0000 Received: by mail-vs1-xe2a.google.com with SMTP id s10so3094436vsi.9 for ; Wed, 25 Mar 2020 22:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OWg/acTnu+8Lch6YmChisbrvAM5FQ2ldYF4lgPasEBA=; b=aEwgDisLbemxQLIc6+FnGzp+h+w0ThXLhbzkxpMhR8QIHCOBAeVnVSlNtBGKzZxMqO pCMoIKNZ9yLfKLzNMG+/FW77gd+x5l0Y0FeEtwZHxPjxmHSpkZ/q5G9WgKGj5ILDQun4 nud/HdZFuB3b98v07cMfNCxwpesQAWtkqDg/w34e3m56ToJiWVeeqx4TDgr1zvhMCSnr G1tr94OMYsGWO3BJGBZ0LErYKl0JDzzEVX4KZCABkr7aNQsqfmDC5KsgyRIR69ROomC1 Up6iykINXnHo7JtuKOfa5iEuF1ZMoqMoZqeDeNqdDfPZpKOl5c1VPXqLo04DgVZ9/wZM Jtbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OWg/acTnu+8Lch6YmChisbrvAM5FQ2ldYF4lgPasEBA=; b=gsVelCd31f+OPkgfmJ/efZ4EhE7FuzISftStlpB24HyvoX3jhaU7l8kSG1Y14I5ofY y/Mp3VnhFUCS5GCYNu0SWG3UM7G4nc1lTsCRXlHiWSVDoXAP96HEsC01fXPG6ndiKaol BFpY//Ztmg3WO3N7ftuKcenmHsGI3ixjEG/QSeD5jG5YSBhGiu/HNhg9uf5VzG5cdaYa OMnahEwtssIYaisCGlmgZQQn+USxmnaZDXx8Te9WL9d8N3y7JN8MZbOgG+odA9qqXG8G k6LVm8jko4RCLwgSuj+Zrc9DUtLGoALO/EK9czGlIkX0cAW0pwFdbrrtgUbulvJBCxjf iOvg== X-Gm-Message-State: ANhLgQ2WiVghXfP5HB4gmCd6LCeCXasF3ElGUZJVYkGwJq6PztuWTonc 2n65mrBaIpDKMp4//yTHoOfoacI+gmZn8WNTrSZMNGHPwsB9lCSf1DlP2quSk8ktRoIUyFYP5fd xRXekoQR6ren4dlIgYC+uiZW38mvMWArEZX1H1cg8T7P+vRxFwd7c/AUaTEFIly5PIU959NCVMp vtUEx9IJesNpWAMuTSR0xZAj6i82m01w2ilx2CxEyQ/I/img1PdaE= X-Google-Smtp-Source: ADFU+vuGprm7Le4XySIgFdV0L+uJVzLzfvpM2/BUOYezjHESHhW6/RqPrwJACIGtgKOVf3mz0Kd0WzoOKExsKVUQRYY= X-Received: by 2002:a67:f81:: with SMTP id 123mr5579343vsp.50.1585200598559; Wed, 25 Mar 2020 22:29:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nagesh Dhope Date: Thu, 26 Mar 2020 10:59:47 +0530 Message-ID: Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000093d80805a1bb466d" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000093d80805a1bb466d Content-Type: multipart/alternative; boundary="00000000000093d80505a1bb466b" --00000000000093d80505a1bb466b Content-Type: text/plain; charset="UTF-8" Please find an updated patch, which fixes review comments. On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Nagesh, > > I cannot see any change related to $active-border variable apart from > !default. Plus, $active-border should not be allowed to edit. It is a > structural variable and not a variable which affects theme change. > Please revert the $active-border change and send the patch. > > On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < > nagesh.dhope@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find a patch which includes >> >> 1. Use *btn-secondary* styles for all buttons in alertify dialog >> header. >> 2. Added *!default *for $active-border variable, so that it can be >> overridden if required. >> 3. Added entry for *.scss *in .editorconfig >> >> -- >> Thanks, >> Nagesh >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Nagesh --00000000000093d80505a1bb466b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please find an updated patch, which fixes review comments.=

= On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> w= rote:
Hi=C2=A0Nagesh,

I cannot see any change related to $active-border = variable apart from !default. Plus, $active-border=C2=A0should not be allow= ed to edit. It is a structural=C2=A0variable and not a variable which affec= ts theme change.
Please revert the=C2=A0$active-border change and send = the patch.

On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <nagesh.dhope@en= terprisedb.com> wrote:
Hi Hackers,

Please find a= patch which includes
  1. Use btn-secondary styles for= all buttons in alertify dialog header.
  2. Added !default for=C2=A0$active-border variable, so that it can be overridden if require= d.=C2=A0
  3. Added entry for .scss in .editorconfig
    4. <= /ol>--
    Thanks,
    Nagesh
    =


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks,
Nagesh
<= /div> --00000000000093d80505a1bb466b-- --00000000000093d80805a1bb466d Content-Type: application/octet-stream; name="RM5292_v2.patch" Content-Disposition: attachment; filename="RM5292_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k88bgwkz0 ZGlmZiAtLWdpdCBhL3dlYi8uZWRpdG9yY29uZmlnIGIvd2ViLy5lZGl0b3Jjb25maWcKaW5kZXgg ZjdlMjhlYS4uZmIzYzAyNyAxMDA2NDQKLS0tIGEvd2ViLy5lZGl0b3Jjb25maWcKKysrIGIvd2Vi Ly5lZGl0b3Jjb25maWcKQEAgLTIyLDYgKzIyLDkgQEAgaW5kZW50X3NpemUgPSAyCiBbKi5jc3Nd CiBpbmRlbnRfc2l6ZSA9IDIKIAorWyouc2Nzc10KK2luZGVudF9zaXplID0gMgorCiAjIE1hdGNo ZXMgdGhlIGV4YWN0IGZpbGUgcGFja2FnZS5qc29uCiBbe3BhY2thZ2UuanNvbn1dCiBpbmRlbnRf c2l6ZSA9IDIKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL19hbGVydGlmeS5v dmVycmlkZXMuc2NzcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL19hbGVydGlmeS5vdmVycmlk ZXMuc2NzcwppbmRleCAwOWNjYTdiLi5iMjBiNWNhIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9z dGF0aWMvc2Nzcy9fYWxlcnRpZnkub3ZlcnJpZGVzLnNjc3MKKysrIGIvd2ViL3BnYWRtaW4vc3Rh dGljL3Njc3MvX2FsZXJ0aWZ5Lm92ZXJyaWRlcy5zY3NzCkBAIC0yODEsOCArMjgxLDE4IEBACiB9 CiAKIAotLmFqcy1tYXhpbWl6ZSB7CisuYWpzLWNvbW1hbmRzIHsKKyAgYnV0dG9uIHsKICAgICBA ZXh0ZW5kIC5idG4tc2Vjb25kYXJ5OwogICAgIG91dGxpbmU6IG5vbmUgIWltcG9ydGFudDsKKyAg fQogfQogCisud2l6YXJkLWhlYWRlciB7CisgIC5tbC1hdXRvIHsKKyAgICBidXR0b24geworICAg ICAgQGV4dGVuZCAuYnRuLXNlY29uZGFyeTsKKyAgICAgIG91dGxpbmU6IG5vbmUgIWltcG9ydGFu dDsKKyAgICAgfQorICB9Cit9Cg== --00000000000093d80805a1bb466d--