Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkqDC-0006tw-7k for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Jul 2019 13:31:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hkqD7-00030H-3u for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Jul 2019 13:31:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkowE-0004ie-4w for pgadmin-hackers@lists.postgresql.org; Tue, 09 Jul 2019 12:09:38 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkowA-0006C6-QA for pgadmin-hackers@postgresql.org; Tue, 09 Jul 2019 12:09:37 +0000 Received: by mail-ua1-x942.google.com with SMTP id 34so6290862uar.8 for ; Tue, 09 Jul 2019 05:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XBF+5tPZ0/omShOSKz0g053bOZ177zXJHt6IZ7Gqe7Q=; b=iPE+MWBShP374C6TgX5QU/q/q75Kb0qq07SKdunVFDVEhnFdfgtJTblFZuFk21mz/b lR2dOD9zaNb61uGsgbawX6KG66MONHQt5bamIyy4Gb3SOXIjvUxb53P/1DiVEmZFhbhN H4E+bFBPOxwAS/ZKpKzq7/au3i9Rc/G5pz0b0U6l7zhLT9s9DM3QkzWtbtymetqsB1zI VOx0Rbm5Ksa+xy1nxBSAU2ZZ2963XMjaOWLUJBu5sY9dHxqgwCDmJZax/VlzLceFZvhH skacoSLqwwkLv1qGeRHO02utBK1N3Is3on0kiOytiTaQ+4fqNITK2W+4NqTXsfzgvSQO bSBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XBF+5tPZ0/omShOSKz0g053bOZ177zXJHt6IZ7Gqe7Q=; b=ISk0sGWU4BAamlNHXSMdxPI5tevhOF0GivWOdlZfmyJH8xJXuFM9IlAeWBbrP9TWd5 fzgHa1xczzEImtdUkhUJlY3ONu0L4MPRQVDrN7ha7/EJsz9wepIgnFjwVB5IoUbofbJm 2t0kR1N65rpkdbkVo98XJNLx3CDWg9/qJDoU5ucADOJEiq0Ze5d1dCAojtoVbUXjnaFr aFqGrVJBiqTjLXqYxZWU09KKrCu9fJvGWaUr7Fr4tfCYMqoJ9ZNt+YRE84sdTKew/WwW JE5v9pVazQ1GVAbYfiCq6dj5YTLFtFo/5aY3luCWmSdw19VnR2YL/+WwpjoqMVYnbbYJ dQZA== X-Gm-Message-State: APjAAAWDuwyhcIOF5ugRwMwJwSlL/oD3RNX23R8nq86zV654J+rx+Y7y Jc1Mxa2UmhYpGU4xdyMQDaxZaBWP1/pbdRtr8JrxN2rFpZk= X-Google-Smtp-Source: APXvYqwM6n18G1u/yZf398uCJuhnWYPKqYan7KPQfZRX/skp0BEeRQn4JXy1Mos7mhmZJ5iLh/8d44VnW/oLLueMKZw= X-Received: by 2002:a9f:3806:: with SMTP id p6mr13629878uad.21.1562674172724; Tue, 09 Jul 2019 05:09:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nagesh Dhope Date: Tue, 9 Jul 2019 17:39:21 +0530 Message-ID: Subject: Re: RE-SQL test patch for extension node To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000f74ab2058d3e6ef7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f74ab2058d3e6ef7 Content-Type: multipart/alternative; boundary="000000000000f74ab0058d3e6ef5" --000000000000f74ab0058d3e6ef5 Content-Type: text/plain; charset="UTF-8" Hi Dave, On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: > Hi > > I have a sneaking suspicion that the work Akshay and Khushboo have been > doing might have broken this :-( > Yup, earlier we were able to create a schema if not exists while running *alter *test cases. As this capability is remove alter test case for extension was failing. I have fixed the test case, PFA updated patch. > Create Extension with all options..............OK > ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query > (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): > Error Message:ERROR: schema "test_extension_schema" does not exist > > Alter Extension version..............FAIL > Traceback (most recent call last): > File > "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line > 230, in execute_test_case > self.assertEquals(response.status_code, 200) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 1338, in deprecated_func > return original_func(*args, **kwargs) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 839, in assertEqual > assertion_func(first, second, msg=msg) > File > "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", > line 832, in _baseAssertEqual > raise self.failureException(msg) > AssertionError: 500 != 200 > > > On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope > wrote: > >> Hi Dave, >> >> Please find updated patch with *sslinfo.* >> >> On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>> nagesh.dhope@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> Please review attached patch for RE-SQL test cases for *extension* >>>> node. >>>> >>> >>> Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel >>> contrib module has finally been removed. >>> >>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000f74ab0058d3e6ef5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Tue, Jul 9, 2019 at 4:54 PM Dave Page <= dpage@pgadmin.org> wrote:
Hi
I have a sneaking suspicion that the work Akshay and Khus= hboo have been doing might have broken this :-(=C2=A0

Yup, earlier we were able to create a=C2=A0 schema i= f not exists while running alter test cas= es. As this capability is remove alter test case for extension was failing.= =C2=A0
I have fixed the test case, PFA updated patch.
<= br>

Create Extension with all options..............OK
= =C2=A0... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query= (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245):Error Message:ERROR: =C2=A0schema "test_extension_schema" does n= ot exist

Alter Extension version..............FAIL
Traceback (mos= t recent call last):
=C2=A0 File "/Users/dpage/git/pgadmin4/web/reg= ression/re_sql/tests/test_resql.py", line 230, in execute_test_case=C2=A0 =C2=A0 self.assertEquals(response.status_code, 200)
=C2=A0 File = "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/pytho= n3.7/unittest/case.py", line 1338, in deprecated_func
=C2=A0 =C2=A0= return original_func(*args, **kwargs)
=C2=A0 File "/opt/local/Libr= ary/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py= ", line 839, in assertEqual
=C2=A0 =C2=A0 assertion_func(first, sec= ond, msg=3Dmsg)
=C2=A0 File "/opt/local/Library/Frameworks/Python.f= ramework/Versions/3.7/lib/python3.7/unittest/case.py", line 832, in _b= aseAssertEqual
=C2=A0 =C2=A0 raise self.failureException(msg)
Asserti= onError: 500 !=3D 200


On Tue, Jul 9, 2019 at 6:16 A= M Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi=C2=A0Dave,
Please find updated patch with sslinfo.
<= br>
On Mon,= Jul 8, 2019 at 2:03 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
On F= ri, Jul 5, 2019 at 5:16 PM Nagesh Dhope <nagesh.dhope@enterprisedb.com> w= rote:
Hi Hackers,
Please review attached patch for RE-SQL test cases= for extension node.=C2=A0

Unfortunately this fails on PostgreSQL 12 as the deprecated timetravel c= ontrib module has finally been removed.

Perhaps us= e sslinfo? That seems less likely to go away anytime soon.

Thanks.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company


--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company
--000000000000f74ab0058d3e6ef5-- --000000000000f74ab2058d3e6ef7 Content-Type: application/octet-stream; name="extension_resql_tests_v3.patch" Content-Disposition: attachment; filename="extension_resql_tests_v3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxvrqvw80 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9leHRlbnNpb25zL3Rlc3RzL2RlZmF1bHQvYWx0ZXJfZXh0ZW5zaW9uX3NjaGVtYS5z cWwgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMv ZXh0ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L2FsdGVyX2V4dGVuc2lvbl9zY2hlbWEuc3FsCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjM3YzYyMGMKLS0tIC9kZXYvbnVsbAorKysg Yi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvZXh0 ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L2FsdGVyX2V4dGVuc2lvbl9zY2hlbWEuc3FsCkBAIC0wLDAg KzEsNyBAQAorLS0gRXh0ZW5zaW9uOiBzc2xpbmZvCisKKy0tIERST1AgRVhURU5TSU9OIHNzbGlu Zm87CisKK0NSRUFURSBFWFRFTlNJT04gc3NsaW5mbworICAgIFNDSEVNQSBwdWJsaWMKKyAgICBW RVJTSU9OICIxLjIiOwpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3Jv dXBzL3NlcnZlcnMvZGF0YWJhc2VzL2V4dGVuc2lvbnMvdGVzdHMvZGVmYXVsdC9hbHRlcl9leHRl bnNpb25fdmVyc2lvbi5zcWwgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2Vy dmVycy9kYXRhYmFzZXMvZXh0ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L2FsdGVyX2V4dGVuc2lvbl92 ZXJzaW9uLnNxbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42ZDE5M2ZiCi0t LSAvZGV2L251bGwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZl cnMvZGF0YWJhc2VzL2V4dGVuc2lvbnMvdGVzdHMvZGVmYXVsdC9hbHRlcl9leHRlbnNpb25fdmVy c2lvbi5zcWwKQEAgLTAsMCArMSw3IEBACistLSBFeHRlbnNpb246IGFkbWlucGFjaworCistLSBE Uk9QIEVYVEVOU0lPTiBhZG1pbnBhY2s7CisKK0NSRUFURSBFWFRFTlNJT04gYWRtaW5wYWNrCisg ICAgU0NIRU1BIHBnX2NhdGFsb2cKKyAgICBWRVJTSU9OICIxLjEiOwpkaWZmIC0tZ2l0IGEvd2Vi L3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL2V4dGVuc2lv bnMvdGVzdHMvZGVmYXVsdC9jcmVhdGVfZXh0ZW5zaW9uX3dpdGhfYWxsX29wdGlvbnMuc3FsIGIv d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL2V4dGVu c2lvbnMvdGVzdHMvZGVmYXVsdC9jcmVhdGVfZXh0ZW5zaW9uX3dpdGhfYWxsX29wdGlvbnMuc3Fs Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmZjOGZjMTAKLS0tIC9kZXYvbnVs bAorKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFz ZXMvZXh0ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L2NyZWF0ZV9leHRlbnNpb25fd2l0aF9hbGxfb3B0 aW9ucy5zcWwKQEAgLTAsMCArMSw3IEBACistLSBFeHRlbnNpb246IHNzbGluZm8KKworLS0gRFJP UCBFWFRFTlNJT04gc3NsaW5mbzsKKworQ1JFQVRFIEVYVEVOU0lPTiBzc2xpbmZvCisgICAgU0NI RU1BIHRlc3RfZXh0ZW5zaW9uX3NjaGVtYQorICAgIFZFUlNJT04gIjEuMiI7CmRpZmYgLS1naXQg YS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvZXh0 ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L2NyZWF0ZV9leHRlbnNpb25fd2l0aF9kZWZhdWx0X3NjaGVt YS5zcWwgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFz ZXMvZXh0ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L2NyZWF0ZV9leHRlbnNpb25fd2l0aF9kZWZhdWx0 X3NjaGVtYS5zcWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYTlhNjFkNAot LS0gL2Rldi9udWxsCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2 ZXJzL2RhdGFiYXNlcy9leHRlbnNpb25zL3Rlc3RzL2RlZmF1bHQvY3JlYXRlX2V4dGVuc2lvbl93 aXRoX2RlZmF1bHRfc2NoZW1hLnNxbApAQCAtMCwwICsxLDcgQEAKKy0tIEV4dGVuc2lvbjogYWRt aW5wYWNrCisKKy0tIERST1AgRVhURU5TSU9OIGFkbWlucGFjazsKKworQ1JFQVRFIEVYVEVOU0lP TiBhZG1pbnBhY2sKKyAgICBTQ0hFTUEgcGdfY2F0YWxvZworICAgIFZFUlNJT04gIjEuMCI7CmRp ZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvZXh0ZW5zaW9ucy90ZXN0cy9kZWZhdWx0L3Rlc3RzLmpzb24gYi93ZWIvcGdhZG1pbi9i cm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvZXh0ZW5zaW9ucy90ZXN0cy9k ZWZhdWx0L3Rlc3RzLmpzb24KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzI4 OTM0OQotLS0gL2Rldi9udWxsCisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vw cy9zZXJ2ZXJzL2RhdGFiYXNlcy9leHRlbnNpb25zL3Rlc3RzL2RlZmF1bHQvdGVzdHMuanNvbgpA QCAtMCwwICsxLDU5IEBACit7CisgICJzY2VuYXJpb3MiOiBbCisgICAgeworICAgICAgInR5cGUi OiAiY3JlYXRlIiwKKyAgICAgICJuYW1lIjogIkNyZWF0ZSBFeHRlbnNpb24gd2l0aCBhbGwgb3B0 aW9ucyIsCisgICAgICAiZW5kcG9pbnQiOiAiTk9ERS1leHRlbnNpb24ub2JqIiwKKyAgICAgICJz cWxfZW5kcG9pbnQiOiAiTk9ERS1leHRlbnNpb24uc3FsX2lkIiwKKyAgICAgICJkYXRhIjogewor ICAgICAgICAibmFtZSI6ICJzc2xpbmZvIiwKKyAgICAgICAgInNjaGVtYSI6ICJ0ZXN0X2V4dGVu c2lvbl9zY2hlbWEiLAorICAgICAgICAidmVyc2lvbiI6ICIxLjIiCisgICAgICB9LAorICAgICAg ImV4cGVjdGVkX3NxbF9maWxlIjogImNyZWF0ZV9leHRlbnNpb25fd2l0aF9hbGxfb3B0aW9ucy5z cWwiCisgICAgfSwKKyAgICB7CisgICAgICAidHlwZSI6ICJhbHRlciIsCisgICAgICAibmFtZSI6 ICJBbHRlciBFeHRlbnNpb24gdmVyc2lvbiIsCisgICAgICAiZW5kcG9pbnQiOiAiTk9ERS1leHRl bnNpb24ub2JqX2lkIiwKKyAgICAgICJzcWxfZW5kcG9pbnQiOiAiTk9ERS1leHRlbnNpb24uc3Fs X2lkIiwKKyAgICAgICJkYXRhIjogeworICAgICAgICAic2NoZW1hIjogInB1YmxpYyIKKyAgICAg IH0sCisgICAgICAiZXhwZWN0ZWRfc3FsX2ZpbGUiOiAiYWx0ZXJfZXh0ZW5zaW9uX3NjaGVtYS5z cWwiCisgICAgfSwKKyAgICB7CisgICAgICAidHlwZSI6ICJkZWxldGUiLAorICAgICAgIm5hbWUi OiAiRHJvcCBFeHRlbnNpb24gd2l0aCBhbGwgb3B0aW9ucyIsCisgICAgICAiZW5kcG9pbnQiOiAi Tk9ERS1leHRlbnNpb24ub2JqX2lkIiwKKyAgICAgICJkYXRhIjoge30KKyAgICB9LAorICAgIHsK KyAgICAgICJ0eXBlIjogImNyZWF0ZSIsCisgICAgICAibmFtZSI6ICJDcmVhdGUgRXh0ZW5zaW9u IHdpdGggZGVmYXVsdChwZ19jYXRhbG9nKSBzY2hlbWEiLAorICAgICAgImVuZHBvaW50IjogIk5P REUtZXh0ZW5zaW9uLm9iaiIsCisgICAgICAic3FsX2VuZHBvaW50IjogIk5PREUtZXh0ZW5zaW9u LnNxbF9pZCIsCisgICAgICAiZGF0YSI6IHsKKyAgICAgICAgIm5hbWUiOiAiYWRtaW5wYWNrIiwK KyAgICAgICAgInZlcnNpb24iOiAiMS4wIgorICAgICAgfSwKKyAgICAgICJleHBlY3RlZF9zcWxf ZmlsZSI6ICJjcmVhdGVfZXh0ZW5zaW9uX3dpdGhfZGVmYXVsdF9zY2hlbWEuc3FsIgorICAgIH0s CisgICAgeworICAgICAgInR5cGUiOiAiYWx0ZXIiLAorICAgICAgIm5hbWUiOiAiQWx0ZXIgRXh0 ZW5zaW9uIHZlcnNpb24iLAorICAgICAgImVuZHBvaW50IjogIk5PREUtZXh0ZW5zaW9uLm9ial9p ZCIsCisgICAgICAic3FsX2VuZHBvaW50IjogIk5PREUtZXh0ZW5zaW9uLnNxbF9pZCIsCisgICAg ICAiZGF0YSI6IHsKKyAgICAgICAgInZlcnNpb24iOiAiMS4xIgorICAgICAgfSwKKyAgICAgICJl eHBlY3RlZF9zcWxfZmlsZSI6ICJhbHRlcl9leHRlbnNpb25fdmVyc2lvbi5zcWwiCisgICAgfSwK KyAgICB7CisgICAgICAidHlwZSI6ICJkZWxldGUiLAorICAgICAgIm5hbWUiOiAiRHJvcCBFeHRl bnNpb24gZGVmYXVsdChwZ19jYXRhbG9nKSBzY2hlbWEiLAorICAgICAgImVuZHBvaW50IjogIk5P REUtZXh0ZW5zaW9uLm9ial9pZCIsCisgICAgICAiZGF0YSI6IHt9CisgICAgfQorICBdCit9Cg== --000000000000f74ab2058d3e6ef7--