Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlTY0-0001Bd-JM for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 07:31:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hlTXz-0006EO-9c for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 07:31:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlSVt-0003nc-EI for pgadmin-hackers@lists.postgresql.org; Thu, 11 Jul 2019 06:25:05 +0000 Received: from mail-vk1-xa41.google.com ([2607:f8b0:4864:20::a41]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlSVq-0003u9-9l for pgadmin-hackers@postgresql.org; Thu, 11 Jul 2019 06:25:03 +0000 Received: by mail-vk1-xa41.google.com with SMTP id g124so989024vkd.1 for ; Wed, 10 Jul 2019 23:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=UaIcqWAyYZplQszl/Gf/ypT7KgLHd1kE7RfGn7gGd+o=; b=wWT+CwT+IYOpzpaB7o9YFtnVk+VzJMmbO5Jhc/9nMAvCVWCEHpewUocvqEtgnlOqgt tpU9UIg9HG7YxCic39NRCT1padcNAqUUFhkdwL2gqbUtAiVi77eBuYVBiXS9vpyAqvHp +vtqurmZkRxGx61wOAXDbIYq0KXW5nOPCPLO81qHwpW1UF+lW26cWYjsjUvRzrtddGuw SX4Tawk59kHU6fZKKrvS28JSgJcWw3skBJOATdT0uenRJ6ZM+uePVmqJ2GRk9PPEu6QY 1VWvIwD6K/OochH0MuA9hKeWgScpjoYrFVZG5BpWtZUpxspuVqftoLCaxLT6ZDJmC00G BKYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=UaIcqWAyYZplQszl/Gf/ypT7KgLHd1kE7RfGn7gGd+o=; b=mXzpWbGp9bE0/2RodpkfaMgVEtsk2eoB/E8gD0PCKogbKy7p5GnQEt+xpxwnYRlEau YOvfiDkiQsy7F5afL2dBcHYYyrGV1Sf7khlpOxWFNaxBulUWvef5k12ENILF7YZfJMMC M+kL6KzjIjnwSA5k6CpIjim9WAmTkOJG+lueC6YI9Gqta4+1PsZqVvbgqnLJFZGLrv4U EFufxN1QcFDfaZG72p6izz4nDuNCYOF2Hrus9FGmPVOxfJaG6/1mGLxr9+ndri3rO1y9 s1c882t2fqCFMOnuoPgMHFZYAHhWYruFtmkajOfvCFCiQ2toiRsuV4BtgeDHvbJmqeRM bnbQ== X-Gm-Message-State: APjAAAXBISPU9b1CakWtndsOARBp2e5L1WChZJXmsMW2bVCRom31rKGq dzwPeuQe4yTzSeLeS9ehb6SccC6mSA31MSHZWfapBkmdeLw= X-Google-Smtp-Source: APXvYqzrMQc+McNya/U4d+HYkXe5EW3O0aGlxLRyqMxWkdv4mT1VpA+8qrMNM3A8DFZHvQzEMrn1iPlMsf0bLUoLrdw= X-Received: by 2002:a1f:2cce:: with SMTP id s197mr1034093vks.28.1562826300864; Wed, 10 Jul 2019 23:25:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nagesh Dhope Date: Thu, 11 Jul 2019 11:54:50 +0530 Message-ID: Subject: Re: RE-SQL test patch for extension node To: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000824ec0058d61daeb" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000824ec0058d61daeb Content-Type: text/plain; charset="UTF-8" Please ignore this patch. Sending updated on new thread On Thu, Jul 11, 2019 at 11:40 AM Nagesh Dhope wrote: > Fixed failing extension resql test cases on PG 9.4 and PG 9.5. > PFA updated patch. > > On Tue, Jul 9, 2019 at 5:53 PM Dave Page wrote: > >> Thanks, applied! >> >> On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope < >> nagesh.dhope@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Tue, Jul 9, 2019 at 4:54 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> I have a sneaking suspicion that the work Akshay and Khushboo have been >>>> doing might have broken this :-( >>>> >>> >>> Yup, earlier we were able to create a schema if not exists while >>> running *alter *test cases. As this capability is remove alter test >>> case for extension was failing. >>> I have fixed the test case, PFA updated patch. >>> >>> >>>> Create Extension with all options..............OK >>>> ... 2019-07-09 12:22:55,268: ERROR flask.app: Failed to execute query >>>> (execute_dict) for the server #5- DB:test_db_d08e5 (Query-id: 1400245): >>>> Error Message:ERROR: schema "test_extension_schema" does not exist >>>> >>>> Alter Extension version..............FAIL >>>> Traceback (most recent call last): >>>> File >>>> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line >>>> 230, in execute_test_case >>>> self.assertEquals(response.status_code, 200) >>>> File >>>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >>>> line 1338, in deprecated_func >>>> return original_func(*args, **kwargs) >>>> File >>>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >>>> line 839, in assertEqual >>>> assertion_func(first, second, msg=msg) >>>> File >>>> "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py", >>>> line 832, in _baseAssertEqual >>>> raise self.failureException(msg) >>>> AssertionError: 500 != 200 >>>> >>>> >>>> On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope < >>>> nagesh.dhope@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find updated patch with *sslinfo.* >>>>> >>>>> On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope < >>>>>> nagesh.dhope@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> Please review attached patch for RE-SQL test cases for *extension* >>>>>>> node. >>>>>>> >>>>>> >>>>>> Unfortunately this fails on PostgreSQL 12 as the deprecated >>>>>> timetravel contrib module has finally been removed. >>>>>> >>>>>> Perhaps use sslinfo? That seems less likely to go away anytime soon. >>>>>> >>>>>> Thanks. >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > --000000000000824ec0058d61daeb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please ignore this patch. Sending updated on new thread
On = Thu, Jul 11, 2019 at 11:40 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
=
Fixed fa= iling extension resql test cases on PG 9.4 and PG 9.5.=C2=A0
PFA update= d patch.

On Tue, Jul 9, 2019 at 5:53 PM Dave Page <dpage@pgadmin.org> wrote:
= Thanks, applied!

On Tue, Jul 9, 2019 at 1:09 PM Nagesh Dhope <nagesh.dhope@enterp= risedb.com> wrote:
Hi Dave,

On Tue, Jul 9, 2019 at 4:54 PM Dav= e Page <dpage@pga= dmin.org> wrote:
Hi

I have a sneaking suspicion = that the work Akshay and Khushboo have been doing might have broken this :-= (=C2=A0

Yup, earlier we were ab= le to create a=C2=A0 schema if not exists while running alter test cases. As this capability is remove alter test ca= se for extension was failing.=C2=A0
I have fixed the test case, P= FA updated patch.


Create Extension with all= options..............OK
=C2=A0... 2019-07-09 12:22:55,268: ERROR flask.= app: Failed to execute query (execute_dict) for the server #5- DB:test_db_d= 08e5 (Query-id: 1400245):
Error Message:ERROR: =C2=A0schema "test_e= xtension_schema" does not exist

Alter Extension version........= ......FAIL
Traceback (most recent call last):
=C2=A0 File "/User= s/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line = 230, in execute_test_case
=C2=A0 =C2=A0 self.assertEquals(response.statu= s_code, 200)
=C2=A0 File "/opt/local/Library/Frameworks/Python.fram= ework/Versions/3.7/lib/python3.7/unittest/case.py", line 1338, in depr= ecated_func
=C2=A0 =C2=A0 return original_func(*args, **kwargs)
=C2= =A0 File "/opt/local/Library/Frameworks/Python.framework/Versions/3.7/= lib/python3.7/unittest/case.py", line 839, in assertEqual
=C2=A0 = =C2=A0 assertion_func(first, second, msg=3Dmsg)
=C2=A0 File "/opt/l= ocal/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittes= t/case.py", line 832, in _baseAssertEqual
=C2=A0 =C2=A0 raise self.= failureException(msg)
AssertionError: 500 !=3D 200


On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi=C2=A0Dave,

Please find updated patch wi= th sslinfo.

On Mon, Jul 8, 2019 at 2:03 PM Dave Page <dpage@pgadmin.org> = wrote:
Hi

On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope &= lt;nages= h.dhope@enterprisedb.com> wrote:
Hi Hackers,
Please review atta= ched patch for RE-SQL test cases for extension node.=C2=A0

Unfortunately this fails on PostgreSQL 1= 2 as the deprecated timetravel contrib module has finally been removed.

Perhaps use sslinfo? That seems less likely to go awa= y anytime soon.

Thanks.
=C2=A0
--
Dave PageBlog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company


--
Dave Page
Bl= og: http://pgsnak= e.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= /a>
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpri= seDB UK: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company
--000000000000824ec0058d61daeb--