MIME-Version: 1.0
References: 
 <CAKKotZRP_33MFutzVv15yE1A+-KHh+c5+JBH8DV5XprRZv4wPg@mail.gmail.com>
In-Reply-To: 
 <CAKKotZRP_33MFutzVv15yE1A+-KHh+c5+JBH8DV5XprRZv4wPg@mail.gmail.com>
From: Nagesh Dhope <nagesh.dhope@enterprisedb.com>
Date: Fri, 27 Dec 2019 12:56:27 +0530
Message-ID: 
 <CAA3zdZrxSoNSn5ytpcDUN5cfWKk2BU5XnDXULEjWDxfR1pJuBA@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#4772] Add aria-label attribute to buttons used in
 graphical explain plan
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Cc: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Content-Type: multipart/mixed; boundary="000000000000143022059aaa6a07"
Precedence: bulk

--000000000000143022059aaa6a07
Content-Type: multipart/alternative; boundary="00000000000014301f059aaa6a05"

--00000000000014301f059aaa6a05
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,
Please find an updated patch. The patch includes fix for not to blur the
focus from (Zoom in, Zoom out, Zoom to original and Download) button after
a click.


On Fri, Dec 20, 2019 at 5:47 PM Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi,
>
> PFA patch for adding aria-label to buttons used in graphical explain plan
> section.
>
> - Fixed another minor issue where we will only use dialog tab navigator
> keyboard shortcuts only on visible tabs.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

-- 
Thanks,
Nagesh

--00000000000014301f059aaa6a05
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hackers,<div>Please find an updated patch. The patch in=
cludes fix for not to blur the focus from (Zoom in, Zoom out, Zoom to origi=
nal and Download) button after a click.</div><div><br></div></div><br><div =
class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Dec 20,=
 2019 at 5:47 PM Murtuza Zabuawala &lt;<a href=3D"mailto:murtuza.zabuawala@=
enterprisedb.com">murtuza.zabuawala@enterprisedb.com</a>&gt; wrote:<br></di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-fami=
ly:verdana,sans-serif;color:rgb(68,68,68)">Hi,<br clear=3D"all"></div><div =
class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(6=
8,68,68)"><br></div><div class=3D"gmail_default" style=3D"font-family:verda=
na,sans-serif;color:rgb(68,68,68)">PFA patch for adding aria-label to butto=
ns used in graphical explain plan section.</div><div class=3D"gmail_default=
" style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)"><br></div><d=
iv class=3D"gmail_default" style=3D"font-family:verdana,sans-serif;color:rg=
b(68,68,68)">- Fixed another minor issue where we will only use=C2=A0dialog=
 tab navigator keyboard shortcuts only on visible tabs.</div><div class=3D"=
gmail_default" style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)"=
><br></div><div class=3D"gmail_default" style=3D"font-family:verdana,sans-s=
erif;color:rgb(68,68,68)"><br></div><div><div dir=3D"ltr"><div dir=3D"ltr">=
<div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" f=
ace=3D"verdana, sans-serif" color=3D"#444444">--</font><div><font size=3D"2=
" face=3D"verdana, sans-serif" color=3D"#444444">Regards,</font><div><font =
size=3D"2"><font face=3D"verdana, sans-serif" color=3D"#444444">Murtuza Zab=
uawala<br>EnterpriseDB:=C2=A0<a href=3D"http://www.enterprisedb.com/" rel=
=3D"noreferrer" target=3D"_blank">http://www.enterprisedb.com</a><br>The En=
terprise PostgreSQL Company</font></font></div></div><div><font size=3D"2">=
<font face=3D"verdana, sans-serif" color=3D"#444444"><br></font></font></di=
v></div></div></div></div></div></div></div></div></div></div></div></div><=
/div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr">Thanks,<div>Nagesh</div></div><=
/div>

--00000000000014301f059aaa6a05--

--000000000000143022059aaa6a07
Content-Type: application/octet-stream; name="RM4772.patch"
Content-Disposition: attachment; filename="RM4772.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_k4ntve4f0>
X-Attachment-Id: f_k4ntve4f0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5q
cyBiL3dlYi9wZ2FkbWluL21pc2Mvc3RhdGljL2V4cGxhaW4vanMvZXhwbGFpbi5qcwppbmRleCAx
NGNhNzZhLi45YjdlZjQwIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL3N0YXRpYy9leHBs
YWluL2pzL2V4cGxhaW4uanMKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9zdGF0aWMvZXhwbGFpbi9q
cy9leHBsYWluLmpzCkBAIC0xMjgzLDcgKzEyODMsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5l
eHBsYWluJywgWwogICAgICAgICB9KS5hcHBlbmRUbyhncmFwaGljYWxDb250YWluZXIpLAogICAg
ICAgICB6b29tSW5CdG4gPSAkKCc8YnV0dG9uPjwvYnV0dG9uPicsIHsKICAgICAgICAgICBjbGFz
czogJ2J0biBidG4tc2Vjb25kYXJ5IHBnLWV4cGxhaW4tem9vbS1idG4nLAotICAgICAgICAgIHRp
dGxlOiAnWm9vbSBpbicsCisgICAgICAgICAgdGl0bGU6IGdldHRleHQoJ1pvb20gaW4nKSwKKyAg
ICAgICAgICAnYXJpYS1sYWJlbCc6IGdldHRleHQoJ1pvb20gaW4nKSwKICAgICAgICAgICB0YWJp
bmRleDogMCwKICAgICAgICAgfSkuYXBwZW5kVG8oem9vbUFyZWEpLmFwcGVuZCgKICAgICAgICAg
ICAkKCc8aT48L2k+JywgewpAQCAtMTI5MSw3ICsxMjkyLDggQEAgZGVmaW5lKCdwZ2FkbWluLm1p
c2MuZXhwbGFpbicsIFsKICAgICAgICAgICB9KSksCiAgICAgICAgIHpvb21Ub05vcm1hbCA9ICQo
JzxidXR0b24+PC9idXR0b24+JywgewogICAgICAgICAgIGNsYXNzOiAnYnRuIGJ0bi1zZWNvbmRh
cnkgcGctZXhwbGFpbi16b29tLWJ0bicsCi0gICAgICAgICAgdGl0bGU6ICdab29tIHRvIG9yaWdp
bmFsJywKKyAgICAgICAgICB0aXRsZTogZ2V0dGV4dCgnWm9vbSB0byBvcmlnaW5hbCcpLAorICAg
ICAgICAgICdhcmlhLWxhYmVsJzogZ2V0dGV4dCgnWm9vbSB0byBvcmlnaW5hbCcpLAogICAgICAg
ICAgIHRhYmluZGV4OiAwLAogICAgICAgICB9KS5hcHBlbmRUbyh6b29tQXJlYSkuYXBwZW5kKAog
ICAgICAgICAgICQoJzxpPjwvaT4nLCB7CkBAIC0xMjk5LDcgKzEzMDEsOCBAQCBkZWZpbmUoJ3Bn
YWRtaW4ubWlzYy5leHBsYWluJywgWwogICAgICAgICAgIH0pKSwKICAgICAgICAgem9vbU91dEJ0
biA9ICQoJzxidXR0b24+PC9idXR0b24+JywgewogICAgICAgICAgIGNsYXNzOiAnYnRuIGJ0bi1z
ZWNvbmRhcnkgcGctZXhwbGFpbi16b29tLWJ0bicsCi0gICAgICAgICAgdGl0bGU6ICdab29tIG91
dCcsCisgICAgICAgICAgdGl0bGU6IGdldHRleHQoJ1pvb20gb3V0JyksCisgICAgICAgICAgJ2Fy
aWEtbGFiZWwnOiBnZXR0ZXh0KCdab29tIG91dCcpLAogICAgICAgICAgIHRhYmluZGV4OiAwLAog
ICAgICAgICB9KS5hcHBlbmRUbyh6b29tQXJlYSkuYXBwZW5kKAogICAgICAgICAgICQoJzxpPjwv
aT4nLCB7CkBAIC0xMzEzLDcgKzEzMTYsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5leHBsYWlu
JywgWwogICAgICAgICBkb3dubG9hZEJ0biA9ICQoJzxidXR0b24+PC9idXR0b24+JywgewogICAg
ICAgICAgIGlkOiAnYnRuLWV4cGxhaW4tZG93bmxvYWQnLAogICAgICAgICAgIGNsYXNzOiAnYnRu
IGJ0bi1zZWNvbmRhcnkgcGctZXhwbGFpbi1kb3dubG9hZC1idG4nLAotICAgICAgICAgIHRpdGxl
OiAnRG93bmxvYWQnLAorICAgICAgICAgIHRpdGxlOiBnZXR0ZXh0KCdEb3dubG9hZCcpLAorICAg
ICAgICAgICdhcmlhLWxhYmVsJzogZ2V0dGV4dCgnRG93bmxvYWQnKSwKICAgICAgICAgICB0YWJp
bmRleDogMCwKICAgICAgICAgICBkaXNhYmxlZDogZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICB2
YXIgY3VycmVudF9icm93c2VyID0gcGdBZG1pbi5Ccm93c2VyLmdldF9icm93c2VyKCk7CkBAIC0x
MzQxLDcgKzEzNDUsOCBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5leHBsYWluJywgWwogICAgICAg
JCgnPGJ1dHRvbj48L2J1dHRvbj4nLCB7CiAgICAgICAgIGlkOiAnYnRuLWV4cGxhaW4tc3RhdHMn
LAogICAgICAgICBjbGFzczogJ2J0biBidG4tc2Vjb25kYXJ5IHBnLWV4cGxhaW4tc3RhdHMtYnRu
JywKLSAgICAgICAgdGl0bGU6ICdTdGF0aXN0aWNzJywKKyAgICAgICAgdGl0bGU6IGdldHRleHQo
J1N0YXRpc3RpY3MnKSwKKyAgICAgICAgJ2FyaWEtbGFiZWwnOiBnZXR0ZXh0KCdTdGF0aXN0aWNz
JyksCiAgICAgICAgIHRhYmluZGV4OiAwLAogICAgICAgfSkuYXBwZW5kVG8oc3RhdHNBcmVhKS5h
cHBlbmQoCiAgICAgICAgICQoJzxpPjwvaT4nLCB7CkBAIC0xMzgwLDcgKzEzODUsNiBAQCBkZWZp
bmUoJ3BnYWRtaW4ubWlzYy5leHBsYWluJywgWwogICAgICAgICAgIHZhciB0b2RheSAgPSBuZXcg
RGF0ZSgpOwogICAgICAgICAgIHZhciBmaWxlbmFtZSA9ICdleHBsYWluX3BsYW5fJyArIHRvZGF5
LmdldFRpbWUoKSArICcuc3ZnJzsKICAgICAgICAgICBzdmdEb3dubG9hZGVyLmRvd25sb2FkU1ZH
KHMudG9TdHJpbmcoKSwgZmlsZW5hbWUpOwotICAgICAgICAgIGRvd25sb2FkQnRuLnRyaWdnZXIo
J2JsdXInKTsKICAgICAgICAgfQogICAgICAgfTsKIApAQCAtMTQ1MCw3ICsxNDU0LDYgQEAgZGVm
aW5lKCdwZ2FkbWluLm1pc2MuZXhwbGFpbicsIFsKICAgICAgICAgICAgICdoZWlnaHQnOiBoICog
Y3Vycl96b29tX2ZhY3RvciwKICAgICAgICAgICB9KTsKICAgICAgICAgICBwbGFuRGl2LmRhdGEo
J3pvb20tZmFjdG9yJywgY3Vycl96b29tX2ZhY3Rvcik7Ci0gICAgICAgICAgem9vbUluQnRuLnRy
aWdnZXIoJ2JsdXInKTsKICAgICAgICAgfSk7CiAKICAgICAgICAgem9vbU91dEJ0bi5vbignY2xp
Y2snLCBmdW5jdGlvbigpIHsKQEAgLTE0NjYsNyArMTQ2OSw2IEBAIGRlZmluZSgncGdhZG1pbi5t
aXNjLmV4cGxhaW4nLCBbCiAgICAgICAgICAgICAnaGVpZ2h0JzogaCAqIGN1cnJfem9vbV9mYWN0
b3IsCiAgICAgICAgICAgfSk7CiAgICAgICAgICAgcGxhbkRpdi5kYXRhKCd6b29tLWZhY3Rvcics
IGN1cnJfem9vbV9mYWN0b3IpOwotICAgICAgICAgIHpvb21PdXRCdG4udHJpZ2dlcignYmx1cicp
OwogICAgICAgICB9KTsKIAogICAgICAgICB6b29tVG9Ob3JtYWwub24oJ2NsaWNrJywgZnVuY3Rp
b24oKSB7CkBAIC0xNDgyLDcgKzE0ODQsNiBAQCBkZWZpbmUoJ3BnYWRtaW4ubWlzYy5leHBsYWlu
JywgWwogICAgICAgICAgICAgJ2hlaWdodCc6IGggKiBjdXJyX3pvb21fZmFjdG9yLAogICAgICAg
ICAgIH0pOwogICAgICAgICAgIHBsYW5EaXYuZGF0YSgnem9vbS1mYWN0b3InLCBjdXJyX3pvb21f
ZmFjdG9yKTsKLSAgICAgICAgICB6b29tVG9Ob3JtYWwudHJpZ2dlcignYmx1cicpOwogICAgICAg
ICB9KTsKIAogICAgICAgICBkb3dubG9hZEJ0bi5vbignY2xpY2snLCBmdW5jdGlvbigpIHsKQEAg
LTE0OTUsNyArMTQ5Niw2IEBAIGRlZmluZSgncGdhZG1pbi5taXNjLmV4cGxhaW4nLCBbCiAgICAg
ICAgICAgICAgIHZhciB0b2RheSAgPSBuZXcgRGF0ZSgpOwogICAgICAgICAgICAgICB2YXIgZmls
ZW5hbWUgPSAnZXhwbGFpbl9wbGFuXycgKyB0b2RheS5nZXRUaW1lKCkgKyAnLnN2Zyc7CiAgICAg
ICAgICAgICAgIHN2Z0Rvd25sb2FkZXIuZG93bmxvYWRTVkcocy50b1N0cmluZygpLCBmaWxlbmFt
ZSk7Ci0gICAgICAgICAgICAgIGRvd25sb2FkQnRuLnRyaWdnZXIoJ2JsdXInKTsKICAgICAgICAg
ICAgIH0KICAgICAgICAgICB9KTsKICAgICAgICAgfSk7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1p
bi9zdGF0aWMvanMvZGlhbG9nX3RhYl9uYXZpZ2F0b3IuanMgYi93ZWIvcGdhZG1pbi9zdGF0aWMv
anMvZGlhbG9nX3RhYl9uYXZpZ2F0b3IuanMKaW5kZXggNTk0MzcxMS4uYjNmZmM5OSAxMDA2NDQK
LS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2RpYWxvZ190YWJfbmF2aWdhdG9yLmpzCisrKyBi
L3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9kaWFsb2dfdGFiX25hdmlnYXRvci5qcwpAQCAtMTksNyAr
MTksNyBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogCiAgICAgdGhpcy50YWJTd2l0Y2hp
bmcgPSBmYWxzZTsKIAotICAgIHRoaXMudGFicyA9IHRoaXMuZGlhbG9nQ29udGFpbmVyLmZpbmQo
Jy5uYXYtdGFicycpOworICAgIHRoaXMudGFicyA9IHRoaXMuZGlhbG9nQ29udGFpbmVyLmZpbmQo
Jy5uYXYtdGFiczp2aXNpYmxlJyk7CiAKICAgICBpZiAodGhpcy50YWJzLmxlbmd0aCA+IDAgKSB7
CiAgICAgICB0aGlzLnRhYnMgPSB0aGlzLnRhYnNbMF07CkBAIC0zNSw3ICszNSw3IEBAIGNsYXNz
IGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAKICAgb25LZXlib2FyZEV2ZW50KGV2ZW50LCBzaG9ydGN1
dCkgewogICAgIHZhciBjdXJyZW50VGFiUGFuZSA9ICB0aGlzLmRpYWxvZ0NvbnRhaW5lcgotICAg
ICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdCcp
LAorICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpm
aXJzdDp2aXNpYmxlJyksCiAgICAgICBjaGlsZFRhYkRhdGEgPSB0aGlzLmlzQWN0aXZlUGFuZUhh
c0NoaWxkVGFicyhjdXJyZW50VGFiUGFuZSk7CiAKICAgICBpZiAodGhpcy50YWJTd2l0Y2hpbmcp
IHsKQEAgLTU3LDEyICs1NywxMiBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogICB9CiAK
ICAgaXNBY3RpdmVQYW5lSGFzQ2hpbGRUYWJzKGN1cnJlbnRUYWJQYW5lKSB7Ci0gICAgdmFyIGNo
aWxkVGFiID0gY3VycmVudFRhYlBhbmUuZmluZCgnLm5hdi10YWJzOmZpcnN0JyksCisgICAgdmFy
IGNoaWxkVGFiID0gY3VycmVudFRhYlBhbmUuZmluZCgnLm5hdi10YWJzOmZpcnN0OnZpc2libGUn
KSwKICAgICAgIGNoaWxkVGFiUGFuZTsKIAogICAgIGlmIChjaGlsZFRhYi5sZW5ndGggPiAwKSB7
CiAgICAgICBjaGlsZFRhYlBhbmUgPSBjdXJyZW50VGFiUGFuZQotICAgICAgICAuZmluZCgnLnRh
Yi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdCcpOworICAgICAgICAuZmlu
ZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5lLmFjdGl2ZTpmaXJzdDp2aXNpYmxlJyk7
CiAKICAgICAgIHJldHVybiB7CiAgICAgICAgICdjaGlsZFRhYic6IGNoaWxkVGFiLApAQCAtOTMs
NyArOTMsNyBAQCBjbGFzcyBkaWFsb2dUYWJOYXZpZ2F0b3IgewogCiAgICAgICBuZXh0VGFiUGFu
ZSA9IHRhYl9wYW5lLnByZXYoKTsKICAgICAgIGlubmVyVGFiQ29udGFpbmVyID0gbmV4dFRhYlBh
bmUKLSAgICAgICAgLmZpbmQoJy50YWItY29udGVudDpmaXJzdCA+IC50YWItcGFuZS5hY3RpdmU6
Zmlyc3QnKTsKKyAgICAgICAgLmZpbmQoJy50YWItY29udGVudDpmaXJzdCA+IC50YWItcGFuZS5h
Y3RpdmU6Zmlyc3Q6dmlzaWJsZScpOwogCiAgICAgICBpZiAoaW5uZXJUYWJDb250YWluZXIubGVu
Z3RoID4gMCkgewogICAgICAgICBmaW5kQW5kU2V0Rm9jdXMoaW5uZXJUYWJDb250YWluZXIpOwpA
QCAtMTI0LDcgKzEyNCw3IEBAIGNsYXNzIGRpYWxvZ1RhYk5hdmlnYXRvciB7CiAKICAgICAgIG5l
eHRUYWJQYW5lID0gdGFiX3BhbmUubmV4dCgpOwogICAgICAgaW5uZXJUYWJDb250YWluZXIgPSBu
ZXh0VGFiUGFuZQotICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRhYi1wYW5l
LmFjdGl2ZTpmaXJzdCcpOworICAgICAgICAuZmluZCgnLnRhYi1jb250ZW50OmZpcnN0ID4gLnRh
Yi1wYW5lLmFjdGl2ZTpmaXJzdDp2aXNpYmxlJyk7CiAKICAgICAgIGlmIChpbm5lclRhYkNvbnRh
aW5lci5sZW5ndGggPiAwKSB7CiAgICAgICAgIGZpbmRBbmRTZXRGb2N1cyhpbm5lclRhYkNvbnRh
aW5lcik7Cg==
--000000000000143022059aaa6a07--