Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ergcy-0005fO-Iy for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 09:05:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ergcx-0006lR-Ge for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 09:05:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ergcx-0006kv-7o for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 09:05:19 +0000 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ergcs-00042f-BK for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 09:05:18 +0000 Received: by mail-pl0-x243.google.com with SMTP id i6-v6so5355445plt.7 for ; Fri, 02 Mar 2018 01:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z+JF056hPt14KpKMeZn0zP6DaCNu9ae/P+OieFcoi5g=; b=L3mlrS9qrKNzjd1S9FfefD1ZX/Uu47AYMTIQbfcNmeK0ehkj8QSYH9En/jJcJsneUq FDx8mWiw8dUbm5NNVOxlkYwxdXDjSBhWW/gS92bPtpflav2RM8gjcpzmtfXDRQbsKmG3 fot+RyKMib2gcEifCO5bBwD9LiEhjOQKPTNSP+aH2Yzu7e0dCDoMnXA8DATJpqn6OfyX a93nMsowk2+b+FNV2A1UX4jtCOaN+/cIIXEGic20ygh39+hURiCNl/Lo7TsNy45TOK/3 YYPkWeCEgNPTDDA1zrUj1EMY/izosb0QUFJG+8cy2+OfUleFULYO/2ix/iRQ5LbPk17Y 0uFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z+JF056hPt14KpKMeZn0zP6DaCNu9ae/P+OieFcoi5g=; b=hZaR59/wi16SXOoGdlvGTq+34DMo5IzXDVBEJHdnObNjVJCDb+dtJ+AXjTE4UsyWwl 6JJ7/JX8Pi5sqI+2SY4uJZBt6y523GiX54U0sUctH3UsaCjOFaUT2RqsT1w4eUyL/1EH TkGAUJOFEpNBTdkElD5XI70AC00mhvMed8aUnS94613/8q21eA916IATeHGDH4zlqguc 8YtCyI5svdZr0hUh1vqrXOanb3XFZiZX0sw1slepUqQdb/B6fHCyiodSP8gTlWW61uAB wn/pOmpKtp/X0Hi+d7dXyHWG1svNoh1/oLMdILLbSQvu2seg5nq+/1QvxSjvjxXIZnSa 7lXg== X-Gm-Message-State: APf1xPD9XbkHYKEpDO8MpUubTOWubhWMZlwVocB8vBI6GSV7lgZ+kTji jb/MvwaRgbCahm1oMYJYUc1EO75ttv0RA7vNtys= X-Google-Smtp-Source: AG47ELvCO3kWA6OCAJzwRKo+ZHFIxheQu3+BgjG2u5SlwFTPlPEZsOg3E4uoYiYTN+isCpg+pZjNq9WMmdJ0IT57+qg= X-Received: by 2002:a17:902:3001:: with SMTP id u1-v6mr4609052plb.254.1519981511459; Fri, 02 Mar 2018 01:05:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.186.193 with HTTP; Fri, 2 Mar 2018 01:05:10 -0800 (PST) In-Reply-To: References: From: Neethu Mariya Joy Date: Fri, 2 Mar 2018 14:35:10 +0530 Message-ID: Subject: Re: Bug #2309 fix To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000000ed67f05666a46c6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000ed67f05666a46c6 Content-Type: multipart/alternative; boundary="0000000000000ed67c05666a46c4" --0000000000000ed67c05666a46c4 Content-Type: text/plain; charset="UTF-8" Hi, A similar workaround fixed #3137 too. I'm attaching the patch below. Sincerely, Neethu On Fri, Mar 2, 2018 at 9:45 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Neethu, > > Patch looks good. > > We are facing similar issue on dashboard as well where users are not able > to copy the sql from server activity table, I've attached screenshot for > your reference. > Bug: https://redmine.postgresql.org/issues/3137 > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri, Mar 2, 2018 at 3:35 AM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Neethu, >> >> We run the patch though our test pipeline and all tests are green. >> Everything looks good with this patch >> >> Thanks >> Joao >> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy < >> neethumariyajoy@gmail.com> wrote: >> >>> Hi, >>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science >>> at BITS Pilani. >>> >>> I've attempted to fix https://redmine.postgresql.org/issues/2309. >>> Codemirrors catches all the keyboard and mouse events when 'readOnly' >>> option is set to 'noCursor' and does not allow copying. >>> So, I've set 'readOnly' option to true. In order to hide the cursor, >>> I've added a class 'hide-cursor-workaround' and applied css styles to hide >>> the cursor. >>> >>> I'm attaching my patch as bug2309.diff below as per the contribution >>> guidelines. >>> >>> Hope this helps. Thank you for your consideration! >>> >>> Sincerely, >>> Neethu Mariya Joy >>> GitHub | Linkedin >>> >>> >>> >>> > --0000000000000ed67c05666a46c4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

A similar workaround fixed #3137 to= o. I'm attaching the patch below.

Sincerely,
Neethu

On Fri, Mar 2, 2018 at 9:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Neethu,

Patch looks good.

We are facing s= imilar issue on dashboard as well where users are not able to copy the sql = from server activity table, I've attached screenshot for your reference= .
Bug: https://redmine.postgre= sql.org/issues/3137


<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company

=

On Fri, Mar 2, 2018 at 3:35 AM, Joao De Alme= ida Pereira <jdealmeidapereira@pivotal.io> wrote:=
Hello Neethu,

<= div>We run the patch though our test pipeline and all tests are green. Ever= ything looks good with this patch

Thanks
Joao
On Thu, Mar 1, 2018 at= 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:
Hi,
I am Neethu Mariya = Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani.
=

I've attempted to fix=C2=A0https://redmine.postgresql= .org/issues/2309. Codemirrors catches all the keyboard and mouse e= vents when 'readOnly' option is set to 'noCursor' and does = not allow copying.
So, I've set 'readOnly' option to = true. In order to hide the cursor, I've added a class 'hide-cursor-= workaround' and applied css=C2=A0styles to hide the cursor.
<= br>
I'm attaching my patch as bug2309.diff below as per the c= ontribution guidelines.

Hope this helps. Thank you= for your consideration!

Sincerely,
Neet= hu Mariya Joy
GitHub=C2=A0|=C2=A0Linkedin




--0000000000000ed67c05666a46c4-- --0000000000000ed67f05666a46c6 Content-Type: application/octet-stream; name="bug2309_3137.diff" Content-Disposition: attachment; filename="bug2309_3137.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_je9pke731 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9jc3MvY29kZW1pcnJvci5vdmVycmlkZXMu Y3NzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2Nzcy9jb2RlbWlycm9yLm92ZXJyaWRlcy5jc3MKaW5k ZXggMTc4YjAzOC4uMWI1ZmNhYyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2Nzcy9j b2RlbWlycm9yLm92ZXJyaWRlcy5jc3MKKysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2Nzcy9jb2Rl bWlycm9yLm92ZXJyaWRlcy5jc3MKQEAgLTgxLDMgKzgxLDggQEAKIC5zcWxfdGV4dGFyZWEgLkNv ZGVNaXJyb3Itc2Nyb2xsIHsKICAgei1pbmRleDogMDsKIH0KKworLyogd29ya2Fyb3VuZCBmb3Ig Y29kZW1pcnJvcnMgJ3JlYWRPbmx5J8Kgb3B0aW9uIHdoaWNoIGlzIHNldCB0byB0cnVlIGluc3Rl YWQgb2YgJ25vQ3Vyc29yJyAqLworLmhpZGUtY3Vyc29yLXdvcmthcm91bmQgLkNvZGVNaXJyb3It Y3Vyc29yc3sKKyAgZGlzcGxheTogbm9uZTsKK30KZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0 YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tm b3JtLnBnYWRtaW4uanMKaW5kZXggNWJiYmY5Zi4uYWE4MTFjNSAxMDA2NDQKLS0tIGEvd2ViL3Bn YWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKKysrIGIvd2ViL3BnYWRtaW4vc3Rh dGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKQEAgLTIwOTgsMTAgKzIwOTgsMTEgQEAgZGVmaW5l KFsKIAogICAgICAgLy8gRGlzYWJsZSBlZGl0b3IKICAgICAgIGlmIChpc0Rpc2FibGVkKSB7Ci0g ICAgICAgIHNlbGYuc3FsQ3RybC5zZXRPcHRpb24oJ3JlYWRPbmx5JywgJ25vY3Vyc29yJyk7Cisg ICAgICAgIC8vIHNldCByZWFkIG9ubHkgbW9kZSB0byB0cnVlIGluc3RlYWQgb2YgJ25vY3Vyc29y JywgYW5kIGhpZGUgY3Vyc29yIHVzaW5nIGEgY2xhc3Mgc28gdGhhdCBjb3B5aW5nIGlzIGVuYWJs ZWQKKyAgICAgICAgc2VsZi5zcWxDdHJsLnNldE9wdGlvbigncmVhZE9ubHknLCB0cnVlKTsKICAg ICAgICAgdmFyIGNtID0gc2VsZi5zcWxDdHJsLmdldFdyYXBwZXJFbGVtZW50KCk7CiAgICAgICAg IGlmIChjbSkgewotICAgICAgICAgIGNtLmNsYXNzTmFtZSArPSAnIGNtX2Rpc2FibGVkJzsKKyAg ICAgICAgICBjbS5jbGFzc05hbWUgKz0gJyBjbV9kaXNhYmxlZCBoaWRlLWN1cnNvci13b3JrYXJv dW5kJzsKICAgICAgICAgfQogICAgICAgfQogCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29s cy9zcWxlZGl0b3Ivc3RhdGljL2pzL3NxbGVkaXRvci5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3Nx bGVkaXRvci9zdGF0aWMvanMvc3FsZWRpdG9yLmpzCmluZGV4IDU2YTkwMWEuLmE4NGRhYTMgMTAw NjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvanMvc3FsZWRpdG9y LmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvanMvc3FsZWRpdG9y LmpzCkBAIC0yMDE5LDEyICsyMDE5LDEyIEBAIGRlZmluZSgndG9vbHMucXVlcnl0b29sJywgWwog ICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBlbHNlIHsKLSAgICAgICAgICAvLyBEaXNh YmxlIGNvZGVtaXJyb3IgYnkgc2V0dGluZyBjdXJzb3IgdG8gbm9jdXJzb3IgYW5kIGJhY2tncm91 bmQgdG8gZGFyay4KKyAgICAgICAgICAvLyBEaXNhYmxlIGNvZGVtaXJyb3IgYnkgc2V0dGluZyBy ZWFkT25seSBvcHRpb24gdG8gdHJ1ZSwgYmFja2dyb3VuZCB0byBkYXJrLCBhbmQgY3Vyc29yLCBo aWRkZW4uCiAgICAgICAgICAgc2VsZi5pbml0X2V2ZW50cygpOwotICAgICAgICAgIHNlbGYuZ3Jp ZFZpZXcucXVlcnlfdG9vbF9vYmouc2V0T3B0aW9uKCdyZWFkT25seScsICdub2N1cnNvcicpOwor ICAgICAgICAgIHNlbGYuZ3JpZFZpZXcucXVlcnlfdG9vbF9vYmouc2V0T3B0aW9uKCdyZWFkT25s eScsIHRydWUpOwogICAgICAgICAgIHZhciBjbSA9IHNlbGYuZ3JpZFZpZXcucXVlcnlfdG9vbF9v YmouZ2V0V3JhcHBlckVsZW1lbnQoKTsKICAgICAgICAgICBpZiAoY20pIHsKLSAgICAgICAgICAg IGNtLmNsYXNzTmFtZSArPSAnIGJnLWdyYXktMSBvcGFjaXR5LTUnOworICAgICAgICAgICAgY20u Y2xhc3NOYW1lICs9ICcgYmctZ3JheS0xIG9wYWNpdHktNSBoaWRlLWN1cnNvci13b3JrYXJvdW5k JzsKICAgICAgICAgICB9CiAgICAgICAgICAgc2VsZi5kaXNhYmxlX3Rvb2xfYnV0dG9ucyh0cnVl KTsKICAgICAgICAgICBzZWxmLmV4ZWN1dGVfZGF0YV9xdWVyeSgpOwo= --0000000000000ed67f05666a46c6--