Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQoaY-0000JL-VJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jun 2018 06:40:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQoaX-0005KT-Cu for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jun 2018 06:40:01 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQoaW-0005KG-Ql for pgadmin-hackers@lists.postgresql.org; Thu, 07 Jun 2018 06:40:01 +0000 Received: from mail-io0-x22f.google.com ([2607:f8b0:4001:c06::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQoaT-0002Ua-Dg for pgadmin-hackers@postgresql.org; Thu, 07 Jun 2018 06:39:59 +0000 Received: by mail-io0-x22f.google.com with SMTP id l25-v6so10518127ioh.12 for ; Wed, 06 Jun 2018 23:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O3uA2sBE7bDkKwuB0WPoQgW7WDgFKMU9npg4+TFIK+k=; b=V2qnYlMLQ3fMtgse9psPTOmJb21GOHaP/e+JuyoQ/+HLGgMwe/gKG20muK271Vdvsj PTbtTo8hm3m5hB5dYp76hdo9kXBJIAczgyqLcssroDz0r7SWbzfoWX8o4wSpQvBAWteM +rO93JLAR/MLZB2BhnEghVMJl6G01S4xdS5JKjhDQf3zZK9qdP6rGh0YIP8p+AwpsjSr Qr25t6tYctloziZ213Yxi5VKBwUHijhmR3wzT5nEjkyLE2OgAxJyf0JnI5NyT88eLoWk 804LsOK3v/fSGHpJzTUOs4TC2ADTGF2RI7xisxylG78TkaOn9VxKaurSqJIiO1FcTV0P e/NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O3uA2sBE7bDkKwuB0WPoQgW7WDgFKMU9npg4+TFIK+k=; b=Y/DfO149A56d7wjx7j3b9Sf7iRkaUE3KH1psKkHvA3Nb+gzJVOfy2QqyRHkcA+O0SS ESUFn508KSSlFsjqfpARvXa87qayZnFuSM/9LuG4pHl3s5VU87Sf1DwmyBT+cPfvXokm G5zKyYPe0SvvQlt05ahqjE9P6rXKE8+zADuVumAcwlgd3bvpbv85Rrph/e5nr9Lr16GW nMMzYN73sQxCfta41XbBojUGaaJzQ3PjSiic6sTDHZPRhPZslJsLG8UmiGy4zzZb3iKI B1cDUAXBE8E046kmmVhAFhHk6li4y8bSdeZnHL+/xi3fq2z/1y84PD+YezimvZ0qTzpu fiRg== X-Gm-Message-State: APt69E2mDF+VXnSZ95sSuLc24web7bveNfSOpF0pS2GU9ZwxMSI0u1Yr b0BYfLNrWQR3yS+jTHpaUQaA1mkYXGSvMJAE0G1bKQ== X-Google-Smtp-Source: ADUXVKJUa3c7WhAFAViKA8R0pn3kyQbaAz0yDf/hpMQ8GA0Ylkdsks2B59dpxK4k5BalNeak4PC8FHh9sydUHLaP6AM= X-Received: by 2002:a6b:8b91:: with SMTP id n139-v6mr439188iod.109.1528353595952; Wed, 06 Jun 2018 23:39:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paresh More Date: Thu, 7 Jun 2018 12:09:43 +0530 Message-ID: Subject: Re: pgAgent 4.0 patch To: Fahar Abbas Cc: Ashesh Vashi , pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="0000000000002da560056e078d0c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000002da560056e078d0c Content-Type: text/plain; charset="UTF-8" Hello Fahar, File, pgagent-4.0.0-1-linux-x64.run is uploaded @ https://uploads.enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6 On Tue, Jun 5, 2018 at 3:10 PM, Dave Page wrote: > Thanks, committed with those changes. > > Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS > Bitrock installers) from git head for Fahar to test? > > Once he's happy with them, I'll tag and build the community packages. > > Thanks! > > On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page wrote: >> >>> Hi >>> >>> Can you review the attached please Ashesh? >>> >> Hi Dave, >> >> Due to the wrong pattern in '.gitignore', it was ignoring the new file >> 'sql/pgagent--3.4--4.0.sql'. >> We should ignore only the '*.sql' in the root directory. >> Something like this. >> >> *$ git diff .gitignore* >> *diff --git a/.gitignore b/.gitignore* >> *index 9883354..40fe7a9 100644* >> *--- a/.gitignore* >> *+++ b/.gitignore* >> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake* >> * Makefile* >> * cmake_install.cmake* >> * install_manifest.txt* >> *-pgagent* >> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.* >> *+/pgagent* >> *+!/*/pgagent* >> * pgagent.control* >> *+!/*/pgagent.control* >> * *.log* >> *-*.sql* >> *+# Ignore '*.sql' files in root directory only.* >> *+/*.sql* >> *+!/*/*.sql* >> >> >> And, I am getting the following warning applying the patch. >> >> *$ git apply ~/Downloads/pgagent-4.0-update.diff* >> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing >> whitespace.* >> *//* >> *warning: 1 line adds whitespace errors.* >> >> >> Otherwise - it looks good to me. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi >> * >> >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks & Regards *Paresh More* [image: NEW-EDB-logo-4c] Pune, India. Cell : +919922000564 | www.enterprisedb.com --0000000000002da560056e078d0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hel= lo Fahar,

File, pgagent-4.0.0-1-linux-= x64.run is uploaded @=C2=A0=C2=A0https:/= /uploads.enterprisedb.com/download.php?file=3Dbd89aec08d73ceae21cf560c39159= 8f6

On Tue, Jun 5, 2018 at 3:10 PM, Dave Page <dpage= @pgadmin.org> wrote:
Thanks, committed with those changes.

Paresh;= can you please create some pgAgent 4.0 installers (PG not EPAS Bitrock ins= tallers) from git head for Fahar to test?

Once he&= #39;s happy with them, I'll tag and build the community packages.
=

Thanks!
=
On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi= <ashesh.vashi@enterprisedb.com> wrote:
On= Mon, Jun 4, 2018 at 10:04 PM, Dave Page <dpage@pgadmin= .org> wrote:
Hi

Can you review the attached please Ashe= sh?
Hi Dave,

Due to the wrong pattern in = 9;.gitignore', it was ignoring the new file 'sql/pgagent--3.4--4.0.= sql'.
We should ignore onl= y the '*.sql' in the root directory.
Something like this.
<= font color=3D"#6aa84f">$=C2=A0<= /font>git diff .gitignore
diff --git a/.gitignore b/.gitignore
index 9883354..40fe7= a9 100644
--- a/= .gitignore
+++ b= /.gitignore
@@ -= 6,7 +6,12 @@ CPackSourceConfig.cmake
=C2=A0Makefile
=C2=A0cmake_install.cmake
=C2=A0install_manifest.txt
-pgagent
+# Ignore 'pgagent' & 'pg= agent.control' in root directory only.
= +/pgagent
+!/*/pgagent
=C2=A0pgagent.control
= +!/*/pgagent.control
=C2=A0*.log
-*.sql
+# Ignore '*.sql' files in root directory only.
+/*.sql<= /div>
+!/*/*.sql
=

And, I am getting the following warning a= pplying the patch.
$=C2=A0git apply ~/Downloads/pgagent-4.0-update.diff
/Users/asheshvashi/Downloads/pgagent-4.0-update= .diff:320: trailing whitespace.
//
warning: 1 line adds whitespace errors.

=
Otherwise - it looks good to me.

= --

Thanks & Regards,

Ashesh Vashi
Ente= rpriseDB INDIA:=C2=A0= Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi=C2=A0


Thanks.

--
Dave Page
Blog: = http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB = UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= br>




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.co= m
The Enterprise PostgreSQL Company



--
=

= Thanks & Regards

Paresh More

3D"NEW-EDB-logo-4c"

Pune, India.

Cell : =C2=A0+919922000564 | =C2=A0www.enterprisedb.com
--0000000000002da560056e078d0c--