Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0omf-0001S1-Ur for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 13:37:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0ome-0001C9-Gw for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 13:37:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0ome-0001Bz-43 for pgadmin-hackers@lists.postgresql.org; Tue, 27 Mar 2018 13:37:04 +0000 Received: from mail-vk0-x241.google.com ([2607:f8b0:400c:c05::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0omZ-0006Uf-Q0 for pgadmin-hackers@postgresql.org; Tue, 27 Mar 2018 13:37:02 +0000 Received: by mail-vk0-x241.google.com with SMTP id k187so13194948vke.12 for ; Tue, 27 Mar 2018 06:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/Tv/VN3hoqu5fCb8GItG/fMkp4s2guyjjTMjwaTHhts=; b=pzuzDO8LzZ8v5npujVcurEptoPaqHPG6aM85XKBM6KnccxiObkWegNx5M+7ucZ5F6A mH0MkZlj7+fLVw0GM0EVM1y+40r1JBLSnhECfBVMnUJbcBhD/rZOUTo7OP6hwp/lTuX8 fEIiHvdS+V1QQ6cG/N3XR7Vn7wV5hwMFTATYARrbgRtDRuAASgY9mXDyy/j8qwtdV7Y6 jX23DtfYGjKRrQk1dtYptZ1dhVL7EwtkMGhGNiXqX3gKbNkr2CHuU8zQLIrkwPIMxm6F znVaoIUnHNFuTBpkB3kMMDGqOh7Nu/d5EwS/YJ895gVvNogEzlKeED5AZuF4vYAOL3Fy Cj7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/Tv/VN3hoqu5fCb8GItG/fMkp4s2guyjjTMjwaTHhts=; b=FrKTdbFm4Uib5Kqu8V0g8WRKyTAqNTICMszx9ke3AcFkY+cntfRL7PD8P+bJK4MHYo bWImNDuTYtLARqo/TEt2MbpTXb6VxVn5WJ8J7yzhsxXaMF4M4L0lKCLQ36OQkIPU3hP3 Q3EylJ1sWKatGRpOYpkndO5/mZ1XO0DbbhkR1jhihWEby3U3wKcxhlr9XCb0G1ooTcXP E00K2YzcLtONtzmZQFNz6YpFEA/+2NOAZdL6P0hlGdqJ8NY+khCCtAJljiRz3GzGxA0D YX23/yDLLFPXTVwYZfz3TltnsOA2jjKTXvU1/p6/PaWRwTw+rLyNH/LKshxnEBMGoyC9 Srxg== X-Gm-Message-State: AElRT7GQGH27wEH2e9lPMTPoAm3QnYCqfN9GuCncVpE8LpulVLFAUh9d XVgGViC8iMTy0EFwkd9BYYLFxyJM5yUClPsrObYwug== X-Google-Smtp-Source: AG47ELtgjhrcmOOPWFk1mYu9bMP8BidQnqBCwHLqhMLj2M94fJtAM2AIUbr8GETPR917/YrGINun23/bThHqZF1cF80= X-Received: by 10.31.60.133 with SMTP id j127mr22588359vka.178.1522157817548; Tue, 27 Mar 2018 06:36:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.96.136 with HTTP; Tue, 27 Mar 2018 06:36:57 -0700 (PDT) In-Reply-To: References: From: Robert Eckhardt Date: Tue, 27 Mar 2018 09:36:57 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode To: Murtuza Zabuawala Cc: Dave Page , Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114289f801f10c056864fc65" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114289f801f10c056864fc65 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > On Tue, Mar 27, 2018 at 3:13 PM, Dave Page wrote: > >> >> >> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt >> wrote: >> >>> >>> >>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi Hackers, >>>> >>>> @Murtuza: The patch codewise looks good. Nice to see that we are using >>>> axios instead of jquery ajax calls and that there is some coverage for= the >>>> change. >>>> Nevertheless the Javascript testing looks a bit slim and could be >>>> improved. Also the DataSorting class could have some other member func= tions >>>> like the model validation could be extracted out so that it is easily >>>> tested. >>>> >>>> >>>> @Hackers: This was how we tried to test this feature: >>>> 1 - Started pgAdmin >>>> 2 - Opened the query tool for a specific server >>>> 3 - Executed a SQL statment >>>> 4 - Pressed the column header to try to order, nothing happened >>>> 5 - Right clicked the column header to see if it was there the option, >>>> nothing >>>> >>>> This is the behavior that we were expecting, not to have to open Data >>>> View and then press the icon that is not even near the grid in order t= o >>>> sort the column. Is this really the way we want people to use the grid= in >>>> pgAdmin? Should it be more intuitive? >>>> >>> >>> Have we considered making the grid behave more like excel or other >>> grids? I think that having the ascending and descending inside the colu= mn >>> header, we could similarly provide filtering. Something that would give >>> users a more intuitive place to look. >>> >> >> Doing the sorting via header clicks is convenient but very restrictive. >> How do you specify multiple columns to sort by for example? The current >> design allows you to select columns and the sort order as you see fit. >> > Honestly I'm not sold on my idea, I was just proposing an alternative in an effort to start a discussion about the user experience. Ideally what I'd like to see, maybe this happened, is some user research. When we initial worked on refactoring the results grid we made a bunch of changes. One of the things we intended to do was to follow up to see how people were using the grid now so that we could better understand how it was now being used in order to design and implement features just like this. Clearly we haven't gotten there yet. > > Another reason we can't use that because w > e have already occupied that behaviour for selecting entire column > =E2=80=8B when user clicks on header. > As Dave suggested, I will be merging it with filter dialog meaning it wil= l > be accessible via direct button on toolbar & keyboard shortcut.=E2=80=8B > =E2=80=8B > How are users currently interacting with that filter dialog? What I'm suggesting is that we understand how users want to interact with their results, be those the results of a query or a table view, then we can design something that meets those needs. I agree that changing the column selection behavior isn't desirable, however, I also feel like providing the best user experience is better than holding onto a particular feature implementation. -- Rob > > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a114289f801f10c056864fc65 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala &l= t;m= urtuza.zabuawala@enterprisedb.com> wrote:
On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <= span dir=3D"ltr" style=3D"font-family:arial,sans-serif;color:rgb(34,34,34)"= ><dpage@pgadmin.o= rg> wrote:


On M= on, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <reckhardt@pivotal.io= > wrote:

<= div class=3D"gmail_extra">
On Mon, Mar = 26, 2018 at 2:07 PM, Joao De Almeida Pereira <jdealmeidapereir= a@pivotal.io> wrote:
Hi Hackers,

@Murtuza: The patch codewise look= s good. Nice to see that we are using axios instead of jquery ajax calls an= d that there is some coverage for the change.
Nevertheless the Ja= vascript testing looks a bit slim and could be improved. Also the DataSorti= ng class could have some other member functions like the model validation c= ould be extracted out so that it is easily tested.=C2=A0


@Hackers: This was how we tried to test this feature:=
1 - Started pgAdmin
2 - Opened the query tool for a sp= ecific server
3 - Executed a SQL statment
4 - Pressed t= he column header to try to order, nothing happened
5 - Right clic= ked the column header to see if it was there the option, nothing
=
This is the behavior that we were expecting, not to have to = open Data View and then press the icon that is not even near the grid in or= der to sort the column. Is this really the way we want people to use the gr= id in pgAdmin? Should it be more intuitive?
Have we considered making the grid behave more like exc= el or other grids? I think that having the ascending and descending inside = the column header, we could similarly provide filtering. Something that wou= ld give users a more intuitive place to look.

Doing the sorting via header clicks is convenien= t but very restrictive. How do you specify multiple columns to sort by for = example? The current design allows you to select columns and the sort order= as you see fit.

Honestly I'm not sold on my idea, I= was just proposing an alternative in an effort to start a discussion about= the user experience. Ideally what I'd like to see, maybe this happened= , is some user research. When we initial worked on refactoring the results = grid we made a bunch of changes. One of the things we intended to do was to= follow up to see how people were using the grid now so that we could bette= r understand how it was now being used in order to design and implement fea= tures just like this. Clearly we haven't gotten there yet.=C2=A0
<= div>=C2=A0
=C2=A0
Another reason we can't use that because w
e have alr= eady occupied that behaviour for selecting entire column
=E2=80=8B whe= n user clicks on header.
As Dave suggested, = I will be merging it with filter dialog meaning it will be accessible=C2=A0= via direct=C2=A0button on toolbar & keyboard shortcut.=E2=80=8B<= /div>=E2=80=8B<= /div>

How are users curre= ntly interacting with that filter dialog?=C2=A0

Wh= at I'm suggesting is that we understand how users want to interact with= their results, be those the results of a query or a table view, then we ca= n design something that meets those needs. I agree that changing the column= selection behavior isn't desirable, however, I also feel like providin= g the best user experience is better than holding onto a particular feature= implementation.=C2=A0

-- Rob
=C2=A0

=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--001a114289f801f10c056864fc65--