Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0YhJ-00028t-CD for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 20:26:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0YhI-00024L-4A for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 20:26:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0YhH-00024A-RI for pgadmin-hackers@lists.postgresql.org; Mon, 26 Mar 2018 20:26:28 +0000 Received: from mail-ua0-x244.google.com ([2607:f8b0:400c:c08::244]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0YhC-00079r-Ft for pgadmin-hackers@postgresql.org; Mon, 26 Mar 2018 20:26:26 +0000 Received: by mail-ua0-x244.google.com with SMTP id l21so7489924uak.1 for ; Mon, 26 Mar 2018 13:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zBdGYNTR6D+Qj9IMGJmFBx4S0evx8pof7nik4i/lALE=; b=NCH5VVNeE2ikMJtx8z9pDCIs77DShTMcvtSxaosvAYtnExGubjinpbGUe0pUs8P1y7 6isyCVI0rWsyMn38aXbQVqJlSzhcJb3Yfjh03PPg88OrQWJ7KFban9ceidtGs2emNmD3 KO4onjOSAsQGKCj9ZXXu4XyBRQ4LlKFSpIeA0fGSujEYY+K0Gn/+1y/4irzdTohS8r+i g2Wbkp8v0qqEe7MFu4pXhk74cI7aMhLAJvB0GD4foy9U1/o2cipkqQa/F4aidJwsLUBC 7wsehc9oP8Ab67KX0HyI5Dbyhapqtvde3o8ckOc7DEyDA15WJMqp4ZHiaSyzVKR5Iy6b kROw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zBdGYNTR6D+Qj9IMGJmFBx4S0evx8pof7nik4i/lALE=; b=khbI+Ka3mf/3Gt/4+9SBYg9zRnePPzJ2ke0Q6H+0PNxB62yWq2zm2EsqbK1OxjbLb3 /kQcLKq2L64fRkdfta0idlqfOYMXG4r4FBT2cURzyZm8tsUj5i7R3Umqn3AvFYFpGWX8 Q0LWPdUTdi8z5O9jOBpxvty2tLLuTfnD+G7L4ZbnTVZJpDL8WQVJwLde+FuqN5ExEgHk hRu58SaX89Gcnwl88NmeDb5h6SGhAYXUlxsqUGFEbmbPJKdHdtbe58ASW5ExznmE9H4l XtXAdEL2stsBQe57ewMeQ3kfaHntfiAvaye0ChwHlk7QGzCKuRZSk3ovjBLkBpyNMTeF 6ksw== X-Gm-Message-State: AElRT7Fw4qhos6aiJvxzXaH5tTBXvPLAiErePgHiIUtgaYkKJ+wyXnf3 HV3MsxkironExMP56KhQbRfR5BdhW45ZIpVA2Ugi4g== X-Google-Smtp-Source: AG47ELvlKc88vclCPQAXxj+44shSk3/PTgtsDF7gSTrWpdjn6th0H6a0KxtnBrEnxiLJWFBXgic6a0XQqz8f+Q4AK7k= X-Received: by 10.176.24.215 with SMTP id d23mr23085945uah.29.1522095979314; Mon, 26 Mar 2018 13:26:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.96.136 with HTTP; Mon, 26 Mar 2018 13:26:18 -0700 (PDT) In-Reply-To: References: From: Robert Eckhardt Date: Mon, 26 Mar 2018 16:26:18 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode To: Joao De Almeida Pereira Cc: Murtuza Zabuawala , Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="f40304379d7c29615f05685696de" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f40304379d7c29615f05685696de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Hackers, > > @Murtuza: The patch codewise looks good. Nice to see that we are using > axios instead of jquery ajax calls and that there is some coverage for th= e > change. > Nevertheless the Javascript testing looks a bit slim and could be > improved. Also the DataSorting class could have some other member functio= ns > like the model validation could be extracted out so that it is easily > tested. > > > @Hackers: This was how we tried to test this feature: > 1 - Started pgAdmin > 2 - Opened the query tool for a specific server > 3 - Executed a SQL statment > 4 - Pressed the column header to try to order, nothing happened > 5 - Right clicked the column header to see if it was there the option, > nothing > > This is the behavior that we were expecting, not to have to open Data Vie= w > and then press the icon that is not even near the grid in order to sort t= he > column. Is this really the way we want people to use the grid in pgAdmin? > Should it be more intuitive? > Have we considered making the grid behave more like excel or other grids? I think that having the ascending and descending inside the column header, we could similarly provide filtering. Something that would give users a more intuitive place to look. -- Rob > > > PS: Also that Orange after the selection is like a push in the eyes and > not in a good way. Maybe we should think about changing the color of the > icon to blue to match the rest of the website or something. > > Thanks > Victoria & Joao > > On Mon, Mar 26, 2018 at 12:13 PM Murtuza Zabuawala enterprisedb.com> wrote: > >> On Mon, Mar 26, 2018 at 5:52 PM, Dave Page wrote: >> >>> Hi >>> >>> On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala >> enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch which allow user to sort the data in View data mode. >>>> >>> >>> The patch looks good in general, however I'm not sure about the UI, in >>> particular that the closely-linked dialogue for filtering is a complete= ly >>> different design. I think it would be better to combine the Sort/Filter >>> options and use a single dialogue for both, as pgAdmin 3 did (though, m= aybe >>> not using separate tabs for each part, but the top and bottom of the sa= me >>> dialogue. >>> >>> That would certainly fix the consistency of the dialogues (obviously, a= s >>> there would only be one!), and I think would perhaps be a more simple >>> overall UI, particularly for those that want to sort and filter. >>> >> =E2=80=8BSure, I'll send updated it accordingly.=E2=80=8B >> >> >>> >>> Thoughts? >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> --f40304379d7c29615f05685696de Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <j= dealmeidapereira@pivotal.io> wrote:
Hi Hackers,

@Murtuza: The patc= h codewise looks good. Nice to see that we are using axios instead of jquer= y ajax calls and that there is some coverage for the change.
Neve= rtheless the Javascript testing looks a bit slim and could be improved. Als= o the DataSorting class could have some other member functions like the mod= el validation could be extracted out so that it is easily tested.=C2=A0


@Hackers: This was how we tried to tes= t this feature:
1 - Started pgAdmin
2 - Opened the quer= y tool for a specific server
3 - Executed a SQL statment
4 - Pressed the column header to try to order, nothing happened
5 - Right clicked the column header to see if it was there the option, not= hing

This is the behavior that we were expecting, = not to have to open Data View and then press the icon that is not even near= the grid in order to sort the column. Is this really the way we want peopl= e to use the grid in pgAdmin? Should it be more intuitive?

Have we considered making the grid behave more = like excel or other grids? I think that having the ascending and descending= inside the column header, we could similarly provide filtering. Something = that would give users a more intuitive place to look.=C2=A0=C2=A0

-- Rob
=C2=A0


PS: Also that Orange a= fter the selection is like a push in the eyes and not in a good way. Maybe = we should think about changing the color of the icon to blue to match the r= est of the website or something.

Thanks
= Victoria & Joao

=
On Mon, Mar 26, 2018 at 12:13 P= M Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:=
On Mon, Mar 26, 2018 at 5:52 PM, Dave Page= <dpage@= pgadmin.org> wrote:
=
Hi

On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala = <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch which allow user to sort the data in View data mode.=

The patch looks good in genera= l, however I'm not sure about the UI, in particular that the closely-li= nked dialogue for filtering is a completely different design. I think it wo= uld be better to combine the Sort/Filter options and use a single dialogue = for both, as pgAdmin 3 did (though, maybe not using separate tabs for each = part, but the top and bottom of the same dialogue.

That would certainly fix the consistency of the dialogues (obviously, as t= here would only be one!), and I think would perhaps be a more simple overal= l UI, particularly for those that want to sort and filter.
=E2=80=8BSure, I'll send u= pdated it accordingly.=E2=80=8B
=C2=A0

Thoughts?

Tha= nks.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpris= e PostgreSQL Company

--f40304379d7c29615f05685696de--