Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6FHz-0006NI-7v for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 May 2017 11:51:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d6FHy-00031k-PW for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 May 2017 11:51:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d6FHy-00031Y-1E for pgadmin-hackers@postgresql.org; Thu, 04 May 2017 11:51:18 +0000 Received: from mail-vk0-x22d.google.com ([2607:f8b0:400c:c05::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d6FHu-0006rm-DW for pgadmin-hackers@postgresql.org; Thu, 04 May 2017 11:51:16 +0000 Received: by mail-vk0-x22d.google.com with SMTP id y190so5713169vkc.1 for ; Thu, 04 May 2017 04:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MynuTTZZ4sJ2XQSbOS2bhRoOMFDe2LdkrHaxq0NGX2w=; b=o7RQxAV1PmVT1hlq2VByuFB0/dd7joOe4oaMQ7XlSVomqiSWC8tN3P8FCI29WB1Jg/ T9Fx0LZ5q0JkNO0DNaKNI6UpFDv2nK2mQuVxA6E0pWzTv4V5/UJ4BlqZK8TjbcjxlngS gh+zrCajuSI/eAJYToxupcyZCyGfGSAYTF1MnGGCWF39SWNEU+2lNv+hu/q3aWTv3qH5 GZVfl+tD8ukEeFX5kQIk4PCo3gyW6NnCBXFoehwXeDx/rJDH9y1KjxAwJ7zb0RwlJvSQ mAmXqme/w8uL1N7Tc2Vf9NcaNK6oC5H1NFw287zjEnlrRmTkLWZXnvX+fR7P9HPESh1w hzUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MynuTTZZ4sJ2XQSbOS2bhRoOMFDe2LdkrHaxq0NGX2w=; b=Yc/exHcOtrN2WOxrRDJ8Br+6pTD/z1Ief+QhQmT/iLhXD9+6Wd2SDkZ1ChjpI4HwNZ KlNmBl2UcUdZ8uZa62PQDs0YhfwvnZqhL3siVurwtEcuPMNv1GDfJz3GGSBHIP1eRhk2 61VJUqrpA4GwtGnKwT/c4c78FiYiUMOyDpN5lcGxghWPmhRxWbaIdXGz2wN84LPx7ZYE xA5cr7Z7Q2sOttlzf4f847OM6N/aKG9L0moamuw2t1uxZsbrN8TmF/rgeEFzc8xpllvd NmaRbg/a/YFR6KmcnGlLChEcKaDMPkvldXZOsnAfFwb8YMrbptd7XFMHn4YQvoSAbkkk qxQw== X-Gm-Message-State: AN3rC/5HqUzVCOn6dkOC0Grvf8PMxVgZhdWO9HLDkP1oDJHD89Mw+kDo km8oivsjiqeVEywjGtbXYN6WJGfeX1Bk X-Received: by 10.31.135.1 with SMTP id j1mr19748214vkd.134.1493898672080; Thu, 04 May 2017 04:51:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.0.243 with HTTP; Thu, 4 May 2017 04:51:11 -0700 (PDT) In-Reply-To: References: From: Robert Eckhardt Date: Thu, 4 May 2017 07:51:11 -0400 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Sarah McAlear Cc: Joao Pedro De Almeida Pereira , Ashesh Vashi , Dave Page , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=001a11412c84ae229b054eb16308 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11412c84ae229b054eb16308 Content-Type: text/plain; charset=UTF-8 All, This change in the xss testing is preventing our CI from going green and is also preventing the Dependents and Dependencies tabs in Greenplum from being useful. Can we either merge this or provide feedback as to what needs to change so that it can be merged. Thank you Rob On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear wrote: > Hi Hackers & Ashesh! > > Is there anything else we can do for this? > > Thanks! > Matt & Sarah > > On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Thanks for reviewing, Ashesh. >> >> We have updated the patch. The headers are all consistent and we removed >> the __init__.py files in directories containing only .sql. >> >> Thanks! >> Joao & Matt >> >> On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Ashesh, >>> >>> Thanks for reviewing the patch. >>> >>> We added the __init__.py files into templates to convert them into >>> packages so that the tests inside of them can be found by the test runner. >>> >>> Thanks! >>> Joao & Sarah >>> >>> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: >>>> >>>>> Ashesh, can you review/commit this please? >>>>> >>>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >>>>> jdealmeidapereira@pivotal.io> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> We found out that when you are connected to a GreenPlum database and >>>>>> try to get Dependents and Dependencies of an object the application was >>>>>> returning a SQL error. >>>>>> >>>>>> This patch splits the SQL query used to retrieve the Dependents, >>>>>> Dependencies, and Roles SQL file into multiple versioned files. >>>>>> Add Unit Tests for each file. >>>>>> Also added __init__.py files to other test directories to run the >>>>>> tests in them. >>>>>> >>>>> Hi Joao & Sarah, >>>> >>>> Why do we need to add __init__.py in the template directory? >>>> I didn't understand the purpose of the adding __init__.py files in the >>>> template directories. >>>> >>>> NOTE: The headers in those files are not consistent with the other >>>> project files. >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>>> Add ORDER BY into Copy Selection Feature test to ensure the results >>>>>> are retrieved always in the same order >>>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and >>>>>> skip it for versions less than 9.1 >>>>>> >>>>>> Thanks >>>>>> >>>>>> Joao & Sarah >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > --001a11412c84ae229b054eb16308 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
All,=C2=A0

This change in the xss testi= ng is preventing our CI from going green and is also preventing the=C2=A0De= pendents and Dependencies tabs in Greenplum from being useful.=C2=A0
<= div>
Can we either merge this or provide feedback as to what = needs to change so that it can be merged.=C2=A0

Th= ank you
Rob

On Tue, May 2, 2017 at 5:17 PM, Sarah McAlear <smcalear= @pivotal.io> wrote:
Hi Hackers & Ashesh!

Is there anything else we ca= n do for this?

Thanks!
Matt & Sarah

=
On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De = Almeida Pereira <jdealmeidapereira@pivotal.io> wr= ote:
Thanks for reviewin= g, Ashesh.

We have updated the patch. The headers are al= l consistent and we removed the __init_= _.py files in directories containing only .sql.

Thanks!
Joao &= ; Matt

On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Ashesh,

Thanks fo= r reviewing the patch.

We added the __init__.py fi= les into templates to convert them into packages so that the tests inside o= f them can be found by the test runner.

Than= ks!
Joao & Sarah

On Wed, = Apr 26, 2017 at 1:26 AM, Ashesh Vashi <ashesh.vashi@enterprise= db.com> wrote:
On Mo= n, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org> wr= ote:
= Ashesh, can you review/commit this please?
=
On Fr= i, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jdea= lmeidapereira@pivotal.io> wrote:
Hi Hackers,

We found out that when you= are connected to a GreenPlum database and try to get Dependents and Depend= encies of an object the application was returning a SQL error.
This patch splits the SQL query used to retrieve the Dependent= s, Dependencies, and Roles SQL file into multiple versioned files.
Add Unit Tests for each file.
Also added __init__.py files to o= ther test directories to run the tests in them.
Hi Joao & Sarah,

Why do we need to add __init__.py in the template directory?
I didn't understand the purpose of the adding __init__.py files in th= e template directories.

NOTE: The headers in those= files are not consistent with the other project files.

--

Thanks &a= mp; Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2= =A0Enterp= rise PostgreSQL Company


= http://www.linkedin.com/in/asheshvashi

Add ORDER BY into Copy Selection Feature test to ensure the resu= lts are retrieved always in the same order
Renamed the Scenario o= f the=C2=A0xss_checks_pgadmin_debugger_test and skip it for versions l= ess than 9.1

Thanks

Joao = & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave PageBlog: http://pgs= nake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--001a11412c84ae229b054eb16308--