Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3Ng6-0001qj-0s for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 15:16:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3Ng5-0000on-5z for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 15:16:53 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3Ng4-0000od-Jk for pgadmin-hackers@lists.postgresql.org; Tue, 03 Apr 2018 15:16:53 +0000 Received: from mail-vk0-x232.google.com ([2607:f8b0:400c:c05::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3Nfz-00027a-Je for pgadmin-hackers@postgresql.org; Tue, 03 Apr 2018 15:16:51 +0000 Received: by mail-vk0-x232.google.com with SMTP id v205so8971729vkv.13 for ; Tue, 03 Apr 2018 08:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MSmaxiPQU9APsZq9Pyvr4eF7X1SrTPhwKLX/lB7CQNw=; b=TxxKGKCBLqjrvQ0v9PC8bAw9Ma4bzzduLzK9LDv4+AjXbFymYjY68rZAmxq232gdw4 xzrboN7F6fjticmgfpRc5o+L+AxwGTtmnYNXP6M4/uNtr9GQAspz0xFPP0AP1NmyzDvE lnMe/rLRVVlUtcAhCRG/K17ZTNONmZR/0o3c6AAevvdMVJzO7ooSijYW+LBVDdDGfitR SZFurEKqDN78Kc3iO9zIXGRihYq2l8OTtchk5DBq+uTnhV3Cy0hqDPMskZ1e1aGpEmFN nJAlkN1LB98Fdf/s24bTvJu+drTbkgWHR11bRQpQzkI7s5LRP9HGz6SB+KmIwLmWdPPZ xwvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MSmaxiPQU9APsZq9Pyvr4eF7X1SrTPhwKLX/lB7CQNw=; b=M5A51yCtLkD6VBR3Ij5DRzWwbY7S4mwZmy5CL4CWr7EZKPc+dNSV5Q+S76x+oHAghy IQnfrp+BQH7+Mo7z3qrEWToi4VtfKaxQsBpIyIY4eGkUxM4RNwPavUodccj+xJD/AiQz aSE4hU8l2uGPwAxaeyxypOYaB5j+v5HxWaO8vjlS5YpklGBVhJ468E3aEtQmQ+ocWQiE KuBavubAYvLvv1N9C0RdsGHPerRZGSNlirUqvPjjke++51EdwvU/0BWmBnHDC21u9DT8 nZ6anZoumEvuuy2c4KJ7w2hwqCt5ulvbeF5UUMx3zG8MB3u1oR7jgS1XRdrkiE1x0wV0 Pyxg== X-Gm-Message-State: ALQs6tC3Y+gKIRvajT8hFpQWpsg0IEnBkhXdrEdgYZZo+6NnVuSgBOpX egeyiCI5OD+F5Km1ORgKaQ1ZKJhGgeMyOWzyq9QKwQ== X-Google-Smtp-Source: AIpwx48ikOPJdIS14iUhaC6xxemS7ZAKOQbOWpuDszKzvNd6NWRf7OwRjww352wXJygDXb2zEzGxTaSZw+P6qkS1gfs= X-Received: by 10.31.188.13 with SMTP id m13mr8063466vkf.86.1522768605931; Tue, 03 Apr 2018 08:16:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.96.136 with HTTP; Tue, 3 Apr 2018 08:16:45 -0700 (PDT) In-Reply-To: References: From: Robert Eckhardt Date: Tue, 3 Apr 2018 11:16:45 -0400 Message-ID: Subject: Re: v3.0 release on hold To: Dave Page Cc: Joao De Almeida Pereira , Akshay Joshi , pgadmin-hackers , Murtuza Zabuawala , Khushboo Vashi , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a11438092d51a710568f331b2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11438092d51a710568f331b2 Content-Type: text/plain; charset="UTF-8" On Tue, Apr 3, 2018 at 11:04 AM, Dave Page wrote: > I'm thinking build Monday, release Thursday. > > Objections? > It we can make it happen faster I'd be all for it. If not that will work. Thanks -- Rob > > > On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt > wrote: > >> All, >> >> Where are we with respect to cutting this release? >> >> -- Rob >> >> On Mon, Mar 26, 2018 at 9:59 AM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Did we had any progress on the things that are holding the release back? >>> >>> Thanks >>> Joao >>> >>> On Fri, Mar 23, 2018 at 9:26 AM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Dave >>>> >>>> On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote: >>>>>> >>>>>>> >>>>>>>>>>> 2) Starting a second instance of the app bundle on Mac doesn't >>>>>>>>>>> always open a new pgAdmin window as it should. It works fine in the >>>>>>>>>>> debugger, or if you start the app with a command like: >>>>>>>>>>> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It >>>>>>>>>>> doesn't work if you double-click the appbundle or use a command like "open >>>>>>>>>>> /Applications/pgAdmin\ 4.app" >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Still working on this, not found any solution yet. >>>>>>>>>> >>>>>>>>> >>>>>>>> Not able to figure out the solution yet. I have tried to >>>>>>>> debug the code, but every time it will create a new instance(tray icon). Do >>>>>>>> I need to look into the code or something related to app bundle may be some >>>>>>>> settings in info.plist or any other pointer? >>>>>>>> >>>>>>> >>>>>>> Have a look at the code around line 85 an onwards of pgAdmin4.cpp. >>>>>>> It creates the shared memory interlock (and log/address files) based on the >>>>>>> current username and a hash of the executable name/path. My suspicion is >>>>>>> that the path hash (which is calculated from argv[0] on line 72) is for >>>>>>> some reason getting a different value each time when launched via the >>>>>>> Finder or "open", thus the interlock is failing. >>>>>>> >>>>>> >>>>>> So I took a look at this, and it seems the code is just fine. What is >>>>>> happening is that macOS only allows a single instance of an app to run at >>>>>> once. Whilst that is what we want of course, macOS is causing the new >>>>>> instance to exit before it has a change to open a new pgAdmin window. Using >>>>>> "open -n ..." or calling the embedded executable directly resolves that >>>>>> issue. >>>>>> >>>>>> So, there's another challenge to figure out... :-( >>>>>> >>>>> >>>>> OK. Will try to figure that out. >>>>> >>>> >>>> After googled I have tried following solution: >>>> >>>> 1. Create a shell script "launch.sh" and kept it in "/Applications/pgAdmin\ >>>> 4.app/Contents/MacOS" folder. That shell script will contain the command >>>> "open -n /Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". >>>> Change the "CFBundleExecutable" parameter of Info.plist from "pgAdmin4" to >>>> "launch.sh". It didn't work, shall script didn't launch. >>>> 2. Create one apple script with command like "do shell execute "/Applications/pgAdmin\ >>>> 4.app", compile it and save it as Application. It create the app bundle, >>>> copy contents of pgAdmin4 app to this newly created application. But the >>>> problem is it opens and having icon in the dock and no response on double >>>> click (second time). >>>> >>>> Will continue to figure out some other solutions tomorrow. >>>> >>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>> 976-788-8246 <+91%2097678%2088246>* >>>>> >>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>> 976-788-8246 <+91%2097678%2088246>* >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a11438092d51a710568f331b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Apr 3, 2018 at 11:04 AM, Dave Page <dpage@pgadmin.org><= /span> wrote:
I'm th= inking build Monday, release Thursday.

Objections?
=

It we can make it happen faster I= 9;d be all for it. If not that will work. Thanks

-= - Rob
=C2=A0


On Tue, Apr 3, 2018 at 2:43 PM, Robert Eckhardt <reck= hardt@pivotal.io> wrote:
All,

Where are we with respect to cutting= this release?=C2=A0

-- Rob
<= div class=3D"gmail_extra">
On Mon, Mar 26, 20= 18 at 9:59 AM, Joao De Almeida Pereira <jdealmeidapereira@pivot= al.io> wrote:
Hi Hackers,

Did we had any progress on the things th= at are holding the release back?

Thanks
Joao

On Fri= , Mar 23, 2018 at 9:26 AM Akshay Joshi <akshay.joshi@enterprisedb.com&g= t; wrote:
Hi Dave<= div class=3D"gmail_extra">
=
On F= ri, Mar 23, 2018 at 11:06 AM, Akshay Joshi <akshay.joshi@enter= prisedb.com> wrote:


On Thu, Mar 22, 2018 at 10:24 PM, Dave Page <<= a href=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.org= > wrote:
Hi

On Thu, Ma= r 22, 2018 at 1:13 PM, Dave Page <dpage@pgadmin.org> wrote:<= br>
=

2) Starting a second i= nstance of the app bundle on Mac doesn't always open a new pgAdmin wind= ow as it should. It works fine in the debugger, or if you start the app wit= h a command like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin= 4". It doesn't work if you double-click the appbundle or use = a command like "open /Applications/pgAdmin\ 4.app"

=C2=A0 Still working on this, not foun= d any solution yet.
=

=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Not able to figure out the solution yet. I have tried to debug the co= de, but every time it will create a new instance(tray icon). Do I need to l= ook into the code or something related to app bundle may be some settings i= n info.plist or any other pointer?=C2=A0

Have a look at the code around line 85 an onwa= rds of pgAdmin4.cpp. It creates the shared memory interlock (and log/addres= s files) based on the current username and a hash of the executable name/pa= th. My suspicion is that the path hash (which is calculated from argv[0] on= line 72) is for some reason getting a different value each time when launc= hed via the Finder or "open", thus the interlock is failing.

So I took a look= at this, and it seems the code is just fine. What is happening is that mac= OS only allows a single instance of an app to run at once. Whilst that is w= hat we want of course, macOS is causing the new instance to exit before it = has a change to open a new pgAdmin window. Using "open -n ..." or= calling the embedded executable directly resolves that issue.
So, there's another challenge to figure out... :-(=C2=A0

=C2=A0 =C2=A0= OK. Will try to figure that out.=C2=A0

=C2=A0 =C2=A0 =C2=A0 =C2=A0 After go= ogled I have tried following solution:=C2=A0
  1. Create a she= ll script "launch.sh" and kept it in=C2=A0 "/Applications/pgAdmin\ 4.app/Contents/MacOS" folder. That sh= ell script will contain the command "open -n=C2=A0/Applications/pgAdmin\ 4.app/Contents/MacOS= /pgAdmin4". Change the "CFBundleExecutable" para= meter of Info.plist from "pgAdmin4" to "launch.sh".=C2= =A0 It didn't work, shall script didn't launch.
  2. <= li>Create one apple scr= ipt with command like "do shell execute "

    --
    Dave Page
    Blog: http://pgsnake.blogspot.com
    Twi= tter: @pgsnake

    EnterpriseDB UK: http://www.enterprisedb.com
    The Enterprise Pos= tgreSQL Company



    --
    Akshay Joshi
    Sr. Sof= tware Architect

=


--
Akshay= Joshi
Sr. Software Architect
<= /div>




--
=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

= EnterpriseDB UK: = http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a11438092d51a710568f331b2--