MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjakQjs7i2=-6fUQeji8i7qUz3x0e1NSgsbanvzPxD-uzYg@mail.gmail.com>
References: 
 <CAFiP3vxaM9ixpmaM04JAkTT1ONwmnMPwUCbK+kzCN+r6F+7-ZA@mail.gmail.com>
 <CA+OCxozb7qDTiskHXv08G5TrCi7zmhR7Csz=x9V4ermehyO8cg@mail.gmail.com>
 <CAFiP3vzas6ez9u-snfCuXzb1eL6_aZwAfrb+561sq8V19PT4Eg@mail.gmail.com>
 <CA+OCxoy-8RyH-QYxXkLn1KSTUJMArev0ukKpfJx+yvATEyJV+Q@mail.gmail.com>
 <CAFiP3vz6_Up4OfSAR4J8C35EzgdApbAiZCeZzzCKxnjwgJMdYQ@mail.gmail.com>
 <CAGRPzo_KmDF=ThGC9hy6JepsxBn23nuXkamJBQgT6eOFh0p1pg@mail.gmail.com>
 <CAFiP3vwYLTLXX5EFPzE_s-0ucQikDERp_iS+4Neb1JN-sHfG9A@mail.gmail.com>
 <CAFiP3vxvFMHv=yEOXcbxi9YABtTwOk3Feci92YMA4_9Fcp-4mA@mail.gmail.com>
 <CAFiP3vzj2HBjau+N5TN+Asb_7DW6zgmPrzJf0rmd_H0NJ3Sttg@mail.gmail.com>
 <CAE+jjamhZ27XJ2ZHGRgpsL0yUUOawDhiMXoxfB-bRCu=M8RBhg@mail.gmail.com>
 <CAFiP3vw=rGTY1BFPB2ZLjLBehEaPpXgXRY2SerK+07TrA+nxzA@mail.gmail.com>
 <CA+OCxozQj0gy7dsorij5fXSgLuhGDJP7uC4++VviAPR1XFs-Fw@mail.gmail.com>
 <CAFiP3vyjbmQN2bRpHJvNXFnK6YvtgPm12OiF_Oa2Z7J73=C3Ag@mail.gmail.com>
 <CAFiP3vzomo+37TZ87tVr4AsmUNzzsFQkq8j8fEXNKdpVj9bOxw@mail.gmail.com>
 <CAFiP3vz1EGT4cgv3XJNT6wLDz0Ca7dT_W0p6GsDVPua+tWZrpw@mail.gmail.com>
 <CA+OCxoxyAD1x_bEhzPS0RGU1SuL8Lfhx39ME7wY=L28ep4PdvQ@mail.gmail.com>
 <CAG7mmoxASRd2wTahma6WNLCLfg=4gy5eOQ+e5K0ioOHPUS+7bA@mail.gmail.com>
 <CAE29nRn0Z7v4oOWWndLr1Cr8HRwHizBK3+7BK12KnT0uHHHi7Q@mail.gmail.com>
 <CAFiP3vxEra_mZGc8ZMJ+zNOpNb+LRGT7LobYktFgTetVMktmsw@mail.gmail.com>
 <CA+OCxoz=hJpzbca9kwMesf+K2axYLaa_s7bThmnQh2WQHL0SmQ@mail.gmail.com>
 <CAFiP3vzQQ8MxzSGuYcOPR9cDRRdz06LuLuGKo3cnTWXNcgFrew@mail.gmail.com>
 <CA+OCxoy=+A0xE2gaFTH0VkAF-f4dpkW4nvF8sLd7Guag3czorA@mail.gmail.com>
 <CAFiP3vy3rUMT+t6FBoNZftWf1ATth09t6+_GW_+qiBvsfFr4FQ@mail.gmail.com>
 <CA+OCxox=8+nnQOAARWVRaxvBYBAG1sFyV1fWT-whPhdqVoJMmQ@mail.gmail.com>
 <CAFiP3vwqO-0CtAvzu4SYa_UCj9-xbgLyauSy7agDc5ss10+LJg@mail.gmail.com>
 <CA+OCxoxZzWEUj49+OYYdSJiiqMa-4HD9OZN7BFiM4X8_Ws9FtA@mail.gmail.com>
 <CA+OCxowu1z=wKO=8=dw-xZCfHeegCxnMKS=O_fRae8OhY6k1uQ@mail.gmail.com>
 <CAFiP3vzOStcTxWrqnCJNCjqAN+xBNLAa3vhGeDozzHT+wnxUAg@mail.gmail.com>
 <CA+OCxoxiELAZxek49=MM-nUOka1rJpQ60B+y-qN+xHbZ8iDvzQ@mail.gmail.com>
 <CAFiP3vzYYWya1C91m348_KfbUnMjtU6X60jzXjAi1stAYdRnAQ@mail.gmail.com>
 <CAFiP3vxmgT_3a7_1C51XoS0a0tJ_M=T+B=bngzgNX3+9Fb_Vpw@mail.gmail.com>
 <CA+OCxoycFy83wwn8g=oRXcBo-XAzLR8BjmVHC=iO6azckAKjxA@mail.gmail.com>
 <CAFOhELdBhBRzcVNcCE-3TBpdh4nuLARLPv6V0eE6zm2aNNH4zQ@mail.gmail.com>
 <CAAtBm9UHd0K3y4DQMvmisy6xMKzyE_kEgEc+5kwn5jKT0kt6SA@mail.gmail.com>
 <CAE+jjakQjs7i2=-6fUQeji8i7qUz3x0e1NSgsbanvzPxD-uzYg@mail.gmail.com>
From: Robert Eckhardt <reckhardt@pivotal.io>
Date: Tue, 27 Jun 2017 17:18:29 -0400
Message-ID: 
 <CAAtBm9W5uMhhC9TSVAf2g=9hDuM60709bMd3jsF4EDzZ_Z9zwQ@mail.gmail.com>
Subject: Re: [pgadmin-hackers] Re: Server side cursor limitations for on
 demand loading of data in query tool [RM2137] [pgAdmin4]
To: Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 Dave Page <dpage@pgadmin.org>,
	Ashesh Vashi <ashesh.vashi@enterprisedb.com>,
	Harshal Dhumal <harshal.dhumal@enterprisedb.com>,
 Shirley Wang <swang@pivotal.io>
Content-Type: multipart/alternative; boundary="f403043663cee755f40552f79bcd"
Precedence: bulk

--f403043663cee755f40552f79bcd
Content-Type: text/plain; charset="UTF-8"

On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hello Hackers,
>
> When we started the app we noticed some change in the front end.
>
> The line numbers in the Editor:
> - We noticed a bug with the numbers where at 10000 rows, the numbers would
> be cut off.
> - When the row is selected the color of the text should be white
> - Centering the number column would differentiate it from the rest of the
> table and prevent any confusion
>
>
Do we want line numbers? I'm of mixed opinion. On the one hand it implies
and ordered set of results when Postgres inherently doesn't order results.
On the other hand it nicely tells you where you are in the results set if
you are scrolling around.

-- Rob

--f403043663cee755f40552f79bcd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira <span di=
r=3D"ltr">&lt;<a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_bl=
ank">jdealmeidapereira@pivotal.io</a>&gt;</span> wrote:<br><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex"><div dir=3D"ltr">Hello Hackers,<div><br></div><div>When we s=
tarted the app we noticed some change in the front end.</div><div><br></div=
><div>The line numbers in the Editor:=C2=A0</div><div>- We noticed a bug wi=
th the numbers where at 10000 rows, the numbers would be cut off.</div><div=
>- When the row is selected the color of the text should be white=C2=A0</di=
v><div>- Centering the number column would differentiate it from the rest o=
f the table and prevent any confusion</div><div><br></div></div></blockquot=
e><div><br></div><div>Do we want line numbers? I&#39;m of mixed opinion. On=
 the one hand it implies and ordered set of results when Postgres inherentl=
y doesn&#39;t order results. On the other hand it nicely tells you where yo=
u are in the results set if you are scrolling around.=C2=A0</div><div><br><=
/div><div>-- Rob</div><div>=C2=A0</div></div></div></div>

--f403043663cee755f40552f79bcd--