MIME-Version: 1.0
References: 
 <CABUevEyMFa0ti59E0CkZfcNDdo6tgtX4PZcXqrK54KzKFfVCBA@mail.gmail.com>
 <CAFOhELcBwMpJ1dUM_XMoA3VSiAz8kBi2h1HXP=OycJ1WkxYx1Q@mail.gmail.com>
In-Reply-To: 
 <CAFOhELcBwMpJ1dUM_XMoA3VSiAz8kBi2h1HXP=OycJ1WkxYx1Q@mail.gmail.com>
From: Magnus Hagander <magnus@hagander.net>
Date: Tue, 12 Jan 2021 20:50:40 +0100
Message-ID: 
 <CABUevEw2Y20sJcQ0r7s6Gi72jsVJaKWitsm3yRkF5Phmfu61pg@mail.gmail.com>
Subject: Re: Somewhat excessive version checks
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 12, 2021 at 5:59 AM Khushboo Vashi
<khushboo.vashi@enterprisedb.com> wrote:
>
>
>
> On Tue, Jan 12, 2021 at 3:36 AM Magnus Hagander <magnus@hagander.net> wrote:
>>
>> Hi!
>>
>> If I read the code correctly, pgadmin will (unless turned off) hit the
>> website to check the version.json file for updates *every time it
>> starts*.
>>
>> Wouldn't it make sense to rate limit that to checking say once per 24
>> hours maximum? Or even 48?
>>
>> It seems nobody needs the update *that* quickly, and AFAICT it does
>> call out to make that check synchronously on startup which means the
>> user is waiting.
>>
> Agreed, we should have some mechanism in place to limit the server hit, maybe an asynchronous call from the client while loading.


Seems async front he server would be a better choice there, if you
have some ways for that? Otherwise, how to determine which user to
trust when storing the result etc?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/