Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aMNTm-0003K2-FD for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2016 22:13:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aMNTl-00080i-72 for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2016 22:13:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aMNTk-00080Y-Mt for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2016 22:13:20 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aMNTg-0002ln-SV for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2016 22:13:20 +0000 Received: by mail-wm0-x22e.google.com with SMTP id n5so103368057wmn.0 for ; Thu, 21 Jan 2016 14:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Xeh2Gp0Zqy3i41rJFpniBJKs2utQaws9lniXpoz9l34=; b=Kk97jBdR5BFi2FfQlFIibMy7c2Z/SFY2S0u0qQ+SAZIzUTcCtj5Rp2IRY4vlT8UY0U rY4wfX0P7/BCo7+4YinlvRz/YEkjVr9pP8ZhQgkals9V79xOFBHpkWWDCGiTlhuY+u8j P3VahpGGR/difbHkx3KNG/gaP3VdxoCoSMmOcTQFsCNdRmqqSslMu7O6MNVI8FLYMoN4 LwYflRa+WHxm+ehUt4ErwhwiwZJ74ZUS6l98rc7jLFfKKVI7qg/GkwL/r20cNyNZu7sS 0olEkXY7KSzLigVUJkoVKzkgPp8ImXQnMPE+6x5yzkrJOtLpU+rxL1vWIPYTKJOdC12w AM1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Xeh2Gp0Zqy3i41rJFpniBJKs2utQaws9lniXpoz9l34=; b=Qz0P4DHp73TRhA+C/jdYxL8PNEt4+0uSOAUoofXOrH/+3B7MQG3XJhqCyRdSpYaekd L9GG2hW8sNvRekVfdyMf9Pcc5D65PY5T2auFauHDV70do+gByjAEx12Q/J8PR9mDfOa7 Mqr9QBRXjMmbLqdUWWsnTUltGqF4OW/yUnDaH0DrUrfo1snbKNBLkEIiO92c/cjlo/FW vjxcCYUwouFSpsH92WJvdJxjuQOLOM3c/Fg1+X+EOIZTmLgDbuiVsPijO2CWKqKopkoT lG6tgcyZIsAnPj3HVQz80qp6COVe5L/EPKcQQM7EkpTEVdBkwEHvWSgzUhxBlvCPngZB APQg== X-Gm-Message-State: AG10YOQt9OlocNBVD4DJDI/1MJVF5Wox1K55j2mytkg9DBljOc6z8mwIeeMOJ/6TFoPUPsIBnn8eTqpxgBTZ1g== MIME-Version: 1.0 X-Received: by 10.28.32.206 with SMTP id g197mr48787wmg.28.1453414396132; Thu, 21 Jan 2016 14:13:16 -0800 (PST) Received: by 10.194.41.135 with HTTP; Thu, 21 Jan 2016 14:13:16 -0800 (PST) In-Reply-To: References: <569C4395.4080603@wars-nicht.de> <569EBEA2.5040903@wars-nicht.de> Date: Thu, 21 Jan 2016 23:13:16 +0100 Message-ID: Subject: Re: Remove "unsupported version" warning for Greenplum From: Magnus Hagander To: Dave Page Cc: "Andreas 'ads' Scherbaum" , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113d7d68cb1dd60529df6814 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113d7d68cb1dd60529df6814 Content-Type: text/plain; charset=UTF-8 On Thu, Jan 21, 2016 at 10:31 AM, Dave Page wrote: > On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum > wrote: > > On 19.01.2016 16:03, Dave Page wrote: > >> > >> > >> Your patch won't apply again. I have no idea why - I'm trying to do it > >> on my Mac, which is a *nix under the hood (they don't use Mac line > >> endings any more - that was the old Mac OS 9 and earlier from a decade > >> or so ago iirc). How are you creating them? The normal way is to do > >> something like: > > > > > > And how does the attached work? Fresh clone again, only difference is a > > warning (not an error) for whitespaces removed. > > Still doesn't apply. I tried on the following systems: > > Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61) > Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1 > CentOS release 6.7 (Final) - git version 1.7.1 > > I'm fairly convinced at this stage that there's something funky on > your system. Perhaps we should take a look next week when we're both > in Brussels? > > Tried off a fresh clone of HEAD and it works perfectly: mha@mha-laptop:~/postgresql/pgadmin3$ patch -p1 < /tmp/gp-warning2.diff (Stripping trailing CRs from patch; use --binary to disable.) patching file pgadmin/schema/pgServer.cpp git 2.1.4 on Debian Jessie Dave - have you tried off a completely clean checkout as well? In case some metadata has gotten screwed? The settings that you have that I don't (so they're not the ones you get by default) are: [core] ignorecase = true precomposeunicode = true I wonder if it's the unicode one.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ --001a113d7d68cb1dd60529df6814 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On T= hu, Jan 21, 2016 at 10:31 AM, Dave Page <dpage@pgadmin.org> = wrote:
On Tue, Jan 19, 2016 at 10:54 P= M, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> = wrote:
> On 19.01.2016 16:03, Dave Page wrote:
>>
>>
>> Your patch won't apply again. I have no idea why - I'm try= ing to do it
>> on my Mac, which is a *nix under the hood (they don't use Mac = line
>> endings any more - that was the old Mac OS 9 and earlier from a de= cade
>> or so ago iirc). How are you creating them? The normal way is to d= o
>> something like:
>
>
> And how does the attached work? Fresh clone again, only difference is = a
> warning (not an error) for whitespaces removed.

Still doesn't apply. I tried on the following systems:

Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
CentOS release 6.7 (Final) - git version 1.7.1

I'm fairly convinced at this stage that there's something funky on<= br> your system. Perhaps we should take a look next week when we're both in Brussels?


Tried off a fresh clone of HEAD and it works perfectly:
<= br>
mha@mha-laptop:~/postgresql/pgadmin3$ patch -p1 < /tmp/gp-= warning2.diff=C2=A0
(Stripping trailing CRs from patch; use --bin= ary to disable.)
patching file pgadmin/schema/pgServer.cpp
<= div>
git 2.1.4 on Debian Jessie

Dave= - have you tried off a completely clean checkout as well? In case some met= adata has gotten screwed?
=C2=A0
The settings that = you have that I don't (so they're not the ones you get by default) = are:

[core]
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 ignorecase =3D true
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 precomposeunic= ode =3D true

<= br>
I wonder if it's = the unicode one..


-- <= br>
=C2=A0Magnus Hagander
=C2=A0Me: http://www.hagander.net/
=C2=A0Work: http://www.redpill-linpro.com/
--001a113d7d68cb1dd60529df6814--