Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aMO8G-0005Cr-6G for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2016 22:55:12 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aMO8F-0005ym-Jo for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2016 22:55:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aMO81-0005iD-Ka for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2016 22:54:57 +0000 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aMO7y-0002gh-1K for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2016 22:54:55 +0000 Received: by mail-wm0-x22f.google.com with SMTP id 123so193376818wmz.0 for ; Thu, 21 Jan 2016 14:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ylJIXh+nbzjdZqpaes41fFvf+ungnF50lOsPHaLoMaM=; b=ONcx0bGXvGzdjzAhnj9CXmhhe63hWjQZaDmBrbsHOw/fHk2YOnDXo9H9DmwYF0tkDy sEdHHEfKv9ZSjgeOKeDFx6Jp42+FKXzT5fgIO9S2ivzi964NVOsmUnVkbI8kfD/3a5bQ HNYV19I+qu18fMYuyx2h6sqAujBY6ne+d7mMpd+19kwjyUvVeoE7hXk2kFg3sVKr8FUX dlr8my3QlAb8dJLFjlAmhGJwm84D7TSyz2D1kz6+/bp8/x0jVwv3vLRjAZI70TAFz7KB wcHtPYhq+tJcwNJ/YWqXRY1CPZVugBgZtWXcKuNXbXhJ9MCbr+9VjltDl30K46ASrdb2 YZ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ylJIXh+nbzjdZqpaes41fFvf+ungnF50lOsPHaLoMaM=; b=Q2J9qTfmMjCgDMoZAsm9OSnkrmQ8W687umYtJVTvcr+EkH8LqB4pwJGfDjFx2+iyID uN+8TCcgUlOeWL8I4/U+yJxcP+98qHdVnVYjeb3dstxvtTvX6zqL8VvXuTx0Ph16QCk1 Mz+kjkyV9/m/QK8BkbASTG9RoOF3ZUdlQPFqgw3xnekfpeg76ecw/+gj3hdip+0vgspc VzqP/3/CDYuX40gX5IribHpuyVdKr4ZfCjRvE3/BWbIPIYvXlKm0HCdkdoa373CIDlQB wnMNpzVwwVFXSHVkwXpYXDD/OQpVU/3kEGAw5B22Djj/gzi9uv3g1JLtBqq0rpgXKfbJ ZCgw== X-Gm-Message-State: AG10YOTROqvNzIcmiW6kDxCxyjYxtLiuOiM3JCNUmL9OqYeWN8Vl0OodfMEqy8kDhCRttCfuaL/jceW74rDUjA== MIME-Version: 1.0 X-Received: by 10.28.54.65 with SMTP id d62mr132163wma.35.1453416892312; Thu, 21 Jan 2016 14:54:52 -0800 (PST) Received: by 10.194.41.135 with HTTP; Thu, 21 Jan 2016 14:54:52 -0800 (PST) In-Reply-To: <56A15D3F.4030207@wars-nicht.de> References: <569C4395.4080603@wars-nicht.de> <569EBEA2.5040903@wars-nicht.de> <56A15D3F.4030207@wars-nicht.de> Date: Thu, 21 Jan 2016 23:54:52 +0100 Message-ID: Subject: Re: Remove "unsupported version" warning for Greenplum From: Magnus Hagander To: "Andreas 'ads' Scherbaum" Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1143667e93c6440529dffdd3 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143667e93c6440529dffdd3 Content-Type: text/plain; charset=UTF-8 On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum < adsmail@wars-nicht.de> wrote: > On 21.01.2016 10:31, Dave Page wrote: > >> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum >> wrote: >> >>> On 19.01.2016 16:03, Dave Page wrote: >>> >>>> >>>> >>>> Your patch won't apply again. I have no idea why - I'm trying to do it >>>> on my Mac, which is a *nix under the hood (they don't use Mac line >>>> endings any more - that was the old Mac OS 9 and earlier from a decade >>>> or so ago iirc). How are you creating them? The normal way is to do >>>> something like: >>>> >>> >>> >>> And how does the attached work? Fresh clone again, only difference is a >>> warning (not an error) for whitespaces removed. >>> >> >> Still doesn't apply. I tried on the following systems: >> >> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61) >> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1 >> CentOS release 6.7 (Final) - git version 1.7.1 >> >> I'm fairly convinced at this stage that there's something funky on >> your system. Perhaps we should take a look next week when we're both >> in Brussels? >> >> > After debugging back and forth with Magnus, it looks like that Google Mail > is fooling you. Your downloaded file has a different line ending, and your > file is 3269 bytes, where the original file is 3210 bytes. That's 59 > additional line breaks. > > 4fa0990a1020e425fe95b99ea9f186de gp-warning2.diff > > The file you download from the archive: > > http://www.postgresql.org/message-id/569EBEA2.5040903@wars-nicht.de > > is also correct. It's also worth noticing that "patch" has no problem with either of the two files, but "git apply" does. At least on my system. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ --001a1143667e93c6440529dffdd3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum <adsmail@wars-nicht.de> wrote:
On 21.01.2016 10:31, Dave Page wrote:
On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum
<adsmail@wars= -nicht.de> wrote:
On 19.01.2016 16:03, Dave Page wrote:


Your patch won't apply again. I have no idea why - I'm trying to do= it
on my Mac, which is a *nix under the hood (they don't use Mac line
endings any more - that was the old Mac OS 9 and earlier from a decade
or so ago iirc). How are you creating them? The normal way is to do
something like:


And how does the attached work? Fresh clone again, only difference is a
warning (not an error) for whitespaces removed.

Still doesn't apply. I tried on the following systems:

Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
CentOS release 6.7 (Final) - git version 1.7.1

I'm fairly convinced at this stage that there's something funky on<= br> your system. Perhaps we should take a look next week when we're both in Brussels?


 After debugging back and forth with Magnus, it looks like that Google Mail = is fooling you. Your downloaded file has a different line ending, and your = file is 3269 bytes, where the original file is 3210 bytes. That's 59 ad= ditional line breaks.

4fa0990a1020e425fe95b99ea9f186de=C2=A0 gp-warning2.diff

The file you download from the archive:

http://www.postgresql.org/message= -id/569EBEA2.5040903@wars-nicht.de

is also correct.

It's also worth notici= ng that "patch" has no problem with either of the two files, but = "git apply" does. At least on my system.
=C2=A0
--
=C2=A0Magnus Hagander
=C2=A0Me= : http://www.hagande= r.net/
=C2=A0Work: http://www.redpill-linpro.com/
--001a1143667e93c6440529dffdd3--