Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aMNfq-0003vV-1S for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2016 22:25:50 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aMNfp-0006vE-G0 for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jan 2016 22:25:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aMNfo-0006v7-UA for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2016 22:25:49 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aMNfl-000222-MG for pgadmin-hackers@postgresql.org; Thu, 21 Jan 2016 22:25:47 +0000 Received: by mail-wm0-x22e.google.com with SMTP id b14so103791975wmb.1 for ; Thu, 21 Jan 2016 14:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=J5wJ9VAWz2Gtpg7iSoWCN9mK8C3nkT1NC1oZj/o2TUI=; b=eDfC9XzoPtEPJN/bd84avdQ65EgoJ4D8to/uUoYICSTrACAaJhMvIpDZmCFhwW2SE2 Q6iwlmPjZZippDUumb6WHb5Smmr6TuTLRagTeFTMx01MjJofSO2aS6RZ7myPmh6gGxVT FZwqfYS3GW+3UlfaNpuhck2IBXuxGzVZPLcSwmxvLJCR2FTgkf+uPDzq/rZXg9eTXdjN Lc0ejdbHlUMiLu76a/RdoDKOYkJk6yDCblMCVd15Av1CRXWKZystTk/5Bm9wYj3/lAKi LIaIqmKzH8r2ChFECAjJ1SneX4Xn4+G1R7lgkqWNUqbYlcvgJygFhulMm/kqk2X3vVmD LvOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=J5wJ9VAWz2Gtpg7iSoWCN9mK8C3nkT1NC1oZj/o2TUI=; b=d25yvGqtFPAPAhg37ketZGRC2d7iizFoa1aN2sJZFd2wIyHl8OlxxZdIyG4K6wBzZU 2wBYnWcksBUxw1RizK+/K5hf/x1ZstNrj5jPGDvO1us/aLLamZFPtr/zKmqcmDLo8kAW 2kxdlig9lq3mGdm2ollWpIdOMWH9iK8gKTgIK+Ut01bGn7MVyLr/1QZ8JfoDWj+7qREk R3u/fXnk8Ac0S5eyXGjiFW3OyieMXfyPq3fggtXe/BronEODnh7MJqzAVC+Qps3aoPHG LsESOgvfl/PNgIGlu/+csFKert+HJR9DBQciW/Kc0vFLUS0BS7DdRS/uRRI7AnHkldW5 ccmQ== X-Gm-Message-State: AG10YOQcbZvPrjLNhcTe0VUjL1i4aF2KplgLK2IQInm4TGHb0z9/Y588ErCUvmmhXMLJD6r7THuaFkzpSYcwbQ== MIME-Version: 1.0 X-Received: by 10.28.223.67 with SMTP id w64mr83852wmg.28.1453415143135; Thu, 21 Jan 2016 14:25:43 -0800 (PST) Received: by 10.194.41.135 with HTTP; Thu, 21 Jan 2016 14:25:43 -0800 (PST) In-Reply-To: References: <569C4395.4080603@wars-nicht.de> <569EBEA2.5040903@wars-nicht.de> Date: Thu, 21 Jan 2016 23:25:43 +0100 Message-ID: Subject: Re: Remove "unsupported version" warning for Greenplum From: Magnus Hagander To: Dave Page Cc: "Andreas 'ads' Scherbaum" , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114a0f6c51773c0529df9594 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114a0f6c51773c0529df9594 Content-Type: text/plain; charset=UTF-8 On Thu, Jan 21, 2016 at 11:13 PM, Magnus Hagander wrote: > On Thu, Jan 21, 2016 at 10:31 AM, Dave Page wrote: > >> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum >> wrote: >> > On 19.01.2016 16:03, Dave Page wrote: >> >> >> >> >> >> Your patch won't apply again. I have no idea why - I'm trying to do it >> >> on my Mac, which is a *nix under the hood (they don't use Mac line >> >> endings any more - that was the old Mac OS 9 and earlier from a decade >> >> or so ago iirc). How are you creating them? The normal way is to do >> >> something like: >> > >> > >> > And how does the attached work? Fresh clone again, only difference is a >> > warning (not an error) for whitespaces removed. >> >> Still doesn't apply. I tried on the following systems: >> >> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61) >> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1 >> CentOS release 6.7 (Final) - git version 1.7.1 >> >> I'm fairly convinced at this stage that there's something funky on >> your system. Perhaps we should take a look next week when we're both >> in Brussels? >> >> > Tried off a fresh clone of HEAD and it works perfectly: > > mha@mha-laptop:~/postgresql/pgadmin3$ patch -p1 < /tmp/gp-warning2.diff > (Stripping trailing CRs from patch; use --binary to disable.) > patching file pgadmin/schema/pgServer.cpp > > git 2.1.4 on Debian Jessie > Actually, since I'm using patch to apply it, the relevant version is probably: $ patch --version GNU patch 2.7.5 Copyright (C) 2003, 2009-2012 Free Software Foundation, Inc. Copyright (C) 1988 Larry Wall -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ --001a114a0f6c51773c0529df9594 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Thu, Jan 21, 2016 at 11:13 PM, Magnus Hagander <= ;magnus@hagander.n= et> wrote:
On Thu, Jan 21, 2= 016 at 10:31 AM, Dave Page <dpage@pgadmin.org> wrote:
On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads'= Scherbaum
<adsmail@wars= -nicht.de> wrote:
> On 19.01.2016 16:03, Dave Page wrote:
>>
>>
>> Your patch won't apply again. I have no idea why - I'm try= ing to do it
>> on my Mac, which is a *nix under the hood (they don't use Mac = line
>> endings any more - that was the old Mac OS 9 and earlier from a de= cade
>> or so ago iirc). How are you creating them? The normal way is to d= o
>> something like:
>
>
> And how does the attached work? Fresh clone again, only difference is = a
> warning (not an error) for whitespaces removed.

Still doesn't apply. I tried on the following systems:

Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
CentOS release 6.7 (Final) - git version 1.7.1

I'm fairly convinced at this stage that there's something funky on<= br> your system. Perhaps we should take a look next week when we're both in Brussels?


Tried off= a fresh clone of HEAD and it works perfectly:

mha= @mha-laptop:~/postgresql/pgadmin3$ patch -p1 < /tmp/gp-warning2.diff=C2= =A0
(Stripping trailing CRs from patch; use --binary to disable.)=
patching file pgadmin/schema/pgServer.cpp

git 2.1.4 on Debian Jessie

Actually, since I'm using patch to apply it, the relevant versio= n is probably:
$= patch --version
GNU patch 2.7.5
Copyright (C) 2003, 2009-2012 Free Software Foundatio= n, Inc.
Copyright (C) 1988 Larry Wall
=


--
=C2=A0M= agnus Hagander
=C2=A0Me: http://www.hagander.net/
=C2=A0Work: http://www.redpill-linpro.com/
--001a114a0f6c51773c0529df9594--