public inbox for [email protected]
help / color / mirror / Atom feedFrom: Magnus Hagander <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Somewhat excessive version checks
Date: Mon, 11 Jan 2021 23:05:44 +0100
Message-ID: <CABUevEyMFa0ti59E0CkZfcNDdo6tgtX4PZcXqrK54KzKFfVCBA@mail.gmail.com> (raw)
Hi!
If I read the code correctly, pgadmin will (unless turned off) hit the
website to check the version.json file for updates *every time it
starts*.
Wouldn't it make sense to rate limit that to checking say once per 24
hours maximum? Or even 48?
It seems nobody needs the update *that* quickly, and AFAICT it does
call out to make that check synchronously on startup which means the
user is waiting.
And if/when doing that, it would be useful to include an
If-Modified-Since header on the request, so the server can just
respond with a tiny 304 reply when there is no update, which is going
to be the majority of the time. Or possibly even more efficiently,
create a custom etag and use If-None-Matches. If you make that etag be
say the version that the client has, it becomes very cheap to check
and you don't need to track any extra data.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Somewhat excessive version checks
In-Reply-To: <CABUevEyMFa0ti59E0CkZfcNDdo6tgtX4PZcXqrK54KzKFfVCBA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox