Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aMYTP-0006gp-Os for pgadmin-hackers@arkaria.postgresql.org; Fri, 22 Jan 2016 09:57:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aMYTP-0001gW-BY for pgadmin-hackers@arkaria.postgresql.org; Fri, 22 Jan 2016 09:57:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aMYTB-0001BI-3i for pgadmin-hackers@postgresql.org; Fri, 22 Jan 2016 09:57:29 +0000 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aMYT7-0007wR-Vk for pgadmin-hackers@postgresql.org; Fri, 22 Jan 2016 09:57:27 +0000 Received: by mail-wm0-x235.google.com with SMTP id 123so7946792wmz.0 for ; Fri, 22 Jan 2016 01:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hagander-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=N6W792OuxxIBpyJfHklxgPSqfB7uju4fekDiy5uqq6U=; b=mfeN996DpQVoNbeaK/gxrW5d7+yTBWPZZASHSAAE1f0SBYrybZx9aZ7T2UNixpuOmO gUPEJqxqRmRF/VtrOBYA1MgLpQBNNPXL5D314J6drhx17MZZE6v2Zvl6hSwXoprmZlzf IJKK3mikOWaEoACUgyeF3fGtJ25W1RQox47wkWNtP9kwWqYls0RtbakhW97T5YXmTUvY czQGoxAWwigSRbMoKB4yMR5wICUb1kUi7iwYNVgZ4+qA7cvvhZ7JuYNTywswCIX3wHUk eoTyqmKJSj2AJ+9hQLTbzIa4e1S4dFdAgKMvVly7/Kw+7anfD3dwBzWnhb0Lg5wrmwgF 8ajw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=N6W792OuxxIBpyJfHklxgPSqfB7uju4fekDiy5uqq6U=; b=NWXnKxNTk9cwES78ZecYYtf3OI6bkkjjl4eld/Kp1uwd8EmaeO13jvUYJPjVO5ifgL nNEqQWDTqx6XVZZc2nqnipBJizIGUKqFwbAaoavhhbbKHXJsnRwDzLl0hyrmz35s/uYG YBm8f1mcl4bODzXyBAUe3EH5Euad4oR4vxoO2lHpnW8pVyAdL6Qka9fdly2JTVxRnQJ0 q9j0TAw7msu27WVyHQJCDBzwoTaIuFOYf7JfECA0OWRJb4R/ax0WQrp97gkZXiPI99ZZ h1mhB4KWBt4xQ9204SFlQZEgdYLLE2/v+C7DoJ7X7ulpGP6FJfUppeT/pRIPhWVQUyqN Ss8A== X-Gm-Message-State: AG10YOQXrVrrw44Bpp4KvUv8t3CmDIQOI2IOLhSdBrFeoZ6n7vO4roeGRCoHwPX9hBUkMT/dXmHH2dL5igMlZw== MIME-Version: 1.0 X-Received: by 10.28.99.69 with SMTP id x66mr2609733wmb.10.1453456644236; Fri, 22 Jan 2016 01:57:24 -0800 (PST) Received: by 10.194.41.135 with HTTP; Fri, 22 Jan 2016 01:57:24 -0800 (PST) In-Reply-To: References: <569C4395.4080603@wars-nicht.de> <569EBEA2.5040903@wars-nicht.de> <56A15D3F.4030207@wars-nicht.de> Date: Fri, 22 Jan 2016 10:57:24 +0100 Message-ID: Subject: Re: Remove "unsupported version" warning for Greenplum From: Magnus Hagander To: Dave Page Cc: "Andreas 'ads' Scherbaum" , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1148f7aafa0a880529e93e9e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1148f7aafa0a880529e93e9e Content-Type: text/plain; charset=UTF-8 On Fri, Jan 22, 2016 at 10:43 AM, Dave Page wrote: > On Thu, Jan 21, 2016 at 10:54 PM, Magnus Hagander > wrote: > > > > > > On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum > > wrote: > >> > >> On 21.01.2016 10:31, Dave Page wrote: > >>> > >>> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum > >>> wrote: > >>>> > >>>> On 19.01.2016 16:03, Dave Page wrote: > >>>>> > >>>>> > >>>>> > >>>>> Your patch won't apply again. I have no idea why - I'm trying to do > it > >>>>> on my Mac, which is a *nix under the hood (they don't use Mac line > >>>>> endings any more - that was the old Mac OS 9 and earlier from a > decade > >>>>> or so ago iirc). How are you creating them? The normal way is to do > >>>>> something like: > >>>> > >>>> > >>>> > >>>> And how does the attached work? Fresh clone again, only difference is > a > >>>> warning (not an error) for whitespaces removed. > >>> > >>> > >>> Still doesn't apply. I tried on the following systems: > >>> > >>> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61) > >>> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1 > >>> CentOS release 6.7 (Final) - git version 1.7.1 > >>> > >>> I'm fairly convinced at this stage that there's something funky on > >>> your system. Perhaps we should take a look next week when we're both > >>> in Brussels? > >>> > >> > >> After debugging back and forth with Magnus, it looks like that Google > Mail > >> is fooling you. Your downloaded file has a different line ending, and > your > >> file is 3269 bytes, where the original file is 3210 bytes. That's 59 > >> additional line breaks. > >> > >> 4fa0990a1020e425fe95b99ea9f186de gp-warning2.diff > >> > >> The file you download from the archive: > >> > >> http://www.postgresql.org/message-id/569EBEA2.5040903@wars-nicht.de > >> > >> is also correct. > > Well that's weird. But why is it only happening with your patches? I > apply patches from others constantly without issues. > What MIME types do you get those in typically? Could be that gmail is reacting to it being text/x-patch and not application/x-patch or something? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ --001a1148f7aafa0a880529e93e9e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Fri, Jan 22, 2016 at 10:43 AM, Dave Page <dpage@pgadmin.org>= wrote:
On Thu, Jan 21, 2016 at 10:54 PM, Magnus Hagander <magnus@hagander.net> wrote:
>
>
> On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum
> <adsmail@wars-nicht.de= > wrote:
>>
>> On 21.01.2016 10:31, Dave Page wrote:
>>>
>>> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherb= aum
>>> <adsmail@wars-nich= t.de> wrote:
>>>>
>>>> On 19.01.2016 16:03, Dave Page wrote:
>>>>>
>>>>>
>>>>>
>>>>> Your patch won't apply again. I have no idea why -= I'm trying to do it
>>>>> on my Mac, which is a *nix under the hood (they don= 9;t use Mac line
>>>>> endings any more - that was the old Mac OS 9 and earli= er from a decade
>>>>> or so ago iirc). How are you creating them? The normal= way is to do
>>>>> something like:
>>>>
>>>>
>>>>
>>>> And how does the attached work? Fresh clone again, only di= fference is a
>>>> warning (not an error) for whitespaces removed.
>>>
>>>
>>> Still doesn't apply. I tried on the following systems:
>>>
>>> Mac OS X 10.11.1 - git version 2.5.4 (Apple Git-61)
>>> Windows 7 Enterprise SP1 - git version 1.8.1.msysgit.1
>>> CentOS release 6.7 (Final) - git version 1.7.1
>>>
>>> I'm fairly convinced at this stage that there's someth= ing funky on
>>> your system. Perhaps we should take a look next week when we&#= 39;re both
>>> in Brussels?
>>>
>>
>> After debugging back and forth with Magnus, it looks like that Goo= gle Mail
>> is fooling you. Your downloaded file has a different line ending, = and your
>> file is 3269 bytes, where the original file is 3210 bytes. That= 9;s 59
>> additional line breaks.
>>
>> 4fa0990a1020e425fe95b99ea9f186de=C2=A0 gp-warning2.diff
>>
>> The file you download from the archive:
>>
>> http://www.postgresql.or= g/message-id/569EBEA2.5040903@wars-nicht.de
>>
>> is also correct.

Well that's weird. But why is it only happening with your p= atches? I
apply patches from others constantly without issues.
<= br>
What MIME types do you get those in typically? Could be that = gmail is reacting to it being text/x-patch and not application/x-patch or s= omething?


--
=C2=A0Magnus Hagander
=C2=A0Me: http://www.hagander.net/
=C2=A0Work: http://www.redpi= ll-linpro.com/
--001a1148f7aafa0a880529e93e9e--