Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAcIl-000366-Dm for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Aug 2021 18:04:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mAcIk-000334-D4 for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Aug 2021 18:04:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mATIM-0007ab-2k for pgadmin-hackers@lists.postgresql.org; Mon, 02 Aug 2021 08:27:34 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mATII-0005a3-DY for pgadmin-hackers@postgresql.org; Mon, 02 Aug 2021 08:27:33 +0000 Received: by mail-ed1-x52a.google.com with SMTP id g21so4079033edb.4 for ; Mon, 02 Aug 2021 01:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bJcZvDomd0byVFg+4mkh3g2szAhOErvchE+OhuDOB2k=; b=Vd7yT4/EmtBuADS7OhVIcF8YGNQrAYj6F09pUefgFhvEYD/+J5U5uTapDGTpsiipHj em9GBsT///peApFno4Ct7SzvrVMXCTZ7Idk7nBRY3Eoo/gbikKKTxArBTjxQgu6AN6Ho J1stMjCoCK/i87EpL2e9/Cuy8md/p0X6vPrUORodedn8yQFvKDMNFkYKg7p0VaWsWSjX OOpLSenUKFFBn5/my+atoOFhab2kIMVAEAZrr9FLyVyLF/XU4aB6nSC4T3z3Ws4BWGYF oQukBrrj3brqc2pFkm2BKh+rqBEiOllBw4m9RBiY3sCbvr0dGyLBnwUnN1q3cTglfgtE EYiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bJcZvDomd0byVFg+4mkh3g2szAhOErvchE+OhuDOB2k=; b=OyakUpcudbbWwOzXDdt9Q91IfvLMEUcuT7qjJHXElZN7kVKnZ/dynAZTcdyDJ07+Xf u5aP8/0p0sHJZrwS5Xk47/X7mk7gSjSw6HDusRWRebDq56qEZc0PNIyNx0Hmn8B9i1Tt H+pH7WawamstXJQwEBImW24OSntCqFp9otpHYRpekyiNTSaTutTz04Plgc7U4T8LXqgj 49yunRtTMk4dSAAWtCmZynnwZ4y13enLguUWaX/JmG9ZZAg6CrzVQOeHxJCr/dPLab5F 50qHcIJAtgD6ee9+RWtl9tbMXlerv81H59jCtBN66+gc+R67YCnkAcfzryLGUIuXN3wo A+RA== X-Gm-Message-State: AOAM531RaaLhrOKszzzK07140cF0h8lqrKMEFeA7Hqpl+hx0nM9CTUci 8KcG6ZPriteZwyHVHqSLgVh0kCxDZ0GsPq6mRcWRag9/1qjjHa/z0P75xL9Xa5fdJAVSCnUjB/j QoEJN8/rjVNgOl9O69/2kqqD08Ygna6QEKgLXjVAyPviI1I4SsF8o37yr5Wf4ZfUfVoPz8y2fS9 AJo2hvUQbWXnAhYMasu6QgGjeWi1UfHbkEuTZztnpXIBwkuu69pyxQxqVQrw== X-Google-Smtp-Source: ABdhPJw9WFtx6AEQgB+CDbEz+lxDIV1HpcBb6RNgtspAleaucgL8xq4n25iGRbATkM+g9SOPZ6J8UhhnUYBnMb1mBOE= X-Received: by 2002:a05:6402:299:: with SMTP id l25mr17879674edv.283.1627892849198; Mon, 02 Aug 2021 01:27:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Semab Tariq Date: Mon, 2 Aug 2021 13:27:17 +0500 Message-ID: Subject: Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000025ab905c88f570d" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000025ab905c88f570d Content-Type: text/plain; charset="UTF-8" Great, thanks for letting me know. On Mon, Aug 2, 2021 at 1:12 PM Dave Page wrote: > Thanks, patch applied. > > On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq > wrote: > >> Hi Team >> >> In my previous email, I attached a link to the JIRA ticket and I was >> hoping that you can access that ticket and see the details about my patch >> but I was unaware that JIRA is not accessible to the community so now I am >> attaching the details here >> >> *Details about my patch* >> >> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >> BigSur x86_64* architecture via following command >> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.app >> /Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >> MacOSX11.1.sdk CMakeLists.txt >> >> I got this error in configure log >> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >> Configuring incomplete, errors occurred! >> >> After some debugging, I found out that the >> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition >> so I added that, and now I am able to build pgAgent universal binaries >> successfully. If you don't have any concerns with my patch can someone >> please push the changes to the source? Thanks & Regards, >> Semab >> >> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq >> wrote: >> >>> Hi Team >>> >>> Can someone please push this patch to the *master* branch of *pgAgent* >>> repo? >>> For more details Please refer to JIRA PPS-310 >>> >>> >>> -- >>> Thanks & Regards, >>> Semab >>> >> >> >> -- >> > > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- Thanks & Regards, Semab --000000000000025ab905c88f570d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Great, thanks for letting me know.=C2=A0

On Mon, Aug 2,= 2021 at 1:12 PM Dave Page <dpage@p= gadmin.org> wrote:
Thanks, patch applied.

On Mon, Aug 2, 2021 at 2:= 44 AM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
= Hi Team=C2=A0

In my previous email, I attached a link to the JIRA ti= cket and I was hoping that you can access that ticket and see the details a= bout my patch but I was unaware=C2=A0that JIRA is not accessible to the com= munity so now I am attaching the details here

Details about my p= atch

While trying to ge= nerate pgAgent-4.2.1 universal binaries on macOS BigSur x86_64= architecture via following command

1BOOST_ROOT=3D/tmp/PG-pgAgent PGDIR=3D/tmp/PG<= /span>-pgAgent /Applications/CMake.app/Contents= /bin/cmake -<= span>DCMAKE_INSTALL_PREFIX=3D/tmp= /PG= -pgAgent <= span style=3D"font-family:unset;font-size:unset;font-variant-caps:unset;fon= t-weight:unset;font-stretch:unset;line-height:unset;font-feature-settings:u= nset;text-orientation:unset;writing-mode:unset;zoom:unset;background-image:= unset;background-size:unset;background-origin:unset;background-clip:unset;b= ackground-color:unset;background-blend-mode:unset;border:unset;border-radiu= s:unset;border-collapse:unset;box-sizing:unset;break-after:unset;break-befo= re:unset;break-inside:unset;caption-side:unset;clear:unset;columns:unset;co= lumn-fill:unset;column-rule:unset;column-span:unset;display:unset;empty-cel= ls:unset;float:unset;height:unset;image-orientation:unset;isolation:unset;l= etter-spacing:unset;line-break:unset;list-style:unset;margin:unset;max-heig= ht:unset;max-width:unset;min-height:unset;min-width:unset;mix-blend-mode:un= set;object-fit:unset;object-position:unset;opacity:unset;outline:unset;over= flow:unset;padding:unset;quotes:unset;table-layout:unset;text-align:unset;t= ext-decoration:unset;text-indent:unset;text-overflow:unset;text-transform:u= nset;text-underline-position:unset;vertical-align:unset;border-spacing:unse= t;white-space:unset;width:unset;word-break:unset;word-spacing:unset;backgro= und-position:unset;background-repeat:unset">-DCMAKE_OSX_ARCHIT= ECTURES:ST= RING=3D"x86_64;arm64&= quot; -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=3D10.14 -DSTATIC_BUILD=3DNO -D CMAKE_OSX_SYSROOT:FILEPATH=3D/Libr= ary/Developer/CommandLineTools/SDKs/MacOSX11.1= .sdk CMakeLists.txt

I got this error in configure log

=
1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" <= span style=3D"color:rgb(0,102,68);font-family:unset;font-size:unset;font-va= riant-caps:unset;font-weight:unset;font-stretch:unset;line-height:unset;fon= t-feature-settings:unset;text-orientation:unset;writing-mode:unset;zoom:uns= et;background-image:unset;background-size:unset;background-origin:unset;bac= kground-clip:unset;background-color:unset;background-blend-mode:unset;borde= r:unset;border-radius:unset;border-collapse:unset;box-sizing:unset;break-af= ter:unset;break-before:unset;break-inside:unset;caption-side:unset;clear:un= set;columns:unset;column-fill:unset;column-rule:unset;column-span:unset;dis= play:unset;empty-cells:unset;float:unset;height:unset;image-orientation:uns= et;isolation:unset;letter-spacing:unset;line-break:unset;list-style:unset;m= argin:unset;max-height:unset;max-width:unset;min-height:unset;min-width:uns= et;mix-blend-mode:unset;object-fit:unset;object-position:unset;opacity:unse= t;outline:unset;overflow:unset;padding:unset;quotes:unset;table-layout:unse= t;text-align:unset;text-decoration:unset;text-indent:unset;text-overflow:un= set;text-transform:unset;text-underline-position:unset;vertical-align:unset= ;border-spacing:unset;white-space:unset;width:unset;word-break:unset;word-s= pacing:unset;background-position:unset;background-repeat:unset">"x86_6= 4" "arm64" "STREQUAL" "" 4 Unknown arguments specif= ied 5-- Configuring incomplete, errors occurred!

After some debugg= ing, I found out that the pgAgent-4.2.1-Source/CMakeLists.txt file= doesn't have proper double quotes around CMAKE_OSX_ARCHITECTURES variable inside if condition so I added that, and now I am abl= e to build pgAgent universal binaries successfully.=20 If you don't have any concerns with my patch can someone please push th= e changes to the source? Thanks &= ; Regards,
Semab


On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <semab.tariq@enterpr= isedb.com> wrote:
Hi Team

Can someone please push this pat= ch to the master branch of pgAgent repo?
For more details = Please refer to JIRA PPS-310=C2=A0

--
Thanks & Regards,
Semab


--


--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EDB: http= s://www.enterprisedb.com



--
Thanks & Regards,
Semab
--000000000000025ab905c88f570d--