Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXS2m-0002tu-An for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Oct 2021 17:46:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mXS2k-0006XQ-43 for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Oct 2021 17:46:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXS2j-0006XI-DR for pgadmin-hackers@lists.postgresql.org; Mon, 04 Oct 2021 17:46:25 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mXS2e-0001TY-LM for pgadmin-hackers@postgresql.org; Mon, 04 Oct 2021 17:46:24 +0000 Received: by mail-ed1-x532.google.com with SMTP id p11so15077931edy.10 for ; Mon, 04 Oct 2021 10:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FOxqNcRFGUKm/ps3Rx1YlDt9E6chSeiN6P3wJtBDwYM=; b=aqleFV1/IhMRqdl2mCX7YLK7SNzM/SkGsbQxd1YWkrkiF/qbvL9pVgIUff7eN1RjzD qU5nOCe/r9JLiPiRSp6xb3YHSCBCZaaTDVp7Q4SrPFjt3NFK8Cc0mbQIQpVj9FBkKazU WLy1o3Q4/A2pzszX7OGHQG+uq1ckQmoFELIuWkWDlL2q0lH0RFRlTCiWOa0oLrxoVge3 0DvgT4cMkmkjgad0VwZuYTKfEjC3MJZvB19Fn0vGhTDQlbQPgPOkK7T5MFddHsTn+UAM hUPP4uK+InjAlh1eBNOa2kpbHBYd2GgIhFi+Ox9BScMuyzk+RVHh3dHt4INuRKg5NVRo rI2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FOxqNcRFGUKm/ps3Rx1YlDt9E6chSeiN6P3wJtBDwYM=; b=b8wh9SpXD/IMOZVZWi93X3UznEcUHuT2SSRbPNYTs5AV1gy1hxL9ulr2JbImScam3g ODeJOA6BSyr+0hQeO9ZHhFgjFWx6pQz7JzFxwwxRIAfEnLGIb2wl2p4whUa6EepqJA5r 2U6iJJOXEz1LgqtJsC50/1C8qNL0DeEX5OYkT6Og3nZCzKFhq1SB6hu/9ViSW6HCU2Lu KfneIvJNb0B4xjdL868m3spGqrsaEYlGydd8IPdPYNCCaFP/s2QQ6jsUp4rpCldkYV3e fvkN8r6x8UtAsIRRN8KmIFKsS2Xg1s+mlZ+8214ubuuVo13jFc16pu20NHfUQLu4WmCh f+5w== X-Gm-Message-State: AOAM531fYS6mcX6PJ5JC09lKhs0gA1/qn1/eOxKxQ7ycJclqgu4tjiRN 5dlbuyIcONoc1qat8IxazJ456I7uG5xFizefmtGEp2e6EUDrFUcdFMoAD8tZp2C0iZNCOxlGNce GOrQSFqh3L4hD0mIFUCx3X2546mBQNgZCRHvb7Iv20bJeBGR2eq68gIovnmvqG4Ph6fglu4OWPU gyD5C9g/364HiG81rhrnYExGs29NKmZcfAsEpou/DrdCC5uW557TI+5rFicArsgZRNyA== X-Google-Smtp-Source: ABdhPJweNO/NH25V8QkqBnFUhE65ZqZkBin739eioMifUDc+D/B00Jni9hjzqEyFoiDzQzRojKe4ZpNXuBqW/c7kFxo= X-Received: by 2002:a05:6402:d5a:: with SMTP id ec26mr5210960edb.247.1633369579467; Mon, 04 Oct 2021 10:46:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Semab Tariq Date: Mon, 4 Oct 2021 22:45:42 +0500 Message-ID: Subject: Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS To: Dave Page Cc: pgadmin-hackers , Sandeep Thakkar , Ashesh Vashi Content-Type: multipart/alternative; boundary="000000000000924d6305cd8a7dd5" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000924d6305cd8a7dd5 Content-Type: text/plain; charset="UTF-8" Awesome, thanks! Thanks & Regards, Semab On Mon, Oct 4, 2021 at 4:00 PM Dave Page wrote: > Hi > > I've tagged 4.2.2. > > On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq > wrote: > >> (Adding Ashesh, Sandeep) >> >> Hi Team >> >> Do we have any possible date for the pgAgent-4.2.2 release? >> I am interested in 4.2.2 because 4.2.1 doesn't have support to build >> universal binaries on macOS but 4.2.2 will have this support because this >> >> commit is already pushed to the master branch >> Also, we plan to release pgAgent for PG-14.0, and for this, we need >> pgAgent-4.2.2(Due to its universal binaries support) >> >> Thanks & Regards, >> Semab >> >> On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq >> wrote: >> >>> Great, thanks for letting me know. >>> >>> On Mon, Aug 2, 2021 at 1:12 PM Dave Page wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq < >>>> semab.tariq@enterprisedb.com> wrote: >>>> >>>>> Hi Team >>>>> >>>>> In my previous email, I attached a link to the JIRA ticket and I was >>>>> hoping that you can access that ticket and see the details about my patch >>>>> but I was unaware that JIRA is not accessible to the community so now I am >>>>> attaching the details here >>>>> >>>>> *Details about my patch* >>>>> >>>>> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >>>>> BigSur x86_64* architecture via following command >>>>> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake. >>>>> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >>>>> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >>>>> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >>>>> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >>>>> MacOSX11.1.sdk CMakeLists.txt >>>>> >>>>> I got this error in configure log >>>>> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >>>>> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >>>>> Configuring incomplete, errors occurred! >>>>> >>>>> After some debugging, I found out that the >>>>> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >>>>> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* >>>>> condition so I added that, and now I am able to build pgAgent universal >>>>> binaries successfully. If you don't have any concerns with my patch can >>>>> someone please push the changes to the source? Thanks & Regards, >>>>> Semab >>>>> >>>>> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq < >>>>> semab.tariq@enterprisedb.com> wrote: >>>>> >>>>>> Hi Team >>>>>> >>>>>> Can someone please push this patch to the *master* branch of >>>>>> *pgAgent* repo? >>>>>> For more details Please refer to JIRA PPS-310 >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Semab >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: https://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EDB: https://www.enterprisedb.com >>>> >>>> >>> >>> -- >>> Thanks & Regards, >>> Semab >>> >> >> >> -- >> >> > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- --000000000000924d6305cd8a7dd5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Awesome, thanks!=C2=A0

Thanks & Regards,
Semab

On Mo= n, Oct 4, 2021 at 4:00 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

I've tagged 4= .2.2.

On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq <semab.tariq@enterprisedb.= com> wrote:
(Adding Ashesh, Sandeep)

Hi Tea= m

Do we have any possible date for the pgAgent-4.2.2 release?
=
I am interested in 4.2.2 because 4.2.1 doesn't have support to bui= ld universal binaries=C2=A0on macOS but 4.2.2 will have this support becaus= e this commit is already pushed = to the master branch
Also, we plan to release pgAgent for PG-14.0= , and for this, we need pgAgent-4.2.2(Due to its universal binaries support= )

Thanks & Regards,
Semab
On Mon, = Aug 2, 2021 at 1:27 PM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
= Great, thanks for letting me know.=C2=A0

On Mon, Aug 2, 2021 at 1:12 PM = Dave Page <dpage@= pgadmin.org> wrote:
Thanks, patch applied.

On Mon, Aug 2, 2021 at 2:= 44 AM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
= Hi Team=C2=A0

In my previous email, I attached a link to the JIRA ti= cket and I was hoping that you can access that ticket and see the details a= bout my patch but I was unaware=C2=A0that JIRA is not accessible to the com= munity so now I am attaching the details here

Details about my p= atch

While trying to ge= nerate pgAgent-4.2.1 universal binaries on macOS BigSur x86_64= architecture via following command

1BOOST_ROOT=3D/tmp/PG-pgAgent PGDIR=3D/tmp/PG<= /span>-pgAgent /Applications/CMake.app/Contents= /bin/cmake -<= span>DCMAKE_INSTALL_PREFIX=3D/tmp= /PG= -pgAgent <= span style=3D"font-family:unset;font-size:unset;font-variant-caps:unset;fon= t-weight:unset;font-stretch:unset;line-height:unset;font-feature-settings:u= nset;text-orientation:unset;writing-mode:unset;zoom:unset;background-image:= unset;background-size:unset;background-origin:unset;background-clip:unset;b= ackground-color:unset;background-blend-mode:unset;border:unset;border-radiu= s:unset;border-collapse:unset;box-sizing:unset;break-after:unset;break-befo= re:unset;break-inside:unset;caption-side:unset;clear:unset;columns:unset;co= lumn-fill:unset;column-rule:unset;column-span:unset;display:unset;empty-cel= ls:unset;float:unset;height:unset;image-orientation:unset;isolation:unset;l= etter-spacing:unset;line-break:unset;list-style:unset;margin:unset;max-heig= ht:unset;max-width:unset;min-height:unset;min-width:unset;mix-blend-mode:un= set;object-fit:unset;object-position:unset;opacity:unset;outline:unset;over= flow:unset;padding:unset;quotes:unset;table-layout:unset;text-align:unset;t= ext-decoration:unset;text-indent:unset;text-overflow:unset;text-transform:u= nset;text-underline-position:unset;vertical-align:unset;border-spacing:unse= t;white-space:unset;width:unset;word-break:unset;word-spacing:unset;backgro= und-position:unset;background-repeat:unset">-DCMAKE_OSX_ARCHIT= ECTURES:ST= RING=3D"x86_64;arm64&= quot; -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=3D10.14 -DSTATIC_BUILD=3DNO -D CMAKE_OSX_SYSROOT:FILEPATH=3D/Libr= ary/Developer/CommandLineTools/SDKs/MacOSX11.1= .sdk CMakeLists.txt

I got this error in configure log

=
1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" <= span style=3D"color:rgb(0,102,68);font-family:unset;font-size:unset;font-va= riant-caps:unset;font-weight:unset;font-stretch:unset;line-height:unset;fon= t-feature-settings:unset;text-orientation:unset;writing-mode:unset;zoom:uns= et;background-image:unset;background-size:unset;background-origin:unset;bac= kground-clip:unset;background-color:unset;background-blend-mode:unset;borde= r:unset;border-radius:unset;border-collapse:unset;box-sizing:unset;break-af= ter:unset;break-before:unset;break-inside:unset;caption-side:unset;clear:un= set;columns:unset;column-fill:unset;column-rule:unset;column-span:unset;dis= play:unset;empty-cells:unset;float:unset;height:unset;image-orientation:uns= et;isolation:unset;letter-spacing:unset;line-break:unset;list-style:unset;m= argin:unset;max-height:unset;max-width:unset;min-height:unset;min-width:uns= et;mix-blend-mode:unset;object-fit:unset;object-position:unset;opacity:unse= t;outline:unset;overflow:unset;padding:unset;quotes:unset;table-layout:unse= t;text-align:unset;text-decoration:unset;text-indent:unset;text-overflow:un= set;text-transform:unset;text-underline-position:unset;vertical-align:unset= ;border-spacing:unset;white-space:unset;width:unset;word-break:unset;word-s= pacing:unset;background-position:unset;background-repeat:unset">"x86_6= 4" "arm64" "STREQUAL" "" 4 Unknown arguments specif= ied 5-- Configuring incomplete, errors occurred!

After some debugg= ing, I found out that the pgAgent-4.2.1-Source/CMakeLists.txt file= doesn't have proper double quotes around CMAKE_OSX_ARCHITECTURES variable inside if condition so I added that, and now I am abl= e to build pgAgent universal binaries successfully.=20 If you don't have any concerns with my patch can someone please push th= e changes to the source? Thanks &= ; Regards,
Semab


On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <semab.tariq@enterpr= isedb.com> wrote:
Hi Team

Can someone please push this pat= ch to the master branch of pgAgent repo?
For more details = Please refer to JIRA PPS-310=C2=A0

--
Thanks & Regards,
Semab


--


--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EDB: http= s://www.enterprisedb.com



--
Thanks & Regards,=
Semab


--



--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EDB: http= s://www.enterprisedb.com



--

--000000000000924d6305cd8a7dd5--