Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWFgL-0000dM-OW for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Oct 2021 10:22:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mWFgK-0005W3-LZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 01 Oct 2021 10:22:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWFgJ-0005Vv-TE for pgadmin-hackers@lists.postgresql.org; Fri, 01 Oct 2021 10:22:20 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mWFgG-0006eu-C9 for pgadmin-hackers@postgresql.org; Fri, 01 Oct 2021 10:22:19 +0000 Received: by mail-ed1-x533.google.com with SMTP id x7so31900791edd.6 for ; Fri, 01 Oct 2021 03:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qvB+4//5g41SlQ1uigQe1etHr4Jch7iutSqJ/HmU1z4=; b=ErXXjMpalG//5dIpME0SKaqE7tZiy1WW228jnYpSydqQMzgoOjHqW0bpcMAQZj5BML ZaME1XbzTZX10AfpUGwqFllinI77rk/DDTqFmKgEqAtMc9SFoB44g8e36TsFBJlGE2s8 WblP8OmkZggt5SkH5S3EZdb2bFGKW1adMvgEsSZQLigFJQeSpEFpOhdTTHR8fa4wRcUR 8ufmzqTS94ZDUAvilvM/oybCnwLhWHJTnpru1nbJZ1ZqSwJtteyUaWmI2K1OhZT4PwwO HHOou3dO2aRrn6X2mnzlLiH1Jr3nB6073FIlnvQGYU0Wo0rxowFSKISESUuieT6GVqpn h6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qvB+4//5g41SlQ1uigQe1etHr4Jch7iutSqJ/HmU1z4=; b=OmjOlv9rro6R9Pzr3/SAHA1auEkMTh57AY0bZI5wFn9ddzOZ2B5G4e1nRLt2SKLviw fIbab3l36tRfwG70O/oGBk890PXycFTbiZ94DqT7D80cg2noFD0Bt4GxpDHbbqtEk/hs 5x36e+wLHAtR7BftWdMe2Tmr8W61pXvHmvdYPg6utvDwqi3G7ruyluJ5DxSnE9DQ9HqI 2scRKehr4f0yQumJ+x8Yxi8povIK2KpkFZytG2yo3nVGyoJ0246fn9CR402gbDDbHA4k 5Ac2HUXvl5OSLe23H+TMETSJmljkCtAtrW/CeK9NdEPjhY+zhxKVgFD984IJ2auk+E09 VUZg== X-Gm-Message-State: AOAM530mZ3dyxwcpQV/5VaVKfY6IVyYLxW9pgIkj9WiLS1wQiZx3M45z CI1+NmNJX6HLD3k78APlDrZ+h0dqS4VtfhcjmlbBT5IYHDST42dYj1dLZFI5CZaUmwh0P4kEljN Lo/u00sQbZqYcyoSyA0U7xPcNHIqM1+/o71xdnumVtYKAmv7UEm2tVGFrsYrsxsm1EM1+dbWc9S mJlpl07NlOJ9xje9By3AYtYmZL3Y0ICMuKlxfm753Swr30dJM0iUWEdDM2OA== X-Google-Smtp-Source: ABdhPJwe7etKYDTSQmbts7Ez5MVLbs9HIclMfLXMYSNFv+DSmtHnsG9mO5BcSvG36EbpfTfZAN2KFW+9ZkCyMgzV0/c= X-Received: by 2002:a50:e005:: with SMTP id e5mr13215247edl.211.1633083734932; Fri, 01 Oct 2021 03:22:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Semab Tariq Date: Fri, 1 Oct 2021 15:21:37 +0500 Message-ID: Subject: Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS To: Dave Page Cc: pgadmin-hackers , Sandeep Thakkar , Ashesh Vashi Content-Type: multipart/alternative; boundary="000000000000e8d38f05cd47ef4f" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e8d38f05cd47ef4f Content-Type: text/plain; charset="UTF-8" (Adding Ashesh, Sandeep) Hi Team Do we have any possible date for the pgAgent-4.2.2 release? I am interested in 4.2.2 because 4.2.1 doesn't have support to build universal binaries on macOS but 4.2.2 will have this support because this commit is already pushed to the master branch Also, we plan to release pgAgent for PG-14.0, and for this, we need pgAgent-4.2.2(Due to its universal binaries support) Thanks & Regards, Semab On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq wrote: > Great, thanks for letting me know. > > On Mon, Aug 2, 2021 at 1:12 PM Dave Page wrote: > >> Thanks, patch applied. >> >> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq >> wrote: >> >>> Hi Team >>> >>> In my previous email, I attached a link to the JIRA ticket and I was >>> hoping that you can access that ticket and see the details about my patch >>> but I was unaware that JIRA is not accessible to the community so now I am >>> attaching the details here >>> >>> *Details about my patch* >>> >>> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >>> BigSur x86_64* architecture via following command >>> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake. >>> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >>> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >>> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >>> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >>> MacOSX11.1.sdk CMakeLists.txt >>> >>> I got this error in configure log >>> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >>> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >>> Configuring incomplete, errors occurred! >>> >>> After some debugging, I found out that the >>> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >>> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition >>> so I added that, and now I am able to build pgAgent universal binaries >>> successfully. If you don't have any concerns with my patch can someone >>> please push the changes to the source? Thanks & Regards, >>> Semab >>> >>> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq < >>> semab.tariq@enterprisedb.com> wrote: >>> >>>> Hi Team >>>> >>>> Can someone please push this patch to the *master* branch of *pgAgent* >>>> repo? >>>> For more details Please refer to JIRA PPS-310 >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Semab >>>> >>> >>> >>> -- >>> >> >> >> -- >> Dave Page >> Blog: https://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: https://www.enterprisedb.com >> >> > > -- > Thanks & Regards, > Semab > -- --000000000000e8d38f05cd47ef4f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(Adding Ashesh, Sandeep)

Hi Team
Do we have any possible date for the pgAgent-4.2.2 release?
I am interested in 4.2.2 because 4.2.1 doesn't have support to build = universal binaries=C2=A0on macOS but 4.2.2 will have this support because <= a href=3D"https://github.com/postgres/pgagent/commit/6df18a9a0ac79f1d913f42= 79f36f2c95c9b9aa08" target=3D"_blank">this commit is already pushed to = the master branch
Also, we plan to release pgAgent for PG-14.0, a= nd for this, we need pgAgent-4.2.2(Due to its universal binaries support)

Thanks & Regards,
Semab

<= div class=3D"gmail_quote">
On Mon, Aug= 2, 2021 at 1:27 PM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
<= /div>
Gre= at, thanks for letting me know.=C2=A0

On Mon, Aug 2, 2021 at 1:12 PM Dav= e Page <dpage@pga= dmin.org> wrote:
Thanks, patch applied.

On Mon, Aug 2, 2021 at 2:44 = AM Semab Tariq <semab.tariq@enterprisedb.com> wrote:
H= i Team=C2=A0

In my previous email, I attached a link to the JIRA tic= ket and I was hoping that you can access that ticket and see the details ab= out my patch but I was unaware=C2=A0that JIRA is not accessible to the comm= unity so now I am attaching the details here

Details about my pa= tch

While trying to gen= erate pgAgent-4.2.1 universal binaries on macOS BigSur x86_64<= /em> architecture via following command

1BOOST_ROOT=3D/tmp/PG-pgAgent PGDIR=3D/tmp/PG-pgAgent /Applications/CMake.app/Contents/= bin/cmake -DCMAKE_INSTALL_PREFIX=3D/tmp<= /span>/PG<= span style=3D"font-family:unset;font-size:unset;font-variant-caps:unset;fon= t-weight:unset;font-stretch:unset;line-height:unset;font-feature-settings:u= nset;text-orientation:unset;writing-mode:unset;zoom:unset;background-image:= unset;background-size:unset;background-origin:unset;background-clip:unset;b= ackground-color:unset;background-blend-mode:unset;border:unset;border-radiu= s:unset;border-collapse:unset;box-sizing:unset;break-after:unset;break-befo= re:unset;break-inside:unset;caption-side:unset;clear:unset;columns:unset;co= lumn-fill:unset;column-rule:unset;column-span:unset;display:unset;empty-cel= ls:unset;float:unset;height:unset;image-orientation:unset;isolation:unset;l= etter-spacing:unset;line-break:unset;list-style:unset;margin:unset;max-heig= ht:unset;max-width:unset;min-height:unset;min-width:unset;mix-blend-mode:un= set;object-fit:unset;object-position:unset;opacity:unset;outline:unset;over= flow:unset;padding:unset;quotes:unset;table-layout:unset;text-align:unset;t= ext-decoration:unset;text-indent:unset;text-overflow:unset;text-transform:u= nset;text-underline-position:unset;vertical-align:unset;border-spacing:unse= t;white-space:unset;width:unset;word-break:unset;word-spacing:unset;backgro= und-position:unset;background-repeat:unset">-pgAgent -DCMAKE_OSX_ARCHITE= CTURES:STR= ING=3D"x86_64;arm64&q= uot; -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=3D10.14 -DSTATIC_BUILD=3DNO -D CMAKE_OSX_SYSROOT:FILEPATH=3D/Libra= ry/Developer/CommandLineTools/SDKs/MacOSX11.1= .sdk CMakeLists.txt

I got this error in configure log

=
1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" <= span style=3D"color:rgb(0,102,68);font-family:unset;font-size:unset;font-va= riant-caps:unset;font-weight:unset;font-stretch:unset;line-height:unset;fon= t-feature-settings:unset;text-orientation:unset;writing-mode:unset;zoom:uns= et;background-image:unset;background-size:unset;background-origin:unset;bac= kground-clip:unset;background-color:unset;background-blend-mode:unset;borde= r:unset;border-radius:unset;border-collapse:unset;box-sizing:unset;break-af= ter:unset;break-before:unset;break-inside:unset;caption-side:unset;clear:un= set;columns:unset;column-fill:unset;column-rule:unset;column-span:unset;dis= play:unset;empty-cells:unset;float:unset;height:unset;image-orientation:uns= et;isolation:unset;letter-spacing:unset;line-break:unset;list-style:unset;m= argin:unset;max-height:unset;max-width:unset;min-height:unset;min-width:uns= et;mix-blend-mode:unset;object-fit:unset;object-position:unset;opacity:unse= t;outline:unset;overflow:unset;padding:unset;quotes:unset;table-layout:unse= t;text-align:unset;text-decoration:unset;text-indent:unset;text-overflow:un= set;text-transform:unset;text-underline-position:unset;vertical-align:unset= ;border-spacing:unset;white-space:unset;width:unset;word-break:unset;word-s= pacing:unset;background-position:unset;background-repeat:unset">"x86_6= 4" "arm64" "STREQUAL" "" 4 Unknown arguments specif= ied 5-- Configuring incomplete, errors occurred!

After some debugg= ing, I found out that the pgAgent-4.2.1-Source/CMakeLists.txt file= doesn't have proper double quotes around CMAKE_OSX_ARCHITECTURES variable inside if condition so I added that, and now I am abl= e to build pgAgent universal binaries successfully.=20 If you don't have any concerns with my patch can someone please push th= e changes to the source? Thanks &= ; Regards,
Semab


On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <semab.tariq@enterpr= isedb.com> wrote:
Hi Team

Can someone please push this pat= ch to the master branch of pgAgent repo?
For more details = Please refer to JIRA PPS-310=C2=A0

--
Thanks & Regards,
Semab


--


--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EDB: http= s://www.enterprisedb.com



--
Thanks & Regards,=
Semab


--

--000000000000e8d38f05cd47ef4f--