Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAMzx-0003Tf-RE for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Aug 2021 01:44:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mAMzw-0004xD-RU for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Aug 2021 01:44:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAFil-0003yL-NC for pgadmin-hackers@lists.postgresql.org; Sun, 01 Aug 2021 17:57:56 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mAFie-0007Dx-HN for pgadmin-hackers@postgresql.org; Sun, 01 Aug 2021 17:57:54 +0000 Received: by mail-ej1-x636.google.com with SMTP id yk17so19388131ejb.11 for ; Sun, 01 Aug 2021 10:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ZSqdp+Zxgi0mpmeCo7R59PosaqgSCSML+MQMVpPM8/c=; b=dxqCz38x8bDJnM85JJWvDUM9WnH8BQCgdQC/BeCkes2rHI5rch75L+0+F7MdwmLsRg arIjPUr+/1t/KAiXG23rjrCAUYryEihX5Un56fEl1w+L/aQye8g9BMoiXsUoTuyR+Wp9 aUnDwCpDWGVVDT5r50DHP/fC/vzfPlvAITIaLWAikJqSb9abkUtudOKfvI8yfgG0CIlL 6A2nr2dGH4CLLWIMbAWJPHiQ9oASCVEE5R4qxQsFi06ir/7z1VejX2Atoxl0CLEq9A0M zV3p32PtwZpf7Klu2SISc6oXxDCRe1IRKCS1jvqL0A7CIP2wNrjlKebOAMXBundBeG+x OC+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ZSqdp+Zxgi0mpmeCo7R59PosaqgSCSML+MQMVpPM8/c=; b=c+QcDQXVCtquM//iIVtwWuTqppwwczeNayF4EesRE5TMqChi68yGXBrolgIiKLscNV +YJVH/g8LGelKNeWVrgYItJ05geO6/SAaFXHabnHLumKPQ8YGQvZmTxuy9kiLLQTHFms 2J8f+C2g27m6elXlAOvwifFx8norkgRaArZ4rSPhI7CSEpqG1jNFy10lT9m2STNnVeVC Od88xj0hbTwSA3oguTWW4PATBecnNTeudwEbsf4d7QwmZC+5TF+9vwuqFULxA+BbvL+K fms4v8Rdrw7qQLcppro5uqx0bCJzDVSGvOUF1Zf6apYVff0VwslCOOlKqXimB+Nf50Dx jQfA== X-Gm-Message-State: AOAM531A1ayQvNBFxFdg/etrk4WPSMMnOYRokLIon8v2g5sNVnTPMnz9 iZ3yLwHJHIDaxaNrGTEOc8Cq9nGQDNeggqII0i5meguMIfTjDwZZXvlObqRz/BB/bdveJj7Qt61 2YBwz/PalkzFIDLZIg5O9Ikc5QBVOVUwYC9FqS7Qb0f7T1ArjlLDCoLO6y6DpnYQsvR30tH6oQC fqmrfwcEZWFqrUFxHg2Dc8gqePayfTSBjRUoeBmAfdXYBT6CBg1B3a89VGfUNiHmXXvA== X-Google-Smtp-Source: ABdhPJxub85afQBCZ2OAPbuj1cjAqE78bQMY0yH6C6jST2T3yPRu/dQF1YJZMVTZIrXCYdcxGgYW5+ZoolVwiCfTRQo= X-Received: by 2002:a17:907:76d3:: with SMTP id kf19mr12039674ejc.221.1627840666757; Sun, 01 Aug 2021 10:57:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Semab Tariq Date: Sun, 1 Aug 2021 22:57:31 +0500 Message-ID: Subject: Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS To: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000b1827905c883307b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000b1827905c883307b Content-Type: text/plain; charset="UTF-8" Hi Team In my previous email, I attached a link to the JIRA ticket and I was hoping that you can access that ticket and see the details about my patch but I was unaware that JIRA is not accessible to the community so now I am attaching the details here *Details about my patch* While trying to generate *pgAgent-4.2.1* universal binaries on *macOS BigSur x86_64* architecture via following command 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.app/ Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET :STRING=10.14 -DSTATIC_BUILD=NO -D CMAKE_OSX_SYSROOT:FILEPATH=/Library/ Developer/CommandLineTools/SDKs/MacOSX11.1.sdk CMakeLists.txt I got this error in configure log 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- Configuring incomplete, errors occurred! After some debugging, I found out that the *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition so I added that, and now I am able to build pgAgent universal binaries successfully. If you don't have any concerns with my patch can someone please push the changes to the source? Thanks & Regards, Semab On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq wrote: > Hi Team > > Can someone please push this patch to the *master* branch of *pgAgent* > repo? > For more details Please refer to JIRA PPS-310 > > > -- > Thanks & Regards, > Semab > -- --000000000000b1827905c883307b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Team=C2=A0

In my previous email= , I attached a link to the JIRA ticket and I was hoping that you can access= that ticket and see the details about my patch but I was unaware=C2=A0that= JIRA is not accessible to the community so now I am attaching the details = here

Details about my patch

While trying to generate pgAgent-4.2.1 = universal binaries on macOS BigSur x86_64 architecture = via following command

1BOOST_ROOT=3D/tmp/= PG-pgAgent PGDIR=3D/tmp= /PG-pgAgent /App= lications/CMake.app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=3D/tmp/PG-pgAgent -DCMAKE_OSX_ARCHITECTURES:STRING=3D= "x86_64;arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET:STRING= =3D10.14 -DSTATIC_B= UILD= =3DNO -D CMAKE_OSX_SYSROOT:FILEPATH=3D/Lib= rary/= Developer/CommandLineTools/SDKs= /MacOSX11.1.sdk= CMakeLists.txt

I go= t this error in configure log

1CMake Error<= span class=3D"gmail-"> at CMakeLists.txt:43 (IF): 2 if given arguments= : 3 <= span class=3D"gmail-token gmail-string" style=3D"color:rgb(0,102,68);font:u= nset;font-feature-settings:unset;font-kerning:unset;text-orientation:unset;= writing-mode:unset;zoom:unset;background:unset;background-blend-mode:unset;= border:unset;border-radius:unset;border-collapse:unset;box-sizing:unset;bre= ak-after:unset;break-before:unset;break-inside:unset;caption-side:unset;cle= ar:unset;columns:unset;column-fill:unset;column-rule:unset;column-span:unse= t;display:unset;empty-cells:unset;float:unset;height:unset;image-orientatio= n:unset;isolation:unset;letter-spacing:unset;line-break:unset;list-style:un= set;margin:unset;max-height:unset;max-width:unset;min-height:unset;min-widt= h:unset;mix-blend-mode:unset;object-fit:unset;object-position:unset;opacity= :unset;outline:unset;overflow:unset;padding:unset;quotes:unset;speak:unset;= table-layout:unset;text-align:unset;text-align-last:unset;text-combine-upri= ght:unset;text-decoration:unset;text-indent:unset;text-overflow:unset;text-= transform:unset;text-underline-position:unset;vertical-align:unset;border-s= pacing:unset;white-space:unset;width:unset;word-break:unset;word-spacing:un= set">"NOT" "x86_6= 4" "arm64"= "STREQUAL" "" 4 Unknown arguments specified 5-- Configuring incomplete, errors occurred!

After some = debugging, I found out that the pgAgent-4.2.1-Source/CMakeLi= sts.txt file doesn't have proper double quotes around CMAKE_OSX_ARCHITECTURES variable inside if cond= ition so I added that, and now I am able to build pgAgent universal binarie= s successfully.=20 If you don't have any concerns with my patch can someone please push th= e changes to the source? Thanks &= ; Regards,
Semab


On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <semab.tariq@enterprisedb.com> = wrote:
Hi Team

Can someone please push this patch to the master= branch of pgAgent repo?
For more details Please refer to JIR= A PPS-310=C2=A0

--
Thanks & Reg= ards,
Semab


--
--000000000000b1827905c883307b--