Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snziL-007Ubh-91 for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 12:11:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1snziK-00CN5z-U7 for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 Sep 2024 12:11:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1snziK-00CN5m-Do for pgadmin-hackers@lists.postgresql.org; Tue, 10 Sep 2024 12:11:20 +0000 Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1snziG-000Sj8-AB for pgadmin-hackers@postgresql.org; Tue, 10 Sep 2024 12:11:18 +0000 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-27b88b8a24aso2017772fac.1 for ; Tue, 10 Sep 2024 05:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1725970276; x=1726575076; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=httHBV4Cnec/LAcf47N36+/uPSRQY/OJp1wvoU5RZnI=; b=BvKwqHen2+5XYkbR5KcqQEuYhI8G0MMer0lZFydyeuRr0pFXg4R5wefeaS9nc4i0d5 By3dAiOqNMglI8A+yhcxsMIoe72fCMO2FZz0BybvYKqKos+0+Jrn55SUXBGDu7UQOr/h MkupWw9tmSpnchV5PsxPg9JLGiNrsP3ZpxA2fZqL/3Fv/PpIkn/RvgxgePD4iOyhvVlu FwSWoyJEdfbBL/ZciVvfrNHT1wbLIbfzkkoMCV4pamrBPsM1XbZQP0eOeL1V6Y/aEfbG tZUXRS7wpbqt5fQtUvAafmo5CijwAh6Es67dkOY0cZiED4asEjopYPgnAQkbBWzzJMrV WdMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725970276; x=1726575076; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=httHBV4Cnec/LAcf47N36+/uPSRQY/OJp1wvoU5RZnI=; b=rKWjLNacqe6yrrhg+x772x1rtWnCN0GTY6MQKUyMLfYPVtoCFChBDLNtE3ye+zkDYZ kUZotXpZKCdLDBL0UJy7XTemY9rAuj+xvh4q6WImAAtfTZRlvhB4Ga8DXJ5ZPGVROIg3 BXZvgoe8kS2RMZO2+zpKUf8Vkmx3xK+bkdDnhF4k5S4oK8m/tttq/hgj96TeH+qeEHh5 4GexkCtrr/VgIJMw/hdgqeLNBa/QZkWFJ+ikJZnzA7NtgrQ+5ZFkOxIeQVpW910jM68L T2skZ2WLoE7FbFS+x1C3E403qO23y4romVFoM4cww4mSLS4s7a0Uf+Jq+cia71Zx5jdh ykuA== X-Gm-Message-State: AOJu0YxRsoaE+xjvPa/quJiShGitPCq/jjh933BFCZLxMB8mxLnt0CkG dEAHza7unq3YGqqr1iv4ybfWAWoAu3Y9i7T7Fzc8Kf0bArgU0kAuebmdLTrvLfwffq/zFcy7vyd eRkAfMWN9q++uqBlMNyJMPs9JCliQ8uMVuPc5 X-Google-Smtp-Source: AGHT+IF2iC6OR5mww8f+vu1YVLJWSM4VEHQCuvFgTR61WJ5FEf3m65RvWlZkor2767+UxYvws0TUNFQGlc4TWNV3/68= X-Received: by 2002:a05:6870:3289:b0:277:ef62:e6a7 with SMTP id 586e51a60fabf-27b9dd7b24amr5563079fac.37.1725970275775; Tue, 10 Sep 2024 05:11:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rohit Bhati Date: Tue, 10 Sep 2024 17:41:04 +0530 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Dave Page Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000002e50b70621c2c5ab" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000002e50b70621c2c5ab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, I am applying that. Thanks for the suggestions. On Tue, Sep 10, 2024 at 5:34=E2=80=AFPM Dave Page wrote= : > Hi > > > On Tue, 10 Sep 2024 at 12:43, Rohit Bhati > wrote: > >> Hi Dave, >> >> I have made some changes and made the header and serial number row >> column color the same. >> >> Please once check the attached images. >> > > I think that looks much better! > > Thanks. > > >> >> Thanks >> >> On Tue, Sep 10, 2024 at 2:42=E2=80=AFPM Dave Page wr= ote: >> >>> Hi >>> >>> Shadow is more visible, but it doesn't really follow the material UI >>> styling which is flat rather than 3D. >>> >>> I think Anil's idea is worth exploring; remove the alternating colour >>> for the row number column, and use a different background shade for it >>> entirely. >>> >>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati >>> wrote: >>> >>>> Hi Dave, >>>> >>>> I have added shadow to make the text more distinct and attached >>>> screenshots based on themes. >>>> Please once check and let me know if we can go ahead with this or >>>> provide suggestions if need to make changes. >>>> >>>> Thanks & Regards >>>> Rohit Bhati >>>> >>>> >>>> On Mon, Sep 9, 2024 at 4:11=E2=80=AFPM Rohit Bhati < >>>> rohit.bhati@enterprisedb.com> wrote: >>>> >>>>> I already set weight to 900. >>>>> If we need to be more distinct then I think we can have some shadow o= r >>>>> if anything else please suggest. >>>>> >>>>> On Mon, Sep 9, 2024 at 3:29=E2=80=AFPM Dave Page = wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati < >>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> I have made changes as per your suggestions. >>>>>>> I have attached screenshots showing how the updates look across all >>>>>>> themes for your reference. >>>>>>> >>>>>>> If the current changes does not fit well with the theme or if you >>>>>>> have any suggestions for improvements, please let me know. >>>>>>> >>>>>> >>>>>> The colours etc. look correct now (ie. there are no weird borders), >>>>>> but I still don't think the row number looks visually distinct from = the >>>>>> rest of the data. The bold text simply isn't very bold - I think it = still >>>>>> needs more weight. >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> Rohit Bhati >>>>>>> EnterpriseDB >>>>>>> >>>>>>> >>>>>>> On Fri, Sep 6, 2024 at 2:01=E2=80=AFPM Dave Page wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati < >>>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> I have made some more changes with changing background color. >>>>>>>>> >>>>>>>> >>>>>>>> Yeah, that looks weird again, specifically on the selected rows. I >>>>>>>> believe the issue is that we should not highlight the row number c= olumn >>>>>>>> when a row is selected at all. That makes sense, as we should only= be >>>>>>>> highlighting the columns that would get copied in a copy/paste ope= ration >>>>>>>> anyway. >>>>>>>> >>>>>>>> Also, the bold still doesn't look bold. I think the weight needs t= o >>>>>>>> be increased. >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> I have attached screenshots showing how the updates look across >>>>>>>>> all themes. >>>>>>>>> >>>>>>>>> On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati < >>>>>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> I have removed the border and background color, just made the r= ow >>>>>>>>>>> numbers bold. >>>>>>>>>>> >>>>>>>>>>> I have attached screenshots showing how the updates look across >>>>>>>>>>> all themes. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> That doesn't look bold at all to me - and I think we still need >>>>>>>>>> some other visual distinction, such as the column background col= our. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi < >>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati < >>>>>>>>>>>>> rohit.bhati@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have made changes for issue #7863 >>>>>>>>>>>>>> based >>>>>>>>>>>>>> on theme requirements. >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have attached screenshots showing how the updates look >>>>>>>>>>>>>> across all themes for your reference. >>>>>>>>>>>>>> >>>>>>>>>>>>>> If the current color does not fit well with the theme or if >>>>>>>>>>>>>> you have any suggestions for improvements, please let me kno= w. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for >>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey s= eems like it >>>>>>>>>>>>> might not be to me, but I haven't tested. >>>>>>>>>>>>> >>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the >>>>>>>>>>>>> time. Thoughts? >>>>>>>>>>>>> >>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look >>>>>>>>>>>> good to me. >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Dave Page >>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>>>>>> >>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>>>> >>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>> EDB: https://www.enterprisedb.com >>>>>>>> >>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>>>> >>>>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> pgAdmin: https://www.pgadmin.org >>>>>> PostgreSQL: https://www.postgresql.org >>>>>> EDB: https://www.enterprisedb.com >>>>>> >>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>>> >>>>>> >>> >>> -- >>> Dave Page >>> pgAdmin: https://www.pgadmin.org >>> PostgreSQL: https://www.postgresql.org >>> EDB: https://www.enterprisedb.com >>> >>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>> >>> --0000000000002e50b70621c2c5ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, I am applying that.

Thanks for the suggestions.=

= On Tue, Sep 10, 2024 at 5:34=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

<= div>
On= Tue, 10 Sep 2024 at 12:43, Rohit Bhati <rohit.bhati@enterprisedb.com> wro= te:
Hi Dave,

I have made some changes and made the header and seria= l number row column=C2=A0color the same.

Please once check the attac= hed images.

I think that looks much better!

Thanks.



Thanks

On Tue, Sep 10, 20= 24 at 2:42=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

Shadow is more visible, but it doesn't really follow the materi= al UI styling which is flat rather than 3D.

I thin= k Anil's idea is worth exploring; remove the=C2=A0alternating colour fo= r the row number column, and use a different background shade for it entire= ly.

On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <rohit.bhati@enterprisedb.com&g= t; wrote:
Hi=C2=A0Dave,

I have added shadow to make the text=C2=A0<= span style=3D"color:rgb(80,0,80)">more distinct and attached screenshots ba= sed on themes.
Please once check and let me=C2=A0know if we can g= o=C2=A0ahead with this or provide suggestions if need to make changes.
<= br>Thanks & Regards
Rohit Bhati


On Mon, Sep 9, 2024 at 4:11= =E2=80=AFPM Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
I already s= et weight to 900.
If we need to be more distinct then I think we can hav= e some shadow or if anything else please suggest.

On Mon, Sep 9, 2024 = at 3:29=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, 9 Sept 2024 = at 10:18, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
Hi Dave,
<= br>I have made changes as per your suggestions.
I have attached screensh= ots showing how the updates look across all themes for your reference.
<= br>If the current changes does not fit well with the theme or if you have a= ny suggestions for improvements, please let me=C2=A0know.

The colours etc. look correct now (ie. there are n= o weird borders), but I still don't think the row number looks visually= distinct from the rest of the data. The bold text simply isn't very bo= ld - I think it still needs more weight.

=C2=A0

T= hanks
Rohit Bhati
EnterpriseDB


On Fri, Sep 6, 2024 at 2:01=E2= =80=AFPM Dave Page <dpage@pgadmin.org> wrote:


On Fri, 6 Sept 20= 24 at 09:25, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
I have mad= e some more changes with changing background color.
<= div>
Yeah, that looks weird again, specifically=C2=A0on the s= elected rows. I believe the issue is that we should not highlight the row n= umber column when a row is selected at all. That makes sense, as we should = only be highlighting the columns that would get copied in a copy/paste oper= ation anyway.

Also, the bold still doesn't loo= k bold. I think the weight needs to be increased.
=C2=A0

I have attached screenshots showing how the upd= ates look across all themes.

On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
=
Hi

On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <rohit.bhati@enterprisedb.com&= gt; wrote:
Hi,

I have removed the border and background color, just= =C2=A0made the=C2=A0row numbers bold.

I have attached screenshots showing how the updates look ac= ross all themes.
=

That doesn't look bold at all to me - = and I think we still need some other visual distinction, such as the column= background colour.
=C2=A0


On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi <khushboo.vashi@en= terprisedb.com> wrote:


On Thu, Sep 5, 2024 at = 7:11=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, 5 Sept 2024 = at 14:38, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
Hi,

I= have made changes for issue #7863=C2=A0based on theme requireme= nts.

I have attached screenshots showing how the updates look across= all themes for your reference.

If the current color does not fit we= ll with the theme or if you have any suggestions for improvements, please l= et me know.

Is the colour c= ontrast high enough on the row numbers for selected rows in the high contra= st theme? The black on grey seems like it might not be to me, but I haven&#= 39;t tested.
=C2=A0
I wonder also if we should make the= row numbers bold all the time. Thoughts?
We can check how it looks. Also the cell border doesn't look good to = me.

<= div dir=3D"ltr">

--
Dave P= age
PostgreSQL: https://www.postgresql.org

PGDay UK 2024, 11th September,= London: https://2024.= pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--0000000000002e50b70621c2c5ab--