MIME-Version: 1.0
References: 
 <CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com>
 <CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com>
 <CA+OCxoxiy6xc9V9qUOP0f5LSA22PwHyNFWXjMvBT10EHjF5F+g@mail.gmail.com>
In-Reply-To: 
 <CA+OCxoxiy6xc9V9qUOP0f5LSA22PwHyNFWXjMvBT10EHjF5F+g@mail.gmail.com>
From: Rohit Bhati <rohit.bhati@enterprisedb.com>
Date: Thu, 5 Sep 2024 16:49:03 +0530
Message-ID: 
 <CABscKViG4=vECzrEhQNKbwGKJwPrWDn3isw-mPA5fNphw-G6=Q@mail.gmail.com>
Subject: Re: Require suggestions for Issue #2874
To: Dave Page <dpage@pgadmin.org>, pgadmin-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000ef1acd06215d754d"
Archived-At: 
 <https://www.postgresql.org/message-id/CABscKViG4%3DvECzrEhQNKbwGKJwPrWDn3isw-mPA5fNphw-G6%3DQ%40mail.gmail.com>
Precedence: bulk

--000000000000ef1acd06215d754d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Currently it is just theme based, whenever the user changes the theme
accordingly the color changes.
Not for any specific preference option for this right now, But if we want
that we can add.

And if i am not wrong you are talking about this  #7863
<https://github.com/pgadmin-org/pgadmin4/issues/7863> . If this is the
issue then I can work together on both.


Rohit Bhati
EnterpriseDB

On Thu, Sep 5, 2024 at 3:51=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <rohit.bhati@enterprisedb.com>
> wrote:
>
>> Hi Hackers,
>>
>> Please check the updated attached screenshot  for an alternate backgroun=
d
>> color of table rows.
>> The images also shows alternate row color with some selected rows color
>> from the table.
>>
>>
> I think that looks good. Are you making it a preference, so users that
> prefer non-stripey grids can keep the current look?
>
> Whilst you're hacking on that, I believe there is another ticket (which I
> can't find right now) about changing the colour of the row number column =
to
> give it better visual distinction from the data columns. Probably worth
> working on that one at the same time?
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>

--000000000000ef1acd06215d754d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br><br>Currently it is just theme based, whenever the =
user changes the theme accordingly the color changes.<br>Not for any specif=
ic preference option for this right now, But if we want that we can add.<br=
><br>And if i am not wrong you are talking about this=C2=A0 <a href=3D"http=
s://github.com/pgadmin-org/pgadmin4/issues/7863">#7863</a>=C2=A0. If this i=
s the issue then I can work together on both.<br><br><br>Rohit Bhati<br>Ent=
erpriseDB<br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Thu, Sep 5, 2024 at 3:51=E2=80=AFPM Dave Page &lt;<a href=
=3D"mailto:dpage@pgadmin.org">dpage@pgadmin.org</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>Hi</di=
v><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On T=
hu, 5 Sept 2024 at 08:27, Rohit Bhati &lt;<a href=3D"mailto:rohit.bhati@ent=
erprisedb.com" target=3D"_blank">rohit.bhati@enterprisedb.com</a>&gt; wrote=
:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.=
8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"lt=
r">Hi Hackers,<br><br>Please=C2=A0check the updated attached screenshot=C2=
=A0 for an alternate background color of table rows.<br>The images also sho=
ws alternate row color with some selected rows color from the table.<br><br=
></div></blockquote><div><br></div><div>I think that looks good. Are you ma=
king it a preference, so users that prefer non-stripey grids can keep the c=
urrent look?</div><div><br></div><div>Whilst you&#39;re hacking on that, I =
believe there is another ticket (which I can&#39;t find right now) about ch=
anging the colour of the row number column to give it better visual distinc=
tion from the data columns. Probably worth working on that one at the same =
time?</div></div><div><br></div><span class=3D"gmail_signature_prefix">-- <=
/span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave =
Page<div>pgAdmin: <a href=3D"https://www.pgadmin.org" target=3D"_blank">htt=
ps://www.pgadmin.org</a></div><div>PostgreSQL: <a href=3D"https://www.postg=
resql.org" target=3D"_blank">https://www.postgresql.org</a><br><div>EDB:=C2=
=A0<a href=3D"https://www.enterprisedb.com" target=3D"_blank">https://www.e=
nterprisedb.com</a></div><div><br></div><div>PGDay UK 2024, 11th September,=
 London: <a href=3D"https://2024.pgday.uk/" target=3D"_blank">https://2024.=
pgday.uk/</a></div><div><br></div></div></div></div></div>
</blockquote></div>

--000000000000ef1acd06215d754d--