public inbox for [email protected]  

help / color / mirror / Atom feed

From: Rohit Bhati <[email protected]>
To: Dave Page <[email protected]>
To: [email protected]
Subject: Re: Require suggestions for Issue #2874
Date: Thu, 5 Sep 2024 19:08:20 +0530
Message-ID: <CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com> (raw)
In-Reply-To: <CABscKViS50079irxJfgL5ARtd5g4D86z+OwJ7huY7nRJbB2rLQ@mail.gmail.com>
References: <CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com>
	<CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com>
	<CA+OCxoxiy6xc9V9qUOP0f5LSA22PwHyNFWXjMvBT10EHjF5F+g@mail.gmail.com>
	<CABscKViG4=vECzrEhQNKbwGKJwPrWDn3isw-mPA5fNphw-G6=Q@mail.gmail.com>
	<CA+OCxoxOzUKjPF8pC=z4vjVKegBzNUDtGtwc5tewmtz2MfMhMw@mail.gmail.com>
	<CABscKViS50079irxJfgL5ARtd5g4D86z+OwJ7huY7nRJbB2rLQ@mail.gmail.com>

Hi,

I have made changes for issue #7863
<https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
requirements.

I have attached screenshots showing how the updates look across all themes
for your reference.

If the current color does not fit well with the theme or if you have any
suggestions for improvements, please let me know.

Note :- As I also follow this DBEAVER
<https://dbeaver.io/wp-content/uploads/2018/03/data_edit-450x220.png;
image which
the user shares on the issue #7863
<https://github.com/pgadmin-org/pgadmin4/issues/7863;.

Thanks,
Rohit Bhati
EnterpriseDB

On Thu, Sep 5, 2024 at 5:03 PM Rohit Bhati <[email protected]>
wrote:

> Ok
>
> On Thu, Sep 5, 2024 at 5:03 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, 5 Sept 2024 at 12:19, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> Currently it is just theme based, whenever the user changes the theme
>>> accordingly the color changes.
>>> Not for any specific preference option for this right now, But if we
>>> want that we can add.
>>>
>>
>> Let's just go with it for now, and if people don't like it, we can add a
>> preference.
>>
>>
>>>
>>> And if i am not wrong you are talking about this  #7863
>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; . If this is the
>>> issue then I can work together on both.
>>>
>>
>> Yes, that's the one :-)
>>
>>
>>>
>>>
>>> Rohit Bhati
>>> EnterpriseDB
>>>
>>> On Thu, Sep 5, 2024 at 3:51 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please check the updated attached screenshot  for an alternate
>>>>> background color of table rows.
>>>>> The images also shows alternate row color with some selected rows
>>>>> color from the table.
>>>>>
>>>>>
>>>> I think that looks good. Are you making it a preference, so users that
>>>> prefer non-stripey grids can keep the current look?
>>>>
>>>> Whilst you're hacking on that, I believe there is another ticket (which
>>>> I can't find right now) about changing the colour of the row number column
>>>> to give it better visual distinction from the data columns. Probably worth
>>>> working on that one at the same time?
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>


Attachments:

  [image/png] cell-dark.png (126.9K, ../CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com/3-cell-dark.png)
  download | view image

  [image/png] cell-light.png (144.6K, ../CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com/4-cell-light.png)
  download | view image

  [image/png] cell-highcontrast.png (148.3K, ../CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com/5-cell-highcontrast.png)
  download | view image

view thread (33+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Require suggestions for Issue #2874
  In-Reply-To: <CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox