Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aJPCq-0003wJ-8T for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jan 2016 17:27:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aJPCp-0004ub-6J for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jan 2016 17:27:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aJPCb-0004fs-6R for pgadmin-hackers@postgresql.org; Wed, 13 Jan 2016 17:27:21 +0000 Received: from mail-yk0-x232.google.com ([2607:f8b0:4002:c07::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aJPCX-0002Uh-IV for pgadmin-hackers@postgresql.org; Wed, 13 Jan 2016 17:27:20 +0000 Received: by mail-yk0-x232.google.com with SMTP id v14so402889893ykd.3 for ; Wed, 13 Jan 2016 09:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=GWP7QBLQggJJ9SJjLuKA+8nDyQO5Cvu19n4cZQMivWU=; b=GxTHfjN1hZQu2g1RFouAvS5Kx1lphe+lIEe0pBXDD6uC7IolPdS10NVGtdmGDOTs/2 Zc9BoZxhFBF9CjxRoZFjTZ8DTqA+xbxCyamVpczE/8+dllr5N2+J8BIjh9uXWWivuAXw zh4I7Wpd4h8JUNunQpMLCE/DXntMfxjHYyK3kw2Ltxx0DPNlsmQ1geI3VFmG2QDdRLa7 29Xg/lEfI3zJqIfxqhhC99pdUa8Rxn8jUW035jNDkEJMQVeFY6CjO06Z6cifwgODCTSW y/dDOdALffqR+bOeXsPFOdR1TVfEhdvEyUwYoPuM33SlSYIPwqnk1i25a2C0EWfgaO1n FfVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=GWP7QBLQggJJ9SJjLuKA+8nDyQO5Cvu19n4cZQMivWU=; b=dpiotmPIrUjaLGu7ba1+elvW7d+ftN4cdtVLR4tSf39nx6SGcxEi0wzRjuSvoXN+2y Y5cBAZVhfFDCR/nuW0mco6jIWHEFqKgbtpP0teneyBQW8pyWw+yXLiWuIWf66bFhwjWn MzzmbsYOwPKEhFzfgdO2urDuMx68DIs++a1+ZYR5ezvqAlsPUIs1YnsYauj+Ul0LeqxG jePm37xhOuyXa49xNshd02OoK8f48l4X+q/zePoYZXxjbbfOQ/FMfpQif+Herq07RuHf 02X2l8ve30dM2PytQWJXI+TCDoxMx/qroqTn+cncDlRAuIW7ipGBKsQcZ5pf4sP6GAFn D43A== X-Gm-Message-State: ALoCoQkdavgGciZQlT2wkjSM7obbjI6nC5oz/mUCsMZfSDxFmcpJ3gOfIu1hlT84Yg10vhxdGEdfcRD4+L3/LBEr9l3mg8Gt1QRydffvOFaPy2RqR2T9Hw8= MIME-Version: 1.0 X-Received: by 10.13.194.196 with SMTP id e187mr14931897ywd.40.1452706035512; Wed, 13 Jan 2016 09:27:15 -0800 (PST) Received: by 10.37.202.75 with HTTP; Wed, 13 Jan 2016 09:27:15 -0800 (PST) In-Reply-To: References: Date: Wed, 13 Jan 2016 22:57:15 +0530 Message-ID: Subject: Re: Unable to update Domain properly From: Neel Patel To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114e6f6a36003e05293a7b8b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114e6f6a36003e05293a7b8b Content-Type: multipart/alternative; boundary=001a114e6f6a36003905293a7b89 --001a114e6f6a36003905293a7b89 Content-Type: text/plain; charset=UTF-8 Hi, Please find the attached patch file for fix of above issue. *Issue:- * Below generated SQL was wrong. ALTER DOMAIN pem."TestDomain" RENAME TO "TestDomain1"; ALTER DOMAIN pem."TestDomain" DROP NOT NULL; In second query, domain name is wrong as domain name was updated by the first query. *Resolution:-* Now when any properties got changed along with domain name then correct SQL will be generated. Correct query should be as below. ALTER DOMAIN pem."TestDomain" RENAME TO "TestDomain1"; ALTER DOMAIN pem."TestDomain1" DROP NOT NULL; Please review it and do let us know for any comment. Thanks, Neel Patel On Wed, Jan 13, 2016 at 6:43 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > While updating Domain from pgAdmin-III , I observed an error. > > When I update only Domain name it is working properly, but when I try to > update multiple fields, I get an error. > > For example, if I try to rename Domain *TestDomain* to *TestDomain1* and > also modifies one or more fields (except comment). I get below error. > > > ERROR: type "pem.TestDomain" does not exist > > *Generated SQL:* > > ALTER DOMAIN pem."TestDomain" > RENAME TO "TestDomain1"; > ALTER DOMAIN pem."TestDomain" > DROP NOT NULL; > > > Thanks, > Khushboo > --001a114e6f6a36003905293a7b89 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find the attached patch file= for fix of above issue.

Issue:-=C2=A0
Below generated SQL was wrong.

ALTER DOMAIN pem."TestDomain"
=C2=A0 RENAME TO &= quot;TestDomain1";
ALTER DOMAIN pem."TestDomai= n"
=C2=A0 DROP NOT NULL;
=

In second query, domain name is wrong as domain name was = updated by the first query.

Resolut= ion:-

= Now when any properties got changed along with domain name then correct SQL= will be generated.
Corre= ct query should be as below.

ALTER DOMAIN pem= ."TestDomain"
=C2=A0 RENAME TO "TestDomain1";
ALTER DOMAIN=C2=A0<= font color=3D"#000000">pem."TestDomain1"
=C2=A0 DROP NOT NULL= ;

Please review it and do let us know for any comment.

Thanks,
N= eel Patel

On Wed, Jan 13, 2016 at 6:43 PM, Khushboo Vashi <= khushboo.vashi@enterprisedb.com> wrote:
Hi,

While updating Do= main from pgAdmin-III=C2=A0 , I observed an error.

When I= update only Domain name it is working properly, but when I try to update m= ultiple fields, I get an error.

For example,=C2=A0 if I t= ry to rename Domain TestDomain to TestDomain1 and also modifi= es one or more fields (except comment). I get below error.

ERROR:=C2=A0 type "pem.TestDomain" does not exist

Generated SQL:

ALTER DOMAIN pem."TestDomain"
=C2= =A0 RENAME TO "TestDomain1";
ALTER DOMAIN pem."TestDomain= "
=C2=A0 DROP NOT NULL;


Thanks,
Khushboo

--001a114e6f6a36003905293a7b89-- --001a114e6f6a36003e05293a7b8b Content-Type: application/octet-stream; name="domain_fix.patch" Content-Disposition: attachment; filename="domain_fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ijd3m68a0 ZGlmZiAtLWdpdCBhL3BnYWRtaW4vZGxnL2RsZ0RvbWFpbi5jcHAgYi9wZ2Fk bWluL2RsZy9kbGdEb21haW4uY3BwCmluZGV4IGEzOTkyZjIuLjA3Mzg1MGMg MTAwNjQ0Ci0tLSBhL3BnYWRtaW4vZGxnL2RsZ0RvbWFpbi5jcHAKKysrIGIv cGdhZG1pbi9kbGcvZGxnRG9tYWluLmNwcApAQCAtMjkyLDcgKzI5Miw3IEBA IHd4U3RyaW5nIGRsZ0RvbWFpbjo6R2V0U3FsKCkKIAkJfQogCQlpZiAoY2hr Tm90TnVsbC0+R2V0VmFsdWUoKSAhPSBkb21haW4tPkdldE5vdE51bGwoKSkK IAkJewotCQkJc3FsICs9IHd4VCgiQUxURVIgRE9NQUlOICIpICsgZG9tYWlu LT5HZXRRdW90ZWRGdWxsSWRlbnRpZmllcigpOworCQkJc3FsICs9IHd4VCgi QUxURVIgRE9NQUlOICIpICsgcXRJZGVudChuYW1lKTsKIAkJCWlmIChjaGtO b3ROdWxsLT5HZXRWYWx1ZSgpKQogCQkJCXNxbCArPSB3eFQoIlxuICBTRVQg Tk9UIE5VTEw7XG4iKTsKIAkJCWVsc2UKQEAgLTMwMCw3ICszMDAsNyBAQCB3 eFN0cmluZyBkbGdEb21haW46OkdldFNxbCgpCiAJCX0KIAkJaWYgKHR4dERl ZmF1bHQtPkdldFZhbHVlKCkgIT0gZG9tYWluLT5HZXREZWZhdWx0KCkpCiAJ CXsKLQkJCXNxbCArPSB3eFQoIkFMVEVSIERPTUFJTiAiKSArIGRvbWFpbi0+ R2V0UXVvdGVkRnVsbElkZW50aWZpZXIoKTsKKwkJCXNxbCArPSB3eFQoIkFM VEVSIERPTUFJTiAiKSArIHF0SWRlbnQobmFtZSk7CiAJCQlpZiAodHh0RGVm YXVsdC0+R2V0VmFsdWUoKS5Jc0VtcHR5KCkpCiAJCQkJc3FsICs9IHd4VCgi XG4gIERST1AgREVGQVVMVDtcbiIpOwogCQkJZWxzZQpAQCAtMzE4LDcgKzMx OCw3IEBAIHd4U3RyaW5nIGRsZ0RvbWFpbjo6R2V0U3FsKCkKIAkJCQl0bXBE ZWYuUmVtb3ZlQXQoaW5kZXgpOwogCQkJZWxzZQogCQkJewotCQkJCXRtcHNx bCArPSB3eFQoIkFMVEVSIERPTUFJTiAiKSArIGRvbWFpbi0+R2V0UXVvdGVk RnVsbElkZW50aWZpZXIoKQorCQkJCXRtcHNxbCArPSB3eFQoIkFMVEVSIERP TUFJTiAiKSArIHF0SWRlbnQobmFtZSk7CiAJCQkJICAgICAgICAgICsgIHd4 VCgiXG4gIEFERCIpOwogCQkJCWlmICghY29ubmFtZS5Jc0VtcHR5KCkpCiAJ CQkJCXRtcHNxbCArPSB3eFQoIiBDT05TVFJBSU5UICIpOwpAQCAtMzM1LDkg KzMzNSw4IEBAIHd4U3RyaW5nIGRsZ0RvbWFpbjo6R2V0U3FsKCkKIAkJCQlk ZWZpbml0aW9uID0gZGVmaW5pdGlvbi5NaWQoMSkuQmVmb3JlRmlyc3QoJyIn KTsKIAkJCWVsc2UKIAkJCQlkZWZpbml0aW9uID0gZGVmaW5pdGlvbi5CZWZv cmVGaXJzdCgnICcpOwotCQkJc3FsICs9IHd4VCgiQUxURVIgRE9NQUlOICIp ICsgZG9tYWluLT5HZXRRdW90ZWRGdWxsSWRlbnRpZmllcigpCisJCQlzcWwg Kz0gd3hUKCJBTFRFUiBET01BSU4gIikgKyBxdElkZW50KG5hbWUpCiAJCQkg ICAgICAgKyB3eFQoIlxuICBEUk9QIENPTlNUUkFJTlQgIikgKyBxdElkZW50 KGRlZmluaXRpb24pICsgd3hUKCI7XG4iKTsKLQogCQl9CiAKIAkJLy8gQWRk IHRoZSBBREQgQ09OU1RSQUlOVHMuLi4K --001a114e6f6a36003e05293a7b8b Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114e6f6a36003e05293a7b8b--