Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d80Vz-0001wK-H9 for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:29:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d80Vz-0001uB-3k for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 08:29:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d80Vy-0001tz-Jn for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:29:02 +0000 Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d80Vu-00087H-GM for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 08:29:01 +0000 Received: by mail-pf0-x231.google.com with SMTP id v14so45846249pfd.2 for ; Tue, 09 May 2017 01:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g2yfdOt+1A8bFvrODT7pVQ8tpNYzV0dvF+FkGIKAtBk=; b=Z7+ZSt4UkNn2lvCgVMXqTqmtLfY5P0jxlQrCo8Mq6qR4d6ZhXoew7sdpxUk8NXLPDk s2RbQD0Zdb54DFSkZ1F4v17bUXhjjfheb/ILDppnoFaO8q+RLhPnptoVk26+ZDDlvisa xJkYOeTEhaJ6qqYZBS26J8bwTxhLw40x6jpHtCTSrud5PWXcbvFx4t2s06KiV9VrjYrP huNPs/Gw3RyYUjW7SpInZfRdbVV6H1Isjf83ICpuY9aJT7LtYtL11h5ORAdQ+QD7RSh8 6hXtK2Wk4XSCDiz9YVWPpTf95Hs3IXw61JrouQ9Eq5kjZ+j/znmYR6DFG9gamNkMOoBP YasQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g2yfdOt+1A8bFvrODT7pVQ8tpNYzV0dvF+FkGIKAtBk=; b=RxSnPgT1UmlloG5mEstFDufoXnINym5s8CooiyygFV8ZdAacPd/vpQhfJ8l23Ee0fV 6Qb1xk2HnL/yY7VJXuVUiIp3UBrtIuUmimtKkLx8PHSBBTMfiQ2Fsm/yCHz6zQeGjBqO OMszExEKlYCgwzxVRA0eH/pDaYoUyHQErlVivUNhqVFN4qFqJsyyxLe28XTfpozEA/B2 J7w22Qi7ZST2TTWU6WtsICVKNSaobZ7+L/AsnIkNrmTrvXKMYmPtqqfZh/DIuiBdgPZc 1ws/dlyvEKpk6wqI5HT6IJt4YRyC+P1d5JAMCP+jq8bkaKlzgpdRdsgQDgF/xKOkN7lR KwFw== X-Gm-Message-State: AODbwcBKN5hVR3NBME7uWyQON8EvyA2rIGt+VJ5Pfz2VWZa3cA/gsMeQ eKbB44nlcSXY+1oFGo2fBjbQMppx2GELWHg= X-Received: by 10.84.194.165 with SMTP id h34mr488789pld.138.1494318536365; Tue, 09 May 2017 01:28:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.137.16 with HTTP; Tue, 9 May 2017 01:28:55 -0700 (PDT) In-Reply-To: References: From: Neel Patel Date: Tue, 9 May 2017 13:58:55 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c1896368aaf10054f13251f X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1896368aaf10054f13251f Content-Type: text/plain; charset=UTF-8 Hi Dave, Yes, It looks like compilation fails on Qt4. We will fix this issue but which version of Qt4 we are using in Jenkins ? Thanks, Neel Patel On Tue, May 9, 2017 at 1:56 PM, Dave Page wrote: > > > On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi >> >> On Tue, May 9, 2017 at 1:42 PM, Dave Page >> wrote: >> >>> This appears to have made Jenkins get all angry and red :-( >>> >>> https://jenkins.pgadmin.org/ >>> >> >> We(Neel and I) have tested it and working fine. >> > > It clearly doesn't compile on QT4. Please review the Jenkins logs. > > >> >>> >>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks patch applied. >>>> >>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: >>>> >>>>> Akshay, could you review this please? >>>>> >>>>> Thanks. >>>>> >>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>> neel.patel@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please find attached patch file with the fix of RM #2328 - [Runtime]: >>>>>> Unable to launch query tool and debugger in new browser tab. >>>>>> >>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>> >>>>>> https://github.com/annulen/webkit/releases >>>>>> >>>>>> >>>>>> As there was a bug in QWebKit regarding "unload" event. We have >>>>>> raised and also they have provided patch file to fix this issue. I have >>>>>> applied the patch in linux and compile the webkit and tested the attached >>>>>> patch with compiled webkit which is now working fine. >>>>>> >>>>>> Below is the link for reference regarding unload issue. They have >>>>>> provided test webkit release for Mac in below URL but for other platform we >>>>>> need to apply the patch and compile the webkit until they provide >>>>>> webkit-releases for all platforms. >>>>>> >>>>>> https://github.com/annulen/webkit/issues/519 >>>>>> >>>>>> Do review it and let me know in case of any issue. >>>>>> >>>>>> Thanks, >>>>>> Neel Patel >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> *Principal Software Engineer * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>> 976-788-8246 <+91%2097678%2088246>* >>>> >>> >>> >>> >>> -- >>> Dave Page >>> VP, Chief Architect, Tools & Installers >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > --94eb2c1896368aaf10054f13251f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Yes, It looks like compilation= fails on Qt4. We will fix this issue but which version of Qt4 we are using= in Jenkins ?

Thanks,
Neel Patel

On Tue, May 9= , 2017 at 1:56 PM, Dave Page <dave.page@enterprisedb.com><= /span> wrote:


On Tue= , May 9, 2017 at 9:18 AM, Akshay Joshi <akshay.joshi@enterpris= edb.com> wrote:
Hi

On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave.page@enterpri= sedb.com> wrote:
This = appears to have made Jenkins get all angry and red :-(

<= a href=3D"https://jenkins.pgadmin.org/" target=3D"_blank">https://jenkins.p= gadmin.org/

=C2=A0 = =C2=A0We(Neel and I) have tested it and working fine.=C2=A0=C2=A0

It clearly doesn'= t compile on QT4. Please review the Jenkins logs.
=C2=A0


On Tue, May 9, 2017 at = 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb.com&= gt; wrote:
Thanks patch applied= .

On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org&= gt; wrote:
Akshay, could you re= view this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@ente= rprisedb.com> wrote:
Hi,

Ple= ase find attached patch file with the fix of RM #2328 - [Runtime]: Unable t= o launch query tool and debugger in new browser tab.

I have used Qt 5.8 with webkit mentioned= in below URL.

<= div style=3D"font-size:12.8px">
As there was a bug in QWebKit regar= ding "unload" event. We have raised and also they have provided p= atch file to fix this issue. I have applied the patch in linux and compile = the webkit and tested the attached patch with compiled webkit which is now = working fine.

Below is the link for reference regarding unload issue. T= hey have provided test webkit release for Mac in below URL but for other pl= atform we need to apply the patch and compile the webkit until they provide= webkit-releases for all platforms.

Do review it and let me know in case of= any issue.

Thanks,
Neel Pat= el


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave PageBlog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0

<= font color=3D"#3333FF">
=



--
Dave Page
VP, Chief Architect, Tools & Installers
Enter= priseDB: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company

Bl= og: http://pgsnak= e.blogspot.com
Twitter: @pgsnake



--
Akshay Joshi=
Principal = Software Engineer=C2=A0





--
Dave Page
VP, Chief Architect, Tools= & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

--94eb2c1896368aaf10054f13251f--