MIME-Version: 1.0
From: Neel Patel <neel.patel@enterprisedb.com>
Date: Thu, 18 May 2017 20:12:17 +0530
Message-ID: 
 <CACCA4P0KyPQj=Q4EieTvs1JH=LTkvjHOTEZytbu-CFB+_L5zbQ@mail.gmail.com>
Subject: [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded
 server in runtime on Windows
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="94eb2c11ad18630d5b054fcd6927"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--94eb2c11ad18630d5b054fcd6927
Content-Type: multipart/alternative; boundary="94eb2c11ad18630d56054fcd6925"

--94eb2c11ad18630d56054fcd6925
Content-Type: text/plain; charset="UTF-8"

Hi Dave,

Please find attached patch for the fix of RM#2398 - "Proxy not bypassed for
embedded server in runtime on Windows".

*Observation:-*
We have observed this issue only with Qt WebEngine. We have not observed
this issue with Webkit ( Tested with Qt 5.3 ).

*Issue:-*
If user set option "Bypass proxy server for local addresses" then WebEngine
doesn't bypass the request for local addresses even if that option is set.

*Solution:-*
Now if user set option "Bypass proxy server for local addresses" then Web
Engine bypass the request for localhost and if user unset then request will
not be bypassed.

Please find attached fix for this issue. Do review and test it and let me
know for any issue.

Thanks,
Neel Patel

--94eb2c11ad18630d56054fcd6925
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Dave,<div><br></div><div>Please find attached patch for=
 the fix of RM#2398 - &quot;Proxy not bypassed for embedded server in runti=
me on Windows&quot;.</div><div><br></div><div><b><u>Observation:-</u></b></=
div><div>We have observed this issue only with Qt WebEngine. We have not ob=
served this issue with Webkit ( Tested with Qt 5.3 ).</div><div><br></div><=
div><b><u>Issue:-</u></b></div><div>If user set option &quot;<span style=3D=
"font-size:12.8px">Bypass proxy server for local addresses</span>&quot; the=
n WebEngine doesn&#39;t bypass the request for local addresses even if that=
 option is set.</div><div><br></div><div><b><u>Solution:-</u></b></div><div=
>Now if user set option &quot;<span style=3D"font-size:12.8px">Bypass proxy=
 server for local addresses</span>&quot; then Web Engine bypass the request=
 for localhost and if user unset then request will not be bypassed.</div><d=
iv><br></div><div>Please find attached fix for this issue. Do review and te=
st it and let me know for any issue.</div><div><br></div><div>Thanks,</div>=
<div>Neel Patel</div></div>

--94eb2c11ad18630d56054fcd6925--

--94eb2c11ad18630d5b054fcd6927
Content-Type: application/octet-stream; name="RM_2398.patch"
Content-Disposition: attachment; filename="RM_2398.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_j2udwt0h0

ZGlmZiAtLWdpdCBhL3J1bnRpbWUvcGdBZG1pbjQuY3BwIGIvcnVudGltZS9w
Z0FkbWluNC5jcHAKaW5kZXggYTJkYmU3NC4uODY1ZTZhZCAxMDA2NDQKLS0t
IGEvcnVudGltZS9wZ0FkbWluNC5jcHAKKysrIGIvcnVudGltZS9wZ0FkbWlu
NC5jcHAKQEAgLTMyNyw2ICszMjcsMTIgQEAgaW50IG1haW4oaW50IGFyZ2Ms
IGNoYXIgKiBhcmd2W10pCiAgICAgYnJvd3NlcldpbmRvdy5zZXRXaW5kb3dJ
Y29uKFFJY29uKCI6L3BnQWRtaW40LmljbyIpKTsKICAgICBicm93c2VyV2lu
ZG93LnNob3coKTsKIAorICAgIC8vIERpc2FibGUgcGxhdGZvcm0gc3BlY2lm
aWMgcHJveHkgc2V0dGluZ3MuCisgICAgLy8gVGhpcyBpcyByZXF1aXJlZCBm
b3IgUXRXZWJFbmdpbmUgb24gd2luZG93cyBwbGF0Zm9ybS4KKyAgICAvLyBJ
ZiB1c2VyIGhhcyBhbHJlYWR5IHNldCB0aGUgcHJveHkgc2VydmVyIHRoZW4g
IkJ5cGFzcyBwcm94eSBmb3IgbG9jYWxob3N0IgorICAgIC8vIG9wdGlvbnMg
aXMgcmVxdWlyZWQgdG8gZW5hYmxlIHRvIG1ha2UgdGhlIGFwcGxpY2F0aW9u
IHdvcmtpbmcuCisgICAgUU5ldHdvcmtQcm94eUZhY3Rvcnk6OnNldFVzZVN5
c3RlbUNvbmZpZ3VyYXRpb24oZmFsc2UpOworCiAgICAgLy8gR28hCiAgICAg
c3BsYXNoLT5maW5pc2goTlVMTCk7CiAgICAgcmV0dXJuIGFwcC5leGVjKCk7
Cg==

--94eb2c11ad18630d5b054fcd6927
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--94eb2c11ad18630d5b054fcd6927--