public inbox for [email protected]
help / color / mirror / Atom feedFrom: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: RM4292 - Dark mode support for Windows/macOS
Date: Thu, 9 Apr 2020 22:26:29 +0530
Message-ID: <CACCA4P0L-0PS_8-9i-sa4ECvH16kK6eJSgUcMHP57fTyzBHCBA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowhYTCS0g7q=9BVi-Nd0=++3dWugAeZQTRzEVikwSdosA@mail.gmail.com>
References: <CA+OCxoyiLYcN0N00nFPT9YCOFo8HT47rcoidccq2N5fDJFuqtQ@mail.gmail.com>
<CANxoLDdFpBpAg_V5r5M2ni9ycQzr-vhRkeQmMUfqEMYZXq-pZw@mail.gmail.com>
<CACCA4P1U8iLJWDM4_by0+HC9oPyUrrfArsu522FgWC6+sjjzWA@mail.gmail.com>
<CA+OCxowhYTCS0g7q=9BVi-Nd0=++3dWugAeZQTRzEVikwSdosA@mail.gmail.com>
Hi Dave,
On Thu, Apr 9, 2020 at 10:19 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Apr 9, 2020 at 2:28 PM Neel Patel <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I reviewed and tested the code on Windows and fixed below issues. Except
>> below, it looks good to me.
>>
>> - Compilation error on windows
>>
>> Oops, thanks.
>
>>
>> - In configuration window, "maximumSize" of the control is provided
>> along with "minimumSize" so it prevents control from expanding when the
>> user resizes the window. Removed maxSize and set as default.
>>
>> OK.
>
>
>> A Couple of points for discussion.
>>
>> - AFAIK - Users need to manually set the "AppsUseLightTheme" value in
>> the registry, right ? Do we need to document that somewhere ?
>>
>> No, it's an option if you go to personalise your desktop:
>
OK
>
> [image: Screenshot 2020-04-09 at 17.45.02.png]
>
>
>>
>> - As we have introduced 2 new "dark.qss" & "light.qss" files, so
>> during packaging we need to make sure that it should reside along with
>> "pgAdmin4" application binary otherwise those css will not be applied at
>> runtime. right ?
>>
>> Hmm, that's a good point. I'll look at that.
>
>>
>> - Checkbox is not visible in Configure window UI as per below
>> screenshot. Are you able to see on Mac ? If no, I can take a look at it.
>>
>> [image: Screenshot 2020-04-09 at 5.05.25 PM.png]
>>
>
> No, that works on Mac. If you can look at it that would be great (are the
> SVGs from the patch in your filesystem?):
>
Yes, all SVGs from the patch are there. I will take a look.
>
> [image: Screenshot 2020-04-09 at 17.47.39.png]
> Thanks!
>
>
>>
>> Attached is the updated patch.
>>
>> Thanks,
>> Neel Patel
>>
>> On Thu, Apr 9, 2020 at 11:12 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Neel,
>>>
>>> Can you please review/test it?
>>>
>>> On Wed, Apr 8, 2020 at 9:08 PM Dave Page <[email protected]> wrote:
>>>
>>>> The attached patch detects if dark mode is enabled on Windows
>>>> (10+)/macOS (10.14+) at server start, and styles the runtime accordingly.
>>>> It doesn't dynamically switch if the user changes their preferences.
>>>>
>>>> Linux builds continue to use the standard styling from Qt.
>>>>
>>>> NOTE: I've tested this on macOS, but my Windows build system is playing
>>>> up at the moment. Akshay, can you have someone on your team test it please?
>>>> I believe the code should work; it's just a case of reading a reg key and
>>>> then doing the same thing as on macOS to set the theme accordingly.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachments:
[image/png] Screenshot 2020-04-09 at 5.05.25 PM.png (74.0K, 3-Screenshot%202020-04-09%20at%205.05.25%20PM.png)
download | view image
[image/png] Screenshot 2020-04-09 at 17.45.02.png (103.6K, 4-Screenshot%202020-04-09%20at%2017.45.02.png)
download | view image
[image/png] Screenshot 2020-04-09 at 17.47.39.png (398.3K, 5-Screenshot%202020-04-09%20at%2017.47.39.png)
download | view image
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: RM4292 - Dark mode support for Windows/macOS
In-Reply-To: <CACCA4P0L-0PS_8-9i-sa4ECvH16kK6eJSgUcMHP57fTyzBHCBA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox