Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw2GI-0003h9-SL for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Apr 2016 06:50:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aw2GH-000059-St for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Apr 2016 06:50:49 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aw2GF-0008WI-Eg for pgadmin-hackers@postgresql.org; Fri, 29 Apr 2016 06:50:47 +0000 Received: from mail-yw0-x234.google.com ([2607:f8b0:4002:c05::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aw2G7-00037v-72 for pgadmin-hackers@postgresql.org; Fri, 29 Apr 2016 06:50:46 +0000 Received: by mail-yw0-x234.google.com with SMTP id t10so168799166ywa.0 for ; Thu, 28 Apr 2016 23:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=zbiM0GB5HHvkWN26/s13ekdGTVR0RTuEMwtCOPBW56A=; b=SFdolkX0pjgEOGS0bbHagxoOjGg5ANynwGXqBzVjh0yoE7G0OS9b+PVZZ7UaW3hSk9 NrvqfzFDTAWQ4ufbYW0ANYPoj9mQDekLblpgwpRD5nXlQ1iomU6uUSBMoOyxb/ytAxA4 7D2WBcxs1Hs96nLeqldnIkmgezrrzkGv0pm3BmfX1W4734JQ9n+01xLPX8vQe64G1Wti BwfWA1ZzExIk0M9ItbWoJcXYEF4Gf7uWjCVm19QY6Y17DiwXPaM5agearghMhTSqq96t Ot69n8Mc8EtYiZrwWZt11px4K5MeotleM9YWZpYj+oykMtYUTwPXUCRlZn0jCMGSnWrF 5T8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=zbiM0GB5HHvkWN26/s13ekdGTVR0RTuEMwtCOPBW56A=; b=l47kvGiGcDM1p7Ah6MblX0J2X9YaSZY3lDs3cBlZ8vbWbp4KfDT4VQ7JfeFIGnVrxE qkDIUmE8gysgxAXrOqPhKbifhkBG45H6cNMi92oCNkUO0O3tidHk9eG1abUqiRCmpF4j c0MS3/o9kFS20wA5d3yxae3Ss+QGh01hv9KRfONeqDnzJk+FqK5SCmla5U39ijASiaIz Oik6JHj0FBwOZ5Icq5KMhinzib/Z1WW+OAamXha35TJV4ptKXqh0gYl6xenFrjxbmWYD T5zEAR/da0Ty3FFPacdn29jqdWjtAVNmY7R5/5c1HMUcFJVYVvLxVupsVidYxBE+0oB4 oL6g== X-Gm-Message-State: AOPr4FUrK0HEnKQ0eA1PdoGBS4qh66j8VBMSg+JvxXQDk5zGQ3Tusu/Cnt/UoiSqQo6tfRZoJigmdv5C9pj8sczb MIME-Version: 1.0 X-Received: by 10.129.83.213 with SMTP id h204mr10544515ywb.276.1461912638146; Thu, 28 Apr 2016 23:50:38 -0700 (PDT) Received: by 10.37.203.134 with HTTP; Thu, 28 Apr 2016 23:50:38 -0700 (PDT) In-Reply-To: References: Date: Fri, 29 Apr 2016 12:20:38 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Foreign Table Module From: Neel Patel To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114d8e167d7bc805319a0f2f X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114d8e167d7bc805319a0f2f Content-Type: text/plain; charset=UTF-8 Hi Khushboo, Below are the observations. - When we create the new Foreign Table with column name and types then it shows NULL along with column name and type in properties tab. e.g. column_1 xml[] NULL - Once we inherits the table from another table then column and another parameters of inherited table should not allowed to change. - When we create any foreign table then same foreign table is also listed under "Tables" node. - SQL is not generated properly. Please find below SQL which gives error during execution. CREATE FOREIGN TABLE public.test_2 (id1 integer NOT NULL DEFAULT12 COLLATEpg_catalog."POSIX") SERVER fsrv; - When we create the new foreign table with security label then no SQL is generated for security label. - In Edit mode, when we provide security label with both value "provider" and "security label" then security label is displayed NULL e.g. SECURITY LABEL FOR frgn_table ON FOREIGN TABLE public.fsrv_table IS NULL; - During creation of the column, when we remove the collation then it gives below error. TypeError: item is undefined - Delete/Drop cascade functionality is not working, we are getting below error. TypeError: self.canDrop.apply is not a function - When we edit the foreign table and try to remove the existing "Data Type" of column then it gives below error. TypeError: this.dataAdapter is null - Create the new foreign table and click on ADD button in Column tab and do not provide any column name and data type. Need to do proper validation in Column tab for all parameters. Currently if user do not provide any value then wrong SQL is getting generated. CREATE FOREIGN TABLE public.test_4 (None None NULL) SERVER test_fsrv; - When we do not provide the Check parameters in constraint then it gives SQL syntax error. CREATE FOREIGN TABLE public.test_5 () SERVER test_fsrv; ALTER FOREIGN TABLE public.test_5 ADD CONSTRAINT test CHECK () NOT VALID; - If we edit foreign table and change the schema then it gives below error. IndexError: list index out of range - We should have proper indentation in the SQL tab once we give the parameters. Currently it looks like below for "Options" value. CREATE FOREIGN TABLE "1_test"."5_test" () SERVER asas OPTIONS (test1 'test2' , test3 'test4'); - If user provide foreign table name and do not provide foreign server and click on SQL tab then we are getting error on browser side as below. We should have proper error handling in this case. Couldn't find the required parameter (ftsrvname). - Create the foreign table, add the constraint and do not provide any constraint information then SQL generated is wrong. CREATE FOREIGN TABLE "1_test"."9_test" () SERVER test_fsrv; ALTER FOREIGN TABLE "1_test"."9_test" ADD CONSTRAINT None CHECK (); - When we click on the foreign table collection node then "Comment" column is blank even though we have comment in the foreign table. - Create the foreign table on PG 9.1 and after pressing Save button we are getting below error. "the JSON object must be str, not 'list'" - When we delete the options parameters then it gives SQL error because DROP statement does not include the value. ALTER FOREIGN TABLE public.test_12 OPTIONS ( DROP ser2 'val2'); - There are some new functionality added in PG 9.5. Do we really need to implement ? Need to discuss with Dave/Ashesh. Below are the new functionality. - In create foreign table,we have added column constraint but "table constraint" is added from 9.5.Do we really require to add table constraint ? - In alter foreign table, below are the new functionality added. 1. ALTER [ COLUMN ] column_name SET STORAGE { PLAIN | EXTERNAL | EXTENDED | MAIN } 2. DISABLE TRIGGER [ trigger_name | ALL | USER ] 3. ENABLE TRIGGER [ trigger_name | ALL | USER ] 4. ENABLE REPLICA TRIGGER trigger_name 5. ENABLE ALWAYS TRIGGER trigger_name 6. SET WITH OIDS 7. SET WITHOUT OIDS Do let us know in case of any queries. Thanks, Neel Patel On Tue, Apr 5, 2016 at 2:27 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find updated patch for the Foreign Table Module. > > This patch is dependent on > 1. Backgrid Depscell Patch, (submitted by me) > 2. NodeAjaxOptionsCell Transform change patch, on which Ashesh and Murtuza > are working > > Thanks, > Khushboo > > > > > On Wed, Feb 24, 2016 at 2:57 PM, Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi, >> >> I have updated the Foreign Table module as below: >> >> - Used 'NodeByListControl' to get schemas, in the foreign_table.js file >> as suggested by Ashesh to avoid code redundancy. >> >> - Applied *'Security Label Macro'* Patch (Implemented by Harshal). >> To test the Foreign Table patch, 'Security Label Macro' patch must be >> applied first as that is not committed yet. >> >> Please find attached Foreign Table Patch. >> >> Thanks, >> Khushboo >> >> On Tue, Feb 23, 2016 at 6:53 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find attached patch for the Foreign Table Module. >>> >>> The patch will be modified after Types module implementation as we need >>> to populate Base Type and some Type related validations from the Types >>> module. >>> >>> Please review it and let me know the feedback. >>> >>> Thanks, >>> Khushboo >>> >> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a114d8e167d7bc805319a0f2f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Khushboo,

Below are the observations= .
  • When we create the new Foreign Table with column name a= nd types then it shows NULL along with column name and type in properties t= ab.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0e.g.=C2= =A0column_1 xml[] NULL=C2=A0
  • Once we inherits the table from a= nother table then column and another parameters of inherited table should n= ot allowed to change.
  • When we create any foreign table then same fo= reign table is also listed under "Tables" node.
  • SQL is no= t generated properly. Please find below SQL which gives error during execut= ion.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CREATE FOREIGN = TABLE public.test_2
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(id1= integer NOT NULL DEFAULT12 COLLATEpg_catalog."POSIX")
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SERVER fsrv;
  • When we create the new foreign table with security label t= hen no SQL is generated for security label.
  • In Edit mode, when we p= rovide security label with both value "provider" and "securi= ty label" then security label is displayed NULL
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 e.g.=C2=A0 SECURITY LABEL FOR frgn_table= ON FOREIGN TABLE public.fsrv_table IS NULL;
  • Du= ring creation of the column, when we remove the collation then it gives bel= ow error.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0TypeError: item is undefined
  • Delete/Drop casc= ade functionality is not working, we are getting below error.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0TypeError: self.can= Drop.apply is not a function
  • When we edit the f= oreign table and try to remove the existing "Data Type" of column= then it gives below error.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 TypeError: this.dataAdapter is null
<= ul>
  • Create the new foreign table and click on ADD button in Column tab a= nd do not provide any column name and data type. Need to do proper validati= on in Column tab for all parameters. Currently if user do not provide any v= alue then wrong SQL is getting generated.
    • =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0CREATE FOREIGN TABLE public.test_4
    =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(None None NULL)
    =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 SERVER test_fsrv;
    <= div>
    • When we do not provide the Check parameters in constraint then = it gives SQL syntax error.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0CREATE FOREIGN TABLE public.test_5
    =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0()
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0SERVER test_fsrv;

    =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ALTER FOREIGN TABLE public.test_5
    =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ADD CONSTRAINT test CHECK () NOT VAL= ID;
    • If we edit foreign table and change the s= chema then it gives below error.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 IndexError: list index out of range
    • We should have proper indentation in the SQL tab once we give the= parameters. Currently it looks like below for "Options" value.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 CREATE FOREIGN = TABLE "1_test"."5_test"
    =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ()
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 SERVER asas
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 OPTIONS (test1 'test2'
    =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 , test3 'test4');
    • If user provide foreign table name and do not provide foreign serv= er and click on SQL tab then we are getting error on browser side as below.= We should have proper error handling in this case.
    =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Couldn't find the required= parameter (ftsrvname).
    • Create the foreign ta= ble, add the constraint and do not provide any constraint information then = SQL generated is wrong.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0CREATE FOREIGN TABLE "1_test"."9_test"
    <= div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0()
    =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0SERVER test_fsrv;

    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTER FOREIGN TABLE "1_test&q= uot;."9_test"
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 ADD CONSTRAINT None CHECK ();
    • When we= click on the foreign table collection node then "Comment" column= is blank even though we have comment in the foreign table.
    • Create = the foreign table on PG 9.1 and after pressing Save button we are getting b= elow error.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 "the JSON object must be str, not 'list'"
    • When we delete the options parameters then it gives SQL= error because DROP statement does not include the value.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTER FOREIGN TABLE publ= ic.test_12
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 OPTIONS ( DROP ser2 'val2');
      <= li>There are some new functionality added in PG 9.5. Do we really need to i= mplement ? Need to discuss with Dave/Ashesh. Below are the new functionalit= y.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0- I= n create foreign table,we have added column constraint but "table cons= traint" is added from 9.5.Do we really r= equire to add table constraint ?
    =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0- In alter foreign table, below are the new = functionality added.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01.=C2=A0 ALTER [ COLUMN ] column_name SET= STORAGE { PLAIN | EXTERNAL | EXTENDED | MAIN }
    =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A02.=C2=A0 DISABLE= TRIGGER [ trigger_name | ALL | USER ]
    =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A03.=C2=A0 ENABLE TRIGGER= [ trigger_name | ALL | USER ]
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A04.=C2=A0 ENABLE REPLICA TRIGGER t= rigger_name
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A05.=C2=A0 ENABLE ALWAYS TRIGGER trigger_name
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A06.=C2=A0 SET WITH OIDS
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A07.=C2=A0 SET WITHOUT OIDS

    Do let us know in case of any queries.

    Thanks,
    Neel Patel
    On Tue, Apr 5, 2016 at 2:27 PM, Khushboo Vashi= <khushboo.vashi@enterprisedb.com> wrote:
    <= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
    Hi,

    Pleas= e find updated patch for the Foreign Table Module.

    This patch is dependent on=C2=A0
    1. Backgrid Depscell Patch, (su= bmitted by me)
    2. NodeAjaxOptionsCell Transform change patch, on = which Ashesh and Murtuza are working

    Thanks,
    =
    Khushboo




    On Wed, Feb 24, 2016 at 2:57 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
    Hi,

    I= have updated the Foreign Table module as below:

    - = Used 'NodeByListControl' to get schemas, in the foreign_table.js fi= le as suggested by Ashesh to avoid code redundancy.

    - Applied = 'Security Label Macro'=C2=A0 Patch (Implemented by Harshal)= .
    =C2=A0 To test the Foreign Table patch, 'Security Label Macro'= ; patch must be applied first as that is not committed yet.
    <= br>
    Please find attached Foreign Table Patch.

    T= hanks,
    Khushboo

    On Tue, Feb 23, 2016 at 6:53 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
    Hi,

    Please find attached p= atch for the Foreign Table Module.

    The patch will be modified after = Types module implementation as we need to populate Base Type=C2=A0 and some= Type related validations from the Types module.

    Please review it an= d let me know the feedback.

    Thanks,
    Khushboo




    --
    Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
    To make changes to your subscription:
    http://www.postgresql.org/mailpref/pgadmin-hackers=


    --001a114d8e167d7bc805319a0f2f--