MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D8hPH9Hj8mAq+XorWvV7N4xKn5g3PCUj-x6UhhCReiPmQ@mail.gmail.com>
References: 
 <CAM5-9D8hPH9Hj8mAq+XorWvV7N4xKn5g3PCUj-x6UhhCReiPmQ@mail.gmail.com>
Date: Sun, 24 Jan 2016 19:23:00 +0530
Message-ID: 
 <CACCA4P0dr2MoPHRX_Px3UroVBd3UJ8m2VEC2DGmCy1wogDQjTw@mail.gmail.com>
Subject: Re: [pgAdmin3][Extension]: Wrong SQL generated
From: Neel Patel <neel.patel@enterprisedb.com>
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary=001a1146de543fa1b0052a14c5a0
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a1146de543fa1b0052a14c5a0
Content-Type: multipart/alternative; boundary=001a1146de543fa1a9052a14c59e

--001a1146de543fa1a9052a14c59e
Content-Type: text/plain; charset=UTF-8

Hi,

Please find attached patch file for the issue mentioned below.

*Issue:- *
When user "Edit" any existing extension module property, and try to change
the schema and version field to blank then SQL should not be generated for
the blank field.

Above issue is fixed with attached patch file.

Do review it and let us know for any comments.

Thanks,
Neel Patel

On Mon, Jan 18, 2016 at 4:33 PM, Surinder Kumar <
surinder.kumar@enterprisedb.com> wrote:

> Hi all,
>
>
> While implementing Extension module in pgAdmin4, I came to know that there
> is an bug in pgadmin3.
>
> Following are the steps to reproduce it:
> 1. Edit an existing extension.
> 2. In definition tab, set schema and version fields to empty.
> 3. In SQL tab, it generates an sql for the changes made which is wrong, it
> shouldn't generate sql for the schema and version field if it is kept
> empty, both fields should be validated.
>
>
> Below is the wrong SQL generated:
>
> *ALTER EXTENSION btree_gin*
> *  SET SCHEMA ;*
> *ALTER EXTENSION btree_gin*
> *  UPDATE TO ;*
>
>
> Let me know for any comments.
>
> Thanks
> Surinder Kumar
>

--001a1146de543fa1a9052a14c59e
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>Please find attached patch file for=
 the issue mentioned below.</div><div><br></div><div><b>Issue:-=C2=A0</b></=
div><div>When user &quot;Edit&quot; any existing extension module property,=
 and try to change the schema and version field to blank then SQL should no=
t be generated for the blank field.</div><div><br></div><div>Above issue is=
 fixed with attached patch file.</div><div><br></div><div>Do review it and =
let us know for any comments.</div><div><br></div><div>Thanks,</div><div>Ne=
el Patel</div></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quot=
e">On Mon, Jan 18, 2016 at 4:33 PM, Surinder Kumar <span dir=3D"ltr">&lt;<a=
 href=3D"mailto:surinder.kumar@enterprisedb.com" target=3D"_blank">surinder=
.kumar@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail=
_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:=
1ex"><div dir=3D"ltr">Hi all,<div><br></div><div><br><div>While implementin=
g Extension module in pgAdmin4, I came to know that there is an bug in pgad=
min3.</div><div><br></div><div>Following are the steps to reproduce it:</di=
v><div>1. Edit an existing extension.</div><div>2. In definition tab, set s=
chema and version fields to empty.</div><div>3. In SQL tab, it generates an=
 sql for the changes made which is wrong, it shouldn&#39;t generate sql for=
 the schema and version field if it is kept empty, both fields should be va=
lidated.</div><div><br></div><div><br></div><div>Below is the wrong SQL gen=
erated:</div><div><br></div><div><div><b style=3D"background-color:rgb(255,=
255,255)">ALTER EXTENSION btree_gin</b></div><div><b style=3D"background-co=
lor:rgb(255,255,255)">=C2=A0 SET SCHEMA ;</b></div><div><b style=3D"backgro=
und-color:rgb(255,255,255)">ALTER EXTENSION btree_gin</b></div><div><b styl=
e=3D"background-color:rgb(255,255,255)">=C2=A0 UPDATE TO ;</b></div></div><=
div><b style=3D"background-color:rgb(255,255,255)"><br></b></div><div><b st=
yle=3D"background-color:rgb(255,255,255)"><br></b></div><div>Let me know fo=
r any comments.</div><div><b style=3D"background-color:rgb(255,255,255)"><b=
r></b></div><div>Thanks</div><span class=3D"HOEnZb"><font color=3D"#888888"=
><div>Surinder Kumar</div></font></span></div></div>
</blockquote></div><br></div>

--001a1146de543fa1a9052a14c59e--

--001a1146de543fa1b0052a14c5a0
Content-Type: application/octet-stream; name="extension_fix.patch"
Content-Disposition: attachment; filename="extension_fix.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ijslujtv0

ZGlmZiAtLWdpdCBhL3BnYWRtaW4vZGxnL2RsZ0V4dGVuc2lvbi5jcHAgYi9w
Z2FkbWluL2RsZy9kbGdFeHRlbnNpb24uY3BwCmluZGV4IGNmYTYyYTMuLjdj
MjM2MmUgMTAwNjQ0Ci0tLSBhL3BnYWRtaW4vZGxnL2RsZ0V4dGVuc2lvbi5j
cHAKKysrIGIvcGdhZG1pbi9kbGcvZGxnRXh0ZW5zaW9uLmNwcApAQCAtMTgw
LDEwICsxODAsMTAgQEAgd3hTdHJpbmcgZGxnRXh0ZW5zaW9uOjpHZXRTcWwo
KQogCWlmIChleHRlbnNpb24pCiAJewogCQkvLyBlZGl0IG1vZGUKLQkJaWYg
KGNiT2JqZWN0c1NjaGVtYS0+R2V0VmFsdWUoKSAhPSBleHRlbnNpb24tPkdl
dFNjaGVtYVN0cigpKQorCQlpZiAoIWNiT2JqZWN0c1NjaGVtYS0+R2V0VmFs
dWUoKS5Jc0VtcHR5KCkgJiYgY2JPYmplY3RzU2NoZW1hLT5HZXRWYWx1ZSgp
ICE9IGV4dGVuc2lvbi0+R2V0U2NoZW1hU3RyKCkpCiAJCQlzcWwgKz0gd3hU
KCJBTFRFUiBFWFRFTlNJT04gIikgKyBxdElkZW50KGV4dGVuc2lvbi0+R2V0
TmFtZSgpKQogCQkJICAgICAgICsgIHd4VCgiXG4gIFNFVCBTQ0hFTUEgIikg
KyBxdElkZW50KGNiT2JqZWN0c1NjaGVtYS0+R2V0VmFsdWUoKSkgKyB3eFQo
IjtcbiIpOwotCQlpZiAoY2JWZXJzaW9uLT5HZXRWYWx1ZSgpICE9IGV4dGVu
c2lvbi0+R2V0VmVyc2lvbigpKQorCQlpZiAoIWNiVmVyc2lvbi0+R2V0VmFs
dWUoKS5Jc0VtcHR5KCkgJiYgY2JWZXJzaW9uLT5HZXRWYWx1ZSgpICE9IGV4
dGVuc2lvbi0+R2V0VmVyc2lvbigpKQogCQkJc3FsICs9IHd4VCgiQUxURVIg
RVhURU5TSU9OICIpICsgcXRJZGVudChleHRlbnNpb24tPkdldE5hbWUoKSkK
IAkJCSAgICAgICArICB3eFQoIlxuICBVUERBVEUgVE8gIikgKyBxdElkZW50
KGNiVmVyc2lvbi0+R2V0VmFsdWUoKSkgKyB3eFQoIjtcbiIpOwogCX0K

--001a1146de543fa1b0052a14c5a0
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--001a1146de543fa1b0052a14c5a0--