Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d81RR-0004Tr-Bf for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 09:28:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d81RQ-0006Zm-AW for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 09:28:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d81RA-0005gB-0l for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 09:28:08 +0000 Received: from mail-pf0-x22b.google.com ([2607:f8b0:400e:c00::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d81R6-0000On-8g for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 09:28:06 +0000 Received: by mail-pf0-x22b.google.com with SMTP id e193so23908465pfh.0 for ; Tue, 09 May 2017 02:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KcS2QU6feB6qws9hFgauJS5koblnOdghAnMrDz9lv5A=; b=TiqAcFGd6jGwt/7lDCkUIYlgfVGOxIuhV+VfUOqZxZsEUBeC7deUxqsa1hop6TftLe 8kzb/C8uowJZr7yYgRWLHQBBZh3FKb4NzUdQUiNiWvPldgrWlsozjh2mkYjS2yGQqa+O QmAAJiiZx6nzQ4yRnhgzqlGtANQUS58mqgQgDMthnEw650RC3nnr7bLcaOrHulckektg 10mhHpjfybMCoaCIXwgmOlXBKcwByir0qZCFhjc1E7OrnjvELVugu17q0kaJm/Yol1Z3 /f/BDO90VDhzyM+WOQDHFWWiniVlgQp4BXUJPYSG0jRuQNOaddDxa7H28P16v6W9S2OD cWsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KcS2QU6feB6qws9hFgauJS5koblnOdghAnMrDz9lv5A=; b=bvHm4VrFsJ6F7eqqkaGtQGsOI2iWQrVOxD8cYcQB9OEla4JwR3XBtUPpWBWyXTBUh2 bl65jtMI3hvTv4q4HoUQvkw3IDm61GIAYcUoHydfxqRej+h42j8WatjZ/1xtcRoOnGFI 09qmpl7+LqjsGA1gLDL/luUfXWNZPJG1UJc97HQMdwirHHcmqemojWuQXErHdS2fYkcK mWrbw3RdMKLM864mxY4T5jtNhSD/DD2XI7QiXioaXzgbNR3XCMBxMdG5PuWr35N9kxAn ER1oGQ5QjcT0kl/3Yv3HP0XEOkuGbFo5Xo+b+2Kt+Wgbc08AD5GAGRkXIdAsLr/jcKg3 30vQ== X-Gm-Message-State: AODbwcCiLnnzmE/VJl9911zLTkysi9pTLXRqk8ijAi0hsm2A3qQrSIz0 fP2mmRJ0I3EKQqjnZnci0xxrlg+QPQmYGs4= X-Received: by 10.84.216.21 with SMTP id m21mr11219853pli.116.1494322083122; Tue, 09 May 2017 02:28:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.137.16 with HTTP; Tue, 9 May 2017 02:28:02 -0700 (PDT) In-Reply-To: References: From: Neel Patel Date: Tue, 9 May 2017 14:58:02 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=f403045c69a2f1e242054f13f87e X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --f403045c69a2f1e242054f13f87e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Dave, Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' related compilation error in Qt4. BUT Below compilation error is coming because we have not applied the latest patch of webkit which was fixed in annulen/webkit repo which was raised at below path. https://github.com/annulen/webkit/issues/519 BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a me= mber of =E2=80=98QWebPage=E2=80=99 webviewPtr->page()->triggerAction(QWebPage::RequestClose); To fix the above compilation error currently we have two solution. - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) . - Comment the below line temporary for compilation until we get the releases from annulen/webkit. webviewPtr->page()->triggerAction(QWebPage::RequestClose); Other compilation issues, (Me and Akshay) will fix and commit it but need your input on above issue. Thanks, Neel Patel On Tue, May 9, 2017 at 2:02 PM, Dave Page wrote: > It's running CentOS 7.3, with packages from EPEL: > > [dpage@jenkins ~]$ rpm -qa |grep qt > qt5-qtbase-common-5.6.1-10.el7.noarch > qt5-qtbase-devel-5.6.1-10.el7.x86_64 > qt-4.8.5-13.el7.x86_64 > qt5-qtbase-5.6.1-10.el7.x86_64 > qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 > qt5-qtwebchannel-5.6.1-10.el7.x86_64 > qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 > qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 > qt-devel-4.8.5-13.el7.x86_64 > qt-settings-19-23.5.el7.centos.noarch > qt5-qtbase-gui-5.6.1-10.el7.x86_64 > qt5-qtlocation-5.6.1-10.el7.x86_64 > qt5-qtwebsockets-5.6.1-10.el7.x86_64 > qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 > qtwebkit-2.3.4-6.el7.x86_64 > qt3-3.3.8b-51.el7.x86_64 > qt5-qtdeclarative-5.6.1-10.el7.x86_64 > qt5-rpm-macros-5.6.1-10.el7.noarch > qtwebkit-devel-2.3.4-6.el7.x86_64 > qt-x11-4.8.5-13.el7.x86_64 > qt5-qtsensors-5.6.1-10.el7.x86_64 > > On Tue, May 9, 2017 at 9:28 AM, Neel Patel > wrote: > >> Hi Dave, >> >> Yes, It looks like compilation fails on Qt4. We will fix this issue but >> which version of Qt4 we are using in Jenkins ? >> >> Thanks, >> Neel Patel >> >> On Tue, May 9, 2017 at 1:56 PM, Dave Page >> wrote: >> >>> >>> >>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi >>>> >>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page >>>> wrote: >>>> >>>>> This appears to have made Jenkins get all angry and red :-( >>>>> >>>>> https://jenkins.pgadmin.org/ >>>>> >>>> >>>> We(Neel and I) have tested it and working fine. >>>> >>> >>> It clearly doesn't compile on QT4. Please review the Jenkins logs. >>> >>> >>>> >>>>> >>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Thanks patch applied. >>>>>> >>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: >>>>>> >>>>>>> Akshay, could you review this please? >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>>>> neel.patel@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Please find attached patch file with the fix of RM #2328 - >>>>>>>> [Runtime]: Unable to launch query tool and debugger in new browser= tab. >>>>>>>> >>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>> >>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>> >>>>>>>> >>>>>>>> As there was a bug in QWebKit regarding "unload" event. We have >>>>>>>> raised and also they have provided patch file to fix this issue. I= have >>>>>>>> applied the patch in linux and compile the webkit and tested the a= ttached >>>>>>>> patch with compiled webkit which is now working fine. >>>>>>>> >>>>>>>> Below is the link for reference regarding unload issue. They have >>>>>>>> provided test webkit release for Mac in below URL but for other pl= atform we >>>>>>>> need to apply the patch and compile the webkit until they provide >>>>>>>> webkit-releases for all platforms. >>>>>>>> >>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>> >>>>>>>> Do review it and let me know in case of any issue. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Neel Patel >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Akshay Joshi* >>>>>> *Principal Software Engineer * >>>>>> >>>>>> >>>>>> >>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> VP, Chief Architect, Tools & Installers >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> *Principal Software Engineer * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>> 976-788-8246 <+91%2097678%2088246>* >>>> >>> >>> >>> >>> -- >>> Dave Page >>> VP, Chief Architect, Tools & Installers >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >> >> > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > --f403045c69a2f1e242054f13f87e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Here there are 2 compilation i= ssue. We have fixed 'QNetworkCookieJar' related compilation error i= n Qt4. BUT

Below compilation error is coming becau= se we have not applied the latest patch of webkit which was fixed in annule= n/webkit repo which was raised at below path.


BrowserWindow.cpp:= 842:59: error: =E2=80=98RequestClose=E2=80=99 is not a member of =E2=80=98Q= WebPage=E2=80=99
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->trigger= Action(QWebPage::RequestClose);

To fix the a= bove compilation error currently we have two solution.
  • Ap= ply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .
    • =
  • Comment the below line temporary for compilation until we get the relea= ses from annulen/webkit.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->triggerAction(QWebPage::Reque= stClose);

Other compilation issues, (Me = and Akshay) will fix and commit it but need your input on above issue.

Thanks,
Neel Patel

On Tue, May 9, 2017 at 2:02 PM,= Dave Page <dave.page@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
It's running CentOS 7.3,= with packages from EPEL:

[dpage@jenkins ~]$ rpm -q= a |grep qt
qt5-qtbase-common-5.6.1-10.el7.noarch
q= t5-qtbase-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
qt5-qtbase-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5.6.1-1= 0.el7.x86_64
qt5-qtwebchannel-5.6.1-10.el7.x86_64
=
qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
qt5-qtdeclar= ative-devel-5.6.1-10.el7.x86_64
qt-devel-4.8.5-13.el7.x86_64=
qt-settings-19-23.5.el7.centos.noarch
qt5-qtbase-= gui-5.6.1-10.el7.x86_64
qt5-qtlocation-5.6.1-10.el7.x86= _64
qt5-qtwebsockets-5.6.1-10.el7.x86_64
qt5-qtweb= kit-devel-5.6.1-3.b889f46git.el7.x86_64
qtwebkit-2.3.4-6.el7= .x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.= 1-10.el7.x86_64
qt5-rpm-macros-5.6.1-10.el7.noarch
qtwebkit-devel-2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.= x86_64
qt5-qtsensors-5.6.1-10.el7.x86_64

On Tue, May 9, 2017 at 9:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, It looks li= ke compilation fails on Qt4. We will fix this issue but which version of Qt= 4 we are using in Jenkins ?

Thanks,
Neel= Patel

On Tue, May 9, 2017 at 1:56 PM, Dave Page <<= a href=3D"mailto:dave.page@enterprisedb.com" target=3D"_blank">dave.page@en= terprisedb.com> wrote:


= On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <akshay.jos= hi@enterprisedb.com> wrote:
Hi

On Tue, May 9, 2017 at 1:42 PM, Dave Page &= lt;dave.pag= e@enterprisedb.com> wrote:
This appears to have made Jenkins get all angry and red :-(

= =C2=A0 =C2=A0We(Neel and I) have tested it and working fine.=C2=A0=C2=A0

It clearly doe= sn't compile on QT4. Please review the Jenkins logs.
=C2=A0
=

On Tue, May 9, 2017 at 8:39 AM, Aksh= ay Joshi <akshay.joshi@enterprisedb.com> wr= ote:
Thanks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave= Page <dpage@pgadmin.org> wrote:
Akshay, could you review this please?

Thanks.<= /div>

<= div class=3D"m_-2016239111006808430m_-674534015089129385m_-2183617756405375= 713m_4373938761770165468gmail-m_-8604497720299585725m_6017984602102400325h5= ">On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterp= risedb.com> wrote:
Hi,

Please find attached patch file with = the fix of RM #2328 - [Runtime]: Unable to launch query tool and debugger i= n new browser tab.

I have used Qt 5.8 with webkit mentioned in below URL.


As there was a bug in QWebKit regarding "unload" event. We = have raised and also they have provided patch file to fix this issue. I hav= e applied the patch in linux and compile the webkit and tested the attached= patch with compiled webkit which is now working fine.

Below is the lin= k for reference regarding unload issue. They have provided test webkit rele= ase for Mac in below URL but for other platform we need to apply the patch = and compile the webkit until they provide webkit-releases for all platforms= .

https://github.com/annulen/webkit/issues/519

Do review it and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--
= Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB = UK: http://www.en= terprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer= =C2=A0

=

+91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
= VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



=
--
Akshay Joshi=
Principal Software Engineer=C2=A0


<= b>Phone: +91 20-3058-9517
Mobile: <= a href=3D"tel:+91%2097678%2088246" value=3D"+919767888246" target=3D"_blank= ">+91 976-788-8246



--
Dave Page
VP, Chief Archi= tect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake




--
=
Dave Page
VP, Chief Architect, Tools & Installers
En= terpriseDB: http:= //www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog= : http://pgsnake.= blogspot.com
Twitter: @pgsnake

--f403045c69a2f1e242054f13f87e--