Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8LFO-0000GI-GJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 06:37:18 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8LFN-0001T1-DB for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 06:37:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8LF6-0008Ej-0I for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 06:37:00 +0000 Received: from mail-pg0-f45.google.com ([74.125.83.45]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8L9S-0007I7-Sk for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 06:31:24 +0000 Received: by mail-pg0-f45.google.com with SMTP id u187so11527923pgb.0 for ; Tue, 09 May 2017 23:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NKMh6XEH2KGCj9QiAl2UDNOkhKktHvEunvLcX0MLMZQ=; b=Tgxo7su/6ice+mJ4NuE8JovwROCVZIjZxajlI3bCB6nFWxvpuEyCXEg3TNZvIR34o3 /uvI4IkVryS+qfmMXffdnG+NmQc8flO6JI093Utcw6iWfi4BMX1HMoY/ci2Y7OUCMrti YUo5jBfVfbjrAFHrKpA/0o9BR+LWVI+owTppRzngWMxJdZCMF7eLAKO77YMODmIiHGrJ jGY4owWqNj2EcFqLJ8FKBi4DdkO1xis47pHWSUiX47o1TLVR3QHJAwEPioeT53B+zXAN H2PiNmq+ivg1DDGXsIW8hLXAkn2HymGu4sX29p9CY8Shr17ncHLsx91wOaJmBQMfnseW MAYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NKMh6XEH2KGCj9QiAl2UDNOkhKktHvEunvLcX0MLMZQ=; b=GBSCa8OV8krR+SdeMctsKM9KB4sPHo/6siup8k8QfGMIxfeW7PfZ5EXLLcsCjtx/Wa gcXcclCZHUfUxm8OYgtZ34Clo1gEnO98PGtVT4utlDSRRtvHhKWnV3rPlnGTlD8/e+rd XUw1fWRnNkReQrC8n9H3MWSmWMdiWnQ2Pr2e3E7mwLsVFd4FNQqdoIYl8LChZKHgTkOF ej4+OxchWcorcBb5r5SSrhHAEttgOI2JZuHCCCvzLGWbLCWtBdEhNcGiEuaUTTsoa6yd LY0rX9cPOQ+R4LLJ++JLJ0+p2MFDHRoAosmj0dbavey2ICobtY9AwsPKygYRyCkCtRqD o08w== X-Gm-Message-State: AODbwcDMbe5cT7lhsI1s/b28NmRFI9NoWEH1OR/dlb2yYvW9MGYaKric G2SMQw3drd1zTx1nCu5Wqc9Ftp4n/SNK X-Received: by 10.98.193.65 with SMTP id i62mr4362976pfg.134.1494397804433; Tue, 09 May 2017 23:30:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.137.16 with HTTP; Tue, 9 May 2017 23:30:03 -0700 (PDT) In-Reply-To: References: From: Neel Patel Date: Wed, 10 May 2017 12:00:03 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c1852ca4989a2054f259a28 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1852ca4989a2054f259a28 Content-Type: multipart/alternative; boundary=94eb2c1852ca49899d054f259a26 --94eb2c1852ca49899d054f259a26 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, Please find attached patch file with the fix of compilation issues with Qt4. Tested with both the version of Qt4 and Qt5 webkit and it is working now. As triggerAction code will not be applicable for Qt4 so we made conditional macro for Qt5 version check and for backward compatibility webkit version with Qt5, as in new webkit new enum is added so we have incremented with one to previous enum value which will solve the problem with both old and new webkit. Do review it and let me know for any issue. Thanks, Neel Patel On Tue, May 9, 2017 at 3:18 PM, Neel Patel wrote: > Hi Dave, > > On Tue, May 9, 2017 at 3:08 PM, Dave Page > wrote: > >> Hi >> >> On Tue, May 9, 2017 at 10:28 AM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' >>> related compilation error in Qt4. BUT >>> >>> Below compilation error is coming because we have not applied the latest >>> patch of webkit which was fixed in annulen/webkit repo which was raised= at >>> below path. >>> >>> https://github.com/annulen/webkit/issues/519 >>> >>> BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not = a member of >>> =E2=80=98QWebPage=E2=80=99 >>> webviewPtr->page()->triggerAc >>> tion(QWebPage::RequestClose); >>> >>> To fix the above compilation error currently we have two solution. >>> >>> - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) >>> . >>> - Comment the below line temporary for compilation until we get the >>> releases from annulen/webkit. >>> >>> webviewPtr->page()->triggerAc >>> tion(QWebPage::RequestClose); >>> >>> Other compilation issues, (Me and Akshay) will fix and commit it but >>> need your input on above issue. >>> >> >> For various reasons we need to retain compatibility with the previous >> versions of qtwebkit. Can we detect at build time what version we have, = and >> enable/disable that code as appropriate? >> > > Make sense. We will check if we are getting any webkit version in > application or not and update you. > > >> >>> >>> Thanks, >>> Neel Patel >>> >>> On Tue, May 9, 2017 at 2:02 PM, Dave Page >>> wrote: >>> >>>> It's running CentOS 7.3, with packages from EPEL: >>>> >>>> [dpage@jenkins ~]$ rpm -qa |grep qt >>>> qt5-qtbase-common-5.6.1-10.el7.noarch >>>> qt5-qtbase-devel-5.6.1-10.el7.x86_64 >>>> qt-4.8.5-13.el7.x86_64 >>>> qt5-qtbase-5.6.1-10.el7.x86_64 >>>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 >>>> qt5-qtwebchannel-5.6.1-10.el7.x86_64 >>>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 >>>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 >>>> qt-devel-4.8.5-13.el7.x86_64 >>>> qt-settings-19-23.5.el7.centos.noarch >>>> qt5-qtbase-gui-5.6.1-10.el7.x86_64 >>>> qt5-qtlocation-5.6.1-10.el7.x86_64 >>>> qt5-qtwebsockets-5.6.1-10.el7.x86_64 >>>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 >>>> qtwebkit-2.3.4-6.el7.x86_64 >>>> qt3-3.3.8b-51.el7.x86_64 >>>> qt5-qtdeclarative-5.6.1-10.el7.x86_64 >>>> qt5-rpm-macros-5.6.1-10.el7.noarch >>>> qtwebkit-devel-2.3.4-6.el7.x86_64 >>>> qt-x11-4.8.5-13.el7.x86_64 >>>> qt5-qtsensors-5.6.1-10.el7.x86_64 >>>> >>>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel >>> > wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Yes, It looks like compilation fails on Qt4. We will fix this issue >>>>> but which version of Qt4 we are using in Jenkins ? >>>>> >>>>> Thanks, >>>>> Neel Patel >>>>> >>>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page < >>>>>>> dave.page@enterprisedb.com> wrote: >>>>>>> >>>>>>>> This appears to have made Jenkins get all angry and red :-( >>>>>>>> >>>>>>>> https://jenkins.pgadmin.org/ >>>>>>>> >>>>>>> >>>>>>> We(Neel and I) have tested it and working fine. >>>>>>> >>>>>> >>>>>> It clearly doesn't compile on QT4. Please review the Jenkins logs. >>>>>> >>>>>> >>>>>>> >>>>>>>> >>>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Thanks patch applied. >>>>>>>>> >>>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Akshay, could you review this please? >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>>>>>>> neel.patel@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> Please find attached patch file with the fix of RM #2328 - >>>>>>>>>>> [Runtime]: Unable to launch query tool and debugger in new brow= ser tab. >>>>>>>>>>> >>>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>>>>> >>>>>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We have >>>>>>>>>>> raised and also they have provided patch file to fix this issue= . I have >>>>>>>>>>> applied the patch in linux and compile the webkit and tested th= e attached >>>>>>>>>>> patch with compiled webkit which is now working fine. >>>>>>>>>>> >>>>>>>>>>> Below is the link for reference regarding unload issue. They >>>>>>>>>>> have provided test webkit release for Mac in below URL but for = other >>>>>>>>>>> platform we need to apply the patch and compile the webkit unti= l they >>>>>>>>>>> provide webkit-releases for all platforms. >>>>>>>>>>> >>>>>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>>>> >>>>>>>>>>> Do review it and let me know in case of any issue. >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Neel Patel >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>>> To make changes to your subscription: >>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Akshay Joshi* >>>>>>>>> *Principal Software Engineer * >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Akshay Joshi* >>>>>>> *Principal Software Engineer * >>>>>>> >>>>>>> >>>>>>> >>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> VP, Chief Architect, Tools & Installers >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > --94eb2c1852ca49899d054f259a26 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find attached patch file wit= h the fix of compilation issues with Qt4.=C2=A0 Tested with both the versio= n of Qt4 and Qt5 webkit and it is working now.

As = triggerAction code will not be applicable for Qt4 so we made conditional ma= cro for Qt5 version check and for backward compatibility webkit version wit= h Qt5, as in new webkit new enum is added so we have incremented with one t= o previous enum value which will solve the problem with both old and new we= bkit.

Do review it and let me know for any issue.<= /div>

Thanks,
Neel Patel

On Tue, May 9, 2017 at 3:18= PM, Neel Patel <neel.patel@enterprisedb.com> wrot= e:
Hi Dave,

On Tue, May 9= , 2017 at 3:08 PM, Dave Page <dave.page@enterprisedb.com><= /span> wrote:
Hi

On Tue, May 9, = 2017 at 10:28 AM, Neel Patel <neel.patel@enterprisedb.com>= ; wrote:
H= i Dave,

Here there are 2 compilation issue. We hav= e fixed 'QNetworkCookieJar' related compilation error in Qt4. BUT

Below compilation error is coming because we have n= ot applied the latest patch of webkit which was fixed in annulen/webkit rep= o which was raised at below path.


Browser= Window.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a member of= =E2=80=98QWebPage=E2=80=99
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr->page(= )->triggerAction(QWebPage::RequestClose);

To fix the above compilation error currently we have two solution.
  • Apply the given patch in webkit ( qwebpage.cpp & qwebpa= ge.h file ) .
  • Comment the below line temporary for compilation unti= l we get the releases from annulen/webkit.
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->triggerAction(QWebPage::RequestClose);

Other c= ompilation issues, (Me and Akshay) will fix and commit it but need your inp= ut on above issue.

For v= arious reasons we need to retain compatibility with the previous versions o= f qtwebkit. Can we detect at build time what version we have, and enable/di= sable that code as appropriate?
= =C2=A0
Make sense.=C2=A0 We will check if we are getting a= ny webkit version in application or not and update you.

=C2=A0

Thanks,
Neel Patel
On Tue, May 9, 2017 at 2:02 PM, Dave Page <dave.page@enterprisedb.com> wrote:
It's running CentOS 7.3, with packages = from EPEL:

[dpage@jenkins ~]$ rpm -qa |grep qt
qt5-qtbase-common-5.6.1-10.el7.noarch
qt5-qtbase-devel= -5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
qt5-qt= base-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5.6.1-10.el7.x86_= 64
qt5-qtwebchannel-5.6.1-10.el7.x86_64
qt5-qtwebk= it-5.6.1-3.b889f46git.el7.x86_64
qt5-qtdeclarative-devel-5.6= .1-10.el7.x86_64
qt-devel-4.8.5-13.el7.x86_64
qt-s= ettings-19-23.5.el7.centos.noarch
qt5-qtbase-gui-5.6.1-10.el= 7.x86_64
qt5-qtlocation-5.6.1-10.el7.x86_64
q= t5-qtwebsockets-5.6.1-10.el7.x86_64
qt5-qtwebkit-devel-5.6.1= -3.b889f46git.el7.x86_64
qtwebkit-2.3.4-6.el7.x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.1-10.el7.x= 86_64
qtwebkit-dev= el-2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.x86_64
q= t5-qtsensors-5.6.1-10.el7.x86_64

On Tue, May 9, 2017= at 9:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,
=
Yes, It looks like compilation fails on Qt4. We will fix thi= s issue but which version of Qt4 we are using in Jenkins ?

Thanks,
Neel Patel

On Tue, May 9, 2017 at 1:56 PM, Dave Page <dav= e.page@enterprisedb.com> wrote:


On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <a= kshay.joshi@enterprisedb.com> wrote:
Hi

On Tue, May 9, 2017 at 1:42 PM, Dave Page <dave.page@enterprisedb.com> wrote:
This appears to have made Jenkins get all angry and red :-(

=C2=A0 =C2=A0We(Neel and I) have tested it and working fine.=C2= =A0=C2=A0

It= clearly doesn't compile on QT4. Please review the Jenkins logs.
<= div>
=C2=A0

<= /div>

On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.
<= div>

On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org>= wrote:
Akshay, could you revie= w this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Pate= l <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attac= hed patch file with the fix of RM #2328 - [Runtime]: Unable to launch query= tool and debugger in new browser tab.

I have used Qt 5.8 with webkit mentioned in below URL= .



As there was a bug in QWebKit regarding "un= load" event. We have raised and also they have provided patch file to = fix this issue. I have applied the patch in linux and compile the webkit an= d tested the attached patch with compiled webkit which is now working fine.=

Below is the link for reference regarding unload issue. They have prov= ided test webkit release for Mac in below URL but for other platform we nee= d to apply the patch and compile the webkit until they provide webkit-relea= ses for all platforms.


Do review it and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company



--
=
Akshay Joshi
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">Principal Software Engineer=C2=A0


Phone: +91 20-= 3058-9517
Mobile: +91 976-788-8246



--
Dave Page
VP, Chief Architect, Tools & = Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany

Blog: http://pgsnake.blogspot.com
T= witter: @pgsnake



--
Akshay Joshi
= Principal Software En= gineer=C2=A0


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /span>



--
Dave Page
VP, Chief Architect, Tools & Inst= allers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company=

Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake




--
=
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB:= http://www.enter= prisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake




--
Dave Page
VP, Chief Architect, Tools & Installers
= EnterpriseDB: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company

Bl= og: http://pgsnak= e.blogspot.com
Twitter: @pgsnake


--94eb2c1852ca49899d054f259a26-- --94eb2c1852ca4989a2054f259a28 Content-Type: application/octet-stream; name="webkit_compile_issue.patch" Content-Disposition: attachment; filename="webkit_compile_issue.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j2iltqvg0 ZGlmZiAtLWdpdCBhL3J1bnRpbWUvQnJvd3NlcldpbmRvdy5jcHAgYi9ydW50 aW1lL0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IDQ4MmEyYmQuLmQ0MjQ4YTEg MTAwNjQ0Ci0tLSBhL3J1bnRpbWUvQnJvd3NlcldpbmRvdy5jcHAKKysrIGIv cnVudGltZS9Ccm93c2VyV2luZG93LmNwcApAQCAtODM1LDkgKzgzNSwxNSBA QCB2b2lkIEJyb3dzZXJXaW5kb3c6OmNsb3NldGFicygpCiAgICAgICAgICAg ICAgICAgICAgIHdlYnZpZXdQdHIgPSBkeW5hbWljX2Nhc3Q8V2ViVmlld1dp bmRvdyo+KHdpZGdldFB0cik7CiAgICAgICAgICAgICAgICAgICAgIGlmICh3 ZWJ2aWV3UHRyICE9IE5VTEwpCiAgICAgICAgICAgICAgICAgICAgIHsKLSAg ICAgICAgICAgICAgICAgICAgICAgIC8vIFRyaWdnZXIgdGhlIGFjdGlvbiBm b3IgdGFiIHdpbmRvdyBjbG9zZSBzbyB1bmxvYWQgZXZlbnQKLSAgICAgICAg ICAgICAgICAgICAgICAgIC8vIHdpbGwgYmUgY2FsbGVkIGFuZCByZXNvdXJj ZXMgd2lsbCBiZSBmcmVlZCBwcm9wZXJseS4KLSAgICAgICAgICAgICAgICAg ICAgICAgIHdlYnZpZXdQdHItPnBhZ2UoKS0+dHJpZ2dlckFjdGlvbihRV2Vi UGFnZTo6UmVxdWVzdENsb3NlKTsKKyAgICAgICAgICAgICAgICAgICAgICAg IC8vIFRyaWdnZXIgdGhlIGFjdGlvbiBmb3IgdGFiIHdpbmRvdyBjbG9zZSBz byB1bmxvYWQgZXZlbnQgd2lsbCBiZSBjYWxsZWQgYW5kCisgICAgICAgICAg ICAgICAgICAgICAgICAvLyByZXNvdXJjZXMgd2lsbCBiZSBmcmVlZCBwcm9w ZXJseS4KKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIFRyaWdnZXIgJ1Jl cXVlc3RDbG9zZScgYWN0aW9uIGZyb20gUXQ1IG9ud2FyZHMuIEhlcmUgd2Ug aGF2ZSB0cmlnZ2VycmVkIHRoZSBhY3Rpb24KKyAgICAgICAgICAgICAgICAg ICAgICAgIC8vICdUb2dnbGVWaWRlb0Z1bGxzY3JlZW4gKyAxJyBiZWNhdXNl IHdlIGRvIG5vdCBrbm93IGZyb20gd2hpY2ggd2Via2l0CisgICAgICAgICAg ICAgICAgICAgICAgICAvLyB2ZXJzaW9uICdSZXF1ZXN0Q2xvc2UnIGFjdGlv biB3YXMgYWRkZWQgc28gaW5jcmVtZW50IHdpdGggcHJldmlvdXMgZW51bSB2 YWx1ZSBzbyB0aGF0CisgICAgICAgICAgICAgICAgICAgICAgICAvLyBpdCB3 aWxsIGJlIGJhY2t3YXJkIHdlYmtpdCB2ZXJzaW9uIGNvbXBhdGlibGUuCisg ICAgICAgICAgICAgICAgICAgICAgICAjaWYgUVRfVkVSU0lPTiA+PSAweDA1 MDAwMAorICAgICAgICAgICAgICAgICAgICAgICAgd2Vidmlld1B0ci0+cGFn ZSgpLT50cmlnZ2VyQWN0aW9uKHN0YXRpY19jYXN0PFFXZWJQYWdlOjpXZWJB Y3Rpb24+KFFXZWJQYWdlOjpUb2dnbGVWaWRlb0Z1bGxzY3JlZW4gKyAxKSk7 CisgICAgICAgICAgICAgICAgICAgICAgICAjZW5kaWYKICAgICAgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0K ZGlmZiAtLWdpdCBhL3J1bnRpbWUvQnJvd3NlcldpbmRvdy5oIGIvcnVudGlt ZS9Ccm93c2VyV2luZG93LmgKaW5kZXggMzVmNjczNi4uMTQ2NWE0OCAxMDA2 NDQKLS0tIGEvcnVudGltZS9Ccm93c2VyV2luZG93LmgKKysrIGIvcnVudGlt ZS9Ccm93c2VyV2luZG93LmgKQEAgLTMzLDYgKzMzLDggQEAKICAgICAgICAg I2luY2x1ZGUgPFF0V2ViRW5naW5lVmlldz4KICAgICAjZWxzZQogICAgICAg ICAjaW5jbHVkZSA8UVdlYlZpZXc+CisgICAgICAgICNpbmNsdWRlIDxRTmV0 d29ya0Nvb2tpZUphcj4KKyAgICAgICAgI2luY2x1ZGUgPFFOZXR3b3JrQWNj ZXNzTWFuYWdlcj4KICAgICAjZW5kaWYKICNlbmRpZgogCg== --94eb2c1852ca4989a2054f259a28 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c1852ca4989a2054f259a28--